Camelia, the Perl 6 bug

IRC log for #cdk, 2008-06-25

| Channels | #cdk index | Today | | Search | Google Search | Plain-Text | summary

All times shown according to UTC.

Time Nick Message
01:28 malick joined #cdk
01:30 malick joined #cdk
01:35 Conrad joined #cdk
01:37 Conrad joined #cdk
01:38 jpansanel joined #cdk
05:49 bag joined #cdk
06:49 rojasm joined #cdk
07:19 jpansanel moin
07:39 jonalv joined #cdk
08:38 jbrefort joined #cdk
08:58 shk3 joined #cdk
09:24 masak joined #cdk
10:26 cataska joined #cdk
10:27 cataska left #cdk
10:51 egonw joined #cdk
10:53 egonw_ joined #cdk
11:42 malick joined #cdk
14:05 egonw joined #cdk
14:41 olas joined #cdk
14:41 olas egonw: If I spot an NPE in CDK, can I fix it?
14:41 olas and commit?
14:41 shk3 sure
14:41 shk3 go ahead
14:41 olas or how is the review process?
14:41 shk3 you don't need egon for this
14:41 olas well
14:42 shk3 egon sees what's committed and checks
14:42 olas he wants to work in branches
14:42 olas ok
14:42 olas then I will do it
14:44 shk3 but not for such changes, I assume
14:45 egonw shk3: well...
14:45 egonw trunk commits are OK if:
14:45 egonw - they are unit tests
14:45 CIA-33 cdk: egonw * r11437 /cdk/trunk/src/main/org/op​enscience/cdk/io/formats/ (4 files): CDK does not have readers for these formats
14:46 egonw - bug fixes + complementing unit tests
14:46 egonw anything else needs to be approved on beforehand
14:46 egonw by a senior CDK developer
14:46 egonw where senior := rajarshi, christoph, me, miguel, stefan
14:47 egonw or, alternatively, any developer on the CDK ML
14:47 egonw something like that...
14:48 egonw so, the fix I just commited 111437 is OK, because trunk already has a unit test that fails on it
14:48 shk3 ok, so olas, please mak a unit test
14:48 egonw the idea is that all code in trunk is at least seen by *two* developers
14:48 shk3 for your change
14:49 shk3 very wise
14:49 egonw any new functionality, or changed functionality, is first developed in a branch
14:49 egonw so that people can review it,
14:49 shk3 didn't notice we have that official policy
14:49 egonw and only upon approval via the -devel ML allowed to go into trunk
14:49 egonw shk3: no, it has to be formalized still...
14:49 egonw but getting into place
14:50 egonw miguel and I have been experimenting with the branch stuff
14:51 CIA-33 cdk: egonw * r11438 /cdk/trunk/src/main/org/openscience/cdk/io​/formats/PubChemSubstancesASNFormat.java: Method should return null if no reader is defined
14:53 CIA-33 cdk: ospjuth * r11439 /cdk/trunk/src/main/org/openscie​nce/cdk/ConformerContainer.java: Throw exception if title is missing, as is done if title is not similar. Catches NPE if title is missing from SDFile.
14:54 olas egonw: very small fix, hope it's OK.
14:54 olas please review if you like
14:54 olas but I will not write a unit test for that
14:54 egonw olas: well, that's why it should have been tied together with a unit test...
14:54 olas too much hassle for a simple NPE
14:54 egonw then you should have better emailed the fix to the list
14:54 olas are you kidding?
14:55 egonw no
14:55 olas is this the way you want to run cdk?
14:55 egonw because Rajarshi might have a better idea on how to fix this...
14:55 egonw yes
14:55 olas ok
14:55 olas left #cdk
14:55 egonw olas: in branches you are free to do what you like...
15:21 CIA-33 cdk: egonw * r11440 /cdk/trunk/src/test/org/openscience/cd​k/io/formats/ResourceFormatTest.java: It is custom to return new String[0] too
16:11 carsten joined #cdk
17:02 carsten joined #cdk
17:02 malick joined #cdk
17:02 shk3 joined #cdk
17:02 jbrefort joined #cdk
17:02 jpansanel joined #cdk
17:02 Conrad joined #cdk
17:02 azeem joined #cdk
17:02 CIA-33 joined #cdk
17:03 carsten joined #cdk
17:05 malick joined #cdk
17:09 jbrefort joined #cdk
17:12 jbrefort joined #cdk
17:43 CIA-33 jmol: nicove * r9522 /trunk/Jmol-FAH/projects/ (6 files): Folding@Home
17:54 CIA-33 jmol: nicove * r9523 /trunk/Jmol-web/ (cache.properties source/doc/fah/fah-projects.xml): Folding@Home
19:55 CIA-33 jmol: nicove * r9524 /trunk/Jmol-FAH/projects/ (5 files): Folding@Home
22:08 bag joined #cdk
23:46 edrin joined #cdk

| Channels | #cdk index | Today | | Search | Google Search | Plain-Text | summary