Camelia, the Perl 6 bug

IRC log for #cdk, 2008-09-18

| Channels | #cdk index | Today | | Search | Google Search | Plain-Text | summary

All times shown according to UTC.

Time Nick Message
06:14 rojasm joined #cdk
06:54 thomas_ku joined #cdk
06:55 thomas_ku moin
06:55 zarah hi thomas_ku
06:56 bag joined #cdk
07:38 jonalv joined #cdk
08:23 jbrefort joined #cdk
08:55 rojasm joined #cdk
09:16 maclean joined #cdk
09:25 shk3 joined #cdk
09:46 jpansanel moin
09:46 zarah hi jpansanel
09:59 gilleain joined #cdk
11:50 olas joined #cdk
12:42 CIA-14 cdk: rajarshi * r12337 /cdk/branches/cdk-1.2.x/src/ (5 files in 5 dirs): Converted to JUnit4, added test annotationh, fixed test class annotation, converted reaction coverage test to use annotation coverage
12:45 CIA-14 cdk: rajarshi * r12338 /cdk/branches/cdk-1.2.x/src/main/org/openscien​ce/cdk/tools/StructureResonanceGenerator.java: cleaned up javadocs and removed some unnecessary exceptions
12:54 jonalv Hm cdk used in Bioclipse no longer commits for me. org.openscience.cdk.charges.StabilizationCharges row 83: Unreachable catch block for CDKException. This exception is never thrown from the try statement body
12:55 jonalv rojasm: Do you know anythign about this?
13:07 olas left #cdk
13:25 rojasm jonalv
13:26 rojasm mmm I don't know
13:26 jonalv rojasm
13:26 jonalv :)
13:26 rojasm let me take a look
13:26 jonalv Could you have a look?
13:26 jonalv ah :)
13:36 rojasm I don't understand correctly the error
13:37 rojasm That means that CDKException is not found or the some of the method should not add this exception
13:38 rojasm because it compiles
13:46 shk3 hm, I don't get an error
13:48 rojasm I think it is about Exception is less specific
13:49 rojasm may be it should be basically Exception and not CDKException
13:49 rojasm http://saloon.javaranch.com/cgi-bin/ubb/ultim​atebb.cgi?ubb=get_topic&f=24&t=039280
13:49 shk3 I would revmoe the catch block
13:50 rojasm it is necessary for the reaction exception I think
13:50 shk3 and see if it complaines about an exception not be caught
13:50 shk3 just test it
13:51 rojasm for me it is null fails :(
13:52 rojasm shk3 you mean the test with build ant or junit specific for the method
13:53 shk3 no, i mean just remove the catch in eclipse and see what eclipse says
13:54 rojasm it complains that we should add a catch. the  catch (CDKException e)
13:54 rojasm but that is as It is now
13:55 gilleain but StructureResonanceGenerator.setReactions is throwing a CDKException
13:55 shk3 that's stragne
14:01 rojasm some one has the similar problem and he pointed that he solved the problem putting the exception in the function itself throught method() throws blablaException. Also He changed the header of the function
14:02 rojasm http://www.neowin.net/forum/lof​iversion/index.php/t484120.html
14:02 rojasm I don't it makes sense
14:05 gilleain Now i see the problem. The method "setReactions" throws no exception. Just remove the "throws CDKException" from the method signature.
14:06 shk3 ah
14:06 gilleain The body of the method is simply "reactionsList = newReactionsList;"
14:11 rojasm ooo
14:17 CIA-14 cdk: miguelrojasch * r12339 /cdk/trunk/src/main/org/openscience/cdk/ (2 files in 2 dirs):
14:17 CIA-14 cdk: removed "throws CDKException" from method
14:17 CIA-14 cdk: StructureResonanceGenerator.setR​eactions(List<IReactionProcess>
14:17 CIA-14 cdk: newReactionsList). And depending methods as
14:17 CIA-14 cdk: StabilizationCharges.calculatePositive. It was producing some incoherences:
14:17 CIA-14 cdk: org.openscience.cdk.charges.StabilizationCharges row 83: Unreachable catch block
14:17 CIA-14 cdk: for CDKException. This exception is never thrown from the try statement body.
14:18 CIA-14 cdk: miguelrojasch * r12340 /cdk/trunk/src/main/org/openscience/c​dk/charges/StabilizationCharges.java: removed imports not used anymore.
14:32 jonalv syou guys fixed it_
14:32 jonalv ?
14:33 jonalv bbl
14:57 CIA-14 cdk: rajarshi * r12341 /cdk/branches/cdk-1.2.x/src/ (3 files in 3 dirs): Added unit tests, annotations
15:13 CIA-14 cdk: rajarshi * r12343 /cdk/branches/cdk-1.2.x/src/ (2 files in 2 dirs): Converted to JUnit 4 and added test annots.
15:14 CIA-14 cdk: rajarshi * r12344 /cdk/branches/cdk-1.2.x/src/test/org/opens​cience/cdk/modulesuites/MextraTests.java: Updated to JUnit4 version of tanimot tests
15:45 jonalv joined #cdk
16:39 carsten joined #cdk
18:16 jbrefort joined #cdk
19:53 jbrefort joined #cdk

| Channels | #cdk index | Today | | Search | Google Search | Plain-Text | summary