Camelia, the Perl 6 bug

IRC log for #cdk, 2008-10-07

| Channels | #cdk index | Today | | Search | Google Search | Plain-Text | summary

All times shown according to UTC.

Time Nick Message
04:59 thomas_ku joined #cdk
05:01 thomas_ku moin
05:01 zarah hi thomas_ku
06:11 jbrefort joined #cdk
06:58 egonw joined #cdk
06:59 egonw moin
06:59 zarah hi egonw
07:16 malick joined #cdk
07:22 CIA-14 cdk: egonw * r12561 /cdk/trunk/src/test/data/hin/connectivity1.hin: Added missing test file
07:27 CIA-14 cdk: egonw * r12562 /cdk/branches/cdk-1.2.x/src/main/org/op​enscience/cdk/geometry/BondTools.java: added better commeentary
07:28 jpansanel moin
07:28 zarah hi jpansanel
07:29 egonw hi jpansanel
07:48 jonalv joined #cdk
08:01 egonw funny... doing a mix of my complete m3 collections... which contains the soundtrack of LotR which we watched over the past week...
08:02 egonw funny how some movie images pop up every now and then :)
08:16 shk3 hi egonw
08:18 egonw hi shk3
08:18 egonw ported your JavaDoc patch to 1.2.x
08:19 shk3 I had a look at some complaints about the builder3d module
08:19 shk3 (complaints by debug)
08:19 shk3 and there is
08:19 shk3 Missing test class: org.openscience.cdk.modeling.​builder3d.ModelBuilder3DTest
08:19 shk3 Missing test class: org.openscience.cdk.modeling​.builder3d.AtomPlacer3DTest
08:19 shk3 I renamed the classes respectivly created one
08:20 shk3 but it still complains
08:20 shk3 anything else needed except proper naming?
08:23 egonw which Coverage testing does it use?
08:23 egonw the old one, or with annotation?
08:24 shk3 no annotation
08:24 shk3 do I need one?
08:24 egonw depends on which Coverage tester is being used...
08:24 shk3 or, there is @Test, but this refers to methods,
08:24 shk3 not the class, right?
08:24 egonw mom
08:25 egonw public class Builder3dCoverageTest extends CoverageTest
08:25 egonw that would mean the old coverage tester
08:25 shk3 where is this class?
08:26 egonw the second class is missing in the TestSuite
08:26 egonw Mbuilder3dTests
08:26 shk3 I did not yet commit
08:26 egonw public class Builder3dCoverageTest extends CoverageTest
08:26 egonw crap... wrong paste
08:26 egonw package cdk.coverage
08:27 egonw and check cdk.modulesuites.Mbuilder3dTests
08:28 shk3 ah, so builder3d.javafiles needs to be changed
08:28 shk3 one more question:
08:28 shk3 when writing a test method for a method with a generic parameter, what to do with <>?
08:29 egonw no, builder3d.javafiles is autogenerated
08:29 egonw shk3: consider moving to have it use CoverageAnnotationTest
08:29 egonw then you are not limited in whatever way regarding test method names
08:30 egonw and uses @TestClass and @TestMethod annotation in the class being tested
08:30 egonw search for "@TestClass" and "@TestMethod" for examples
08:31 gilleain joined #cdk
08:31 shk3 I will have a look
08:40 jonalv joined #cdk
09:31 shk3 egonw: I found PartialTChargeMMFF94Descriptor and PartialTChargeMMFF94DescriptorTest are in different packages.
09:31 shk3 is this ok?
09:36 egonw shk3: it's not optimal
09:36 egonw shk3: they should be in the same package
09:45 shk3 when I change the package of the test class,
09:45 shk3 i get new problems: it extends AtomicDescriptorTest, which is not found
09:45 shk3 probably since it's in another package
09:45 shk3 (qsar or so)
09:46 shk3 so a new dependency would be needed
09:47 shk3 should I add this?
09:58 egonw why does changing the (java) package result in a new (cdk module) depedency?
09:59 shk3 sorrry, it's not package
09:59 shk3 it's module
09:59 shk3 they are in different modules
09:59 shk3 and changing the module of the test class to that of the real class,
10:00 shk3 makes trouble
10:00 shk3 to the respective test-module, actually
10:00 shk3 sorry for confusion
10:01 shk3 PartialTChargeMMFF94Descriptor is in builder3d
10:01 shk3 PartialTChargeMMFF94DescriptorTest is in test-qsaratomic module
10:01 shk3 looks odd, for me
10:07 egonw yes, that is not good
10:07 egonw please file a bug report
10:07 egonw I'm used to fixing these kind of things
10:07 shk3 ok
10:17 egonw joined #cdk
10:27 egonw_ joined #cdk
10:39 egonw_ js> cdkdebug.diff()
10:39 egonw_ CDKDebugManager.diff() called
10:39 egonw_ cool...
10:39 * egonw_ is using CDK from a JavaScript environment
11:59 jonalv` joined #cdk
13:17 CIA-14 cdk: rajarshi * r12563 /cdk/branches/cdk-1.2.x/src/main/org/opens​cience/cdk/similarity/DistanceMoment.java: Cleaned up Javadocs and moved some code to 1.5 idiom
13:48 malick left #cdk
14:30 CIA-14 cdk: egonw * r12564 /cdk-eclipse/trunk/.gitignore: Ignore the bin/ dir
14:30 CIA-14 cdk: egonw * r12565 /cdk-eclipse/trunk/ (.gitignore ant.properties.template build.xml): Use a props file for setting the CDK root
14:30 CIA-14 cdk: egonw * r12566 /cdk-eclipse/trunk/.gitignore: Ignore the autogenerated exports folder
14:31 CIA-14 cdk: egonw * r12567 /cdk-eclipse/trunk/ (3 files in 2 dirs): Deal properly with empty tags
16:02 malick joined #cdk
16:02 malick left #cdk
16:41 jbrefort joined #cdk
16:52 carsten joined #cdk
20:13 jbrefort joined #cdk
21:05 bag__ joined #cdk

| Channels | #cdk index | Today | | Search | Google Search | Plain-Text | summary