Camelia, the Perl 6 bug

IRC log for #cdk, 2008-12-05

| Channels | #cdk index | Today | | Search | Google Search | Plain-Text | summary

All times shown according to UTC.

Time Nick Message
05:50 slyrus_ joined #cdk
07:28 jbrefort joined #cdk
07:40 egonw joined #cdk
08:11 Gpox joined #cdk
09:15 shk3 joined #cdk
09:22 jonalv joined #cdk
09:30 carsten joined #cdk
09:57 CIA-16 cdk: egonw * r13486 /cdk/branches/shk3-cleanuptests​/src/test/org/openscience/cdk/ (3 files in 2 dirs): Reviewer comments by me: search for FIXME and TODO lines with 'shk-cleanuptests'
10:09 egonw shk3: patch reviewed
10:12 CIA-16 cdk: egonw * r13487 /cdk/branches/mark_rynbeek-vflib/: Branch for the VFLib patch
10:24 CIA-16 cdk: egonw * r13488 /cdk/branches/mark_rynbeek-vflib/src/ (9 files in 2 dirs): Applied patch #2376779: via vlib.3.tar.gz, which did gave me an gunzip error: gzip: vflib.3.tar.gz: decompression OK, trailing garbage ignored. So, I hope it is OK
12:21 gilleain joined #cdk
12:24 gilleain merry friday, everyone.
12:31 CIA-16 cdk: gilleain * r13489 / (2 files in 2 dirs): Implemented caching of the intermediate representation so that a call to repaint(g) will not regenerate from the chem model. This should speed up operations like scrolling.
12:46 egonw hi gilleain
13:11 gilleain joined #cdk
13:11 gilleain hi egonw
13:28 CIA-16 cdk: shk3 * r13490 /cdk/branches/shk3-cleanuptests/src​/main/org/openscience/cdk/modeling/​builder3d/TemplateHandler3D.java: better commentary
13:36 gilleain egonw: can I change this:
13:36 gilleain public IRing addPhenyl(Point2d worldcoord) {
13:36 gilleain addAtom("C", worldcoord);
13:36 gilleain return addPhenyl(getClosestAtom(worldcoord));
13:36 gilleain }
13:36 gilleain to
13:36 egonw return addPhenyl(addAtom())
13:36 gilleain public IRing addPhenyl(Point2d worldcoord) {
13:36 gilleain IAtom a = addAtom("C", worldcoord);
13:36 gilleain return addPhenyl(a);
13:36 gilleain }
13:36 egonw yes please
13:36 gilleain that's even clearer, yes :)
13:37 egonw indeed
13:37 egonw and much saver too
13:37 egonw and likely faster as well
13:39 gilleain unlikely to be faster
13:39 gilleain I would have thought that the VM would optimise stuff like that
13:41 gilleain also, for this code:
13:41 gilleain IAtomContainer sharedAtoms = atom.getBuilder().newAtomContainer();
13:41 gilleain sharedAtoms.addAtom(atom);
13:41 gilleain Point2d sharedAtomsCenter = GeometryTools.get2DCenter(sharedAtoms);
13:41 gilleain this relation holds:
13:41 gilleain sharedAtomsCenter == atom.getPoint2d()
13:42 egonw ah... no, faster compared to the odl version with getClosestAtom() :)
13:43 egonw yes, agreed
13:43 gilleain oh, right yes, that's certainly true
14:13 jonalv joined #cdk
15:47 CIA-16 cdk: shk3 * r13491 /jchempaint/trunk/ (6 files in 2 dirs): sadly putting the test htmls in an extra dir doesn't work, since the appletviewer only loads applet in the same directory or a subdirectory than the html file
16:31 shk3 egown: about your commit to the cleanup branch
16:31 shk3 I can see it when I do history of the whole project
16:32 shk3 but the individual files stay at an earlier revision
16:32 shk3 and their history doesn't have your changes
16:32 shk3 your commit
16:32 shk3 i mean
16:35 shk3 egonw
16:36 egonw mmm... sounds something badly wrong with your svn checkout
16:36 * egonw is now away for dinner etc
17:36 ilbot2 joined #cdk
17:36 Topic for #cdkis now The Chemistry Development Kit (http://cdk.sf.net) | JUnit CDK 1.2.x: 7760, 80 fails + 17 errors (1.12%) | Logs at http://moritz.faui2k3.org/​irclog/out.pl?channel=cdk | CDK News paper online on pharmacophores: http://www.cdknews.org/ | CDK News Feed: http://beta.friendfeed.com/ro​oms/chemistry-development-kit
18:09 rguha joined #cdk
18:09 rguha hi
18:09 zarah hi rguha
18:20 CIA-16 cdk: shk3 * r13496 /jchempaint/trunk/META-INF/ (3 files): new applet class lists
18:39 gilleain joined #cdk
18:47 CIA-16 cdk: shk3 * r13497 /jchempaint/trunk/META-INF/ (applet-core.files applet-editor-opts.files): new applet class lists
18:50 slyrus_ joined #cdk
19:41 CIA-16 cdk: miguelrojasch * r13498 /cdk/branches/cdk-1.2.x/src/ (2 files in 2 dirs): added functionality to solve elemental formulas with breaks and multipliers.
21:50 edrin joined #cdk

| Channels | #cdk index | Today | | Search | Google Search | Plain-Text | summary