Camelia, the Perl 6 bug

IRC log for #cdk, 2009-02-09

| Channels | #cdk index | Today | | Search | Google Search | Plain-Text | summary

All times shown according to UTC.

Time Nick Message
06:22 bag joined #cdk
06:48 rojasm joined #cdk
08:04 Gpox joined #cdk
08:13 egonw joined #cdk
08:29 rojasm joined #cdk
09:05 maclean joined #cdk
09:14 shk3 joined #cdk
09:32 rojasm joined #cdk
10:42 CIA-62 cdk: gilleain * r14113 /cdk/branches/jchempaint-primary/src/main/o​rg/openscience/cdk/renderer/Renderer.java: More debuggin statements removed. Sorry.
11:03 CIA-62 cdk: gilleain * r14114 /cdk/branches/jchempaint-primary/src​/main/org/openscience/cdk/renderer/ (5 files in 3 dirs): Compact mode drawing now uses the RendererModel.atomRadius and can be set to be oval or square (default).
11:05 egonw maclean++
11:05 maclean karma maclean
11:05 zarah maclean has a karma of 9
11:06 maclean karma gilleain
11:06 zarah gilleain has a karma of 10
11:06 maclean curse him!
12:07 maclean joined #cdk
13:52 CIA-62 cdk: gilleain * r14115 /cdk/branches/jchempaint-primary/src​/main/org/openscience/cdk/renderer/ (3 files in 2 dirs): Rings were not created properly (they were filled, but this did not show until a fix to the fill rendering). Also, the size can be set in the renderer model.
14:11 CIA-62 cdk: gilleain * r14116 /cdk/branches/jchempaint-primary/src/main/org​/openscience/cdk/renderer/RendererModel.java: Typo - setBondLength(double):void was getBondLength(double):void !!
14:17 egonw YES, I nailed the bastard!
14:17 egonw last showstopped for CDK 1.2 fixed
14:17 egonw stoppeR
14:33 maclean egonw++
14:33 maclean well done
14:42 CIA-62 cdk: gilleain * r14117 /cdk/branches/jchempaint-primary/src/main/org/open​science/cdk/renderer/visitor/AWTDrawVisitor.java: Respect the anti-alias parameter.
14:43 CIA-62 cdk: gilleain * r14118 /cdk/branches/jchempaint-primary/src​/main/org/openscience/cdk/renderer/ (RendererModel.java RenderingParameters.java): Anti-alias parameter (re)-introduced.
14:43 egonw maclean++
14:43 egonw I see so much old JCP functionality get back online so quickly...
14:43 egonw the design must be good
14:43 egonw nice and clean patches all over the place, cheers!
14:43 maclean aargh!
14:43 maclean not so clean :(
14:44 egonw well... debug info here and there :)
14:44 maclean I just duplicated the anti-alias param
14:45 maclean I was looking under 'A' for anti-alias, when I should have looked at 'U' for 'useAntiAlias'...
14:45 egonw :)
14:49 CIA-62 cdk: gilleain * r14119 /cdk/branches/jchempaint-primary/src​/main/org/openscience/cdk/renderer/ (3 files in 2 dirs): Better to use the existing parameters, rather than duplicate new ones!
14:52 CIA-62 cdk: gilleain * r14120 /jchempaint/trunk/src/main/org/opens​cience/jchempaint/RenderPanel.java: Set anti-aliasing in the DrawVisitor, depending on RendererModel.getUseAntiAliasing().
14:54 CIA-62 cdk: gilleain * r14121 /jchempaint/trunk/src/main/org/openscience/jche​mpaint/dialog/editor/RendererModelEditor.java: Set a few more parameters : atomRadius, bondLength, and highlightDistance using sliders.
15:11 carsten joined #cdk
15:13 CIA-62 cdk: egonw * r14122 /cdk/branches/cdk-1.2.x/src/ (3 files in 3 dirs): Refactored out a format detection class
15:14 CIA-62 cdk: egonw * r14123 /cdk/branches/cdk-1.2.x/src/ (2 files in 2 dirs): Reuse the new FormatFactory
15:15 CIA-62 cdk: egonw * r14124 /cdk/branches/cdk-1.2.x/src/test/org/ope​nscience/cdk/io/FormatFactoryTest.java: Added unit test for bug 2153298
15:15 CIA-62 cdk: egonw * r14125 /cdk/branches/cdk-1.2.x/src/main/org/o​penscience/cdk/io/FormatFactory.java: Added missing annotation
15:16 CIA-62 cdk: egonw * r14126 /cdk/branches/cdk-1.2.x/src/test/ (2 files in 2 dirs): Added two more unit tests
15:17 CIA-62 cdk: egonw * r14127 /cdk/branches/cdk-1.2.x/src/main/org/o​penscience/cdk/io/FormatFactory.java: Copied code from guessFormat(Reader) and tuned for InputStream
15:18 CIA-62 cdk: egonw * r14128 /cdk/branches/cdk-1.2.x/src/test/org/ope​nscience/cdk/io/ReaderFactoryTest.java: Tuned test: the reader only reads IMolecule, so just read that
15:19 CIA-62 cdk: egonw * r14129 /cdk/branches/cdk-1.2.x/src/test/org/ope​nscience/cdk/io/ReaderFactoryTest.java: Added two unit tests for testing reading of Gzipped files
15:19 CIA-62 cdk: egonw * r14130 /cdk/branches/cdk-1.2.x/src/main/org/op​enscience/cdk/io/GhemicalMMReader.java: Call readChemModel directly, instead of using the more general read()
15:20 CIA-62 cdk: egonw * r14131 /cdk/branches/cdk-1.2.x/src/test/org/ope​nscience/cdk/io/GhemicalReaderTest.java: Added unit test for reading ethene.mm1gp
15:21 CIA-62 cdk: egonw * r14132 /cdk/branches/cdk-1.2.x/src/main/org/o​penscience/cdk/io/ReaderFactory.java: Fixed instantiating readers (fixes #2153298)
15:22 CIA-62 cdk: egonw * r14133 /cdk/branches/cdk-1.2.x/src/test/org/ope​nscience/cdk/io/ReaderFactoryTest.java: More detailed testing: do some additional testing on atom and bond count (not for all readers yet)
15:35 CIA-62 cdk: shk3 * r14134 /jchempaint/trunk/po/es.po: new spanish localization
15:36 CIA-62 cdk: egonw * r14135 /cdk/branches/cdk-1.2.x/build.props: Bumped version
15:39 CIA-62 cdk: egonw * r14136 /cdk/tags/cdk-1.1.5/: Tagged CDK 1.1.5
15:53 CIA-62 cdk: gilleain * r14137 /jchempaint/trunk/src/main/org/opens​cience/jchempaint/RenderPanel.java: Fix for bug 2531393 - cleanup no longer leads to an empty panel for models with a scale different to natural.
15:58 CIA-62 cdk: gilleain * r14138 /jchempaint/trunk/src/main/org/openscien​ce/jchempaint/action/CleanupAction.java: Improvement to previous fix - resets the drawing center after cleanup, as if a new molecule has been loaded (which, effectively, is true).
16:11 a2n joined #cdk
16:11 a2n left #cdk
16:12 CIA-62 cdk: gilleain * r14139 /cdk/branches/jchempaint-primary/src​/main/org/openscience/cdk/renderer/ (3 files in 2 dirs): Implement the bondWidth parameter as a BasicStroke.
16:20 CIA-62 cdk: gilleain * r14140 /jchempaint/trunk/src/main/org/openscience/jche​mpaint/dialog/editor/RendererModelEditor.java: Expose the bond width in the rendering options dialog.
16:47 CIA-62 cdk: gilleain * r14141 /cdk/branches/jchempaint-primary/src​/main/org/openscience/cdk/renderer/ (3 files in 2 dirs): Wedge bonds given a parameter in the renderer model.
16:48 egonw joined #cdk
16:55 maclean joined #cdk
17:26 CIA-62 cdk: gilleain * r14142 /cdk/branches/jchempaint-primary/src​/main/org/openscience/cdk/renderer/ (RendererModel.java RenderingParameters.java): Removed showAromaticityInCDKStyle, as this has (as far as I can tell) never been used.
17:27 CIA-62 cdk: gilleain * r14143 /jchempaint/trunk/src/main/org/openscience/jche​mpaint/dialog/editor/RendererModelEditor.java: Removed the option to set the unused parameter showAromaticityInCDKStyle.
17:28 CIA-62 cdk: shk3 * r14144 /jchempaint/trunk/po/ (5 files in 2 dirs): added the arabic translation
18:01 timvdm joined #cdk
18:02 maclean left #cdk
18:06 Gpox joined #cdk
18:07 CIA-62 cdk: rajarshi * r14145 /cdk/branches/cdk-1.2.x/src/main/org/opens​cience/cdk/fingerprint/Fingerprinter.java: Updated Javadocs for findPathes to by in sync with the code
18:27 CIA-62 cdk: rajarshi * r14146 /cdk/branches/cdk-1.2.x/src/main/org/opens​cience/cdk/fingerprint/Fingerprinter.java:
18:27 CIA-62 cdk: Updated findPathes so that it directly returns the hash values of the path
18:27 CIA-62 cdk: strings, rather than creating a new HashMap to hold the paths and then evaluate
18:27 CIA-62 cdk: the hashes in the caller. This saves a bit of memory in my tests and does not
18:27 CIA-62 cdk: seem to degrade performance
20:06 rojasm joined #cdk
20:17 egonw joined #cdk
20:17 zarah joined #cdk
20:28 rojasm joined #cdk
20:44 CIA-62 joined #cdk
21:11 CIA-62 joined #cdk
21:46 bag joined #cdk
22:25 edrin joined #cdk
22:26 CIA-62 cdk: rajarshi * r14147 /cdk/branches/cdk-1.2.x/src/main/org/openscienc​e/cdk/fingerprint/GraphOnlyFingerprinter.java: Updated graph only fp for the new return type of findpathes
22:46 CIA-62 cdk: rajarshi * r14148 /cdk/branches/cdk-1.2.x/src/main/org/​openscience/cdk/graph/PathTools.java: Updated PathTools to provide a mehtod to get all paths upto length N starting from an atom
22:47 CIA-62 cdk: rajarshi * r14149 /cdk/branches/cdk-1.2.x/src/test/org/opensci​ence/cdk/fingerprint/FingerprinterTest.java: Updated fingerprinter code to get paths from an atom at one go, rather than multiple calls to getPathsOfLength for each path length. Gives a nice speedup
22:49 CIA-62 cdk: rajarshi * r14150 /cdk/branches/cdk-1.2.x/src/main/org/opens​cience/cdk/fingerprint/Fingerprinter.java: Updated fingerprinter code to get paths from an atom at one go, rather than multiple calls to getPathsOfLength for each path length. Gives a nice speedup

| Channels | #cdk index | Today | | Search | Google Search | Plain-Text | summary