Camelia, the Perl 6 bug

IRC log for #cdk, 2009-03-13

| Channels | #cdk index | Today | | Search | Google Search | Plain-Text | summary

All times shown according to UTC.

Time Nick Message
03:23 goomba` joined #cdk
06:37 jbrefort joined #cdk
06:58 tim joined #cdk
07:23 carsten joined #cdk
08:00 Gpox joined #cdk
08:49 jpansanel moin
08:49 zarah oh hai jpansanel
09:16 jonalv joined #cdk
09:28 shk3 joined #cdk
09:47 jonalv` joined #cdk
10:22 maclean joined #cdk
10:29 shk3 joined #cdk
10:34 jonalv joined #cdk
10:43 egonw joined #cdk
11:49 CIA-62 cdk: shk3 * r14473 /cdk/branches/jchempaint-primary/src​/main/org/openscience/cdk/renderer/ (4 files in 2 dirs): rendering of reaction + symbols
11:49 CIA-62 cdk: shk3 * r14474 /jchempaint/trunk/src/main/org/openscienc​e/jchempaint/application/JChemPaint.java: improved reaction handling
12:01 CIA-62 cdk: shk3 * r14475 /jchempaint/trunk/src/main/​org/openscience/jchempaint/ (application/JChemPaint.java io/JCPFileFilter.java): removed rdf support
12:37 CIA-62 cdk: goglepox * r14476 /cdk/branches/jchempaint-primar​y/src/main/org/openscience/cdk/ (9 files in 3 dirs): Refactored IChemModelSelection
12:37 CIA-62 cdk: goglepox * r14477 /cdk/branches/jchempaint-primary/src/main/org/​openscience/cdk/controller/ControllerHub.java: Check for null, workaround for generating selectionChanged event
12:38 CIA-62 cdk: goglepox * r14478 /cdk/branches/jchempaint-primary/src/main​/org/openscience/cdk/renderer/selection/ (6 files): Implemented contains(IChemObject) on IChemObjectSelection
12:38 CIA-62 cdk: goglepox * r14479 /cdk/branches/jchempaint-primary/src/main/org​/openscience/cdk/controller/MoveModule.java: Changed behaviour to work better with selections
12:39 CIA-62 cdk: goglepox * r14480 /cdk/branches/jchempaint-primary/s​rc/main/org/openscience/cdk/render​er/selection/MultiSelection.java: Fail fast if obj is null
12:39 CIA-62 cdk: goglepox * r14481 /cdk/branches/jchempaint-primary/src/main/org​/openscience/cdk/controller/MoveModule.java: Clear selection and do nothing when click is outside highlight radius.
12:39 CIA-62 cdk: goglepox * r14482 /cdk/branches/jchempaint-primary/src/​main/org/openscience/cdk/controller/ (ControllerModuleAdapter.java MoveModule.java): Moved general methods to ControllerModuleAdapter
12:40 CIA-62 cdk: goglepox * r14483 /cdk/branches/jchempaint-primary/src/​main/org/openscience/cdk/controller/ (ControllerHub.java IChemModelRelay.java MoveModule.java): Integrated atom merge with selection changes
12:40 CIA-62 cdk: goglepox * r14484 /cdk/branches/jchempaint-primary/src/main/org/​openscience/cdk/controller/ControllerHub.java: Restructured to get a better overview
12:41 CIA-62 cdk: goglepox * r14485 /cdk/branches/jchempaint-primary/src/main​/org/openscience/cdk/renderer/selection/ (6 files): Implemented elements(...), added to IChemObjectSelection
12:41 CIA-62 cdk: goglepox * r14486 /cdk/branches/jchempaint-primary/s​rc/main/org/openscience/cdk/contro​ller/ControllerModuleAdapter.java: setSelection for updating internal selection
12:42 CIA-62 cdk: goglepox * r14487 /cdk/branches/jchempaint-primary/src/main/org/​openscience/cdk/controller/ControllerHub.java: Added null check to not update atoms with no atomcontainer
12:42 CIA-62 cdk: goglepox * r14488 /cdk/branches/jchempaint-primary/src/​main/org/openscience/cdk/controller/ (3 files): Updated to use new selection strategy
12:43 CIA-62 cdk: goglepox * r14489 /cdk/branches/jchempaint-primary/src/​main/org/openscience/cdk/controller/ (5 files): Updated modules to use new selection behavior
12:57 steinbeck joined #cdk
13:22 egonw steinbeck: the issue came up on whether IMolecule should enfore connectedness...
13:22 egonw any comments on that?
13:24 steinbeck I would very much object that, simply because of the computational overhead of checking and enforcing this
13:25 egonw right, agreed
13:25 egonw so we stick to the implicit semantics only?
13:43 rajarshi joined #cdk
13:44 rajarshi hi
13:44 zarah hello rajarshi, you fantastic person you
13:44 rajarshi zarah: I  love you
13:44 zarah rajarshi: please rephrase or stop trying to be witty :)
13:44 rajarshi egonw: is it possible to include code in the CDK that is derived from Public Domain code?
13:44 egonw hej rajarshi!
13:45 rajarshi egonw: hi
13:45 egonw rajarshi: that was my first thought when reading that statement in your blog...
13:45 egonw I was thinking about maybe dual license?
13:45 rajarshi yes, the pubchem fp's would be useful
13:45 rajarshi and it'd be easy to modify
13:45 egonw yes, it would indeed!
13:45 egonw was not aware that was in the PD
13:45 rajarshi top of the source file :)
13:45 egonw :)
13:46 egonw was not aware that the source could be downloaded
13:46 rajarshi so can we include it as LGPL?
13:46 egonw well...
13:46 egonw never really search
13:46 egonw rajarshi: yes
13:46 egonw that would make things easier, I think...
13:46 rajarshi great
13:48 rajarshi working on the CDK with git is just so much fun now
13:48 egonw good :)
13:48 egonw btw...
13:48 egonw a rebase of master on cdk-1.2.x is not working for me
13:48 egonw so, I have been using pulling from that branch instead
13:48 egonw which does seem to work
13:48 rajarshi what's the error?
13:48 egonw conflicts
13:49 egonw but the patches were seriously orthogonal
13:49 rajarshi an example?
13:49 egonw so, something broken with the last common commit
13:49 rajarshi cdk-1.2.x is a branch right? So pull should be also OK - just more extraneous commit messages
13:50 egonw indeed
13:50 egonw which is not that bad, I gues
13:50 rajarshi right
13:51 egonw btw, did you check shk3's updated patch?
13:51 egonw it contained new code
13:51 rajarshi yes, it seemed OK. Didn't I comment on it?
13:51 egonw I have not looked at the updates, nor the new code
13:51 egonw yes, but I could not derive the 'fine with me' bits :)
13:52 egonw as it only commented on comments on the IReactionSet patch
13:52 egonw and nothing on the ReactionSetManipulator bits...
13:52 egonw which was not in the first draft
13:52 egonw shk3: next time, please do not add too much new code when things are already under review... better to file a new patch
13:53 egonw that makes the review process much more easy to understand
13:55 rajarshi hmm, didn't notice that new method in ReactionSetManipulator - added a comment. But otherwise it seemed good to go
13:57 CIA-62 cdk: goglepox * r14490 /cdk/branches/jchempaint-primary/src/main/org/​openscience/cdk/controller/ControllerHub.java: Changed back to x,y
13:59 rajarshi of for now
15:26 rajarshi joined #cdk
16:16 CIA-62 cdk: egonw * r14491 /cdk-xws/trunk/ (4 files in 2 dirs): Removed obsolete and unused folders
16:56 * egonw is away for dinner
18:46 goomba joined #cdk
18:53 egonw hi goomba
18:56 goomba hey
18:58 goomba this channel looks like the peak of general chemistry channels on freenode :p
18:59 egonw :)
20:58 rajarshi joined #cdk
20:59 rajarshi egon, could you merge the smarts bug patch (sorry for multiple channels - it's holding up other stuff)
21:02 egonw ha rajarshi
21:02 egonw to trunk to?
21:02 egonw btw, I think the patch is flawed
21:02 egonw just send an email
21:03 rajarshi which patch? not the one I sent to the gmail address
21:03 egonw mom
21:04 rajarshi just saw the mail
21:04 rajarshi i thought these were being applied to trunk?
21:05 egonw ha, email on cdkpatches@ ...
21:05 egonw cool
21:05 rajarshi :) but ignore that one
21:05 egonw well, bug fixes should go into cdk1.2.x too, not?
21:05 egonw yes, it's part of the branch too...
21:05 rajarshi yes, I just thought they go intro trun and then into 1.2
21:05 rajarshi doesn't matter in the end
21:06 egonw no, I rather not merge trunk -> cdk-1.2.x
21:06 rajarshi hmm, yes that makes sense
21:06 egonw cdk-1.2.x is double checked
21:06 egonw so always better than trunk
21:07 egonw anyway... going offline now...
21:07 egonw need sleep
21:07 rajarshi ok bye
21:07 egonw btw, I just played with Ubuntu PPA
21:07 egonw https://launchpad.net/~egonw/+archive/ppa
21:07 rajarshi saw that - what is it for?
21:07 egonw ubuntu debs
21:07 rajarshi aah
21:07 egonw I will update the libcdk-java too
21:08 egonw for cdk 1.2.0
21:08 egonw and put it there
21:08 egonw anyway... I will blog about that when done :)
21:08 egonw bye!
21:09 rajarshi bye
21:11 rajarshi patched the code and added unit test
21:30 timvdm joined #cdk
21:47 bag joined #cdk

| Channels | #cdk index | Today | | Search | Google Search | Plain-Text | summary