Camelia, the Perl 6 bug

IRC log for #cdk, 2009-04-03

| Channels | #cdk index | Today | | Search | Google Search | Plain-Text | summary

All times shown according to UTC.

Time Nick Message
05:19 jbrefort joined #cdk
06:29 egonw joined #cdk
06:37 rojasm joined #cdk
06:59 Gpox joined #cdk
07:52 jonalv joined #cdk
08:04 shk3 joined #cdk
08:33 shk3 egonw: I can't find a CMLReader test.
08:33 shk3 Do we not have that?
08:34 egonw sure we do
08:34 egonw where did you look?
08:34 shk3 in test/org.opensicence.cdk.io
08:34 shk3 in 1.2 branch
08:37 egonw http://cdk.pastebin.com/m7bfee643
08:37 zarah egonw's link is also http://tinyurl.com/dhmwwd
08:38 shk3 hm, so it's CML2Test?
08:38 shk3 why that?
08:38 egonw what?
08:38 egonw why not the regular naming scheme?
08:38 egonw because this originates from before that, I guess
08:38 egonw file a bug report
08:39 shk3 just to make sure: It's not my fault I cannot find a org.os.cdk.io.CMLReaderTest class?
08:39 egonw if you check the source, *most* of them are reading tests
08:39 shk3 it's not there, actually?
08:39 egonw a class with that particular name, no
08:39 egonw why were you looking for it?
08:40 shk3 because I thought that would be the expected name
08:41 egonw well, there indeed is:
08:41 egonw @TestClass("org.openscience.cdk.io.CMLReaderTest")
08:41 egonw public class CMLReader extends DefaultChemObjectReader {
08:41 shk3 hm
08:42 egonw btw, why would it be your fault?
08:42 shk3 but I can't find that class
08:42 egonw no, neither do I
08:42 shk3 sorry for confusion
08:42 shk3 I wanted to say "is it my stupidity i can't find the class or is it not there"
08:42 egonw no worries, your question did not have a context
08:42 egonw so I did not understand what you were getting at...
08:43 egonw well, running a 'find' is trivial enough
08:43 egonw so, the first question was a bit lazy :)
08:43 egonw but I can hardly say it is your fault the class does not exist
08:43 egonw that would be my fault
08:44 egonw if we check the 'git blame' it likely shows I added that @TestClass annotation
08:44 egonw anyway, the unit tests exist
08:45 egonw are you already filing a bug report about that annotation, or shall I?
08:45 shk3 if you want, please go ahead
08:45 shk3 just working on that molecule reference stuff
08:45 egonw ack
08:46 egonw check the fragment unit test classes
08:46 egonw each of those is backed up with a CML document
08:46 egonw well, that is...
08:46 egonw each unit test in those classes have the CML snippet in the corresponding CML file
08:46 egonw that's the best appraoch
08:46 egonw that allows us to see that the CML is valid
08:46 egonw the CML file has a comment pointing to the unit test...
08:48 shk3 do you have an example of those comments?
08:48 shk3 can't find them right now
08:49 egonw mom, let me boot Eclipse with my CDK workspace
08:49 shk3 sure
08:53 shk3 it looks like the 1.2 branch handles the references.
08:53 shk3 is that possible?
08:54 egonw no, that should not be possible
08:54 egonw as master is actually cdk-1.2.x with tiny extra bits
08:55 shk3 well, I tried in the jcp-primary branch first
08:55 egonw ah, compared to that one, it can be possible
08:55 shk3 what a coincidence
08:55 egonw and, yes, we really need to port of jcp-primary patches to cdk-1.2.x
08:56 egonw coincidence?
08:56 shk3 do you remember from where jcp-primary was made?
08:56 shk3 1.2
08:56 shk3 or head
08:56 shk3 ?
08:56 egonw I think 1.2.x
08:56 egonw but a *very* *long* *time* ago
08:57 shk3 how can I get the git log of a particular file?
08:57 egonw git log <FILE> ?
08:59 shk3 ah, jcp-primary was goglepox-jcp before
08:59 shk3 so it's really old
09:00 Gpox joined #cdk
09:00 shk3 yes, we need to do that merge
09:00 shk3 what procedure do you suggest?
09:00 egonw fork cdk-1.2.x, and apply then merge in the patches from jcp-primary
09:01 egonw (btw, I think that goglepox-jcp was merged with it, not that it was forked from that branch, IIRC)
09:02 shk3 that sounds like some git expert needs to do it
09:02 egonw more importantly, someone with patience and time at hand
09:05 shk3 "fork cdk-1.2.x" would mean do a git checkout -b?
09:05 shk3 and then jcp-primary would go into that
09:05 egonw yes
09:06 shk3 the branch manager (i. e. you) would then merge back into 1.2.x that branch?
09:06 egonw once the patch has been approved
09:06 egonw but the code is not clean enough for 1.2.x yet
09:06 egonw so, before that merge will happen, we're a few months further down 2009 at least
09:07 shk3 ok
09:07 shk3 what I still struggle with in git
09:07 shk3 where is data actually kep?
09:07 egonw in particular the ControllerHub needs a big rewrite
09:07 egonw what data?
09:07 egonw ah...
09:07 egonw .git
09:07 shk3 if I do git checkout -b the branch is local
09:07 shk3 ?
09:07 egonw in the root folder
09:07 shk3 I mean the branch
09:08 shk3 the repository, so to say
09:08 egonw on SF?
09:08 egonw or the local copy of the repository?
09:08 shk3 does git checkout -b create data on sf?
09:08 egonw no
09:08 shk3 so it's local?
09:09 egonw it's distributed, yes
09:09 shk3 how do other developers then get the code from the branch?
09:09 shk3 from my computer?
09:12 egonw you can put your repository on a web server, just like Mark did a few days ago
09:12 shk3 ah
09:13 shk3 that means just copy the checkout in a public webspace dir, right?
09:13 shk3 or I could directly work there, I suppose?
09:13 egonw yes, I think that would be an option
09:13 egonw if you have direct access to the web folder
09:16 shk3 ok
09:16 shk3 let me see if I try this
09:18 egonw let me know when you have something up, then I can test cloning it
09:37 egonw shk3: does it work?
09:37 shk3 sorry, did not yet try
09:40 CIA-62 cdk: shk3 * r14538 /cdk/branches/jchempaint-primary/src/main/org/‚Äčopenscience/cdk/io/cml/CMLReactionModule.java: ported changes from 1.2.x for handling atom refs
10:06 rojasm joined #cdk
10:14 shk3_ joined #cdk
11:43 jonalv IKEA++
11:43 jonalv IKEA++
11:43 jonalv IKEA++
11:43 jonalv IKEA++
11:43 jonalv IKEA++
11:43 jonalv IKEA++
11:43 zarah IKEA++
11:43 jonalv IKEA++
11:43 jonalv IKEA++
11:43 jonalv IKEA++
11:43 jonalv IKEA++
11:43 jonalv IKEA++
11:43 jonalv *lol*
11:44 egonw huh?
11:44 egonw they have free wireless in the new shop?
11:44 egonw the meatballs were really good today?
11:44 jonalv my entire apartment is from IKEA... and it had a karma of -4 earlier. clearly wrong...
11:46 masak joined #cdk
11:46 masak ANYONE IN HERE A CHEMIST?
11:46 masak REAL!?
11:46 egonw :)
11:46 jonalv ROFLOL
11:46 masak egonw need help!
11:46 jonalv can it be friday today?
11:46 masak with chemist experiment im working on
11:46 masak help
11:46 masak help
11:47 masak im trying to make a masak potion
11:47 masak so i could go fly to space and go visit olass and meklund
11:48 jonalv zarah: votekick masak
11:48 zarah jonalv: excuse me?
11:48 masak rv
11:48 jonalv zarah: you are excused
11:48 zarah jonalv: you want me to leave?
11:49 jonalv zarah: uhm no not really
11:49 zarah jonalv: eh... wha'?
11:49 masak they say the earth was made in a perfection for it not to happen!
11:49 jonalv zarah: never mind
11:49 * zarah never minds
11:49 masak anti-gravity people flying to space and all!
11:51 masak left #cdk
12:01 zarah joined #cdk
12:25 maclean joined #cdk
12:28 rojasm joined #cdk
13:00 rojasm1 joined #cdk
13:28 shk3 joined #cdk
14:14 jonalv joined #cdk

| Channels | #cdk index | Today | | Search | Google Search | Plain-Text | summary