Camelia, the Perl 6 bug

IRC log for #cdk, 2009-04-28

| Channels | #cdk index | Today | | Search | Google Search | Plain-Text | summary

All times shown according to UTC.

Time Nick Message
05:06 egonw joined #cdk
05:11 bag joined #cdk
06:01 jbrefort joined #cdk
06:35 Gpoks joined #cdk
07:03 egonw joined #cdk
07:04 rojasm joined #cdk
07:26 egonw joined #cdk
07:49 jonalv joined #cdk
07:50 egonw hi jonalv
07:51 jonalv zarah: ping
07:51 zarah jonalv: pong
07:51 jonalv egonw: hi
08:10 shk3 joined #cdk
08:12 de__maas joined #cdk
10:28 maclean joined #cdk
10:30 maclean hi
10:30 zarah privet maclean
10:31 maclean prithee, my dear thou seem fair this morn.
11:02 zarah joined #cdk
11:21 zarah joined #cdk
11:21 jonalv joined #cdk
11:21 de__maas left #cdk
11:27 Gpox maclean: pleas explain row 1059 in org.os.cdk.renderer.Renderer.java
11:27 Gpox throw new NullPointerException()
11:28 Gpox and the next line  'catch ( NullPointerException npe) ...'
11:59 maclean joined #cdk
11:59 * maclean is back
11:59 maclean Gpox : just a moment, I'll take a look
12:02 maclean Gpox : you mean in the setup() method?
12:02 Gpox yes
12:02 maclean that was debugging stuff
12:02 maclean I meant to remove it before committing
12:03 maclean sorry
12:14 CIA-58 cdk: gilleain * r14575 /cdk/branches/jchempaint-primary/src/main/o​rg/openscience/cdk/renderer/Renderer.java: Errant debugging line removed.
12:22 rojasm egonw I created in github a public copy of cdk with a branch which is where I just working. Is it so the way that we should submit the things?
12:22 rojasm I send a email to the dev-list where is the patch and the changes done!!
12:23 egonw rojasm: I do not understand your question
12:23 egonw "Is it so the way that we should submit the things?" <-
12:23 egonw sure you must submit your patches...
12:23 rojasm sorry, the question is how is the way to submit some thing
12:24 rojasm but should I do my self
12:24 egonw how you can submit your patches to GitHub so that others can pull them?
12:24 rojasm or I need the approve of others
12:26 rojasm no. It is already submitted the patches to my public github
12:26 rojasm http://github.com/miguelrojasch/cd​k/tree/miguelrojasch-formulaUpdate
12:26 egonw all CDK patches need review and approval
12:26 zarah rojasm's link is also http://tinyurl.com/chy7pt
12:26 egonw OK
12:26 egonw either email to cdk-devel or file a patch ticker on SF
12:27 rojasm ok!
12:27 egonw make sure to describe:
12:27 egonw 1. which branch it is for (cdk-1.2.x or master)
12:27 egonw 2. what the purpose and nature is
12:27 egonw what does it do? bug fix only?
12:27 egonw new functionality?
12:27 egonw just unit tests?
12:27 rojasm perfect!
12:32 rojasm what think I don't understand is the definition of patch. Patch means each commit!. Can a commit contain more of one patch? can several commits define a patch?
12:48 rojasm one other question! maybe some body knows because I can not find
12:48 rojasm to create a patch I am using the command:
12:48 rojasm >git format-patch master
12:48 rojasm do you know where are stored the created files containing the patches
12:50 shk3 in the directory you did the call
12:50 shk3 at least that happened for me
12:52 maclean agreed
12:52 rojasm mmm. thanks
12:52 maclean called like 001-mybranch.patch
12:52 rojasm some thing is not doing well
12:53 maclean how so?
12:53 jbrefort joined #cdk
12:54 rojasm I don't know maybe is because I push already to my public github directory
12:55 rojasm pushed
12:55 rojasm do you know if could it be that the reason?
12:56 maclean okay, so that sounds like there is no difference between your working tree (the visible files) and the files in the .git directory (the staging area)
12:56 rojasm yes that is right
12:56 maclean right, so the patch command won't work, because they are the same, I suppose.
12:57 rojasm mmm
12:58 maclean ahhh. shk3 says there is a way to do this
12:58 maclean you give the patch command the hash of commit /before/ the one you want.
13:00 rojasm achso I think I guess what you are saying. I will check if I can find
13:18 egonw rojasm: give it the last common commit hash
13:18 egonw git format-patch hash
13:18 egonw where hash is the last commit in common with master or cdk-1.2.x
13:23 rojasm I did> git format-patch R1..R2
13:24 rojasm R revision/commit
13:25 egonw never tried that syntax
14:26 rojasm1 joined #cdk
14:37 CIA-58 cdk: gilleain * r14576 /jchempaint/trunk/src/main/​org/openscience/jchempaint/ (4 files in 4 dirs):
14:37 CIA-58 cdk: - Refactoring of the JChemPaint class to allow for two readFrom...() methods.
14:37 CIA-58 cdk: - Workaround for running and testing in eclipse.
14:42 de__maas joined #cdk
14:43 de__maas left #cdk
14:52 rajarshi joined #cdk
15:01 rojasm1 left #cdk
15:50 timvdm joined #cdk
15:58 Andreas joined #cdk
16:01 egonw dinner time
16:01 egonw bbl
16:41 arsenic joined #cdk
16:41 arsenic hi
16:41 zarah ni hao arsenic
16:41 maclean hi As
17:04 rajarshi joined #cdk
17:19 Andreas hi
17:20 zarah hi Andreas
17:20 Andreas i have a problem with the branch i have downloaded with git
17:21 Andreas the classes SMARTSParser, NomParser could not be resolved
17:21 Andreas can anyone help me with this problem?
17:25 rajarshi which branch did you download?
17:27 Andreas i have downloaded it today
17:27 rajarshi what is the command you used?
17:28 Andreas $ git clone git://cdk.git.sourceforge.net/gitroot/cdk
17:31 Andreas commit 28ef9d03dc82452b8f390de73e51343615a1dffb
17:31 Andreas Author: Rajarshi  Guha <rajarshi.guha@gmail.com>
17:31 Andreas Date:   Mon Apr 27 13:48:56 2009 -0400
17:32 rajarshi ok
17:32 rajarshi do you have ant 1.7.1?
17:35 Andreas is as a plugin installed
17:35 rajarshi ok
17:35 rajarshi does ant clean dist-all give any errors?
17:43 Andreas the error is that it could not find ant 1.7.1. i have both installed 1.7.0 and 1.7.1
17:43 Andreas how can i switch between them?
17:43 rajarshi i'm not sure how ant interacts with Eclipse
17:43 rajarshi you could try getting rid of 1.7.0
18:02 bag joined #cdk
18:06 Andreas ant dist-all does make no errors
18:07 rajarshi good, so you should be set
18:09 Andreas but how can i start a single unit test?
18:10 Andreas The errors are still there.
18:10 rajarshi make sure you have done ant test-dist-all jarTestdata
18:10 rajarshi then see http://rguha.net/code/java/#btest
18:10 rajarshi what error?
18:14 rajarshi hmmm, possibly Eclipse doesn't know about the autogenerated source files (which are generated for the Nom & SMARTS parsers)
18:14 rajarshi I don't use Eclipse so not sure about that
18:15 rajarshi but from the command line within the cdk directory you should be able to do:
18:15 rajarshi ant clean dist-all test-dist-all jarTestdata
18:15 rajarshi and get a clean build
18:15 rajarshi if you just want to use the CDK (as opposed to developing the library itself) do
18:15 rajarshi ant dist-large
18:15 rajarshi after the previous ant command and you get the single jar file with everything in it
18:16 Andreas ok thanks i will try to get it work ahve a nice evening
18:25 rajarshi good luck
18:43 Andreas good n8
19:48 edrin joined #cdk
19:58 jbrefort joined #cdk
20:26 maclean joined #cdk
23:56 Conrad joined #cdk

| Channels | #cdk index | Today | | Search | Google Search | Plain-Text | summary