Camelia, the Perl 6 bug

IRC log for #cdk, 2009-07-10

| Channels | #cdk index | Today | | Search | Google Search | Plain-Text | summary

All times shown according to UTC.

Time Nick Message
06:20 jbrefort joined #cdk
06:24 egonw joined #cdk
06:34 jpansanel moin
06:34 zarah saluton jpansanel
06:43 egonw hi jpansanel
07:16 mgerlich joined #cdk
07:23 mgerlich joined #cdk
08:00 mgerlich joined #cdk
08:20 shk3 joined #cdk
08:45 jbrefort joined #cdk
09:04 rojasm joined #cdk
10:56 CIA-61 blueobelisk: pansanel * r295 /structures/trunk/src/jmol/ (20 files): Add unsigned applet
11:00 CIA-61 blueobelisk: pansanel * r296 /structures/tags/2.2.0/: Create 2.2.0 tag
11:05 CIA-61 blueobelisk: pansanel * r297 /structures/tags/2.2.0/trunk/: release 2.2.0
11:07 CIA-61 blueobelisk: pansanel * r298 /structures/tags/2.2.0/: dir fix
11:07 CIA-61 blueobelisk: pansanel * r299 /structures/tags/2.2.0/: release 2.2.0
11:08 CIA-61 blueobelisk: pansanel * r300 /structures/tags/2.2.0/: Could not fix copy path
11:09 CIA-61 blueobelisk: pansanel * r301 /structures/tags/2.2.0/: release 2.2.0 (final)
11:09 jpansanel ok
11:09 jpansanel it's done
11:20 rojasm joined #cdk
11:28 shk3 joined #cdk
11:29 carsten joined #cdk
11:34 egonw jpansanel++
12:18 jpansanel moin egonw
12:18 jpansanel carsten : the new version of Chemical Structures is released
12:27 carsten wow, 1.5 years since the last version :)
12:27 sneumann joined #cdk
12:29 carsten New structures :
12:29 carsten - 4-Aminobutanoic acid
12:29 carsten jpansanel: do you have a full list?
12:30 carsten jpansanel: would be nice to have. Perhaps you could send it to me (if there is such a list)
12:30 carsten I have to go now
12:30 carsten b
12:30 carsten ye
12:57 maclean joined #cdk
13:01 maclean hi egonw, shk3
13:01 egonw hi maclean
13:01 maclean what's the problem with the calculateBondLength method?
13:02 egonw what does it do?
13:02 egonw that is
13:02 maclean take a guess :)
13:02 egonw in what coordinate system?
13:02 maclean model space
13:02 egonw well, being in the renderer, I would say screen coordinates
13:02 maclean no
13:02 maclean but I can see your thinking
13:02 egonw :)
13:02 egonw but this is good
13:03 egonw now I know I can move it out of there...
13:03 maclean I have no problem with it being moved to GeometryTools, or wherever
13:03 maclean bounding boxes, also.
13:03 maclean as this is a general calculation (in the reaction generators, for example)
13:04 maclean I only put this stuff in the Renderer as it was a convenient place at the time, and to reduce the spread of changes to other classes.
13:04 egonw I like the BoundsCalculator
13:04 egonw will use that
13:04 maclean ok cool.
14:11 egonw compiling with BoundsCalculator...
14:12 egonw ok, so far so good
14:13 egonw now, removing the matching methods from Renderer
14:14 egonw mmm... I see another two git history changes coming up...
15:00 egonw 7 compile errors left
15:36 maclean joined #cdk
16:07 egonw maclean: http://pele.farmbio.uu.se/cgi-bin/gitweb.​cgi?p=jchempaint-primary.git;a=commit;h=9​31ae7aa22adf963f9eb10ce800d2746c8365b78
16:07 zarah egonw's link is also http://tinyurl.com/mtprhp
16:08 maclean cool.
16:08 egonw also note that the pile of patches in 0-other is seriously increasign now:
16:08 egonw http://pele.farmbio.uu.se/cgi-bin/gitweb.​cgi?p=jchempaint-primary.git;a=commit;h=9​31ae7aa22adf963f9eb10ce800d2746c8365b78
16:08 zarah egonw's link is also http://tinyurl.com/mtprhp
16:10 maclean that's the same link
16:11 maclean indeed, the tinyurl is the same :)
16:11 egonw http://pele.farmbio.uu.se/cgi-bin/​gitweb.cgi?p=jchempaint-primary.gi​t;a=shortlog;h=refs/heads/0-other
16:11 zarah egonw's link is also http://tinyurl.com/lbbv25
16:11 egonw sorry... something went bad with the C/P
16:12 maclean no problem.
16:12 maclean Okay, so that link is to a list of things.
16:12 maclean So....
16:12 maclean What about it?
16:13 maclean As in : can I help with it, or?
16:13 egonw 0-other is the list of patches that need to be provided as first set of patches to the CDK
16:13 egonw ah, no
16:13 egonw never mind :)
16:13 maclean Oh, ok. I see one of mine in there.
16:14 maclean Hmm. "moved the shift method to the renderer"
16:14 maclean I tried not to do that kind of thing for exactly the reason that it is in this list.
16:15 egonw :)
16:16 maclean I mean, now anyone that was using getClosestAtom will find that it works differently. Not good.
16:18 egonw true
16:18 maclean well, at least the method signature is different, so it won't silently break.
16:18 egonw I agree that I don't think these patches are final
16:18 egonw just reordering what the current SVN jchempaint-primary is
16:18 egonw ummm... of course I agree about what I think....
16:19 egonw what was I thinking!
16:19 egonw I meant:
16:19 egonw I agree: I don't think these patches are final
16:19 egonw well, the method was introduced only in jcpprim
16:19 egonw so it does not actually break something when it changed API
16:19 egonw that's good...
16:20 egonw mmm... just realized that I need to check if those patches came with unit tests!
16:21 maclean not mine. I have made few unit tests until this signature stuff.
16:50 shk3 joined #cdk
16:59 shk3 joined #cdk
17:25 shk3 egonw: if I have a bugfix for the DragBondModule, what shall I do with that?
17:25 shk3 commit?
17:25 shk3 email patch)
17:25 shk3 ?
17:25 CIA-61 cdk: shk3 * r14677 /jchempaint/trunk/src/main/org/openscience​/jchempaint/action/ChangeModeAction.java: if a new bond is added, the new atom(s) are now of the element selected before
17:31 egonw please email patch
17:31 egonw preferably created with git format-patch
17:38 shk3 against which branch?
17:52 egonw preferably the one on pele
18:46 edrin joined #cdk
20:14 edrin joined #cdk

| Channels | #cdk index | Today | | Search | Google Search | Plain-Text | summary