Camelia, the Perl 6 bug

IRC log for #cdk, 2010-08-02

| Channels | #cdk index | Today | | Search | Google Search | Plain-Text | summary

All times shown according to UTC.

Time Nick Message
02:03 Conrad joined #cdk
03:52 azeem joined #cdk
05:08 sneumann joined #cdk
05:33 egonw joined #cdk
05:34 bag_ joined #cdk
06:00 jbrefort joined #cdk
06:17 sneumann joined #cdk
07:05 s_wolf joined #cdk
08:05 jkerssem joined #cdk
08:07 mgerlich joined #cdk
08:14 egonw joined #cdk
08:15 s9asad joined #cdk
10:01 jkerssem hi, anyone awake?
10:04 egonw joined #cdk
10:09 jkerssem Hi egonw
10:11 egonw hi jkerssem
10:12 jkerssem how's Oxford?
10:12 jkerssem In the meanwhile, I've had a look at your comments for the SMSD molhandler
10:13 jkerssem and I've made an updated patch in a separate branch
10:13 jkerssem (posted)
10:13 jkerssem I
10:13 jkerssem 'm wondering now
10:14 jkerssem if I want to fix the bug you mentioned (weird use of Iloggingtool...) as well
10:14 jkerssem how would I proceed?
10:14 jkerssem second patch in the same new branch?
10:14 jkerssem or new patch in new branch?
10:14 jkerssem the thing is, the fix of the Loggingtool capitalisation also affects the patch I just posted
10:15 jkerssem so I would need that included
10:15 jkerssem but it is a different fix, so it should be in its own branch
10:17 jkerssem I'm puzzled by the dilemma..
10:18 egonw :)
10:18 egonw yeah, you need to choose an order here...
10:18 egonw but I guess we wait for s9asad to reply
10:19 egonw I have not had time to look at his latest patch yet
10:21 s9asad Hi folks
10:21 s9asad I have made changes in the SMSD API
10:21 s9asad send me the changes, I will add to the SMSD code, if I haven't done at mine end and submit the whole lot together
10:22 s9asad Egon, why not come down to Cambridge :-)
10:23 s9asad @jkerssem, the new patch of the SMSD is much faster and IQueryAtomContainer will help you compare SMILES/SMARTS
10:25 egonw joined #cdk
10:27 egonw [08/02/10 11:18] <egonw> :)
10:27 egonw [08/02/10 11:18] <egonw> yeah, you need to choose an order here...
10:27 egonw [08/02/10 11:18] <egonw> but I guess we wait for s9asad to reply
10:27 egonw [08/02/10 11:19] <egonw> I have not had time to look at his latest patch yet
10:27 s9asad egonw: Did you enjoy fish and chips ;-)
10:28 egonw no, not yet
10:28 egonw have that scheduled for saturday
10:28 s9asad planning to visit EBI?
10:30 egonw but going too
10:32 egonw joined #cdk
10:35 egonw joined #cdk
10:44 jkerssem smart move scheduling fish-n-chips for saturday, if you don't like it, you'll have the whole weekend to recover :P
10:44 jkerssem s9asad, can I send you a combined patch file? it's just a few lines that were replaced
10:47 s9asad jkerssem, yes please...send it to me by mail.
10:47 jkerssem okay, incoming :)
10:49 egonw joined #cdk
10:49 jkerssem sent!
11:04 egonw_ joined #cdk
11:44 s9asad joined #cdk
12:15 egonw_ joined #cdk
12:45 s9asad joined #cdk
12:57 egonw__ joined #cdk
12:59 egonw__ joined #cdk
12:59 CIA-51 cdk: Jules Kerssemakers master * r1201e01 / src/main/org/openscience/cdk​/smsd/tools/MolHandler.java :
12:59 CIA-51 cdk: Added finally blocks to MolHandler to close its input streams, with proper logging calls if it fails Fixes bug #3032568
12:59 CIA-51 cdk: Signed-off-by: Egon Willighagen <egonw@users.sourceforge.net> - http://bit.ly/a5egw7
13:14 s9asad @Jules I have committed your changes in the latest version of the SMSD http://github.com/downloads/asad/cdk/patches.zip
13:15 s9asad Now its up to the reviewers  to review and commit them
13:15 jkerssem okay :-)
13:15 jkerssem I hope my comments were helpfull
13:15 s9asad thanks for the atches
13:16 s9asad patches ...indeed
13:16 jkerssem great :)
13:20 egonw__ joined #cdk
13:25 s9asad egon, oh...the latest update on the molhanlder chokes my upstream merge
13:25 s9asad :-(
13:25 s9asad as my commit s are not included yet!
13:27 egonw__ mmm... sorry abou that
13:31 egonw__ s9asad: do you manage updating the conflicting patch manually?
13:31 egonw__ otherwise, I'll have a look at it when I review your patches...
13:31 egonw__ for which I have not had time yet...
13:32 s9asad I have included the patches in my submission
13:32 s9asad If you could kindly review it and push them then we can sync it
13:39 egonw_ joined #cdk
13:45 egonw_ joined #cdk
13:47 egonw_ joined #cdk
13:54 s_wolf joined #cdk
14:35 s9asad joined #cdk
14:36 egonw_ joined #cdk
14:43 egonw_ joined #cdk
14:54 egonw__ joined #cdk
16:12 egonw joined #cdk
16:18 egonw joined #cdk
16:24 egonw joined #cdk
16:28 egonw_ joined #cdk
16:39 egonw__ joined #cdk
17:05 egonw__ joined #cdk
17:28 s9asad joined #cdk
18:27 sneumann joined #cdk
19:54 s9asad joined #cdk
20:18 sneumann_ joined #cdk
20:29 s9asad joined #cdk
22:12 egonw__ joined #cdk
22:20 bag_ joined #cdk
22:26 asad_ joined #cdk
23:44 azeem joined #cdk

| Channels | #cdk index | Today | | Search | Google Search | Plain-Text | summary