Camelia, the Perl 6 bug

IRC log for #cdk, 2011-07-02

| Channels | #cdk index | Today | | Search | Google Search | Plain-Text | summary

All times shown according to UTC.

Time Nick Message
04:47 jbrefort joined #cdk
06:25 sneumann joined #cdk
06:42 sneumann left #cdk
06:42 egonw joined #cdk
08:25 jbrefort left #cdk
09:42 slyrus left #cdk
11:12 sneumann joined #cdk
12:00 sneumann left #cdk
12:52 CIA-107 cdk: Egon Willighagen cdk-1.4.x * rd2e502e / (2 files in 2 dirs): Replaced cdk.svnrev with cdk.githash - http://bit.ly/kSNbQx
12:56 CIA-107 cdk: Egon Willighagen cdk-1.4.x * re41a9c7 / (2 files in 2 dirs): Replaced cdk.author with just @author - http://bit.ly/ixI7Pl
13:50 sneumann joined #cdk
14:09 sneumann left #cdk
14:10 maclean joined #cdk
14:10 maclean hi egonw
14:11 egonw maclean: good timing!
14:11 maclean oh?
14:11 egonw maclean: please check the cdk-jchempaint ML
14:11 egonw got a burning question
14:11 egonw maybe you know the answer :)
14:11 * egonw is doing JavaDoc fixing, because no one else is
14:11 maclean Huh. Thought I was on that ML.
14:11 egonw I think you are
14:11 egonw just sent the message a minute ago :)
14:12 egonw hence the timing remark :)
14:12 maclean oh
14:13 maclean got it
14:16 maclean Right. method { public paint(T, IDrawVisitor) : Rectangle } returns the size of the thing drawn.
14:16 maclean While { public paint(T, IDrawVisitor, Rectangle) : void } draws within the supplied rectangle.
14:18 egonw ack
14:19 egonw oh, thanx for the review!
14:20 maclean n/p
14:27 maclean left #cdk
14:39 CIA-107 cdk: Egon Willighagen cdk-1.4.x * r5ccf7d7 / (3 files): Removed @inheritDoc because the method does not override any method - http://bit.ly/lquMAr
14:39 CIA-107 cdk: Egon Willighagen cdk-1.4.x * rda493da / javadoc.xml : Fixed false positives about missing Jena classes, by including those jars to the classpath too - http://bit.ly/mgZSIw
14:39 CIA-107 cdk: Egon Willighagen cdk-1.4.x * r789a6a4 / (18 files in 15 dirs): Fixed various JavaDoc errors - http://bit.ly/jyq1qF
14:41 CIA-107 cdk: Egon Willighagen cdk-1.4.x * r1d2d707 / src/test/org/openscience/cdk/rendere​r/generators/BasicGeneratorTest.java :
14:41 CIA-107 cdk: Updated unit tests according to cdk-jchempaint ML: we expect 1 AtomSymbolElement
14:41 CIA-107 cdk: Signed-off-by: maclean <gilleain.torrance@gmail.com> - http://bit.ly/iZFuwI
14:41 CIA-107 cdk: Egon Willighagen cdk-1.4.x * rdf7c7f5 / src/test/org/openscience/cdk/rende​rer/AtomContainerRendererTest.java :
14:41 CIA-107 cdk: Updated unit tests according to cdk-jchempaint ML: we expect Line and Oval elements
14:41 CIA-107 cdk: Signed-off-by: maclean <gilleain.torrance@gmail.com> - http://bit.ly/lsddJW
15:12 CIA-107 cdk: Jonty Lawson cdk-1.4.x * r185520e / (2 files in 2 dirs):
15:12 CIA-107 cdk: Fixed bug in RingGenerator: it now returns the parameters from the superclass too
15:12 CIA-107 cdk: Signed-off-by: Egon Willighagen <egonw@users.sourceforge.net> - http://bit.ly/jlhUoA
15:14 sneumann joined #cdk
16:27 maclean joined #cdk
16:30 egonw thanx!
16:31 maclean n/p. looking at 3340660 next.
16:31 egonw ok, cool
16:31 egonw leave 3334824 for Rajarshi
16:32 egonw he said he was going to look at that
16:32 maclean ok, thought so.
16:32 egonw but it is huge, and an extra pair of eyes will certainly not be appreciated
16:32 egonw ok, called for dinner now
16:32 egonw bbl
16:32 CIA-107 cdk: Egon Willighagen cdk-1.4.x * rbb51081 / src/main/org/openscience/cdk/mode​ling/builder3d/AtomPlacer3D.java :
16:32 CIA-107 cdk: Fixed spelling error, and added useful whitespace
16:32 CIA-107 cdk: Signed-off-by: maclean <gilleain.torrance@gmail.com> - http://bit.ly/m6chni
16:35 maclean ok, cu
18:00 maclean left #cdk
18:38 CIA-107 cdk: Jules Kerssemakers cdk-1.4.x * rdf59d71 / src/main/org/openscience/cdk/tools/manip​ulator/MolecularFormulaManipulator.java :
18:38 CIA-107 cdk: MolecularFormulaManipulator: fixed whitespacing / bracket style. "Whitespace
18:38 CIA-107 cdk: only" - consistently indented with tabs (was mixed) - made javadoc indent
18:38 CIA-107 cdk: consistent - made {}-use in if/else-if blocks consistent - made 'if(' vs. 'if ('
18:38 CIA-107 cdk: consistent (also for else/for)
18:38 CIA-107 cdk: Signed-off-by: maclean <gilleain.torrance@gmail.com> - http://bit.ly/lBWS47
18:38 CIA-107 cdk: Jules Kerssemakers cdk-1.4.x * rc248d16 / src/main/org/openscience/cdk/tools/manip​ulator/MolecularFormulaManipulator.java :
18:38 CIA-107 cdk: MolecularFormulaManipulator: added element symbols in generateOrderEle* . - added symbols up to and including "Cn" (#112) - updated accompanying JavaDoc - fixes CDK bug #3340660
18:38 CIA-107 cdk: Signed-off-by: maclean <gilleain.torrance@gmail.com> - http://bit.ly/j0Vy4p
18:38 CIA-107 cdk: Egon Willighagen cdk-1.4.x * rd2a2162 / src/test/org/openscience/cdk/tools/manipul​ator/MolecularFormulaManipulatorTest.java :
18:38 CIA-107 cdk: Unit tests for helium and americum for MF string generation
18:38 CIA-107 cdk: Signed-off-by: maclean <gilleain.torrance@gmail.com> - http://bit.ly/lNKUkL
18:38 zarah bug #3340660 | http://tinyurl.com/3f92ya9
18:39 jbrefort joined #cdk
18:56 CIA-107 cdk: Egon Willighagen cdk-1.4.x * rbeab5b3 / src/main/org/openscience/c​dk/layout/AtomPlacer.java : Added Test[Method|Class] annotation - http://bit.ly/jJaYVh
18:56 CIA-107 cdk: maclean cdk-1.4.x * r5438093 / (2 files in 2 dirs):
18:56 CIA-107 cdk: A test class for the atom placer, and a couple of unit tests
18:56 CIA-107 cdk: Signed-off-by: Egon Willighagen <egonw@users.sourceforge.net> - http://bit.ly/iR7eYG
18:59 CIA-107 cdk: Dmitry Katsubo cdk-1.4.x * r3ad6073 / src/main/org/openscience/c​dk/layout/AtomPlacer.java :
18:59 CIA-107 cdk: Fixed potential NPE. Also moved the debug statement inside the loop so that each atom in the list is reported.
18:59 CIA-107 cdk: Signed-off-by: maclean <gilleain.torrance@gmail.com> - http://bit.ly/muwbsw
19:46 jbrefort left #cdk
20:02 sneumann left #cdk
20:23 egonw left #cdk

| Channels | #cdk index | Today | | Search | Google Search | Plain-Text | summary