Camelia, the Perl 6 bug

IRC log for #cdk, 2011-08-11

| Channels | #cdk index | Today | | Search | Google Search | Plain-Text | summary

All times shown according to UTC.

Time Nick Message
04:47 egonw joined #cdk
05:40 jbrefort joined #cdk
06:55 Alchimis1e moin
06:56 egonw hi Alchimiste
06:58 Alchimiste hi egonw
07:01 Gpox joined #cdk
07:52 CIA-90 cdk: Miguel Rojas Cherto cdk-1.4.x * r9733d0e / (2 files in 2 dirs):
07:52 CIA-90 cdk: closed @cdk.bug 3273205 and created a test. Control that IsotopeContainer doesn't get null.
07:52 CIA-90 cdk: Signed-off-by: Egon Willighagen <egonw@users.sourceforge.net> - http://bit.ly/ojYCZB
07:52 CIA-90 cdk: Egon Willighagen cdk-1.4.x * rf6076d5 / src/test/org/openscience/cdk/formul​a/IsotopePatternGeneratorTest.java : Removed usefull JavaDoc - http://bit.ly/nCfF0n
07:56 jonalv joined #cdk
08:25 CIA-90 cdk: Egon Willighagen cdk-1.4.x * r28597f1 / build.props : Indicate that this is the current development tree - http://bit.ly/po2ORk
08:28 s9asad joined #cdk
08:28 egonw hi s9asad
08:29 s9asad Hi egonw
08:30 s9asad how many more AT yet to me reviewed :-)
08:31 egonw dunno... check the commit messages...
08:31 egonw I'm at 50% ?
08:31 egonw haven't counted myself
08:31 s9asad let me check
08:34 s9asad looks like S, N and Ca are major ones
08:35 s9asad but thats great we have rest of them in!
08:35 egonw S and N are more complicated once, and I did not have time to sit down for those yet
08:35 egonw I also skipped P so far
08:35 s9asad yes P too
08:35 s9asad I was about to highlight that
08:36 s9asad will you merge these with current branch?
08:36 s9asad master*
08:37 egonw yeah, that's been a while
08:38 CIA-90 cdk: Egon Willighagen master * r139c70a / (9 files in 8 dirs): Merged branch cdk-1.4.x (+31 more commits...) - http://bit.ly/ri4nYl
08:40 egonw there you go
08:40 s9asad awesome!
08:40 s9asad :-)
08:41 egonw ok, getting coffee + cake now
08:41 egonw bbl
08:42 s9asad k
09:04 s9asad hi egonw:
09:07 s9asad @egonw: wondering if I can send you a formatted (just the indent) CDKAtomTypeMatcher.java. This will fix the swirly "if else" loops and thereby making it easier to see whats changing?
09:09 egonw I rather like to hold that of for now
09:09 egonw it's bound to give trouble with the remaining AT patches
09:27 s9asad sure
09:27 s9asad I will hold on
09:28 s9asad Can I help you in anyway as I have some time today
09:28 s9asad @egonw
09:29 egonw what do you got in mind?
09:29 egonw patch reviewing, writing some patches, do some blogging?
09:29 egonw bug fixing?
09:29 egonw or just writing unit tests for bug reports, confirming the bug?
09:32 egonw so, pick something you like
09:32 egonw help on all those fronts is very much appreciated!
09:37 egonw but hold off reviewing of the Ag atom type patch...
09:37 egonw someone from France joined yesterday here online and was working on it
09:37 s9asad I see
09:38 egonw do you like a suggestion?
09:38 s9asad Ag patches I can try
09:38 egonw no,no... don't do that one
09:38 s9asad is there a new one?
09:39 egonw yes
09:39 s9asad I see
09:39 s9asad where can I find it?
09:39 egonw Nimish' work did not have all silver atom types
09:39 egonw in the patch tracker
09:39 s9asad yes we just covered the KEGG types
09:39 egonw but again, the French guy is already reviewing it
09:39 s9asad I see
09:40 s9asad then I will wait for his answer
09:40 egonw there are not so many patches that need review right now (which are not with the author for updates)
09:40 s9asad I can send you formatted codes patches for CDK
09:40 egonw ones that do need reviewing:
09:40 egonw 3366321silent module like nonotify but better
09:40 egonw 3334824Make isomorphism independent of data
09:40 s9asad sure
09:40 s9asad I will have a look
09:40 egonw 3370547Patch that moves ArrowElement from CDK-JCP to renderbasic
09:40 egonw but those are all pretty big, unfortunately
09:41 egonw which is why they are not done yet, I guess
09:41 s9asad I see
09:42 s9asad Can I send the intend patches which do no require any reviewing at your end but just push...will make the CDK code look good
09:42 s9asad there are alot of codes where else if loops are hanging
09:43 egonw all patches need reviewing
09:43 egonw but yeah, please do submit if you have some done
09:43 egonw good looking code is somewhat subjective
09:43 s9asad sure but they will require eye balling :-) (I don't want to increase you work, just a suggestion)
09:43 egonw and I am not sure what your patches in fact do
09:44 egonw well, try to get more people reviewing patches is a worthy CDK task
09:44 s9asad sure thats a good suggetion
09:44 egonw patches like this do not require reviewing by specifically me
09:45 s9asad from EBI its gilleain, me and may be others
09:45 egonw but I think there are more important tasks than whitespace fixing
09:45 s9asad but I am not very good with git
09:45 egonw yeah, you should learn that
09:45 egonw you're bright enough... you'd have no problem with it
09:45 egonw read this book:
09:45 egonw http://newartisans.com/2008​/04/git-from-the-bottom-up/
09:46 egonw you'd read this book in an hour or two, and then git use would be trivial
09:46 s9asad hmm, looks intesreting
09:46 egonw follow and repeat the examples, and you're an expert in no time
09:46 egonw it's really a good book
09:46 s9asad interesting*
09:46 s9asad I always get stuck with the branching and patch geneartion
09:47 s9asad and my short cut is rebase!
09:47 s9asad so I want to fix this logic :-), will read this book
09:48 egonw yeah, if you have time this afternoon, I can most certainly recommend this as a CDK task :)
09:49 s9asad hahhaa sure
09:49 s9asad I am actually reading it
09:49 s9asad let me know if you are successful with more AT patches
09:50 s9asad now me on happy reading ....
09:51 egonw oh, just running into the "The Structures and Physicochemical Properties of Organic Cofactors in Biocatalysis" paper... it is using the CDK?
09:51 egonw if so, I have a second suggestion task: blog about it, and let the readers know how you use the CDK :)
09:53 s9asad another good suggestion.. :-)
09:53 s9asad seems like you enjoyed your coffee and cake!
09:54 egonw yeah, brilliant chocolate cake :)
09:54 s9asad super!
10:57 CIA-90 cdk: mark_rynbeek * r15618 /jchempaint/trunk/ (8 files in 5 dirs): Minor bugfixes
11:04 s9asad joined #cdk
14:48 zarah joined #cdk
17:51 jbrefort joined #cdk
20:59 s9asad joined #cdk

| Channels | #cdk index | Today | | Search | Google Search | Plain-Text | summary