Camelia, the Perl 6 bug

IRC log for #darcs, 2013-02-04

| Channels | #darcs index | Today | | Search | Google Search | Plain-Text | summary

All times shown according to UTC.

Time Nick Message
00:14 mizu_no_oto joined #darcs
00:15 whaletechno joined #darcs
03:38 carter joined #darcs
03:40 delamonpansie joined #darcs
04:06 preflex_ joined #darcs
06:49 kowey joined #darcs
08:01 raichoo joined #darcs
09:23 gh_ joined #darcs
09:39 raichoo joined #darcs
10:02 raichoo joined #darcs
10:18 iago joined #darcs
10:32 owst joined #darcs
10:46 gh_ hi
10:52 favonia joined #darcs
10:54 owst joined #darcs
11:22 bsrkaditya joined #darcs
11:51 owst joined #darcs
12:19 bsrkaditya Hi,
12:19 bsrkaditya Is there anybody to screen my latest patch?
12:20 bsrkaditya http://bugs.darcs.net/patch1017
12:25 owst bsrkaditya: what's "f"?
12:26 owst I don't like the f [] = [15] case - use Maybe and fromMaybe
12:27 owst Also, your patch message could say how it fixes the problem - you pad spaces based on the maximum command size, rather than arbitrarily chosing 15.
12:38 bsrkaditya owst: f is just a local function, that does not merit it's own name. Briefly, it is supposed to give the command sizes.
12:38 bsrkaditya The f [] = [15] case, this is so that the default is at-least 15. Also, maximum does not work on an empty list. I do not understand what you mean in this line.
12:38 bsrkaditya Yeah, I should have had a more elaborate patch message.
12:38 bsrkaditya
12:40 owst bsrkaditya, I understand what's its supposed to be doing, but it's precisely because you have to say "briefly..." that it *does* merit a descriptive name (or at least a comment)
12:40 * owst should really leave quit messages.
12:41 * owst should also proof read his messages: s/leave/read/
12:41 bsrkaditya joined #darcs
12:41 owst bsrkaditya: I left some comments on the bugtracker
12:41 owst 12:41:49       owst | bsrkaditya, I understand what's its supposed to be doing, but it's precisely because you have to say "briefly..." that it *does* merit a descriptive name (or at least a comment)
12:44 bsrkaditya okay, owst will attend to them!
12:45 owst I'm not really sure what I suggest re: maybe
12:45 owst essentially you're folding over the list with maxmimum (on the CommandData constructors), with 15 as the initial value
12:46 bsrkaditya yes.
12:46 bsrkaditya I could create a function CommandControl -> Maybe Int
12:46 bsrkaditya and then map this to the input
12:47 bsrkaditya use catMaybe
12:47 bsrkaditya add 15 at the start
12:47 bsrkaditya and finally use maximum
12:48 bsrkaditya Is this acceptable?
12:51 owst Yeah, that sounds good: maxmimum $ 15 : catMaybes (map fooer input)
12:51 owst_ joined #darcs
12:51 owst joined #darcs
12:51 owst bsrkaditya: Yeah, that sounds good: maxmimum $ 15 : catMaybes (map fooer input)
12:52 bsrkaditya can I call fooer f?
12:53 owst toMaybeCmdLen or something would be better
12:53 owst CmdNameLen?
12:53 owst I don't know :-)
13:05 mizu_no_oto joined #darcs
13:06 bsrkaditya owst: Just want to confirm, is it okay for the patch name to be that long?
13:06 owst That's fewer than 80 chars or so?
13:07 bsrkaditya 78 chars, so I guess it is okay
13:07 owst I'd personally submit a patch with a name up to that long. If it doesn't fit, stick it in the long message
13:09 bsrkaditya okay owst, new patch
13:10 bsrkaditya it is made using amend-record, but I hope that will not be a problem
13:11 owst That's fine, just send it with the messsage: --subject 'patchXXXX' or whatever it is (check the wiki to look at how to send followups)
13:11 bsrkaditya I sent it using the web interface.
13:12 owst Ah, ok
13:16 raichoo joined #darcs
13:17 raichoo joined #darcs
13:23 owst bsrkaditya: set the BTS entry for that patch back to needs screening
13:24 bsrkaditya owst: done
13:27 owst Cool
13:32 bsrkaditya left #darcs
13:38 mizu_no_oto joined #darcs
14:17 raichoo joined #darcs
14:23 favonia joined #darcs
14:46 mizu_no_oto joined #darcs
14:54 mizu_no_oto joined #darcs
15:02 owst Do you want to unrevert these changes? [Yglqk...], or ? for more options: y
15:02 owst You will not be able to unrevert this operation! Proceed? y
15:02 owst Umm :-)
15:02 owst unrevert unreverting? confusing!
15:04 iago ?
15:06 owst I was unreverting some changes "do you want to unrevert...", but darcs told me "You will not be able to unrevert this operation" - that's confusing!
15:06 iago a bit "funny" but understandable I guess
15:06 iago does changing "unrevert" by "undo" would help?
15:07 owst I don't think I've seen it before. I only selected some of the changes offered to me by unrevert - I suppose the remaining changes I didn't select would be lost
15:08 iago uhm yep, I see
15:09 donri joined #darcs
15:09 iago «Darcs will ask for confirmation before executing an
15:09 iago interactive command that will DEFINITELY prevent unreversion.»
15:09 iago if that's the case then the message is not clear
15:23 * sm reads http://darcs.net/DarcsWeeklyNews/2013-02-04 .. nice
15:26 dcoutts joined #darcs
15:26 dcoutts joined #darcs
15:32 byorgey win 11
16:11 jeltsch joined #darcs
16:27 kmels__ joined #darcs
16:36 raichoo joined #darcs
16:38 mizu_no_oto joined #darcs
16:56 owst joined #darcs
17:44 mizu_no_oto joined #darcs
18:14 kmels_ joined #darcs
18:19 mizu_no_oto joined #darcs
18:28 amgarchIn9 joined #darcs
19:20 carter_ joined #darcs
20:02 jeltsch joined #darcs
22:21 owst joined #darcs
22:43 delamonpansie joined #darcs

| Channels | #darcs index | Today | | Search | Google Search | Plain-Text | summary