Camelia, the Perl 6 bug

IRC log for #darcs, 2013-09-17

| Channels | #darcs index | Today | | Search | Google Search | Plain-Text | summary

All times shown according to UTC.

Time Nick Message
00:00 xymox joined #darcs
00:08 xymox joined #darcs
00:16 xymox joined #darcs
00:25 xymox joined #darcs
00:26 mizu_no_oto joined #darcs
00:33 xymox joined #darcs
00:41 xymox joined #darcs
00:45 favonia joined #darcs
00:49 xymox joined #darcs
00:58 xymox joined #darcs
01:08 xymox joined #darcs
01:17 xymox joined #darcs
01:25 xymox joined #darcs
01:33 xymox joined #darcs
01:42 xymox joined #darcs
01:46 intripoon_ joined #darcs
01:52 xymox joined #darcs
02:02 xymox joined #darcs
02:11 xymox joined #darcs
02:26 xymox joined #darcs
02:36 xymox joined #darcs
02:46 xymox joined #darcs
02:50 mizu_no_oto joined #darcs
02:54 xymox joined #darcs
03:02 xymox joined #darcs
03:07 preflex_ joined #darcs
03:11 xymox joined #darcs
03:20 xymox joined #darcs
03:28 xymox joined #darcs
03:37 xymox joined #darcs
03:46 xymox joined #darcs
03:56 xymox joined #darcs
04:05 xymox joined #darcs
04:12 xymox joined #darcs
04:20 xymox joined #darcs
04:27 xymox joined #darcs
04:34 adnap joined #darcs
05:13 favonia joined #darcs
05:30 bsrk joined #darcs
05:30 bsrk Hi heffalump
05:34 Heffalump hi
05:34 Heffalump how's it going?
05:35 Heffalump I see you've done anonmous bundles
05:35 Heffalump anonymous
05:36 bsrk I have worked on anonymous send, tests for bundles,
05:36 bsrk better ui with ouath buttons and darcs send reply messages
05:38 bsrk As this is the last week, I think the focus should be the next merge
05:39 bsrk Do you (and sm) have some absolute requirement before merging?
05:41 Heffalump that's up to sm, so make sure you ping him to check
05:41 Heffalump didn't you say last meeting that there were a few things in email that weren't on the todo list?
05:44 bsrk The ones that I remember are items like auth for darcs send, removing number of patches limit, etc
05:44 bsrk I don't think we want to do those.
05:45 bsrk In fact, one item in the todo list, client side changes to darcs send
05:45 bsrk is not very useful now.
05:45 Heffalump why's that?
05:45 bsrk Because there are practically no failure cases
05:45 bsrk and all successful cases give some messsage
05:45 Heffalump please do check old emails properly for things that need doing and at least check about them - it's a nuisance to mention things once and then they get lost
05:46 Heffalump hmm, ok
05:46 Heffalump I think the patches limit thing was still under discussion
05:46 Heffalump if the discussion is stalled then chase it up
05:47 bsrk okay
05:47 Heffalump you said you've done the oauth buttons?
05:48 bsrk Not done, but started. It is hard to tell if something is done or not. :-)
05:48 Heffalump if you think you're done, have you asked sm to have a look?
05:49 Heffalump btw re your most recent patch about "warning no account associated", it should probably say something like "NOTE: ..." to avoid scaring users, or be omitted altogether
05:50 bsrk okay
05:50 Heffalump ok. So what's the full list you'll be working on for the rest of the week?
05:51 Heffalump according to your current plans
05:51 bsrk I will first allocate time for any changes simon requires
05:52 bsrk Next, collecting any changes mentioned previously, and weather I am going to do them or not.
05:53 Heffalump which changes? I'm a bit lost on the details of what's left because we've discussed some here and some are on the todo list.
05:53 Heffalump and some of the todo list isn't crossed off
05:54 bsrk I am dropping client side darcs
05:54 bsrk which only leaves oauth buttons
05:54 bsrk and things not  mentioned
05:55 Heffalump things not mentioned = things that sm might come up with in future?
05:55 bsrk I meant more generally as in things not mentioned in todo list
05:56 bsrk which also includes things mentioned in email
05:56 Heffalump why are there things that aren't mentioned in the todo list but you know about? :-)
05:59 bsrk I am rectifying that.
06:02 Heffalump thanks :-)
06:04 sm hi Heffalump, bsrk
06:04 bsrk hi
06:05 Heffalump hi!
06:05 bsrk glad you could join - you just saved me an email
06:06 xymox joined #darcs
06:06 bsrk heffalump: I have looked through all the emails
06:07 bsrk there are two suggestions: 1) better ui for empty changes 2) remove upper limit on number of patches in branches page
06:07 Heffalump I think empty changes was already a bug, so not a priority for your project (unless it's also broken in repo compare)
06:08 bsrk no, its not broken in repo compare
06:08 bsrk at the very least, they both use different mechanisms
06:09 bsrk so, I can declare there are no outstanding changes except oauth buttons then.
06:09 bsrk assuming sm is not firm on feature 2.
06:10 bsrk sm, is feature 2 necessary? It is more of an undo
06:10 sm bsrk: the limit is useless, please remove it
06:10 Heffalump sm: what about the limit on the common patches?
06:11 sm what's a url showing that ?
06:11 sm I just deployed latest at http://hub.darcs.net:8901
06:12 Heffalump http://hub.darcs.net:8901/Aditya/da​rcsden-gsoc/compare/simon/darcsden
06:12 sm http://hub.darcs.net:8901/simon/dar​csden/compare/Aditya/darcsden-gsoc ?
06:12 Heffalump Large number of patches, showing only the chronological last few.
06:12 Heffalump on the changes page, that gets paginated
06:12 sm I don't think there's much point listing common patches
06:12 dolio joined #darcs
06:13 Heffalump that's a good point
06:13 sm you could say "+ N common patches" if it's easy, otherwise forget it
06:14 Heffalump ok: so drop the patch limit on uncommon ones, and just count the common ones
06:14 bsrk The limit also exists for another purpose though - if you are comparing two repos that have not been synced for a very long time
06:14 sm I invoke YAGNI
06:15 sm http://c2.com/cgi/wiki?YouArentGonnaNeedIt
06:15 bsrk we atleast need it for the compare page
06:15 Heffalump bsrk: just remove it, it'd be easy to put back later
06:15 sm ie deal with it when it becomes a real issue
06:15 pr_ joined #darcs
06:15 mami_ joined #darcs
06:15 epta_ joined #darcs
06:16 bsrk okay, I'll remove it. But I should mention that it was a problem, when we had showed both sides of the comparison in the branches page.
06:16 xymox joined #darcs
06:27 _ilbot joined #darcs
06:27 Topic for #darcs is now http://darcs.net/ | logs: http://irclog.perlgeek.de/darcs/ | darcs 2.8.4 is out http://darcs.net/Releases/2.8
06:28 bsrk It won't be anonymous - The repo owner will know the email address, the bundle will show the email address.
06:28 Heffalump sm: packs still have the "build packs" UI
06:28 Heffalump bsrk: ok, sorry, I mean "not associated with an account". "anonymous" was a bad word to ever use.
06:29 Heffalump sm: so either it needs to go in like that or be dropped, I think. There's not enough time to do a decent heuristic IMO.
06:29 sm Heffalump: yes, and also getting them doesn't seem to help or work
06:29 sm one of my first bits feedback
06:30 Heffalump ok, there may still also be some darcs-side issues with packs. I'd suggest we just drop that feature or leave it on bsrk's branch for the time being.
06:30 bsrk It generally works for me, if I am using 2.9, and am explicit about it being a packed get.
06:31 bsrk Just checked, it worked.
06:32 sm bsrk: I am in a bad mood due to having too much feedback ignored and being too many timezones away to chat about it. Don't take it personally
06:32 xymox joined #darcs
06:32 sm also, past my bedtime :)
06:32 Heffalump I really have to go too
06:33 sm bsrk: if you want to clarify the pack status, check the mail I sent about it again
06:33 sm I forget the details
06:33 Heffalump bsrk: can you make sure that the todo list is really up to date and that every outstanding issue or patch is in discussion or it's clear what to do?
06:33 bsrk okay
06:33 Heffalump and obviously get on with doing what you can :-)
06:34 Heffalump for the features that need to be merged, make a list of them explicitly on the todo list
06:34 Heffalump that should help focus the mind on what needs to be discussed
06:34 * Heffalump goes
06:36 bsrk sm: shall we continue, or carry it on to email?
06:36 bsrk sm: I know what it is like to sacrifice sleep. :-)
06:36 sm yes I know you do
06:37 sm I can go a little more, what about ?
06:37 bsrk what you need before you can merge?
06:38 sm the longer you wait, the less I need :)
06:38 bsrk changes, annotate, bundles are they new ones
06:38 bsrk and you want to remove packs
06:38 sm that's not a big deal, easy to do if needed
06:39 sm changes and annotate are ok to go in, I think they were blocked on the patches/compare changes ?
06:39 sm I was hoping for a cleanup of history, is that not doable ?
06:39 xymox joined #darcs
06:40 bsrk what about bundles?
06:40 sm I'd like to see those in action
06:40 bsrk okay, I will separate out changes and annotate.
06:40 sm I was trying to get some of the older stuff merged first
06:41 bsrk Then once compare/branches is good enough you can pull the rest of the patches.
06:41 sm I'm not sure what you plan to do
06:42 bsrk I will rebase so that you can get changes and annotate.
06:42 bsrk Then I will remove the patch limit, common patches.
06:43 sm ok.. and compare (and patches layout tweaks) without the troublesome bits, right
06:43 bsrk what do you mean by patches layout tweaks?
06:44 bsrk (I thought the new UI is acceptable)
06:44 sm I think the only (visible) change we're merging on patches is how you tightened up the patch lists (less whitespace) - right ?
06:45 bsrk in branches page, that is it.
06:45 sm ok. And compare page is fine
06:45 sm I don't think there's much new in trunk, but do rebase on the latest if there is
06:46 sm any thoughts my last code review comments ?
06:47 bsrk If the issue tracker is disabled or if the user is not registered, an email will be sent to the repo owner. (the current behaviour)
06:47 bsrk so, I basically went with the consensus.
06:48 sm good; but I mean the little code comments like "let's give disf a better, intention-revealing name"
06:48 bsrk ah
06:48 sm while rebasing, maybe you can change disf to something clearer ?
06:49 sm and annotateHHK ?
06:49 bsrk I will do that.
06:49 sm thanks, also " "Remove bundles repository when flushing repositories" is not quite clear, something like "Also remove bundles db when resetting the database" would be clearer. Or merge this with a bigger patch.
06:49 bsrk Yes
06:49 sm thanks for hiding the old branches, also
06:50 sm I don't want to make a bunch of busy work for you, but the clearer your work history is trunk, the better it'll look
06:51 sm and Heffalump says rebasing is easy now 8-)
06:51 sm s/is trunk/is in trunk/
06:52 bsrk sure, don't worry about it.
06:52 sm do you think there's any chance of getting highlighting more consistent between view and edit modes ?
06:53 xymox joined #darcs
06:53 preflex joined #darcs
06:53 kaol joined #darcs
06:53 bsrk we can do that. I could add another highlighting mode which uses codemirror and set that to be default.
06:53 mami_ joined #darcs
06:54 bsrk should I add that to the list?
06:54 xymox joined #darcs
06:54 xymox joined #darcs
06:55 sm it would be great for users if 1. when source is highlighted when viewing, it's also highlighted when editing and vice-versa and 2. the colours are similar in both cases.
06:56 bsrk sure.
06:56 sm I don't know how hard this is, you and Ganesh can decide the priority
06:56 sm it'll have to be done one way or another
06:57 sm by someone
06:57 bsrk I'll do it, at some point or the other.
06:58 sm awesome
06:58 sm how hard is it to get side-by-side annotate view ?
06:59 raichoo joined #darcs
06:59 bsrk I had that at some point, but the patch name was getting ugly to look at.
07:00 sm like https://github.com/simonmichael/hledger/b​lame/master/hledger-lib/hledger-lib.cabal
07:00 bsrk I probably just do not know the proper css.
07:00 sm I see they cut off the message when it's long
07:00 sm I have that css somewhere
07:01 sm well I have it right here in firefox: overflow: hidden; text-overflow: ellipsis; width: 210px; are probably the important bits
07:02 sm "changes button now doesn't feel right, the font weight and position is inconsistent" - has that changed at all ?
07:02 bsrk yes, it did.
07:03 bsrk It's position, font etc are the same now
07:03 bsrk (atleast for me)
07:04 sm I'm looking at http://hub.darcs.net:8901/simon/darcsden .. so the changes button has been moved down (as repo changes) ?
07:04 sm previously, we had the major views at the top in bold, now one of them is mixed with the lesser buttons below which is not ideal
07:05 sm when I click it, the button vanishes, which is unusual
07:05 sm what could we do...
07:10 sm after seeing this I think it might work better to leave "changes" where it was, have the additional file changes button (non-bold), maybe add "file" to the annotate button to identify the three file buttons. And separate the fork button from them, since it's a repo operation
07:11 sm but this is not a high priority
07:11 bsrk okay
07:12 sm does it sound good in principle ? grouping repo operations and file operations separately ?
07:12 bsrk yes
07:12 sm ok
07:13 sm there's other repo stuff down there too. Needs more thought
07:14 sm how about removing the packs built date, and showing it only in repo settings next to the build packs button
07:14 sm and maybe that should be a button not a link
07:15 bsrk yes, but the more changes you add, the less likely is it that the it will be done before the deadline.
07:16 sm bsrk: of course, I don't know your deadline but I don't think you'll get all this done
07:16 bsrk The pencil's down date is by the end of this week.
07:17 sm still, it's useful to chat. If we agree you can mention it on the list and it's a useful guide for contributors
07:17 sm anything else from your end ?
07:17 bsrk not really, figuring out what to do. :-)
07:18 sm you probably can only finish one hard thing or a couple of easy things, right
07:18 sm what's your feeling about what to focus on ?
07:19 sm well, history and code cleanup to get the pending work merged is #1
07:20 bsrk yes
07:20 bsrk the changes to compare and branches come next.
07:20 sm that's a few minutes, right ?
07:20 sm dropping the limit and the common list
07:21 bsrk I think you probably also want me clean up after that too, so that you can get compare.
07:22 sm basically I'd like some patces I can pull that don't have those two bits I don't want. And if they can be cleaned up a bit at the same time, even better
07:23 bsrk I would then hopefully be able to get bundles in too.
07:23 sm the second part is not a blocker
07:25 sm bundles needs testing. I'll consider merging it if it works, is useful, and doesn't introduce too much vulnerability or maintenance hassle
07:25 bsrk what do you mean by "testing"?
07:25 sm have you tested it ?
07:26 sm I don't mean automated tests, I mean trying it out for real
07:26 bsrk Yes, I tried it out. I am not sure what you mean by "real".
07:27 sm it sounds like there are still a lot of unknowns
07:27 bsrk like? I would say it's behavior is well defined.
07:28 sm let's at least say it hasn't been validated in the field
07:29 bsrk okay, I don't want to argue for now.
07:30 sm in production, with real users and real projects. That'll take time. I don't think I'm saying anything controversial ?
07:30 sm not a big deal, let's get some things merged
07:31 bsrk in principle, I am against postponement. Still, your decision is the one that's more important.
07:33 bsrk is there anything else?
07:35 bsrk I think we can defer further discussion until after the first rebase.
07:35 sm battery died
07:36 sm everything will be fine. Thanks bsrk
07:36 nomeata joined #darcs
07:37 sm contact me any time if I can help
08:41 donri joined #darcs
08:46 nomeata joined #darcs
08:51 burp joined #darcs
09:04 owst joined #darcs
09:04 alexei___ joined #darcs
09:27 gh__ joined #darcs
09:32 gh__ hi
09:41 schlaftier joined #darcs
09:51 whaletechno joined #darcs
11:19 gh__ joined #darcs
11:54 mizu_no_oto joined #darcs
12:49 mizu_no_oto joined #darcs
13:26 gbeshers joined #darcs
13:50 bfrank_ joined #darcs
14:05 mizu_no_oto joined #darcs
14:51 jlneder joined #darcs
15:28 dolio joined #darcs
15:40 raichoo joined #darcs
16:37 lelit joined #darcs
16:54 alexei___ joined #darcs
17:13 whaletechno joined #darcs
17:24 alexei___ joined #darcs
17:56 mizu_no_oto joined #darcs
18:19 sm gday all
18:19 Heffalump hi
18:20 Heffalump looks like you had a good discussion with bsrk after I left
18:21 sm I hope so.. I was feeling a bit tetchy :)
18:46 epta joined #darcs
19:16 favonia joined #darcs
19:48 schlaftier joined #darcs
19:50 nomeata joined #darcs
20:25 mizu_no_oto joined #darcs
21:43 favonia joined #darcs
22:41 jlneder joined #darcs
23:01 arpunk joined #darcs
23:16 arpunk_ joined #darcs
23:48 dolio joined #darcs

| Channels | #darcs index | Today | | Search | Google Search | Plain-Text | summary