Perl 6 - the future is here, just unevenly distributed

IRC log for #darcs, 2017-02-23

| Channels | #darcs index | Today | | Search | Google Search | Plain-Text | summary

All times shown according to UTC.

Time Nick Message
01:17 Riastradh joined #darcs
02:44 Riastradh joined #darcs
05:25 dolio joined #darcs
11:22 gal_bolle joined #darcs
13:20 leg joined #darcs
13:42 jeltsch joined #darcs
13:43 jeltsch What has happend to darcs hub? I am getting “getCurrentDirectory: does not exist (No such file or directory)” when trying to access any repository.
14:15 notdan weird, I got one message like that but now it seems fine?
14:25 leg joined #darcs
14:35 jeltsch notdan: Maybe simon did something on the server. Like accidentally deleting all repos and copying them back from his backup. :-D
14:36 notdan heh
14:37 Riastradh SHA1 collisions!
14:37 Riastradh https://security.googleblog.com/2017/02/announcing-first-sha1-collision.html
14:38 Riastradh Does Darcs use SHA1 for patch hashes?  Can't remember.
14:45 sm jeltsch: I'm sorry you had trouble, and sorry that such a thought enters your mind :)
14:45 sm I haven't touched it recently.. I'll check a few things
14:46 jeltsch sm: Well, just before the problems occurred, I wanted to delete some repos g
14:48 jeltsch sm: Well, just before the problems occurred, I wanted to delete a directory from my server, containing some repos I had moved to darcs hub, and accidentally removed the parent directory.
14:48 jeltsch sm: So I was immediate for me to assume you had done something similar on darcs hub. :-D
14:48 jeltsch I → it
14:48 jeltsch Great that it is working again.
14:49 sm given that I once had a db "incident" from running unit tests on the production server, I can't blame you
14:50 sm re your question about the markdown renderer, it's pandoc: http://hub.darcs.net/simon/darcsden/browse/src/DarcsDen/Util.hs#102
14:52 sm I don't like how it renders <BR /> in your name at http://hub.darcs.net/jeltsch/ucs/browse/README.markdown
14:58 sm specifically, it's pandoc-1.17.1
14:59 sm I don't have much free time budget for darcsden either, someone could help by setting it up locally and comparing a build with the latest pandoc
15:01 sm and/or specifying different pandoc options
15:02 sm I guess this is the reason line breaks are preserved: readerExtensions = githubMarkdownExtensions
15:05 sm the annotate view seems broken, but those lines were last changed by pointfree in http://hub.darcs.net/simon/darcsden/patch/911ab7acf1a066a04d17555ded94c73f3d47989b and http://hub.darcs.net/simon/darcsden/patch/33d5add6f8b5c2bceb4b26a67016823252a9345e
15:06 sm pointfree: maybe I missed that in code review.. did you need to change these three options ?
15:08 sm is readerSmart the one that renders "smart quotes", so that eg ' and " become non-ascii ? that is always a source of pain, something we should avoid IMHO
15:19 * sm thinks: rendering tests needed
15:19 pointfree sm:  I think "readerParseRaw = True, readerSmart = True," could probably be removed. I'll try removing them and see what happens. afaik githubMarkdownExtensions is what turns urls into links.
15:20 sm ah
15:22 sm I think you can set individual extensions, rather than the predefined githubMarkdownExtensions set
15:22 sm why does github have significant newlines ? does it make sense for darcs hub to be different ? I dunno
15:23 pointfree readerSmart :: Bool             Smart punctuation
15:23 pointfree readerParseRaw :: Bool       Parse raw HTML, LaTeX
15:25 pointfree Maybe this:
15:25 pointfree Ext_hard_line_breaks       All newlines become hard line breaks
15:26 pointfree is getting set somewhere
15:26 sm https://hackage.haskell.org/package/pandoc-1.19.2.1/docs/src/Text-Pandoc-Options.html#githubMarkdownExtensions
15:29 pointfree like you were saying maybe we should individually take only the extensions we want into darcsden
15:29 pointfree although, I do think this is a bug in pandoc as well...
15:34 sm how so ?
15:49 pointfree <BR /> is rendered in his name, but looking at it with View Source in firefox, it's not encoded with HTML character entities...?? But then there's this funky js above it:
15:50 pointfree <!--
15:50 pointfree h='&#106;&#x65;&#108;&#116;&#x73;&#x63;&#104;&#46;&#x69;&#110;&#102;&#x6f;';a='&#64;
15:50 pointfree ';n='&#x77;&#x6f;&#108;&#102;&#x67;&#x61;&#110;&#x67;&#x2d;&#x69;&#116;';e=n+a+h;
15:50 pointfree document.write('<a h'+'ref'+'="ma'+'ilto'+':'+e+'" clas'+'s="em' +
15:50 pointfree 'ail">'+'&#x57;&#x6f;&#108;&#102;&#x67;&#x61;&#110;&#x67;&#60;&#98;&#114;&#32;&#x2f;&#62;&#10;&#74;&#x65;&#108;&#116;&#x73;&#x63;&#104;'+'<\/'+'a'+'>')
15:50 pointfree ;
15:50 pointfree / -->
15:51 pointfree clipped by irc, // -->
17:27 Heffalump Riastradh: fairly sure we're using SHA256 in any vaguely recent version of darcs, but I suspect we still accept SHA1 from old repos
17:27 Heffalump so in principle could be attacked by that
17:33 mornfall there are much easier attacks on darcs than sha collisions
17:33 mornfall (and, for that matter, on git, which is in a lot more trouble)
17:36 mal`` joined #darcs
20:05 lambdabot joined #darcs
20:14 leg joined #darcs
20:17 Riastradh joined #darcs
20:19 jeltsch joined #darcs
20:52 leg joined #darcs
22:30 jeltsch sm, pointfree: I have been reading your comments about rendering Markdown only now.
22:33 jeltsch I think rendering line breaks in Markdown as line breaks is very bad. Usually line breaks are used in the Markdown source such that the source looks good. Since a single source line may correspond to text of very different length, the rendered text almost surely will look ugly.
22:33 jeltsch A also do not like this “cleverness” of translating ASCII quotation marks into “proper” quotation marks. If you want proper quotation marks (which you should ;-) ), then use them in the Markdown source.
22:34 jeltsch Note that while translating "⟨text⟩" to “⟨text⟩” is correct for English, it is not correct for German, for example. In German, it would be „⟨text⟩“. So this automatic translation of quotation marks is not guaranteed to be correct anyhow.
22:35 jeltsch I think, Markdown should be shown either as the source, possibly with syntax highlighting, or as a properly rendered text using some Markdown-to-HTML translation that conforms to the spec.
22:36 jeltsch I think it makes sense to show the highlighted source when watching specific Markdown files in the repository, but using HTML output when showing the README file.
22:36 jeltsch What do you think?
22:41 sm I'd welcome a patch reverting the enabling of readerSmart (quote translation)
22:41 sm I'd like to know what enabling readerParseRaw did
22:43 pointfree jeltsch: right now the markdown is rendered in repo view, while markdown source is viewed in raw view.
22:43 pointfree repo view: http://hub.darcs.net/pointfree/amforth-ad985x/browse/README.md
22:43 pointfree raw view: http://hub.darcs.net/pointfree/amforth-ad985x/raw-file/README.md
22:44 pointfree sm: building darcsden right now... the stack.yaml file needed to be updated.
22:46 jeltsch pointfree: Does it really make sense to render the Markdown in repo view?
22:46 jeltsch For all other file types, we show the source, right?
22:48 pointfree I've asked myself the same question, but it is what github does.
22:50 jeltsch Do we have to do what GitHub does?
22:50 jeltsch I think not.
22:50 jeltsch In any case, I think it is a good idea to show the README rendered on a repo’s homepage.
22:51 jeltsch But *please* without these spurious line breaks. :-(
22:51 jeltsch For the repo view, it would be better to show the highlighted source like for any other file type, I think.
22:54 pointfree although... source code is typically not meant to be rendered except for syntax highlighting. An image file in a repo is rendered as an image not as text.
22:54 pointfree there may be markdown documentation in sub-directories of the repo too... that said, it would make sense to be able to refer to line numbers etc, etc. in the markdown source, so maybe we can indeed think of a way to do it better than github.
23:09 sm viewing a markdown file directly always shows source, viewing a directory always shows rendered README* if any ?
23:11 tg joined #darcs
23:47 jeltsch sm: Viewing a Markdown file directly does not show the source, but the rendered view, doesn’t it? I mean, pointfree’s link to http://hub.darcs.net/pointfree/amforth-ad985x/browse/README.md confirms this, right? ;-)
23:49 jeltsch pointfree: As for now, can you maybe make this change that directories show Markdown README files according to the spec, that is, without rendering line breaks in the source as line breaks and without translating quotation marks.
23:49 jeltsch directories → directory views

| Channels | #darcs index | Today | | Search | Google Search | Plain-Text | summary