Perl 6 - the future is here, just unevenly distributed

IRC log for #gluster-dev, 2016-05-08

| Channels | #gluster-dev index | Today | | Search | Google Search | Plain-Text | summary

All times shown according to UTC.

Time Nick Message
00:10 dlambrig_ joined #gluster-dev
01:09 penguinRaider joined #gluster-dev
02:01 hgowtham joined #gluster-dev
02:08 luizcpg joined #gluster-dev
02:25 luizcpg joined #gluster-dev
02:30 luizcpg joined #gluster-dev
02:51 luizcpg joined #gluster-dev
03:38 atinm joined #gluster-dev
03:39 luizcpg joined #gluster-dev
03:53 atinm hgowtham, pm
04:07 aspandey joined #gluster-dev
04:18 itisravi joined #gluster-dev
04:19 itisravi atinm: hgowtham good morning!
04:19 atinm itisravi, hgowtham : morning
04:19 itisravi atinm: just read your email about you having some comments.
04:20 atinm itisravi, yes
04:21 atinm itisravi, there are places where you are using strerror(-ret) in glfs-heal.c
04:21 itisravi atinm: yeah
04:24 atinmu joined #gluster-dev
04:24 atinmu itisravi, sorry, I had a power cut
04:24 atinmu itisravi, so got logged off
04:24 atinmu itisravi, coming back to my question
04:25 atinmu itisravi, IIUC, we may end up throwing a misleading error message in that case
04:25 itisravi atinmu: np
04:25 itisravi atinmu: why is that?
04:26 atinmu itisravi, I see a code path where if a dict_get_str fails we pass the same ret value
04:27 itisravi atinmu: what is the line number?
04:27 itisravi atinmu: I'm looking the code without hari's patch.
04:28 itisravi atinmu: got it. glfsh_heal_from_brick
04:29 itisravi That is dict_set_str
04:30 itisravi atinmu: but ret is -EINVAL for those dict get/set functions.
04:31 * itisravi thinks atinmu has has a power cut again.
04:31 atinm joined #gluster-dev
04:31 atinm itisravi, I lost the connection again
04:31 itisravi atinm: I guess you are checking the chat logs now.
04:31 atinm itisravi, just now logged
04:32 itisravi cool.
04:32 atinm itisravi, so I missed all previous communication
04:32 atinm itisravi, so do you have an answer for my query?
04:32 itisravi atinm: http://irclog.perlgeek.de/gluster-dev/2016-05-08
04:33 atinm itisravi, cool
04:34 atinm itisravi, so you mean to say there is no way we can return values like -1 ?
04:34 atinm itisravi, if that's the case, we are safe
04:34 itisravi atinm: nope not for those functions.
04:34 itisravi atinm: yup.
04:34 atinm itisravi, ok
04:35 atinm itisravi, glfsh_print_xml_heal_op_status ()
04:35 itisravi atinm: yeah
04:36 atinm itisravi, don't we need a xmlTestWriterStartElement () here?
04:36 itisravi atinm: all that happens in glfsh_xml_init
04:36 atinm itisravi, I haven't spent much time on reviewing it, so pardon me if they sound stupid ;)
04:36 itisravi np :)
04:37 atinm itisravi, so wanted a confirmation from you
04:37 atinm itisravi, otherwise the structure of the patch looks ok to me now
04:37 itisravi glfsh_xml_init and glfsh_xml_end take care of all the init and cleanup
04:37 itisravi atinm: yeah thats what I understood from reviewing the patch.
04:38 atinm hgowtham, I have some minor comments w.r.t indentation, variable usage, if the patch needs a refresh mind addressing them?
04:38 itisravi atinm: plus I tried the regular and xml version of the heal commands, they all worked.
04:38 itisravi s/tried/tested
04:38 atinm hgowtham, otherwise those could be addressed in subsequent commit
04:38 atinm itisravi, yeah, Pranith shared the test result as well which helps w.r.t test coverage
04:38 itisravi atinm: right
04:39 atinm itisravi, once centos regression passes, I will merge it
04:39 itisravi atinm: awesome
04:40 itisravi hgowtham: I suppose you are just AFK and this is not your proxy bot.
04:41 atinm itisravi, actually I was also thinking if a test can be added as well or not?
04:41 atinm itisravi, that would be better
04:41 nishanth joined #gluster-dev
04:41 itisravi atinm: do you know if there are .ts in tests/* that test xml output?
04:42 itisravi atinm: maybe we can add it as a separare patch.
04:42 atinm itisravi, I know we parse volume status xml output in few places
04:42 itisravi atinm: oh ok.
04:42 atinm itisravi, IIRC, brick_up_status does that
04:43 itisravi atinm: you are right
04:43 atinm itisravi, just add it in your backlog such that we don't forget
04:44 itisravi atinm: we can do that.
04:44 atinm itisravi, cool
04:45 atinm itisravi, once the regression passes, ping me at my cell
04:46 itisravi atinm: I'll be going out now. Will let you know by evening.
04:47 atinm itisravi, fine, no issues, I should be able to check it in couple of hours time, so don't worry, enjoy the weekend :)
04:47 itisravi hgowtham: in case you are here..just update the backports as well.
04:47 itisravi atinm: thanks, you too :)
04:47 atinm itisravi, :)
04:47 itisravi atinm: I'll try to send the arbiter patch today addressing your review comments.
04:47 atinm itisravi, sure
04:59 rafi joined #gluster-dev
05:16 rafi joined #gluster-dev
05:31 penguinRaider joined #gluster-dev
06:34 atinm joined #gluster-dev
07:09 pur joined #gluster-dev
07:23 jiffin joined #gluster-dev
07:28 skoduri joined #gluster-dev
08:33 penguinRaider joined #gluster-dev
09:20 Manikandan joined #gluster-dev
09:35 nishanth joined #gluster-dev
10:05 nishanth joined #gluster-dev
10:07 overclk joined #gluster-dev
10:31 penguinRaider joined #gluster-dev
11:32 mchangir joined #gluster-dev
11:43 pur joined #gluster-dev
12:00 nbalacha joined #gluster-dev
12:26 luizcpg joined #gluster-dev
12:36 mchangir joined #gluster-dev
12:42 penguinRaider joined #gluster-dev
13:00 rafi joined #gluster-dev
13:44 luizcpg joined #gluster-dev
13:45 nbalacha joined #gluster-dev
14:05 wushudoin joined #gluster-dev
14:24 shaunm joined #gluster-dev
14:31 luizcpg joined #gluster-dev
14:40 rafi joined #gluster-dev
14:54 EinstCrazy joined #gluster-dev
15:00 rafi joined #gluster-dev
15:01 rafi joined #gluster-dev
15:04 rafi joined #gluster-dev
15:26 shubhendu joined #gluster-dev
15:56 pur joined #gluster-dev
16:04 mchangir joined #gluster-dev
16:43 penguinRaider joined #gluster-dev
17:14 jiffin joined #gluster-dev
17:52 shubhendu joined #gluster-dev
18:20 penguinRaider joined #gluster-dev
18:54 penguinRaider joined #gluster-dev
18:56 s-kania joined #gluster-dev
19:29 mmckeen joined #gluster-dev
19:32 penguinRaider joined #gluster-dev
19:40 mmckeen joined #gluster-dev
21:20 cholcombe joined #gluster-dev
21:57 penguinRaider joined #gluster-dev
22:46 luizcpg joined #gluster-dev

| Channels | #gluster-dev index | Today | | Search | Google Search | Plain-Text | summary