Perl 6 - the future is here, just unevenly distributed

IRC log for #gluster-dev, 2016-06-13

| Channels | #gluster-dev index | Today | | Search | Google Search | Plain-Text | summary

All times shown according to UTC.

Time Nick Message
01:01 v12aml joined #gluster-dev
01:28 josferna joined #gluster-dev
01:32 amye_ joined #gluster-dev
02:37 hagarth joined #gluster-dev
03:00 Bhaskarakiran joined #gluster-dev
03:11 msvbhat_ joined #gluster-dev
03:21 Bhaskarakiran joined #gluster-dev
03:31 Bhaskarakiran joined #gluster-dev
03:42 kdhananjay joined #gluster-dev
03:46 Saravanakmr joined #gluster-dev
03:55 poornimag joined #gluster-dev
04:01 kramdoss_ joined #gluster-dev
04:01 itisravi joined #gluster-dev
04:03 nbalacha joined #gluster-dev
04:05 gem joined #gluster-dev
04:07 overclk joined #gluster-dev
04:10 hgowtham joined #gluster-dev
04:14 msvbhat_ joined #gluster-dev
04:16 atinm joined #gluster-dev
04:25 atinm nigelb, http://review.gluster.org/#/c/14693/ - needs your help to revoke verified -1
04:28 raghug joined #gluster-dev
04:31 Bhaskarakiran joined #gluster-dev
04:43 nigelb atinm: done :)
04:50 atinm nigelb++
04:50 glusterbot atinm: nigelb's karma is now 10
04:54 aspandey joined #gluster-dev
04:55 aravindavk joined #gluster-dev
04:57 ndarshan joined #gluster-dev
05:07 prasanth joined #gluster-dev
05:11 ppai joined #gluster-dev
05:12 hgowtham joined #gluster-dev
05:25 pkalever joined #gluster-dev
05:30 Manikandan joined #gluster-dev
05:39 Apeksha joined #gluster-dev
05:39 skoduri joined #gluster-dev
05:40 Apeksha_ joined #gluster-dev
05:42 nishanth joined #gluster-dev
05:57 kotreshhr joined #gluster-dev
06:05 mchangir joined #gluster-dev
06:06 karthik___ joined #gluster-dev
06:06 ashiq joined #gluster-dev
06:06 hgowtham_ joined #gluster-dev
06:16 kshlm joined #gluster-dev
06:19 asengupt joined #gluster-dev
06:24 aspandey joined #gluster-dev
06:27 s-kania joined #gluster-dev
06:36 kdhananjay joined #gluster-dev
06:36 itisravi joined #gluster-dev
06:38 rafi joined #gluster-dev
06:51 s-kania joined #gluster-dev
06:52 atinm kshlm, http://review.gluster.org/#/c/14693/ - could you merge this?
06:52 k4n0 joined #gluster-dev
06:53 itisravi @later tell pranithk1 to review and +1 http://review.gluster.org/#/c/14687/ so that ndevos could merge it.
06:53 glusterbot itisravi: The operation succeeded.
07:05 spalai joined #gluster-dev
07:07 pur__ joined #gluster-dev
07:08 pkalever joined #gluster-dev
07:20 pranithk1 joined #gluster-dev
07:24 overclk_ joined #gluster-dev
07:28 hgowtham joined #gluster-dev
07:32 itisravi_ joined #gluster-dev
07:42 kdhananjay joined #gluster-dev
07:46 overclk joined #gluster-dev
07:47 pkalever joined #gluster-dev
07:56 jiffin joined #gluster-dev
07:57 shubhendu joined #gluster-dev
08:00 ashiq joined #gluster-dev
08:10 karthik___ joined #gluster-dev
08:13 karthik___ ndevos, could you please do the review and merge this patch http://review.gluster.org/#/c/14619/
08:14 karthik___ ndevos, Thanks!
08:18 ndevos karthik___: how critical is that for 3.8? I've been travelling last week and need to catch up on emails and the patch queue
08:18 ashiq joined #gluster-dev
08:19 ndevos itisravi_: a +2 makes things easier, anything +1 still needs a +2 review :)
08:21 karthik___ ndevos, Its a very critical bug for worm feature, so it needs to be merged with 3.8.
08:22 ndevos karthik___: I'm using https://bugzilla.redhat.com/showdependencytree.cgi?id=glusterfs-3.8.0&hide_resolved=1 for tracking, is it listed there?
08:24 karthik___ ndevos, Yes its listed there.
08:24 ndevos karthik___: ok, good, I'l get to it then :)
08:24 karthik___ ndevos, Thank you :)
08:28 itisravi_ ndevos: done :)
08:31 overclk joined #gluster-dev
08:36 itisravi joined #gluster-dev
08:44 rraja joined #gluster-dev
08:45 kdhananjay joined #gluster-dev
08:47 pranithk1 joined #gluster-dev
08:52 atalur joined #gluster-dev
09:01 kdhananjay joined #gluster-dev
09:01 itisravi_ joined #gluster-dev
09:02 itisravi_ joined #gluster-dev
09:06 itisravi joined #gluster-dev
09:09 hgowtham joined #gluster-dev
09:17 atalur joined #gluster-dev
09:25 poornimag ndevos, Can you please merge http://review.gluster.org/#/c/14626/   (3.8 patch) ??
09:29 ndevos poornimag: if that patch is part of a bug in https://bugzilla.redhat.com/showdependencytree.cgi?id=glusterfs-3.8.0&hide_resolved=1 I should get to that later today
09:30 poornimag ndevos, yes it is, thanku
09:30 ppai joined #gluster-dev
09:31 poornimag ndevos, also there are gfapi api of leases patches awaiting review http://review.gluster.org/#/q/status:open+project:glusterfs+branch:master+topic:bug-1319992
09:33 ndevos poornimag: yeah, I know there are many patches waiting for my reviews, anything non-critical will need to wait for after 3.8 is released
09:47 nishanth joined #gluster-dev
09:48 atinm joined #gluster-dev
09:52 poornimag ndevos, would it be ok to take these patches in 3.8.X?
09:55 atalur joined #gluster-dev
09:58 ndevos poornimag: yeah, we can add new functions to libgfapi in 3.8.x, just not modify any existing ones
09:59 poornimag ndevos, ok then, i shall ping post 3.8;)
10:00 shubhendu joined #gluster-dev
10:03 ppai joined #gluster-dev
10:05 ndevos itisravi: http://review.gluster.org/14687 has a weird topic in Gerrit, could you correct that?
10:07 Manikandan ndevos, can you merge this http://review.gluster.org/#/c/14659/
10:08 ndevos Manikandan: is that a critical change that needs to be included  in 3.8?
10:08 Manikandan ndevos, it is on 3.7 branch
10:09 itisravi ndevos: done
10:09 Manikandan ndevos, it is the nfs chmod issue, which is merged in 3.8 and master
10:09 ndevos Manikandan: hagarth is doing the next 3.7 update, you'll need to bug him :)
10:09 Manikandan ndevos, cool, thanks :-)
10:10 ndevos thanks itisravi!
10:12 aspandey atinm, resent patch http://review.gluster.org/#/c/13968/9 , please review
10:12 atinm aspandey, will do
10:12 atinm aspandey, get an ack from itisravi
10:12 aspandey atinm, ok
10:18 ndevos karthik___: could you find someone to review http://review.gluster.org/14619 please?
10:19 karthik___ ndevos, ya sure..
10:23 ndevos poornimag: could you respond to the comment kshlm left in http://review.gluster.org/14626 ?
10:23 ppai joined #gluster-dev
10:26 ndevos atinm: maybe you want to re-review http://review.gluster.org/14626 , the update of the commit message dropped your +2 (and kshlm's)
10:29 atinm ndevos, sure
10:33 poornimag ndevos++  atinm++
10:33 glusterbot poornimag: ndevos's karma is now 270
10:33 glusterbot poornimag: atinm's karma is now 60
10:35 raghug joined #gluster-dev
10:38 ndevos raghug: is http://review.gluster.org/14351 critical for 3.8.0? if so, please get http://review.gluster.org/14319 reviewed+merged in the master branch today
10:39 ppai joined #gluster-dev
10:41 karthik___ ndevos, http://review.gluster.org/#/c/14619/ is reviewed. Could you please merge this?
10:44 karthik___ Manikandan, Thanks for the review :)
10:44 Manikandan karthik___, no problem :-)
10:45 ndevos atinm: the test-case from http://review.gluster.org/14691 seems to differ, could you update the commit message if that was intentional?
10:48 ndevos poornimag: I'm still waiting for a reply in http://review.gluster.org/14626 to kshlms question
10:59 atinm joined #gluster-dev
10:59 nishanth joined #gluster-dev
11:00 bfoster joined #gluster-dev
11:00 pranithk1 joined #gluster-dev
11:02 skoduri_ joined #gluster-dev
11:04 atinm ndevos, I will
11:04 ndevos hgowtham: is http://review.gluster.org/14541 critical for 3.8.0?
11:05 hgowtham ndevos, checking
11:05 hgowtham ndevos, i dont think so
11:06 ndevos hgowtham: ok, thanks - also, the commit message for 3.8 says it is a backport from the 3.7 patch?
11:07 hgowtham ndevos, that has been sent separately.
11:08 ndevos hgowtham: yes, each bugfix needs a patch for all stable branches, but you only need to mention the original patch in the master branch
11:09 hgowtham oh okie ndevos i'll see to that.
11:19 atinm ndevos, patch refreshed
11:21 ndevos atinm: thanks!
11:24 overclk joined #gluster-dev
11:26 pranithk1 xavih: I have one question about the timer race patch. Let me know when we can discuss that...
11:26 xavih pranithk1: tell me
11:27 pranithk1 xavih: I am curious to know why we are not doing UNLOCK (inode->lock) and then call ec_unlock_timer_add() in ec_unlock_timer_del()
11:30 xavih pranithk1: we probably could, but first thing ec_unlock_timer_add() does is to acquire it again, so I thought it was better this way
11:32 xavih pranithk1: it makes little difference. If you prefer I can unlock the inode and the call ec_unlock_timer_add()
11:32 pranithk1 xavih: Hmm... I have never seen coding style for locks this way where one function locks and another function unlocks.
11:32 xavih pranithk1: yeah, it's not frequently used...
11:33 pranithk1 xavih: yeah. could you change that one once
11:33 xavih pranithk1: ok. I'll update the patch
11:39 ppai joined #gluster-dev
11:41 spalai left #gluster-dev
11:41 xavih pranithk1: Patch updated :)
11:42 hagarth ndevos: fyi, we all are doing the next 3.7 release ;)
11:48 pranithk1 xavih: Code looks good to me. Is it okay if I take some more time to test it a little more and give +2?
11:49 aravindavk joined #gluster-dev
11:49 pranithk1 xavih: I need to leave home now. So may be you will see a 2-3 hour delay from now
11:49 xavih pranithk1: it's ok :)
11:49 pranithk1 xavih: cool, thanks!
11:53 Manikandan joined #gluster-dev
11:56 Bhaskarakiran joined #gluster-dev
12:01 karthik___ joined #gluster-dev
12:02 aravindavk joined #gluster-dev
12:05 pkalever left #gluster-dev
12:21 ndevos hagarth: well, I think all maintainers are holding back when a rc has been tagged
12:27 spalai joined #gluster-dev
12:28 spalai left #gluster-dev
12:34 atinm joined #gluster-dev
12:35 nigelb is there a particular reason why there's a for loop here?
12:35 nigelb https://github.com/nigelbabu/glusterfs-patch-acceptance-tests/blob/split-scripts/jenkins/scripts/glusterfs-rpms#L10
12:35 nigelb We're only ever giving it one value of CFGS
12:36 misc when we had more than 1, I guess ?
12:37 nigelb Hrm.
12:37 nigelb I guess it's worth keeping.
12:45 ira joined #gluster-dev
12:45 hagarth ndevos: yes, non critical fixes can go as part of the next update
12:47 nigelb I'm making all the rpm scripts into one parameterized shell script.
12:53 overclk joined #gluster-dev
13:00 kkeithley yes, please ship 3.8. We can ship 3.8.1 when ever we're ready.
13:00 kkeithley <keeneyefortheobvious>but we'll never be able to ship 3.8.1 unless we first ship 3.8.0</keeneyefortheobvious>
13:00 ndevos kkeithley: release is planned for tomorrow :)
13:01 kkeithley yay
13:01 ndevos that means, today is the last day for patches to get merged and all, update the release notes, etc...
13:01 * kkeithley now wonders about 3.7.12
13:02 ndevos unless amye objects for some reason, she wasnt sure about it (again)...
13:02 kkeithley wasn't sure about what?
13:02 ndevos 3.7.12 is for hagarth, I think he's working on it
13:02 kkeithley indeed
13:02 ndevos well, if I only knew *why*
13:03 kkeithley meh, ship tomorrow. apologize later
13:04 ndevos I'm sorry!?
13:04 ndevos oh, wait, wrong order?
13:07 lpabon joined #gluster-dev
13:08 anoopcs ndevos, I have moved https://bugzilla.redhat.com/show_bug.cgi?id=1332162 back to POST on account of https://review.gluster.org/#/c/11177/ being not merged.
13:08 glusterbot Bug 1332162: medium, medium, ---, anoopcs, POST , Support mandatory locking in glusterfs
13:08 ndevos anoopcs: ok, should be good
13:08 ank joined #gluster-dev
13:09 * ndevos *hates* is that the new Gerrit captures key-shortcuts like CTRL+t
13:10 anoopcs ndevos, Is it right to have mandatory-locks in 3.8.0 release notes and corresponding bug still in POST state? That's why I am concerned.
13:12 hgowtham joined #gluster-dev
13:12 ndevos anoopcs: well, it depends... we can add new libgfapi functions later on in 3.8.x, but it'll need a different bug
13:12 anoopcs ndevos, If so I need to update the commit message with that BZ right?
13:12 ndevos anoopcs: yes
13:14 anoopcs ndevos, Let me see if I can catch Shyam to do a 2nd round review and get it merged. Or else I will move the bug state to ON_QA and re-upload the change with a new BZ.
13:15 ndevos anoopcs: you'll have to get it reviewed, merged and backported today... I'd rather see the change in 3.8.1 which would be released in a month
13:16 anoopcs ndevos, Ok.
13:16 atinm joined #gluster-dev
13:18 ndevos anoopcs: you can add "glusterfs-3.8.1" in the blocks field of that new bug for the libgfapi additions
13:18 anoopcs ndevos, assuming tracker will be created afterwards?
13:19 ndevos anoopcs: no, it already exists :)
13:19 anoopcs ndevos, Wow.. Before 3.8 releases :-)
13:19 ndevos anoopcs: I mostly do then when moving non-critical bugs to the next release
13:20 anoopcs ndevos, Cool...
13:21 hagarth kkeithley: 3.7.12 is frozen unless maintainers report something badly broken
13:21 kkeithley yay
13:21 ndevos hagarth: does fsx crash on 3.7.12 for you too?
13:22 ndevos hmm, maybe I phrased that not right "does fsx crash on 3.7.12 too, for you?"
13:22 hagarth ndevos: no, I haven't seen that happen for 2 days
13:22 ndevos hagarth: oh, but on 3.8 it does?
13:22 hagarth ndevos: yes, it was happening every 4-6 hours when I logged that bug
13:23 ndevos I still could not reproduce it yet...
13:24 hagarth ndevos: will give it a shot again with the latest 3.8 bits
13:24 hagarth ndevos: is/was there any problem attaching a 100KB log file to bugzilla?
13:26 Debloper joined #gluster-dev
13:26 ndevos hagarth: 100KB should be fine, I think the limit is 20MB
13:27 hagarth ndevos: yeah, for some reason I was unable to post an attachment then. will try that again too.
13:28 ndevos anoopcs: what do you think of adding a Jenkins check for commit-messages that complaing if a line starts with "Reviewed-by", without the "> " indention?
13:28 ndevos hagarth: oh, I also wanted to ask what NFS-client distro you use, add that to the bz as well :)
13:30 hagarth ndevos: sure
13:34 josferna joined #gluster-dev
13:51 spalai joined #gluster-dev
13:55 pkalever joined #gluster-dev
13:58 nigelb for gluster-rpm jobs on jenkins, we don't pass the `--cleanup-after`
13:58 glusterbot nigelb: `'s karma is now -2
13:59 nigelb Is that intentional?
13:59 nigelb or we just didn't add it for that particular job?
13:59 ndevos nigelb: do we pass --no-clean ?
14:01 nigelb Nope
14:01 nigelb Let me link you
14:02 ndevos in that case, I dont think we need --cleanup-after either? maybe the left-overs can be helpful for diagnosing a problem?
14:02 nigelb https://github.com/nigelbabu/glusterfs-patch-acceptance-tests/blob/split-scripts/jenkins/scripts/glusterfs-devrpms.sh#L32
14:02 nigelb https://github.com/nigelbabu/glusterfs-patch-acceptance-tests/blob/split-scripts/jenkins/scripts/glusterfs-rpms#L12
14:03 nigelb In all the *devrpm jobs, we pass --cleanup-after
14:03 nigelb in the *rpm jobs we don't pass --cleanup-after
14:03 ndevos I dont think it matters much
14:03 nigelb (I'm merging all of them into one script)
14:03 nigelb so we have less duplication of code.
14:04 ndevos just go with whatever you think is best?
14:04 nigelb Yeah, I'll run it by everyone before I change the jobs.
14:07 ndevos I doubt anyone cares about it, you should be fine with correcting it
14:25 nigelb ndevos: is the release jenkins job run on jenkins at all?
14:25 nigelb or is it always run by release manager on their machines?
14:32 ndevos nigelb: the release managers use the jenkins job to generate the tarball, but the "also build rpms" checkbox can be removed, we dont use that
14:34 nigelb okay.
14:38 kkeithley ndevos: seems to me that glfs_ipc_xd should be removed from 3.8
14:39 hagarth joined #gluster-dev
14:39 kkeithley If it's really for 4.0
14:39 ndevos kkeithley: yes, I think so too
14:40 ndevos kkeithley: you want to send a patch for that?
14:40 kkeithley someone wants to. I'm not sure it's me
14:41 ndevos well, if you dont, I guess I'll have to do it...
14:41 kkeithley hang on...
14:42 shaunm joined #gluster-dev
14:42 nigelb If anyone cares to review bash -> https://github.com/gluster/glusterfs-patch-acceptance-tests/pull/21
14:42 nigelb misc: ^ I'd love to hear your thoughts, especially on my changes to the scripts.
14:43 kkeithley blech, it was merged on an rfc
14:43 ndevos indeed, and with a huge patch set that includes changes all over the place
14:49 * ndevos steps out for a while and will be back online later
14:55 misc nigelb: after all you said on bash, I am not sure I want to click on that link
14:56 nigelb heh
14:59 misc so far, that's correct
15:02 mchangir joined #gluster-dev
15:15 wushudoin joined #gluster-dev
15:15 misc (but meeting)
15:23 Manikandan joined #gluster-dev
15:26 spalai joined #gluster-dev
15:31 lpabon joined #gluster-dev
15:35 nbalacha joined #gluster-dev
15:40 mchangir kkeithley, why do we need to restart rsyslog on gluster install and uninstall i.e. %post and %postun
15:42 kkeithley probably we don't. I guess in case the syslog config changed.   That's crufty old (legacy) stuff in the .spec.  We can probably remove it.
15:43 mchangir kkeithley, hmm ... okay
15:52 Manikandan joined #gluster-dev
15:57 anoopcs ndevos, Did you mean format check for backports?
16:16 jiffin joined #gluster-dev
16:27 skoduri joined #gluster-dev
16:43 shubhendu joined #gluster-dev
16:57 shubhendu joined #gluster-dev
17:01 hagarth joined #gluster-dev
17:16 Guest941 joined #gluster-dev
17:19 aspandey joined #gluster-dev
17:41 jiffin1 joined #gluster-dev
17:54 penguinRaider joined #gluster-dev
18:12 penguinRaider_ joined #gluster-dev
18:15 kkeithley wow.  A change that passed all the tests without me having to retrigger any
18:21 post-factum kkeithley: that is suspicious enough to re-trigger tests :)
18:22 ira joined #gluster-dev
18:23 kkeithley lol
18:34 penguinRaider__ joined #gluster-dev
18:52 lpabon joined #gluster-dev
19:06 penguinRaider_ joined #gluster-dev
19:16 ndevos anoopcs: yes, a simple check for the commit message of the backports, that we dont include incorrect tags for it
19:17 penguinRaider__ joined #gluster-dev
19:29 shaunm joined #gluster-dev
20:16 penguinRaider_ joined #gluster-dev
20:20 primusinterpares joined #gluster-dev
20:52 penguinRaider__ joined #gluster-dev
21:20 penguinRaider_ joined #gluster-dev
21:40 penguinRaider_ joined #gluster-dev
22:18 hagarth joined #gluster-dev
22:48 penguinRaider_ joined #gluster-dev

| Channels | #gluster-dev index | Today | | Search | Google Search | Plain-Text | summary