| Time |
Nick |
Message |
| 00:15 |
|
klapperl joined #metacpan |
| 00:32 |
|
talexb joined #metacpan |
| 01:11 |
|
klapperl_ joined #metacpan |
| 01:26 |
|
cooper joined #metacpan |
| 02:21 |
|
dsteinbrunner joined #metacpan |
| 02:58 |
|
metacpan joined #metacpan |
| 02:58 |
metacpan |
[cpan-api01] oalders pushed 1 new commit to oalders/commonsense: http://git.io/OSvAIA |
| 02:58 |
metacpan |
cpan-api/oalders/commonsense 8fedbb4 Olaf Alders: Adds a .pm.PL test. |
| 02:58 |
|
metacpan left #metacpan |
| 02:58 |
dipsy |
[ Adds a .pm.PL test. · 8fedbb4 · CPAN-API/cpan-api · GitHub ] |
| 02:59 |
oalders |
rwstauner: i just pushed a .pm.PL test, but it looks like Parse::PMFile doesn't play well with Test::Aggregate |
| 02:59 |
oalders |
was wondering if you could check that for me at some convenient point |
| 03:00 |
oalders |
the error is in the fake CPAN creation, so it's likely the test may not entirely be correct. but i can't check it since i don't think the fake files i added are actually getting indexed |
| 03:12 |
rwstauner |
oalders: coincidentally i'm working on a Test::Aggregate bug but it's likely not related. i'll take a look at your branch |
| 03:14 |
rwstauner |
oalders++ # love the test dist name |
| 03:23 |
|
metacpan joined #metacpan |
| 03:23 |
metacpan |
[cpan-api01] rwstauner pushed 1 new commit to oalders/commonsense: http://git.io/4d9iLQ |
| 03:23 |
metacpan |
cpan-api/oalders/commonsense 70ebbaa Randy Stauner: Fix case on new module name in Makefile prereqs |
| 03:23 |
|
metacpan left #metacpan |
| 03:23 |
dipsy |
[ Fix case on new module name in Makefile prereqs · 70ebbaa · CPAN-API/cpan-api · GitHub ] |
| 03:24 |
oalders |
:) |
| 03:24 |
oalders |
rwstauner: thanks for looking into it. figured i'd ask the follow who is now doing all the work on Test::Aggregate :) |
| 03:24 |
oalders |
s/follow/fellow/ |
| 03:25 |
rwstauner |
:-) |
| 03:25 |
rwstauner |
nice |
| 03:25 |
rwstauner |
i did see an "exit()" warning fly by |
| 03:25 |
oalders |
that's the one |
| 03:25 |
oalders |
line 188 of Parse::PMFile |
| 03:26 |
rwstauner |
inside of a fork |
| 03:26 |
oalders |
i see now it's not exiting the test early, but it's a bit weird to see that in the output |
| 03:27 |
rwstauner |
yeah, Test::Aggregate watches out for those |
| 03:27 |
rwstauner |
though i haven't grokked everything Aggregate is doing yet |
| 03:27 |
oalders |
:) |
| 03:28 |
rwstauner |
Parse::PMFile definitely looks a bit weird at that spot but it's probably reasonable |
| 03:32 |
rwstauner |
oh that's weird... the file is in the index twice, once with a file path of "sense.pm.PL" and once as "lib/uncommon/sense.pm" |
| 03:33 |
|
metacpan joined #metacpan |
| 03:33 |
metacpan |
[cpan-api01] rwstauner pushed 1 new commit to oalders/commonsense: http://git.io/kCb4fQ |
| 03:33 |
metacpan |
cpan-api/oalders/commonsense dcab49e Randy Stauner: Fix module name typo in test query |
| 03:33 |
|
metacpan left #metacpan |
| 03:33 |
dipsy |
[ Fix module name typo in test query · dcab49e · CPAN-API/cpan-api · GitHub ] |
| 03:34 |
rwstauner |
it ends up in the tar that way |
| 03:35 |
rwstauner |
uh oh |
| 03:35 |
rwstauner |
that doesn't seem right |
| 03:35 |
oalders |
the tar that CPAN::Faker creates? |
| 03:35 |
rwstauner |
I wonder if Module::Faker is doing that |
| 03:35 |
rwstauner |
yeah |
| 03:36 |
rwstauner |
that's werid |
| 03:38 |
rwstauner |
actually, the MANIFEST only lists the one in lib/ |
| 03:38 |
rwstauner |
it ignores the two sense files in root |
| 03:38 |
rwstauner |
i don't know that we look at the MANIFEST when we parse |
| 03:38 |
rwstauner |
but it's an interesting observation |
| 03:40 |
rwstauner |
in this case it may not actually be a problem because we do seem to be correctly parsing the pmPL (which is really what we want to test) |
| 03:41 |
rwstauner |
but i am concerned that the test may randomly fail b/c i can't tell the difference b/t these two files, so i don't know if we'll always get the right one or not |
| 03:41 |
oalders |
what happens if you recreate the mappings in the test ES? |
| 03:41 |
oalders |
i'm wondering if you're seeing something from 2 different runs |
| 03:42 |
oalders |
before/after you fixed the test |
| 03:42 |
rwstauner |
i considered that... but i thought the test suite deleted the mapping when it starts |
| 03:42 |
oalders |
yeah, it should |
| 03:42 |
rwstauner |
isn't that how the Great Reindex occurred |
| 03:42 |
oalders |
:) |
| 03:42 |
oalders |
that never gets old |
| 03:42 |
rwstauner |
:-) |
| 03:45 |
mo |
:) |
| 03:45 |
|
preflex_ joined #metacpan |
| 03:49 |
rwstauner |
i'm looking through Module::Faker |
| 03:49 |
rwstauner |
starting to see some of how it happens |
| 03:49 |
rwstauner |
but not all of the why yet |
| 03:50 |
rwstauner |
i do see that mtime has been added |
| 03:50 |
rwstauner |
i hadn't noticed that yet |
| 03:52 |
* rwstauner |
testing a work-around |
| 03:54 |
* rwstauner |
wishes JSON allowed comments |
| 03:54 |
rwstauner |
oops... test just complained "don't know how to handle file t/var/fakecpan/configs/.uncommon-sense.json.swp" |
| 03:54 |
rwstauner |
guess i better close the editor first |
| 03:55 |
oalders |
:) |
| 03:55 |
rwstauner |
sweet, that works |
| 03:56 |
rwstauner |
it you don't tell Module::Faker what's inside, it assume a main module based on the dist name |
| 03:56 |
rwstauner |
often times that file already exists in the fake dist |
| 03:56 |
rwstauner |
but if it doesn't, one will be generated |
| 03:56 |
rwstauner |
oh rats |
| 03:56 |
rwstauner |
it's a little more complicated than that |
| 03:57 |
rwstauner |
i did stop it from generating the extra file, but it still put it's generated code above our file data |
| 03:57 |
rwstauner |
:-P |
| 03:57 |
rwstauner |
maybe adding a normal pm to the dist would solve that |
| 03:57 |
oalders |
ah, good idea |
| 04:02 |
rwstauner |
bah! .swp file again |
| 04:09 |
oalders |
rwstauner: any objection to me port forwarding 9900 and 9200 via vagrant as well? |
| 04:09 |
|
talexb joined #metacpan |
| 04:09 |
rwstauner |
no |
| 04:12 |
|
metacpan joined #metacpan |
| 04:12 |
metacpan |
[metacpan-developer01] oalders pushed 1 new commit to master: http://git.io/WG8Lzg |
| 04:12 |
metacpan |
metacpan-developer/master 49a5d13 Olaf Alders: Adds port forwarding for both production and test ES ports. |
| 04:12 |
|
metacpan left #metacpan |
| 04:12 |
dipsy |
[ Adds port forwarding for both production and test ES ports. · 49a5d13 · CPAN-API/metacpan-developer · GitHub ] |
| 04:35 |
oalders |
that port forwarding didn't work for me, but that's not too important right now |
| 04:51 |
rwstauner |
oalders: pf's look right... did you restart the vm? |
| 04:51 |
rwstauner |
provision isn't enough |
| 06:13 |
|
ether_ joined #metacpan |
| 07:10 |
|
metacpan joined #metacpan |
| 07:10 |
metacpan |
[cpan-api01] rwstauner pushed 1 new commit to oalders/commonsense: http://git.io/vdYKUw |
| 07:10 |
metacpan |
cpan-api/oalders/commonsense 10ae232 Randy Stauner: Test that .pm.PL file is unmodified and indexed... |
| 07:10 |
|
metacpan left #metacpan |
| 07:10 |
dipsy |
[ Test that .pm.PL file is unmodified and indexed · 10ae232 · CPAN-API/cpan-api · GitHub ] |
| 07:11 |
|
metacpan joined #metacpan |
| 07:11 |
metacpan |
[metacpan-developer01] rwstauner pushed 1 new commit to master: http://git.io/fcdD5w |
| 07:11 |
metacpan |
metacpan-developer/master f65cecd Randy Stauner: Install Parse::PMFile in anticipation of the merge |
| 07:11 |
|
metacpan left #metacpan |
| 07:11 |
dipsy |
[ Install Parse::PMFile in anticipation of the merge · f65cecd · CPAN-API/metacpan-developer · GitHub ] |
| 10:06 |
|
dsteinbrunner joined #metacpan |
| 11:07 |
|
ilbot2 joined #metacpan |
| 11:07 |
|
Topic for #metacpan is now Have you installed your MetaCPAN VM? https://github.com/CPAN-API/metacpan-developer | Chat logs available at http://irclog.perlgeek.de/metacpan/ |
| 15:18 |
|
bowtie_ joined #metacpan |
| 15:43 |
|
dsteinbrunner joined #metacpan |
| 15:45 |
|
hanekomu joined #metacpan |
| 15:46 |
|
hanekomu joined #metacpan |
| 15:47 |
rwstauner |
after fiddling with local cpan files, it looks like we actually can parse common::sense |
| 15:48 |
rwstauner |
now the question is does that Parse::PMFile really need to fork? :-) |
| 15:48 |
rwstauner |
but that's for another day |
| 15:48 |
* rwstauner |
& |
| 17:36 |
|
dsteinbrunner joined #metacpan |
| 19:53 |
|
dsteinbrunner joined #metacpan |
| 20:03 |
|
dsteinbrunner_ joined #metacpan |
| 22:29 |
|
metacpan joined #metacpan |
| 22:29 |
metacpan |
[cpan-api01] rwstauner pushed 3 new commits to master: http://git.io/UoadHw |
| 22:29 |
metacpan |
cpan-api/master b6ce11f Randy Stauner: Test that changes controller doesn't mojibake content |
| 22:29 |
metacpan |
cpan-api/master de5ffa2 Randy Stauner: Attempt to decode change log content to avoid mojibake... |
| 22:29 |
metacpan |
cpan-api/master bc111fc Randy Stauner: Test that Latin1 change logs are preserved |
| 22:29 |
|
metacpan left #metacpan |
| 22:30 |
dipsy |
[ Comparing 52680579acc6...bc111fce9895 · CPAN-API/cpan-api · GitHub ] |
| 22:40 |
|
dsteinbrunner joined #metacpan |
