Perl 6 - the future is here, just unevenly distributed

IRC log for #metacpan, 2017-05-08

| Channels | #metacpan index | Today | | Search | Google Search | Plain-Text | summary

All times shown according to UTC.

Time Nick Message
07:29 neilb_ joined #metacpan
07:36 nakiro joined #metacpan
08:15 Relequestual joined #metacpan
08:26 neilb joined #metacpan
10:44 metacpan joined #metacpan
10:44 metacpan [metacpan-api] mickeyn created mickey/02packages (+1 new commit): https://git.io/v9rFD
10:44 metacpan metacpan-api/mickey/02packages 7344e4e Mickey Nasriachi: Addde type 'packages' to support 02packages.details info...
10:44 metacpan left #metacpan
12:48 neilb joined #metacpan
14:12 metacpan joined #metacpan
14:12 metacpan [metacpan-api] mickeyn pushed 1 new commit to mickey/02packages: https://git.io/v9ocB
14:12 metacpan metacpan-api/mickey/02packages bad2f3e Mickey Nasriachi: Packages: add dist/author info...
14:12 metacpan left #metacpan
14:29 oalders "==> default: A error occurred during the signature verification. The repository is not updated and the previous index files will be used. GPG error: http://apt.puppetlabs.com wheezy Release: The following signatures couldn't be verified because the public key is not available: NO_PUBKEY 7F438280EF8D349F"
14:29 oalders Trying to provision my VM
14:34 BinGOs http://frederic-wou.net/puppet-apt-update-error-public-key-not-available-no_pubkey-7f438280ef8d349f/
14:34 oalders BinGOs++
14:48 jnap joined #metacpan
15:40 karjala joined #metacpan
19:20 metacpan joined #metacpan
19:20 metacpan [metacpan-api] oalders pushed 1 new commit to master: https://git.io/v9KOI
19:20 metacpan metacpan-api/master fe3352c Olaf Alders: Merge pull request #625 from metacpan/mickey/api_cleanups...
19:20 metacpan left #metacpan
19:20 metacpan joined #metacpan
19:20 metacpan [metacpan-api] oalders deleted mickey/api_cleanups at cd7d998: https://git.io/v9KOt
19:20 metacpan left #metacpan
19:23 metacpan joined #metacpan
19:23 metacpan [metacpan-api] oalders pushed 1 new commit to master: https://git.io/v9KOz
19:23 metacpan metacpan-api/master a626491 Olaf Alders: Merge pull request #628 from metacpan/mickey/02packages...
19:23 metacpan left #metacpan
19:23 metacpan joined #metacpan
19:23 metacpan [metacpan-api] oalders deleted mickey/02packages at bad2f3e: https://git.io/v9KOg
19:23 metacpan left #metacpan
19:58 punter joined #metacpan
20:27 neilb joined #metacpan
20:38 metacpan joined #metacpan
20:38 metacpan [metacpan-web] oalders created oalders/show-less-changes (+1 new commit): https://git.io/v9KEr
20:38 metacpan metacpan-web/oalders/show-less-changes 6544665 Olaf Alders: Show less is the opposite of show more....
20:38 metacpan left #metacpan
21:32 ether gah, rendering of images seems to be semi-broken now
21:33 ether https://metacpan.org/pod/Acme::CPANAuthors::Nonhuman - this should be rendered as a grid of 5ish images per row with padding
21:33 ether somewhere deep in metacpan-web there is a whitelist of html elements, which might have changed?
21:33 ether haarg: you understand this code I think
21:34 haarg ether: https://github.com/metacpan/metacpan-web/pull/1874
21:35 ether even the 'before' image looks a bit off (i.e. the padding is missing)
21:36 ether I don't have any screenshots from before to compare against though
21:36 Grinnz ether: img styles are stripped, arent they?
21:36 haarg they are now
21:36 ether the code that used to whitelist certain styles used to be at https://github.com/metacpan/metacpan-web/blob/master/lib/MetaCPAN/Web/Controller/Module.pm#L51-L87
21:36 haarg right now we're stripping all style tags
21:36 ether but that whole file has changed now
21:36 haarg if we can come up with a suitable way to whitelist some things, i'm open to it
21:37 haarg https://github.com/metacpan/metacpan-web/issues/1863
21:38 ether I don't know enough about html to be able to propose a solution
21:39 haarg well, there is a couple things
21:39 Grinnz are other bootstrap classes like .container and .row allowed? maybe http://getbootstrap.com/css/#grid could be used to format those images
21:39 Grinnz that would only work on metacpan of course
21:39 ether s.c.o is broken several times over with embedded html, already
21:40 Grinnz i was gonna say, s.c.o doesnt even show them :P
21:40 ether it used to I think
21:40 haarg https://github.com/metacpan/metacpan-web/blob/master/lib/MetaCPAN/Web/Controller/Pod.pm#L125
21:41 Grinnz are the rules there what's allowed?
21:41 haarg yes
21:41 Grinnz so those classes would be stripped
21:41 haarg i think to do it correctly, HTML::Restrict needs to be extended to allow subs to munge specific attributes, then we can parse and reassemble style and class attrs
21:42 haarg then filtering classes is pretty simple
21:43 haarg style is a little more complex, but i think we could create a simple parser for the small amount of things we'd want to allow
21:43 haarg it doesn't need to be a full css parser
21:44 Grinnz ether: well the easiest way right now would be to put them in a table
21:44 Grinnz but that's not very responsive
21:45 haarg the img-responsive thing needs to be fixed in some way or another
21:46 Grinnz hmm, i think it messes up the image locations on https://metacpan.org/pod/Dist::Zilla::Plugin::Pod::Spiffy as well
21:46 haarg yeah but i don't care about that one
21:47 haarg i mean, the reason we are filtering aggressively is to prevent layout from getting fucked up
21:48 Grinnz well since img-responsive really just applies 3 styles, maybe you can just apply the two styles that aren't display: block
21:48 Grinnz as that's what causes it to be on its own line i imagine
21:49 haarg i'm not sure it works without block layout
21:50 Grinnz seems to work on both ether's module and the one in that github issue
21:56 Grinnz http://i.imgur.com/aQjniss.png after replacing class="img-responsive" with style="max-width: 100%; height: auto;" in each img tag
22:06 ether is that supposed to be the fixed version? :(
22:06 ether it used to be nicely spaced, with max-width=50% so not too many images got jammed onto one row
22:08 Grinnz well that's because your parent div's styles get stripped
22:08 Grinnz so the only way to allow that would be what haarg was talking about, or to use a table
22:09 Grinnz i'm just trying to think of a simpler way to fix the immediate impact of adding img-responsive to everything
22:16 Grinnz didnt see the issue was updated; commented there

| Channels | #metacpan index | Today | | Search | Google Search | Plain-Text | summary