Camelia, the Perl 6 bug

IRC log for #moarvm, 2013-06-05

| Channels | #moarvm index | Today | | Search | Google Search | Plain-Text | summary

All times shown according to UTC.

Time Nick Message
00:16 benabik The abort seems to be tied to a stack checking of sprintf.  If I change it from buf[20] to buf[21], it works.
00:16 benabik s/stack/buffer overflow/;  I'll submit a pull request when I'm done putting the kid to bed.
00:41 benabik There we go.  Nothing like a fresh pull request on a new project.
01:27 benabik joined #moarvm
01:31 colomon joined #moarvm
01:47 colomon joined #moarvm
02:49 colomon joined #moarvm
02:50 colomon_ joined #moarvm
02:55 lizmat joined #moarvm
03:05 dalek MoarVM: a629202 | benabik++ | src/core/interp.c:
03:05 dalek MoarVM: Avoid minor buffer overflow in say_n
03:05 dalek MoarVM:
03:05 dalek MoarVM: t/moar/float.t fails on darwin/amd64 with an abort in __sprintf_chk.
03:05 dalek MoarVM: Google tells me that this is related to a libssp data protection
03:05 dalek MoarVM: library detecting a buffer overflow.
03:05 dalek MoarVM:
03:05 dalek MoarVM: Sure enough "-127243075316.468048" is 20 characters long which puts
03:05 dalek MoarVM: the null character one byte past the end of `char buf[20]`.
03:05 dalek MoarVM: Allocating a single extra byte for the buffer fixes the problem.
03:05 dalek MoarVM: review: https://github.com/MoarVM/MoarVM/commit/a6292022e1
03:05 dalek MoarVM: cd0500b | benabik++ | nqp-cc/.gitignore:
03:14 dalek MoarVM: 77743cc | jimmy++ | build/Config/ (2 files):
03:14 dalek MoarVM: fixed build on win32 x86 platform
03:14 dalek MoarVM: review: https://github.com/MoarVM/MoarVM/commit/77743cc485
03:14 dalek MoarVM: 62cb622 | jonathan++ | build/Config/ (2 files):
03:14 dalek MoarVM: Merge pull request #5 from zhuomingliang/patch-2
03:14 dalek MoarVM:
03:14 dalek MoarVM: fixed build on win32 x86 platform
03:14 dalek MoarVM: review: https://github.com/MoarVM/MoarVM/commit/62cb622ac4
03:22 lizmat joined #moarvm
03:27 dalek MoarVM: bc92df7 | jonathan++ | src/core/coerce.c:
03:27 dalek MoarVM: Put buffer overrun fix in another place.
03:27 dalek MoarVM: review: https://github.com/MoarVM/MoarVM/commit/bc92df7c1a
03:29 benabik This suggests that coerce could use testing so I would have noticed it failing.  :-D
03:29 jnthn Yeah.
03:29 masak time to write more tests!
03:29 benabik \o/
03:29 jnthn Well, the dev ops should also go away really and so the test should be updated to use the coerce op, I suspect.
03:30 nwc10 shouldn't those 20s, er 21s, become a named constant defined once?
03:30 benabik Dev ops?
03:30 * masak .oO( devops?! o.O )
03:30 jnthn benabik: There's a bank of ops which exist as "cheats" to ease the early development work on Moar.
03:31 jnthn Which we're kinda past now.
03:31 * jnthn will have a look
03:31 jnthn nwc10: Probably, yes
03:34 benabik say_* -> coerce_*_s, getstdout, write_fhs?
03:57 jnthn Well, a say_s should stay
03:57 benabik Ah, good.  That would make things simpler.
03:58 jnthn Maybe it needs to move
03:58 * jnthn looks
03:59 benabik It is currently in dev bank.
03:59 jnthn yeah
03:59 jnthn grr, so we'd have say_s, but print. That can't be :)
04:00 jnthn So: say_s becomes say, print stays as it is, say_i/say_n go away, and both say and print move from dev into the io ops bank
04:01 benabik A task!
04:03 jnthn If you want to work on it: after you update src/core/oplist, run perl6 tools/update_ops.p6
04:04 benabik Was just tracking that down.  But need to change interp.c manually?
04:04 jnthn yeah
04:04 jnthn That actually has to know what things mean :)
04:08 FROGGS_ joined #moarvm
04:10 benabik Should the old ops be replaced with __INVALID_N__ or just vanish into the night?
04:11 jnthn Can vanish if you renumber to avoid gaps, which is probably easy for the dev bank
04:11 jnthn At some point the op numbers get standardized and the ordering can be cleaned up. Not ready for that yet.
04:26 colomon joined #moarvm
04:49 birdwindupbird joined #moarvm
05:12 benabik Ah.  Also have to modify MVM_opcounts_by_bank
05:13 benabik Wait.  No.
05:13 jnthn uh?
05:13 benabik I just have to get the numbers correct.
05:13 jnthn You shouldn't.
05:13 jnthn :)
05:13 benabik C _D_ E F
05:13 jnthn ;)
05:13 jnthn 'night
05:13 benabik 'night
05:35 tomyan joined #moarvm
05:38 benabik It is a little odd to keep writing 'coerce_is, str, int'
06:12 Guest1337 joined #moarvm
06:30 benabik Huh.  threads.t fails when running 'make test' and succeeds when running alone.  Stupid threading tests.  (Fails with "Can't free STables in gen2 GC yet", so I imagine it's not a big deal.)
06:47 cognominal joined #moarvm
07:04 benabik I probably should have gone to bed instead of finishing changing those tests.  Oh well.
07:04 benabik 'night
08:14 flaviusb joined #moarvm
08:33 flaviusb joined #moarvm
08:47 lizmat joined #moarvm
08:51 flaviusb joined #moarvm
09:16 hoelzro hi MoarVM folks
09:17 moritz hello
09:18 hoelzro why is it that the MoarVM has its own organization on GH? why not just put the repo under perl6/?
09:19 leont joined #moarvm
09:20 * moritz has no idea
10:28 flaviusb joined #moarvm
12:08 tgt joined #moarvm
12:24 flaviusb joined #moarvm
12:41 masak hoelzro: one reason is that until MoarVM actually runs Rakudo Perl 6, whether it will succeed or not is still not 100% certain. so dissociating the Perl 6 project and the MoarVM project, at least in name, makes sense.
12:41 hoelzro hmm
12:41 hoelzro I guess that makes sense.
12:42 masak hoelzro: as I understood it, MoarVM could be moved into the 'perl6' organization in the near future, as more progress unfolds.
12:42 masak but it may or may not do so. it might be that keeping the separation makes more sense.
12:43 flaviusb joined #moarvm
12:47 hoelzro 3rdparty/apr/.libs/* is all pre-compiled, yes?
12:49 nwc10 no, built, but I think it's built by Configure.pl
12:50 nwc10 but there's been a bit of discussion about probing for installed useful system versions, and maybe not bundling, but downloading
12:50 hoelzro ah ha
12:52 cognominal masak, is the video and the slides of your presentations at YAPC::NA available somewhere (same for jnthn and pmichaud)
12:52 hoelzro hmm
12:53 benabik joined #moarvm
12:53 hoelzro it's complaining about the files under .libs/ not existing (I removed them, due to linker errors)
12:55 masak cognominal: I have no idea.
12:56 masak cognominal: I will put my slides online, as soon as I exit panic-slide-making mode or travel mode.
12:56 cognominal oh, I thought you were done with your presentations.
13:01 flaviusb joined #moarvm
13:22 flaviusb joined #moarvm
13:27 Ulti joined #moarvm
13:32 lizmat_ joined #moarvm
13:34 lizmat joined #moarvm
13:34 masak_ joined #moarvm
13:37 kbenson1 joined #moarvm
13:40 sorear_ joined #moarvm
13:43 Guest1337 joined #moarvm
13:45 FROGGS joined #moarvm
13:47 ChanServ joined #moarvm
13:54 FROGGS o/
13:55 moritz \o
13:56 lizmat mornin'
14:00 Guest1337 joined #moarvm
14:39 Guest1337 joined #moarvm
14:48 sorear joined #moarvm
14:59 FROGGS joined #moarvm
15:01 bronco_creek joined #moarvm
15:03 Guest1337 joined #moarvm
15:04 birdwindupbird joined #moarvm
15:06 benabik joined #moarvm
15:38 pmichaud_ joined #moarvm
15:41 moritz joined #moarvm
15:43 japhb joined #moarvm
15:43 masak_ joined #moarvm
15:54 pmichaud joined #moarvm
15:54 Guest1337 joined #moarvm
16:08 kbenson joined #moarvm
16:12 FROGGS joined #moarvm
16:19 lizmat joined #moarvm
17:01 Tene_ joined #moarvm
17:01 Tene_ joined #moarvm
17:01 `patch`_ joined #moarvm
17:08 Guest1337 joined #moarvm
17:08 masak joined #moarvm
17:08 diakopte1 joined #moarvm
17:08 dalek joined #moarvm
17:08 nwc10 joined #moarvm
17:08 prammer joined #moarvm
17:08 woosley joined #moarvm
17:12 vmspb joined #moarvm
17:40 benabik joined #moarvm
18:13 FROGGS joined #moarvm
18:22 lizmat joined #moarvm
18:30 colomon joined #moarvm
18:31 sorear o/
18:31 colomon japhb: A few days ago, Jen asked me "Is there a song about electric cars?  Because Henry was just singing about them..."
18:34 japhb_ joined #moarvm
18:40 [Coke] colomon; electric car, so good so far!
18:40 [Coke] colomon: http://www.youtube.com/watch?v=4BPU5mKipNo
18:42 benabik joined #moarvm
19:22 japhb__ joined #moarvm
19:23 colomon joined #moarvm
19:24 FROGGS joined #moarvm
19:25 sorear joined #moarvm
19:30 kbenson joined #moarvm
19:32 Tene_ joined #moarvm
19:32 Tene_ joined #moarvm
20:06 lizmat joined #moarvm
20:18 FROGGS joined #moarvm
20:28 Guest1337 joined #moarvm
20:31 lizmat joined #moarvm
20:48 tgt joined #moarvm
21:02 lizmat joined #moarvm
21:09 donaldh joined #moarvm
21:11 FROGGS joined #moarvm
21:42 cognominal joined #moarvm
22:19 FROGGS joined #moarvm
22:34 colomon joined #moarvm
23:00 tomyan joined #moarvm
23:34 tgt joined #moarvm

| Channels | #moarvm index | Today | | Search | Google Search | Plain-Text | summary