Perl 6 - the future is here, just unevenly distributed

IRC log for #moarvm, 2015-04-13

| Channels | #moarvm index | Today | | Search | Google Search | Plain-Text | summary

All times shown according to UTC.

Time Nick Message
00:47 colomon joined #moarvm
01:24 vendethiel joined #moarvm
04:09 vendethiel joined #moarvm
07:02 Ven joined #moarvm
07:03 vendethiel joined #moarvm
07:06 zakharyas joined #moarvm
07:14 Ven joined #moarvm
07:29 FROGGS joined #moarvm
07:46 Ven joined #moarvm
08:31 Ven joined #moarvm
09:22 vendethiel joined #moarvm
10:26 tadzik joined #moarvm
10:27 tadzik joined #moarvm
10:48 Ven joined #moarvm
11:35 Ven joined #moarvm
12:21 JimmyZ http://docs.libuv.org/en/v1.x/#documentation # better docs for libuv, FYI
12:35 vendethiel joined #moarvm
13:04 vendethiel joined #moarvm
13:19 Ven joined #moarvm
13:33 vendethiel joined #moarvm
14:45 vendethiel joined #moarvm
15:15 Ven joined #moarvm
15:20 vendethiel joined #moarvm
15:30 Ven joined #moarvm
15:59 vendethiel joined #moarvm
17:07 dalek MoarVM: f3512a8 | paultcochrane++ | src/6model/reprs/MVMCode.c:
17:07 dalek MoarVM: Free allocated variable before returning
17:07 dalek MoarVM:
17:07 dalek MoarVM: Coverity scan pointed out that the variable `ann` wasn't being freed before
17:07 dalek MoarVM: the function MVM_code_location() returned.  This should fix this issue.  The
17:07 dalek MoarVM: NQP tests all pass after having made this change (there aren't any MoarVM
17:07 dalek MoarVM: tests), so it seems that everything still works as expected.
17:07 dalek MoarVM: review: https://github.com/MoarVM/MoarVM/commit/f3512a88c5
17:07 dalek MoarVM: 522e168 | timo++ | src/6model/reprs/MVMCode.c:
17:07 dalek MoarVM: Merge pull request #203 from paultcochrane/pr/fix_MVMCode_resource_leak
17:07 dalek MoarVM:
17:07 dalek MoarVM: Free allocated variable before returning
17:07 timotimo [ptc]++
17:07 synbot6 joined #moarvm
18:01 Ven joined #moarvm
18:18 FROGGS joined #moarvm
19:23 jnthn f3512a8 looks legit, but I now think we should check other callsites for that function :)
19:23 timotimo yeah
19:23 timotimo i can do that
19:26 jnthn already found 2 here :)
19:27 jnthn (and written le patches)
19:28 timotimo i see
19:29 dalek MoarVM: 88592c7 | jnthn++ | src/ (3 files):
19:29 dalek MoarVM: More missing frees of bytecode annotations.
19:29 dalek MoarVM: review: https://github.com/MoarVM/MoarVM/commit/88592c7105
19:30 timotimo at least the one in the profiler and spesh seem "hot"
19:31 timotimo so that's very good
19:31 timotimo though since the data is apparently always extremely short-lived, we may want to allocate it on the stack of the caller and populate it in the callee
19:31 jnthn maybe, though none of it is hot path, afaik
19:32 timotimo yeah
19:32 timotimo just a little tingling sensation in my nose :P
19:32 timotimo :-P
20:23 Ven joined #moarvm

| Channels | #moarvm index | Today | | Search | Google Search | Plain-Text | summary