Perl 6 - the future is here, just unevenly distributed

IRC log for #openam, 2017-02-08

| Channels | #openam index | Today | | Search | Google Search | Plain-Text | summary

All times shown according to UTC.

Time Nick Message
01:12 MegaMatt joined #openam
07:20 aldaris joined #openam
07:32 KermitTheFragger joined #openam
08:57 aldaris joined #openam
09:40 jjpp_ joined #openam
10:38 aldaris joined #openam
10:44 aldaris joined #openam
11:12 jjpp_ hi.
11:14 jjpp aldaris: what's with openam's trunk not being public any more?
11:53 aldaris joined #openam
12:25 MegaMatt joined #openam
13:39 jjpp hm, as always. aldaris has left the channel few minutes before i want to ask something..
13:40 asyd :)))
13:43 asyd jjpp: which url? git clone https://stash.forgerock.org/​scm/openam/openam-public.git seem workings here
13:44 jjpp asyd: hm, i haven't cloned it but web view of stash shows only master branch with last commit from january 2016?
13:45 asyd well I'm afraid it's not really their master.. but dunno
13:47 asyd or maybe FR are not opensource anymore..
13:47 jjpp they still claim it on the page of openam:)
14:00 aldaris joined #openam
14:40 aldaris hi jjpp
14:40 aldaris what do you mean?
14:42 jjpp aldaris: by what? i actually have two problems. and the one about trunk is not important.
14:42 jjpp important one is.. that.. it seems that there is an unexpected flow in rest authentication api related to gotourls.
14:42 aldaris now I read back the log :)
14:43 aldaris oh goodness, go on
14:43 jjpp I should check once more if my theory holds but then again, not checking has not stopped me complaining before :)
14:44 jjpp well. in short: during session upgrade, if it appears that there is no actual authentication needed, the url from the original get parameter is ignored and successURL from session is used instead
14:45 jjpp i planned to check what will happen if there is actual multistep authentication with posting callbacks etc.
14:45 jjpp the code (in openam-core-rest/src/main/java/org/forgerock/opena​m/core/rest/authn/RestAuthenticationHandler.java) will check postBody for goto.
14:46 jjpp but for the initial request there is no postBody yet..
14:46 jjpp so even if the goto would have been copied there later (have not checked, sry), in this case it is ignored
14:47 jjpp XUI works around it by not using successUrl from the response, if i understand correctly
14:48 jjpp (hm, afk for 45min, unexpectedly)
14:52 aldaris well, that sounds like a bug, but I can't really do much about it :)
15:46 jjpp hm. why, then? :)
15:47 aldaris well bugs are evil
15:47 jjpp (i could probably create an issue and possibly offer a patch..)
15:50 aldaris based on a year old source code :(
15:51 jjpp i might have something fresher as well (i did clone something in autumn, iirc). but yeah, fresh code might be better..
15:51 aldaris my github profile has an openam repo
15:51 aldaris but that's old now as well
15:52 jjpp there was someone's repo from november. but if you have inside info that this part has changed considerably.. then I'm not sure. :)
15:54 aldaris I don't have any inside info I'm afraid
15:54 aldaris nothing that I could share anyways
15:54 asyd you're not working on openam anymore aldaris ?
15:55 aldaris I am
15:55 aldaris I just joined engineering today
15:55 MegaMatt !!
15:55 aldaris well, MegaMatt, it's not like you can complain
15:55 aldaris you left support before me :D
15:56 MegaMatt True story...
15:56 aldaris although you stayed close
15:56 MegaMatt As you will too, I’m sure :P
15:56 jjpp hm. engineering? iirc you were one of most active contributors on openam for a while .. and all that being "just a support"? :)
15:57 aldaris I was support/sustaining for the past 5,5 years
15:57 MegaMatt Now there will be no excuses for any bugs in new features ;)
15:57 jjpp :)
15:58 aldaris hey, I'm not going to write the code for ALL the new features :)
15:58 asyd what are new features? :)
15:59 MegaMatt Whatever you can bribe aldaris to write…..
15:59 aldaris don't know yet, just joined
15:59 jjpp well.. there is probably a lot in openam that could be rewritten. just to cover it with tests and to get more manageable code..
15:59 aldaris anyways, I'm off to sprint kickoff call, see ya later
16:00 jjpp heh. :)
16:22 aldaris joined #openam
16:53 jjpp it seems that in case of session upgrade, goto parameter is completely ignored, after all..
16:54 jjpp yet, there is a weird attempt to read it from json body for success (and not for failure..)
17:08 jjpp commit cd085ff36bed57615d33434450ffc7c44ca016ed
17:08 jjpp Author: David Luna <david.luna@forgerock.com>
17:09 jjpp and crucible seems to be downb_
17:30 jjpp hm. OPENAM-3303 changed sessionUpgrade parameter to sessionUpgradeSSOTokenId without a comment in jira. "AM FunctionalTests executing without new failures from this change."
17:31 jjpp and i happen to have a bunch of mobile apps that have sessionUpgrade written in (because they run agains openam11 for now). not nice.. :(
17:32 jjpp how did that not break xui?
19:10 aldaris joined #openam
23:01 jelmd joined #openam

| Channels | #openam index | Today | | Search | Google Search | Plain-Text | summary