Perl 6 - the future is here, just unevenly distributed

IRC log for #openam, 2017-11-24

| Channels | #openam index | Today | | Search | Google Search | Plain-Text | summary

All times shown according to UTC.

Time Nick Message
02:56 ilbot3 joined #openam
08:19 Gazooo joined #openam
12:42 FireBurn|Work joined #openam
12:45 FireBurn|Work Good afternoon
14:30 aldaris joined #openam
14:30 aldaris hey FireBurn|Work
14:32 FireBurn|Work Afternoon matey
14:32 aldaris I've lost track amongst the issues, let's limit the PRs to 4 commits
14:32 FireBurn|Work This is the first time I've really done multi-patch pull requests before, so appologies in advance for how messy this has gotten
14:33 FireBurn|Work If I cancel the current pull requet
14:33 FireBurn|Work Go back to master then apply the ones you've already OK'd in the comments, that will be one pull request
14:33 aldaris sounds good to me
14:33 FireBurn|Work The rest I'll do 3-4 at a time
14:34 aldaris just wondering if you'd be happy to do it in serial
14:34 aldaris may take a bit longer, but it would also result in less work for you
14:42 FireBurn|Work that's fine
14:43 aldaris btw the sooner we can finish this the better, I have one month leave coming up any time now
14:45 aldaris also feel free to open a standalone PR for the bugfixes that you are less certain about
14:46 aldaris given that they are more likely to demand more comments
14:46 FireBurn|Work Right there's now a https://github.com/ForgeRock/openam-community-edition/pull/38 with the ones you OK'd in the previous thread
14:47 FireBurn|Work Any idea about OPENAM-7125, OPENAM-5659 & OPENAM-9479 - they don't have any patches in the master branch and I can't view them in Jira either
14:47 aldaris will check them out a bit later
14:48 FireBurn|Work Also do OPENAM-8596, OPENAM-9389 & OPENAM-8575 really affect 11.0.3? They seem to have very few files in common
15:11 aldaris FireBurn|Work 1 PR down
15:13 aldaris OPENAM-7125 is probably a badly done commit, let me find the hash for that
15:18 aldaris nevermind, OPENAM-7125 was a tricky issue that had different fixes for the different versions
15:21 FireBurn|Work Grumble grumble
15:22 FireBurn|Work Right all the other requests have been split up
15:22 FireBurn|Work Thanks again for your help with this
15:22 FireBurn|Work I notice references to 11.0.4
15:22 aldaris OPENAM-5659 was committed as OPENAM-1974, but that is a very dangerous area
15:22 FireBurn|Work Did that ever get released?
15:22 aldaris no
15:24 aldaris openam-5659 is a very complex part of openam, I would not recommend trying to backport that - or you could consider grabbing the relevant classes from 14.0.0-snapshot as is and ignore the diffs altogether
15:26 FireBurn|Work Is that the classes in the OPENAM-1974 commits?
15:26 FireBurn|Work (there seems to be 3)
15:28 aldaris 9479 is #201608-02, just remove the files altogether. You won't find a commit in 13.x because by then those files were already removed.
15:28 aldaris more like the packages associated with it, and anything on their ancestry path
15:29 aldaris they are pretty self-contained components
15:29 aldaris so prefixresourcename, urlresourcename and httpurlresourcename
15:29 aldaris along with base* classes
15:29 aldaris it still won't be an easy backport
15:29 aldaris but the tests will help you greatly
15:31 FireBurn|Work Were those last comments about 9479 or 5659?
15:31 aldaris 5659
15:32 aldaris 9479 was the first one
15:34 FireBurn|Work Ta
15:45 FireBurn|Work I've also bumped Java to 1.7 in an OpenDJ pull request
15:45 FireBurn|Work Not very familiar with Ivy though
15:50 aldaris btw OPENAM-8080 is of interest as well
16:10 aldaris joined #openam
16:18 FireBurn|Work I'll take a look
16:20 FireBurn|Work Can't see any commits for that, and Jira is locked too
17:48 aldaris joined #openam
18:47 aldaris joined #openam
19:08 FireBurn joined #openam
19:08 FireBurn joined #openam
19:12 FireBurn aldaris: Not sure if I missed anything earlier
19:16 Topic for #openam is now Chat about the OpenAM project - https://forgerock.github.io - Channel logs at: http://irclog.perlgeek.de/openam/today
20:56 aldaris joined #openam
22:29 aldaris joined #openam
22:57 aldaris joined #openam

| Channels | #openam index | Today | | Search | Google Search | Plain-Text | summary