Perl 6 - the future is here, just unevenly distributed

IRC log for #openam, 2017-11-28

| Channels | #openam index | Today | | Search | Google Search | Plain-Text | summary

All times shown according to UTC.

Time Nick Message
02:58 ilbot3 joined #openam
02:58 Topic for #openam is now Chat about the OpenAM project - https://forgerock.github.io - Channel logs at: http://irclog.perlgeek.de/openam/today
07:55 aldaris joined #openam
11:28 FireBurn|Work joined #openam
11:29 FireBurn|Work Good morning
11:29 aldaris Good morning
11:29 FireBurn|Work aldaris: Sorry about that missing import, I've been compilign things between all my other commits
11:30 aldaris np
11:33 FireBurn|Work For OPENAM-5659 you said look at OPENAM-1974, there are 3 patches for that. One from 3 years ago that David Luna authored and the exact same one 2 years ago with your name on, which are already in the 11.0.3 code base. The 3rd cherry-picks cleanly - but you made it sound like this would be complicated. What have I missed
11:34 aldaris is David's commit already on 11.0.3?
11:35 FireBurn|Work Seems to be
11:35 aldaris ah
11:35 aldaris good for you
11:35 FireBurn|Work :D
11:35 aldaris then a nice chunk of the horror is already done
11:36 aldaris then I would suggest to look at all the relevant classes and their history on the 13.0.0 branch
11:37 aldaris or just copy all those classes over from 13.x to 11.0.3
11:39 FireBurn|Work I thought those two patches were the fix
11:40 aldaris I didn't really spend too much time on that patch, I really hate that code :)
11:41 aldaris it could be it is the right patch, but then strangely when we applied the patch to 11.0.3 it was different
11:42 FireBurn|Work Well if b1b9ed659b5ba78c15d544b1a76134a6eba06a55 compiles I'll put a PR in for it
11:45 FireBurn|Work I need to update that Xdoclint:none one, was that option doesn't work on Java7
13:26 aldaris joined #openam
14:14 aldaris FireBurn|Work my xerces comment is not really relevant for that code review, just something you may wish to look at later
14:21 FireBurn|Work The OPENDJ commit is already in OpenDJ CE
14:21 FireBurn|Work Couldn't find the commit for OPENAM-3767
14:22 aldaris ah, comment says: Should be resolved as part of fix forĀ https://bugster.forgerock.org/jira/browse/OPENAM-2673
14:22 aldaris so that's already covered then I guess
14:36 FireBurn|Work OPENAM-4170 works on files that don't seem to have counter parts in 11
14:37 aldaris yepp, then that isn't relevant for 11 most likely
14:37 aldaris UtilsTest may exist there somewhere else though
14:44 FireBurn|Work Looked around for it
14:44 aldaris fair enough
14:44 FireBurn|Work Hmm none iwth that exact name but files with UtilsTest in the text
14:45 FireBurn|Work Will take a closer look
14:45 FireBurn|Work I'm not sure OPENAM-4510 is necessary either
14:45 aldaris anyways, if the build doesn't fail for you locally then probably the issue isn't relevant
14:46 aldaris openam uses custom maven plugins during the build, it may be relevant, if those plugins existed in 11
14:46 FireBurn|Work OPENAM-4511 is part of the fix I was doing myself to get those blasted asserts working
15:10 FireBurn|Work xerces-J is still in the master branch at OpenRock, so if it's replaced by something better - its too new for me to backport
15:19 aldaris joined #openam
15:40 FireBurn|Work I'm curious to know how you're going to / have worked around the sun.security stuff
15:40 FireBurn|Work Porting it to java. stuff or using something like bouncy castle
16:12 aldaris with java9 I think for now we are using add exports
16:21 FireBurn|Work https://stackoverflow.com/questions/44056405/whats-the-difference-between-add-exports-and-add-opens-in-java-9
16:27 FireBurn|Work that's the Java 8 stuff updated
16:27 FireBurn|Work Tested with Java7 & Java8
17:32 aldaris joined #openam

| Channels | #openam index | Today | | Search | Google Search | Plain-Text | summary