Perl 6 - the future is here, just unevenly distributed

IRC log for #openstack-rally, 2014-10-05

| Channels | #openstack-rally index | Today | | Search | Google Search | Plain-Text | summary

All times shown according to UTC.

Time Nick Message
00:33 shakamunyi joined #openstack-rally
01:05 boris-42 Kui hi
01:05 Kui boris-42: hi
01:06 boris-42 Kui thank you for patch
01:06 boris-42 Kui there is one very last thing that you should address
01:06 boris-42 Kui unit tests
01:06 boris-42 Kui could you write it?
01:07 Kui boris-42: add a fresh new unit test ?
01:07 boris-42 Kui just a sec I'll point you
01:08 boris-42 Kui so here are all benchmarks https://github.com/stackforge/rally/blob/master/tests/benchmark/scenarios/vm/test_vmtasks.py
01:08 boris-42 Kui unit tests
01:08 boris-42 Kui you should add one more that will check only one thing
01:09 boris-42 Kui if there are volume_args it will properly call create disk and attach it
01:11 Kui boris-42: so I should copy/paste the test_boot_runcommand_delete, to generate a new unit test, which will apply volume_args, is that right ?
01:12 boris-42 Kui it will be better just to test only volume related stuff
01:13 Kui Kui: I think I have added it.  https://review.openstack.org/#/c/122409/5/tests/benchmark/scenarios/vm/test_vmtasks.py
01:17 boris-42 Kui oh sry
01:18 boris-42 Kui okay that works except one thing
01:18 boris-42 Kui you should check that scenario._create_volume.asserct_called_once_with(volume_args)
01:19 Kui boris-42: OK, I will add the assert
01:19 boris-42 Kui otherwise lgmt thank you
01:20 Kui boris-42: thank you for reviewing   :)
01:23 boris-42 Kui btw if you have any scripts
01:23 boris-42 Kui for running in VMTask you can add them as well to support dir
01:23 boris-42 Kui but please do that in separated patch=)
01:26 Kui boris-42: Got it, but  currently I don't have new script.
01:26 boris-42 Kui but how you are testing attached volume?
01:30 Kui boris-42:  I just make use of instance_dd_test.sh to test read/write of the volume.
01:41 openstackgerrit Kui Shi proposed a change to stackforge/rally: Add volume option to boot server from volume and run script  https://review.openstack.org/122409
02:44 andreykurilin_ joined #openstack-rally
03:47 rvcehimanshu joined #openstack-rally
04:26 openstackgerrit Oleh Anufriiev proposed a change to stackforge/rally: Add detailed description for rally commands  https://review.openstack.org/124910
05:16 chandankumar joined #openstack-rally
05:38 rvcehimanshu joined #openstack-rally
06:04 rvcehimanshu joined #openstack-rally
06:09 rvcehimanshu joined #openstack-rally
06:10 rvcehimanshu left #openstack-rally
07:28 chandankumar joined #openstack-rally
07:33 Kui joined #openstack-rally
08:46 chandankumar joined #openstack-rally
09:05 chandan_kumar joined #openstack-rally
09:10 openstackgerrit A change was merged to stackforge/rally: Expand ~ in file paths, specified in rally commands  https://review.openstack.org/126146
09:52 openstackgerrit A change was merged to stackforge/rally: Add volume option to boot server from volume and run script  https://review.openstack.org/122409
12:12 openstackgerrit Artem Borzilov proposed a change to stackforge/rally: Task results are now stored in chunks  https://review.openstack.org/125245
12:17 andreykurilin_ joined #openstack-rally
12:26 tzabal joined #openstack-rally
16:59 jjmb joined #openstack-rally
17:00 tzabal joined #openstack-rally
17:12 vkmc joined #openstack-rally
17:12 vkmc joined #openstack-rally
18:12 andreykurilin_ joined #openstack-rally
19:38 shakamunyi joined #openstack-rally
19:41 shakamunyi joined #openstack-rally
19:48 shakamunyi joined #openstack-rally
20:05 Kui joined #openstack-rally
20:07 shakayumi joined #openstack-rally
20:11 tzabal left #openstack-rally
22:55 jjmb joined #openstack-rally
23:11 jjmb joined #openstack-rally

| Channels | #openstack-rally index | Today | | Search | Google Search | Plain-Text | summary