Perl 6 - the future is here, just unevenly distributed

IRC log for #openstack-rally, 2015-01-05

| Channels | #openstack-rally index | Today | | Search | Google Search | Plain-Text | summary

All times shown according to UTC.

Time Nick Message
00:17 rook_ joined #openstack-rally
00:35 openstackgerrit Andrey Kurilin proposed stackforge/rally: Fix py3k issues  https://review.openstack.org/141163
00:48 andreykurilin_ joined #openstack-rally
01:05 openstackgerrit Andrey Kurilin proposed stackforge/rally: Fix py3k issues  https://review.openstack.org/141163
01:12 mwagner_lap joined #openstack-rally
01:18 rook_ joined #openstack-rally
01:18 aswadr joined #openstack-rally
01:19 yaguang joined #openstack-rally
02:04 yaguang joined #openstack-rally
02:05 rvcehimanshu joined #openstack-rally
03:07 rook joined #openstack-rally
04:18 psd joined #openstack-rally
04:25 nkhare joined #openstack-rally
04:35 rvcehimanshu joined #openstack-rally
04:56 rook joined #openstack-rally
04:59 prmtl joined #openstack-rally
05:07 rdas joined #openstack-rally
05:13 yfried joined #openstack-rally
05:26 tfreger joined #openstack-rally
05:46 prmtl joined #openstack-rally
06:42 rdas joined #openstack-rally
06:45 rook_ joined #openstack-rally
07:01 openstackgerrit Pavel Boldin proposed stackforge/rally: Add the generic script-based benchmark for the VMs  https://review.openstack.org/141671
07:01 openstackgerrit Pavel Boldin proposed stackforge/rally: Add the context benchmark_image  https://review.openstack.org/138466
07:01 openstackgerrit Pavel Boldin proposed stackforge/rally: Tests for rally gates  https://review.openstack.org/143469
07:12 pboldin joined #openstack-rally
07:20 yfried joined #openstack-rally
07:45 rook joined #openstack-rally
08:05 arxcruz joined #openstack-rally
08:08 fhubik joined #openstack-rally
08:16 rvcehimanshu joined #openstack-rally
08:29 yaguang joined #openstack-rally
08:33 andreykurilin joined #openstack-rally
08:38 oanufriev joined #openstack-rally
08:41 neeti joined #openstack-rally
08:45 nmagnezi joined #openstack-rally
08:51 yaguang joined #openstack-rally
08:53 yaguang_ joined #openstack-rally
08:54 dmellado joined #openstack-rally
09:09 exploreshaifali joined #openstack-rally
09:14 dmellado joined #openstack-rally
09:17 stannie joined #openstack-rally
09:29 tkammer joined #openstack-rally
09:34 rook joined #openstack-rally
09:35 amaretskiy joined #openstack-rally
09:35 yaguang_ joined #openstack-rally
10:16 shaifali_ joined #openstack-rally
10:24 ekarlso- joined #openstack-rally
10:25 psd joined #openstack-rally
10:30 tkammer joined #openstack-rally
10:32 openstackgerrit Arx Cruz proposed stackforge/rally: Add a validator for neutron networks  https://review.openstack.org/141813
10:44 andreykurilin joined #openstack-rally
10:48 andreykurilin chen hi!
10:48 andreykurilin arxcruz: hi!
10:48 arxcruz andreykurilin, hey you :)
10:48 arxcruz happy new year
10:48 andreykurilin \o/ happy new year:)
10:50 andreykurilin arxcruz: thanks for your work around fixing py3 issues.
10:50 arxcruz andreykurilin, :)
10:50 andreykurilin arxcruz: before, rally unit tests were not launched at all:)
10:51 arxcruz andreykurilin, now i'm stucked in the ValidationResult :/
10:51 arxcruz some tests are expecting returning ValidationResult(True)
10:52 andreykurilin arxcruz: wait a moment.
10:52 andreykurilin looking at tests
10:53 arxcruz andreykurilin, yes?
10:54 andreykurilin arxcruz: what tests expects returning ValidationResult(True) ?
10:54 arxcruz andreykurilin, https://jenkins05.openstack.org/job/gate-rally-python27/833/console
10:54 arxcruz because of https://github.com/stackforge/rally/blob/master/rally/benchmark/validation.py
10:55 arxcruz line 102
10:59 openstackgerrit Andrey Kurilin proposed stackforge/rally: Fix py3k issues  https://review.openstack.org/141163
11:01 rvcehimanshu joined #openstack-rally
11:02 dmellado joined #openstack-rally
11:03 andreykurilin arxcruz: looks like idea to remove all ValidationResults() needs a lot of refactoring
11:03 arxcruz andreykurilin, yes, a LOT
11:03 andreykurilin arxcruz: imo, needless refactoring:)
11:03 andreykurilin so let's ask the auther of this idea
11:03 andreykurilin amaretskiy: hi
11:03 arxcruz andreykurilin, yes, you know the code so it would be easier for you :P
11:04 amaretskiy hi
11:04 andreykurilin amaretskiy: please look at aour discussion with arxcruz:)
11:04 amaretskiy ok, reading...
11:05 amaretskiy all validators returns ValidationResult(True) by default
11:06 amaretskiy I haven't caught the idea
11:06 amaretskiy do we want to reimplement validators to raising exception if failed?
11:06 amaretskiy like in Django
11:07 andreykurilin amaretskiy: they did not return Validationresult(True) by default, if they are called directly
11:08 andreykurilin but all our unit tests check return value of validator
11:08 amaretskiy andreykurilin, arxcruz: I think validator MUST return success by default
11:09 andreykurilin and it returns success:)
11:09 andreykurilin now
11:12 chenli12 joined #openstack-rally
11:13 andreykurilin amaretskiy, arxcruz: boris-42 is working on refactoring engine of validators, so, imo, it is no reason to refactor returning values now.
11:14 chen andreykurilin hi
11:15 vkmc joined #openstack-rally
11:15 andreykurilin chen: thanks for working on py3 :)
11:16 chen andreykurilin :)
11:17 andreykurilin chen: https://review.openstack.org/#/c/141163/ <- this patch fixing the last issue listed on launchpad, but this does not mean that all py3k issues are fixed:(
11:18 openstackgerrit Andrey Kurilin proposed stackforge/rally: Fix py3k issues  https://review.openstack.org/141163
11:19 fhubik joined #openstack-rally
11:19 andreykurilin chen: tox.ini will include list of tests which are passed in py3 env( https://review.openstack.org/#/c/141163/11/tox.ini ), so gate-rally-python34 will check that existing compatible stuff is not broken
11:20 andreykurilin chen: so I'll happy if you continue work on porting Rally to python 3. there are ~180 failed tests:D
11:21 andreykurilin arxcruz: ^
11:21 chen andreykurilin sure
11:23 rook joined #openstack-rally
11:23 andreykurilin chen, arxcruz: failed tests http://logs.openstack.org/63/141163/8/check/gate-rally-python34/22d797d/console.html :D
11:24 andreykurilin I'll report bugs for most of then a bit later.
11:24 tkammer joined #openstack-rally
11:28 arxcruz andreykurilin, sure
11:28 arxcruz andreykurilin, so, rearding the ValidationResult, shall I keep the returns for now ?
11:28 tfreger1 joined #openstack-rally
11:32 psd_ joined #openstack-rally
11:38 tkammer_ joined #openstack-rally
11:38 tkammer_ joined #openstack-rally
11:44 fhubik joined #openstack-rally
11:45 dmellado joined #openstack-rally
12:02 rvcehimanshu joined #openstack-rally
12:09 openstackgerrit Arx Cruz proposed stackforge/rally: Python 3 fix '+' operand in dict_items  https://review.openstack.org/144971
12:11 tfreger joined #openstack-rally
12:14 rook joined #openstack-rally
12:14 fhubik joined #openstack-rally
12:24 andreykurilin1 arxcruz: yes
12:25 arxcruz andreykurilin1, okay :)
12:26 fhubik joined #openstack-rally
12:28 cdent joined #openstack-rally
12:50 boris-42 arxcruz: hey hey ho
12:50 arxcruz boris-42, hey :)
13:02 tkammer_ joined #openstack-rally
13:03 mwagner_lap joined #openstack-rally
13:14 rook joined #openstack-rally
13:29 arxcruz andreykurilin1, https://review.openstack.org/#/c/144971/
13:29 arxcruz so, it fixes 76 errors in py3k :)
13:29 andreykurilin1 arxcruz: great!
13:31 openstackgerrit Andrey Kurilin proposed stackforge/rally: Fix py3k issues  https://review.openstack.org/141163
13:32 andreykurilin1 arxcruz: can you depend your patch to my ^? if you do it, results of your work will be seen in gate-rally-python34 job
13:36 andreykurilin1 NikitaKonovalov: hi!
13:37 arxcruz andreykurilin1, I'll try, I'm terrible in these dependencies :P
13:39 andreykurilin1 arxcruz: it is very easy. you should checkout my patch, then cherry-pick your and that send to review.
13:39 andreykurilin1 first step: git fetch https://review.openstack.org/stackforge/rally refs/changes/63/141163/13 && git checkout FETCH_HEAD
13:39 openstackgerrit Arx Cruz proposed stackforge/rally: Python 3 fix '+' operand in dict_items  https://review.openstack.org/144971
13:39 andreykurilin1 nice)
13:39 arxcruz andreykurilin1, done :)
13:39 andreykurilin1 good
13:49 pcaruana joined #openstack-rally
13:52 boris-42 arxcruz: so what you would like to refactor in validation stuff?
13:52 boris-42 arxcruz: sorry me still on holidays=)
13:52 boris-42 arxcruz: so not so active lol
13:52 arxcruz boris-42, no problem, me and andreykurilin1 was discussing the ResultsValidation return
13:53 arxcruz because some tests are expecting a return, and it's failing when I remove the return True code
13:53 arxcruz as you can see in https://review.openstack.org/#/c/141813/
13:58 boris-42 arxcruz: why did you remove it
13:58 boris-42 arxcruz: ?)
13:59 arxcruz boris-42, someone told me that was redundant and it was supposed to be removed :)
14:00 yfried_ joined #openstack-rally
14:03 exploreshaifali joined #openstack-rally
14:05 mwagner_lap joined #openstack-rally
14:05 olkonami joined #openstack-rally
14:08 stannie joined #openstack-rally
14:16 rook joined #openstack-rally
14:17 yfried__ joined #openstack-rally
14:24 prmtl joined #openstack-rally
14:35 openstackgerrit Arx Cruz proposed stackforge/rally: Python 3 fix '+' operand in dict_items  https://review.openstack.org/144971
14:35 prmtl joined #openstack-rally
14:38 boris-42 : arxcruz lol I think it's amaretskiy he likes reforms
14:38 arxcruz hehehehe
14:39 amaretskiy :)
14:39 arxcruz boris-42, I'll put the returns again...
14:39 arxcruz for now
14:39 arxcruz :)
14:40 amaretskiy boris-42 what about the idea of removing return value from validators at all
14:41 amaretskiy and raise exception if failure
14:44 yaguang joined #openstack-rally
14:52 openstackgerrit Arx Cruz proposed stackforge/rally: Add a validator for neutron networks  https://review.openstack.org/141813
14:52 prmtl joined #openstack-rally
15:02 prmtl joined #openstack-rally
15:04 boris-42 amaretskiy: maybe someday
15:08 yfried__ joined #openstack-rally
15:11 yfried joined #openstack-rally
15:18 prmtl joined #openstack-rally
15:20 openstackgerrit Merged stackforge/rally: Add the flavor context  https://review.openstack.org/141670
15:23 paboldin yay, finally
15:44 boris-42 pboldin: seems like record for our CI
15:44 boris-42 pboldin: 7 rechecks
15:48 openstackgerrit Oleh Anufriiev proposed stackforge/rally: Support generation of report from N task  https://review.openstack.org/143866
15:56 rvcehimanshu joined #openstack-rally
16:00 paboldin boris-42: :D
16:07 openstackgerrit joined #openstack-rally
16:20 openstackgerrit Andrey Kurilin proposed stackforge/rally: Fix py3k issues  https://review.openstack.org/141163
16:23 openstackgerrit Roman Vasilets proposed stackforge/rally: Add murano benchmarks  https://review.openstack.org/137661
16:23 openstackgerrit Roman Vasilets proposed stackforge/rally: Add murano base for murano benchmarks  https://review.openstack.org/137650
16:24 openstackgerrit Andrey Kurilin proposed stackforge/rally: Fix py3k issues  https://review.openstack.org/141163
16:30 boris-42 jlk: hey =)
16:30 boris-42 jlk: could you please updat your patch with runners?)
16:30 boris-42 jlk: and happy new year=)
16:31 jlk boris-42: yeah I hope to get to it this week
16:32 boris-42 jlk: great
16:48 openstackgerrit Roman Vasilets proposed stackforge/rally: Add murano benchmarks  https://review.openstack.org/137661
16:48 openstackgerrit Roman Vasilets proposed stackforge/rally: Add murano base for murano benchmarks  https://review.openstack.org/137650
16:50 davidlenwell joined #openstack-rally
16:51 openstackgerrit joined #openstack-rally
17:04 openstackgerrit joined #openstack-rally
17:30 psd boris-42, Got any tasks for me?
17:30 boris-42 psd: yep
17:31 psd boris-42, awesome :)
17:31 boris-42 psd: so did you run rally before?
17:31 psd boris-42, how are you doing btw?
17:31 boris-42 psd: I mean locally?
17:31 boris-42 psd: good good vacation=)
17:31 boris-42 psd: actually holidays* not vacation-)
17:31 psd boris-42, oh nice :)
17:31 boris-42 psd: so did you run rally?
17:32 psd yeah! once
17:34 yfried joined #openstack-rally
17:35 boris-42 psd: one moment on call
17:35 boris-42 psd: so actually when we are running task
17:36 boris-42 psd: it displays status
17:36 boris-42 psd: and failed
17:37 boris-42 psd: it looks uclear
17:37 boris-42 psd: for end users so we need to fix it
17:37 psd okay
17:40 boris-42 psd: let me a bit think=)
17:40 psd sure :0
17:40 psd :)
17:46 boris-42 psd: so actually we don't need https://github.com/stackforge/rally/blob/master/rally/db/sqlalchemy/models.py#L149
17:46 boris-42 psd: this in models
17:46 boris-42 psd: and we should remove it from a lot of other places
17:46 boris-42 psd: this can be  1patch
17:47 boris-42 psd: after it we can work on future improvements. Like now we are showing at field created_at (not only in this command but in all) date-time(with_ms) I would prefer to remove ms from it
17:47 boris-42 1 patch
17:48 boris-42 psd: 3rd patch is for example to add duration of task (updated_at - created_at)
17:48 boris-42 psd: enough tasks?)
17:48 psd boris-42, yeah :)
17:48 exploreshaifali joined #openstack-rally
18:00 boris-42 psd: patches are quite small
18:00 boris-42 psd: the smallest one is to add duration
18:00 boris-42 psd: you can start from it
18:01 boris-42 psd: this method is called from cli https://github.com/stackforge/rally/blob/master/rally/cmd/commands/task.py#L344
18:04 psd boris-42, Alright
18:05 boris-42 psd: =)
18:05 boris-42 psd: so if u have any questions just ping=)
18:05 psd boris-42, sure :)
18:07 psd boris-42, what deployment initialization do you use for testing rally?
18:08 boris-42 psd: existing
18:08 boris-42 psd: or even simpler
18:08 boris-42 psd:  if you have installed devstack
18:08 boris-42 and devstack directory is in ~/devstack
18:08 boris-42 then you can do next
18:08 boris-42 . ~/devstack/openrc admin admin
18:09 boris-42 rally deployment create --fromevn --name some_deployment
18:15 psd Thanks :)
18:23 vaidy_ril joined #openstack-rally
19:05 psd boris-42, should I add duration to the headers, or should I just print it?
19:08 mwagner_lap joined #openstack-rally
19:10 boris-42 psd: both
19:10 boris-42 psd: add to header and print it
19:24 andreykurilin joined #openstack-rally
19:32 psd boris-42, okay and as I have understood this function fetches data from the database using the objects.Task.list.
19:32 psd is this correct?
19:33 andreykurilin joined #openstack-rally
19:35 boris-42 psd: yep yep
19:35 boris-42 psd: and you already have created_at and updated_at
19:36 psd so I can add only updated_at in the header, right?
19:36 boris-42 so you need to showdifference
19:36 boris-42 psd: you should show duration
19:36 boris-42 psd: not when it is updated
19:36 boris-42 psd: nobody cares when it was updated
19:37 psd ya right
19:37 psd this is where I am stuck
19:38 psd so I should load the values in a local variables and find the difference?
19:41 boris-42 jlk: your patch with removing hardcoded crap works OK against our scale lab
19:41 boris-42 jlk: andreykurilin1 tested it
19:41 jlk nice!
19:41 jlk I saw the comment about deprecation warning. I could work something in like that
19:41 boris-42 jlk: so I can merge it and I will talk with our other teams (that are running rally in real life on demand)
19:41 boris-42 jlk: ya that will be ok
19:42 boris-42 jlk: when you finish we can merge it
19:42 jlk awesome.
19:42 psd boris-42, I think I got it
19:45 boris-42 yfried: I added you rigth to edit that document
19:46 boris-42 yfried: sorry
19:46 boris-42 psd: nice will wait for patch
19:46 psd boris-42, :)
19:46 yfried boris-42: I had the permission since you've created it. can't you see my suggestions?
19:47 boris-42 yfried: yep I can
19:47 boris-42 ah it's your text=)
19:47 boris-42 lol=)
19:48 boris-42 yfried: lol
19:48 yfried I set them to "suggestion" so you can approve or comment
19:53 boris-42 yfried: ok I will take a look a bit latter
19:53 boris-42 yfried: btw change that you can add even now is put "iteration_timestampt" to results
19:54 boris-42 yfried: we will need it in any case
19:55 yfried boris-42: I'm not familiar with the result output, but if you point me in the general direction I'll take a look
19:56 boris-42 yfried: schema that validates 1 iteration results https://github.com/stackforge/rally/blob/master/rally/benchmark/runners/base.py#L98-L136
19:57 boris-42 yfried: so you'll need to add one extra field
19:57 boris-42 yfried: method that executes one iteration https://github.com/stackforge/rally/blob/master/rally/benchmark/runners/base.py#L60-L93
19:58 boris-42 yfried: ^ you'll need to put to return value timestampt
19:58 yfried boris-42: tnx. I'll take a look tomorrow
19:58 yfried boris-42: it's 22:00 for me
20:12 boris-42 yfried: hehe=)
20:16 andreykurilin joined #openstack-rally
20:24 rook joined #openstack-rally
20:31 andreykurilin joined #openstack-rally
21:46 rook joined #openstack-rally
22:22 openstackgerrit Andrey Kurilin proposed stackforge/rally: Fix py3k issues  https://review.openstack.org/141163
23:16 openstackgerrit Jesse Keating proposed stackforge/rally: Don't hard set keystone endpoint  https://review.openstack.org/144366
23:16 jlk boris-42: ^^ that does the backwards compatible warning.
23:16 jlk similar to how some other files do it
23:17 boris-42 jlk: great
23:17 boris-42 jlk: currently rally gates are broken
23:17 boris-42 jlk: because new release of oslo.config =)
23:17 jlk oops :)
23:17 * jlk shakes fist at oslo
23:18 boris-42 jlk: ya it happens
23:34 rook joined #openstack-rally
23:37 andreykurilin joined #openstack-rally
23:37 boris-42 jlk: LOL http://seclists.org/oss-sec/2015/q1/64
23:38 jlk boris-42: well... fuck
23:48 openstackgerrit Jesse Keating proposed stackforge/rally: Don't hard set keystone endpoint  https://review.openstack.org/144366
23:49 exploreshaifali joined #openstack-rally
23:57 andreykurilin joined #openstack-rally
23:59 boris-42 jlk: we need to wait until new release with fixes is merged
23:59 boris-42 jlk: and we will be able to merge it

| Channels | #openstack-rally index | Today | | Search | Google Search | Plain-Text | summary