Perl 6 - the future is here, just unevenly distributed

IRC log for #openstack-rally, 2015-05-10

| Channels | #openstack-rally index | Today | | Search | Google Search | Plain-Text | summary

All times shown according to UTC.

Time Nick Message
01:29 mwagner_lap joined #openstack-rally
02:31 botang joined #openstack-rally
04:29 tfreger joined #openstack-rally
04:31 tfreger left #openstack-rally
06:20 yfried|afk joined #openstack-rally
07:01 exploreshaifali joined #openstack-rally
07:39 agarciam joined #openstack-rally
07:59 rvasilets joined #openstack-rally
07:59 svasheka joined #openstack-rally
07:59 aarefiev joined #openstack-rally
08:00 oanufriev joined #openstack-rally
08:00 amaretskiy joined #openstack-rally
08:02 andreykurilin1 joined #openstack-rally
09:16 exploreshaifali joined #openstack-rally
09:22 rvasilets joined #openstack-rally
09:29 aarefiev joined #openstack-rally
09:29 svasheka joined #openstack-rally
09:38 amaretskiy joined #openstack-rally
09:38 andreykurilin1 joined #openstack-rally
10:14 oanufriev joined #openstack-rally
12:23 yfried__ joined #openstack-rally
12:38 yfried__ boris-42: ping
12:43 boris-42 yfried__: pong
12:44 yfried__ boris-42: hi
12:44 yfried__ boris-42: https://review.openstack.org//#/c/168849/
12:48 boris-42 yfried__: okay I will review it
12:48 yfried__ boris-42: tnx
12:48 boris-42 yfried__: we need as well andreykurilin1 )
12:48 yfried__ boris-42: of course
12:49 boris-42 yfried__: what about moving SLA stuff
12:52 yfried__ boris-42: working on it now
12:52 yfried__ boris-42: https://review.openstack.org//#/c/180509/7/rally/cmd/commands/info.py
12:52 yfried__ boris-42: I don't understand your comment ther
12:52 yfried__ e
12:53 yfried__ boris-42: do you want to me to add another: utils.load_plugins("/path/to/plugins")?
12:54 boris-42 yfried__: yes you must add it otherwise it won't work
12:55 boris-42 yfried__: you don't need to add /path/to/plugins
12:55 boris-42 yfried__: you can just add "rally.plugins"
12:55 boris-42 yfried__: it should work
12:55 boris-42 yfried__: if you don't import all modules in rally.plugins they won't be autodiscovered and they won't work
12:57 yfried__ boris-42: I'm not sure about that, but does it mean that I need to remove the import from info.py file?
12:57 boris-42 yfried__: what you are not sure about?
12:57 boris-42 yfried__: about autodiscovering?
12:57 boris-42 yfried__: I wrote it, so you can be sure*
12:57 yfried__ boris-42: I mean that I have no idea how this works
12:57 boris-42 yfried__: it is very simple mechanism
12:57 yfried__ boris-42: so I'm just following your instructions
12:58 boris-42 yfried__: let me expalian how it works
12:58 boris-42 there is base class
12:58 yfried__ boris-42: I'm pushing my current draft including scenarios.
12:58 boris-42 and we are iterating over all subclasses
12:58 boris-42 of this baseclass
12:58 boris-42 subclasses are plugins
12:58 boris-42 and we are just checking that name of class (whatever) is that we are looking for
12:58 boris-42 yfried__: ^
12:59 boris-42 yfried__: so if you don't import modules, when you will start iterating over the subclasses (you won't find anything that wasn't imported)
12:59 boris-42 yfried__: that is why we need to do recursive imports
13:00 boris-42 yfried__: here is how it works now https://github.com/openstack/rally/blob/master/rally/benchmark/__init__.py#L19-L21
13:00 yfried__ boris-42: do I need to use the utils.load_plugins func, or do a simple "from rally import plugins"?
13:00 boris-42 yfried__: if you do "from rally import plugins" nothing won't be imported except plugins and import from plugins
13:01 boris-42 yfried__: and you need to improt all modules
13:01 boris-42 so you need these special utils
13:01 boris-42 rutils.import_modules_from_package("rally.plugin")
13:01 boris-42 yfried__: the questing regarding to "do you need to import in info" module
13:02 boris-42 yfried__: nope you don't need if you put where I asked you, becuase that place will be executed before info commands
13:03 boris-42 yfried__: I hope now it's no more magic for you?)
13:09 boris-42 yfried__: by the way I would like one more thing from you
13:09 boris-42 yfried__: it's to put read me file that describes plugins
13:09 boris-42 yfried__: it can be just ln -s to the documentation with name README.rst here
13:10 boris-42 yfried__: https://rally.readthedocs.org/en/latest/plugins.html
13:10 boris-42 yfried__: it will simplify learning repo structure
13:20 aarefiev joined #openstack-rally
13:20 rvasilets joined #openstack-rally
13:38 tfreger joined #openstack-rally
13:38 tfreger left #openstack-rally
14:51 openstackgerrit Yair Fried proposed openstack/rally: Split SLA to base and plugins  https://review.openstack.org/180509
14:51 openstackgerrit Yair Fried proposed openstack/rally: Split runners to base and plugins  https://review.openstack.org/180904
14:51 openstackgerrit Yair Fried proposed openstack/rally: Split scenarios under Plugins  https://review.openstack.org/181738
14:52 yfried__ boris-42: I'm having trouble with the imports (I think) my unitests aren't working
14:52 yfried__ boris-42: could you please take a look? and could you please post the README thing to the patch comments?
15:10 yfried joined #openstack-rally
16:06 yfried_ joined #openstack-rally
16:45 mpopow joined #openstack-rally
17:39 yfried_ joined #openstack-rally
17:53 e0ne joined #openstack-rally
18:03 e0ne joined #openstack-rally
18:05 openstackgerrit joined #openstack-rally
18:28 e0ne joined #openstack-rally
18:34 e0ne joined #openstack-rally
18:41 e0ne joined #openstack-rally
19:05 e0ne joined #openstack-rally
19:12 e0ne joined #openstack-rally
19:18 e0ne joined #openstack-rally
19:40 e0ne joined #openstack-rally
20:26 boris-42 yfried_: I can maybe
23:47 mpopow joined #openstack-rally

| Channels | #openstack-rally index | Today | | Search | Google Search | Plain-Text | summary