Perl 6 - the future is here, just unevenly distributed

IRC log for #openstack-rally, 2015-06-09

| Channels | #openstack-rally index | Today | | Search | Google Search | Plain-Text | summary

All times shown according to UTC.

Time Nick Message
00:08 mahito joined #openstack-rally
00:15 dmorita joined #openstack-rally
00:31 openstackgerrit Pavel Boldin proposed openstack/rally: Add command-dict option to specify command args  https://review.openstack.org/177016
00:31 openstackgerrit Pavel Boldin proposed openstack/rally: Add command_customizer context  https://review.openstack.org/183227
00:31 openstackgerrit Pavel Boldin proposed openstack/rally: Add boot_runcommand_delete_custom_image scenario  https://review.openstack.org/183228
00:31 openstackgerrit Pavel Boldin proposed openstack/rally: Make `boot_runcommand_delete' accept command-dict  https://review.openstack.org/177014
00:31 openstackgerrit Pavel Boldin proposed openstack/rally: Add command-dict option to upload a local command  https://review.openstack.org/177015
00:52 yingjun joined #openstack-rally
00:55 briandowns joined #openstack-rally
01:00 BitSmith joined #openstack-rally
01:10 yingjun joined #openstack-rally
02:10 openstackgerrit John Wu proposed openstack/rally: [Swift] Add additional Swift scenarios  https://review.openstack.org/185793
02:10 openstackgerrit John Wu proposed openstack/rally: [Swift] Add objects context class  https://review.openstack.org/179578
02:19 georgem1 joined #openstack-rally
02:23 openstackgerrit Li Yingjun proposed openstack/rally: Validate tenant related scenarios when using keystone v3  https://review.openstack.org/181321
02:41 davideagnello joined #openstack-rally
03:17 MaxPC joined #openstack-rally
03:21 mahito joined #openstack-rally
03:21 kiran-r joined #openstack-rally
03:22 harlowja_ joined #openstack-rally
03:47 mahito joined #openstack-rally
04:00 psuriset joined #openstack-rally
04:08 ajiang left #openstack-rally
04:19 kiran-r joined #openstack-rally
04:19 MaxPC joined #openstack-rally
04:40 aswadr joined #openstack-rally
04:53 tfreger joined #openstack-rally
04:56 yingjun joined #openstack-rally
04:58 psd joined #openstack-rally
05:06 mahito joined #openstack-rally
05:06 openstackgerrit Kiran proposed openstack/rally: Add validator to check parameter inside a dictionary argument  https://review.openstack.org/188334
05:08 nihilifer joined #openstack-rally
05:09 openstackgerrit Kiran proposed openstack/rally: Add validator to check parameter inside a dictionary argument  https://review.openstack.org/188334
05:13 openstackgerrit Kiran proposed openstack/rally: Add validator to check parameter inside a dictionary argument  https://review.openstack.org/188334
05:17 yingjun_ joined #openstack-rally
05:27 yfried joined #openstack-rally
05:29 e0ne joined #openstack-rally
05:33 kiranr joined #openstack-rally
05:35 kiranr joined #openstack-rally
05:37 rdas joined #openstack-rally
05:37 kiranr joined #openstack-rally
05:41 mahito joined #openstack-rally
05:42 kiran-r joined #openstack-rally
05:44 kiran-r joined #openstack-rally
05:44 mahito joined #openstack-rally
05:47 kiran-r joined #openstack-rally
05:48 kiran-r joined #openstack-rally
05:50 pbandzi joined #openstack-rally
05:50 kiran-r joined #openstack-rally
05:55 kiran-r joined #openstack-rally
05:55 kiran-r joined #openstack-rally
05:57 kiran-r joined #openstack-rally
05:58 kiran-r joined #openstack-rally
05:59 kiran-r joined #openstack-rally
06:00 kiran-r joined #openstack-rally
06:00 kiran-r joined #openstack-rally
06:01 karmatronic joined #openstack-rally
06:01 kiran-r joined #openstack-rally
06:02 kiran-r joined #openstack-rally
06:05 kiran-r joined #openstack-rally
06:06 kiran-r joined #openstack-rally
06:07 kiran-r joined #openstack-rally
06:08 yingjun joined #openstack-rally
06:09 kiran-r joined #openstack-rally
06:14 kiran-r joined #openstack-rally
06:19 kiran-r joined #openstack-rally
06:22 kiran-r joined #openstack-rally
06:23 kiran-r joined #openstack-rally
06:26 kiran-r joined #openstack-rally
06:28 openstackgerrit Kiran proposed openstack/rally: Add validator to check parameter inside a dictionary argument  https://review.openstack.org/188334
06:28 kiran-r joined #openstack-rally
06:30 kiran-r joined #openstack-rally
06:31 kiran-r joined #openstack-rally
06:31 kiran-r joined #openstack-rally
06:32 kiran-r joined #openstack-rally
06:37 serverascode joined #openstack-rally
06:45 anshul joined #openstack-rally
06:46 zhiyan joined #openstack-rally
06:50 kiran-r joined #openstack-rally
06:51 kiran-r joined #openstack-rally
06:52 kiran-r joined #openstack-rally
06:53 kiran-r joined #openstack-rally
06:53 kiran-r joined #openstack-rally
06:55 kiran-r joined #openstack-rally
06:57 kiran-r joined #openstack-rally
06:59 kiran-r joined #openstack-rally
07:00 kiran-r joined #openstack-rally
07:14 arxcruz joined #openstack-rally
07:15 agarciam joined #openstack-rally
07:15 meteorfox joined #openstack-rally
07:16 yfried yingjun: ping re https://review.openstack.org/#/c/187501/
07:17 yingjun fried, sorry didn’t get the email.. will do
07:27 yingjun yfried|afk, reply inline
07:28 kun_huang joined #openstack-rally
07:30 pbandzi_ joined #openstack-rally
07:32 neeti joined #openstack-rally
07:32 yfried yingjun: I'm looking at you comment again, and I think I've misled you
07:32 yfried yingjun: the problem is in L79
07:33 yfried yingjun: it's trying to delete stuff that's already gone.
07:34 yfried yingjun: L94 is executed later
07:34 yfried yingjun: actually, in the problematic case, L94 isn't executed at all (try..else)
07:38 yingjun yfried, what if is_deleted in line179 raised an exception, but the resource is still exist
07:41 yfried yingjun: if is_deleted() raises an exception, then the exception should be handled/raised as well as any kind fo exception. I don't understand the question
07:45 PrashantS joined #openstack-rally
07:49 yingjun yfried, i mean if resource.delete() work but resource.is_deleted() broken as described in L98, self._delete_single_resource() will never be called, so the resource will never be deleted, right?
07:54 cdent joined #openstack-rally
07:57 nkhare joined #openstack-rally
08:05 amaretskiy joined #openstack-rally
08:07 kiran-r joined #openstack-rally
08:09 PrashantS joined #openstack-rally
08:09 kiran-r joined #openstack-rally
08:12 fhubik joined #openstack-rally
08:12 kiran-r joined #openstack-rally
08:13 kiran-r joined #openstack-rally
08:15 yfried yingjun: you want to a try and invoke in case of exception? I'm open to other suggestions
08:17 yingjun yfried, that’s what i mean:)
08:20 kiran-r joined #openstack-rally
08:24 karimb joined #openstack-rally
08:25 amalinow|2 joined #openstack-rally
08:31 karmatronic joined #openstack-rally
08:32 amalinow|2 joined #openstack-rally
08:33 amalinow joined #openstack-rally
08:35 karmatronic joined #openstack-rally
08:36 kiran-r joined #openstack-rally
08:37 yfried andreykurilin: yingjun: amaretskiy: http://paste.openstack.org/show/276981/
08:37 yfried my unittest fails on master. am I missing something?
08:38 openstackgerrit Yair Fried proposed openstack/rally: Avoid cleanup of deleted resources  https://review.openstack.org/187501
08:38 amaretskiy yfried: remova all *pyc
08:38 amaretskiy *remove
08:38 yfried yingjun: ^ please see my patch
08:38 amaretskiy ok
08:39 karimb joined #openstack-rally
08:40 yingjun yfried, ok
08:40 yfried amaretskiy: tnx. fixed
08:46 e0ne joined #openstack-rally
08:49 kiran-r joined #openstack-rally
08:50 kiran-r joined #openstack-rally
08:59 Miouge joined #openstack-rally
09:03 psd_ joined #openstack-rally
09:05 aix joined #openstack-rally
09:13 openstackgerrit Yair Fried proposed openstack/rally: Feature request Uninstall and version.  https://review.openstack.org/185543
09:32 tosky joined #openstack-rally
09:53 redixin joined #openstack-rally
10:05 aix joined #openstack-rally
10:12 kvk joined #openstack-rally
10:21 e0ne joined #openstack-rally
10:25 kiranr joined #openstack-rally
10:29 redixin joined #openstack-rally
10:43 yingjun joined #openstack-rally
10:47 redixin joined #openstack-rally
10:52 openstackgerrit Boris Pavlovic proposed openstack/rally: Feature request improve install script  https://review.openstack.org/185543
10:53 boris-42 joined #openstack-rally
10:57 yingjun joined #openstack-rally
11:14 yfried boris-42: re https://review.openstack.org/#/c/187501/
11:15 yfried boris-42: I remember we discussed this, and that it should be solved by another patch/spec. could you please post this to the comments?
11:18 boris-42 yfried: I left comment to point the spec
11:18 boris-42 yfried: in any case I am not against that patch, I just need to analyze it better
11:19 yfried boris-42: tnx. I'm not offended, I just like everything to be doc'ed because I have terrible memory
11:19 yfried boris-42: tnx
11:20 boris-42 yfried: cleaunp is very important topic but plugin base is more important =)
11:24 boris-42 yfried https://review.openstack.org/#/c/160142/13/rally/common/plugin/plugin.py
11:24 boris-42 yfried: because it's not wrapper
11:25 boris-42 yfried: wrapper means that you are wrapping function by another one
11:25 boris-42 yfried: e..g you return another object function*
11:26 tosky joined #openstack-rally
11:35 MaxPC joined #openstack-rally
11:35 nkhare joined #openstack-rally
11:40 arxcruz joined #openstack-rally
11:40 openstackgerrit Boris Pavlovic proposed openstack/rally: Fix formatting of maintainers section in docs   https://review.openstack.org/189061
11:40 openstackgerrit Boris Pavlovic proposed openstack/rally: Fix formatting of maintainers section in docs   https://review.openstack.org/189061
11:43 aswadr joined #openstack-rally
12:01 jaypipes joined #openstack-rally
12:05 openstackgerrit Boris Pavlovic proposed openstack/rally: Future improvment of plugin base  https://review.openstack.org/160142
12:05 openstackgerrit Boris Pavlovic proposed openstack/rally: Switch to plugin base deployengines and serverproviders  https://review.openstack.org/152612
12:05 openstackgerrit Boris Pavlovic proposed openstack/rally: Switch to plugin base: context, sla, runners  https://review.openstack.org/150647
12:06 boris-42 yfried: andreykurilin redixin ^ let's finish this task?
12:06 openstackgerrit Igor Degtiarov proposed openstack/rally: [Ceilometer] Add  scenario for events and traits  https://review.openstack.org/180514
12:13 georgem1 joined #openstack-rally
12:13 georgem1 joined #openstack-rally
12:14 e0ne joined #openstack-rally
12:14 openstackgerrit Igor Degtiarov proposed openstack/rally: [Ceilometer] Add  scenario for events and traits  https://review.openstack.org/180514
12:25 openstackgerrit Merged openstack/rally: Fix Designate record deletion utility function  https://review.openstack.org/189354
12:28 yfried boris-42: reviewed
12:28 openstackgerrit Nikita Konovalov proposed openstack/rally: Improved wait_for benchmark helper  https://review.openstack.org/172466
12:29 yfried boris-42: re plugin namespace: I understand the code of this, but not the why/how
12:29 yfried boris-42: could you please add this to doc?
12:33 yfried boris-42: https://review.openstack.org/#/c/152612/5/rally/deploy/engine.py,cm "def configure"
12:33 yfried boris-42: why?
12:34 MaxPC joined #openstack-rally
12:42 yfried NikitaKonovalov: https://review.openstack.org/#/c/172466/17..19/rally/benchmark/utils.py,cm
12:42 NikitaKonovalov yfried: hi
12:42 yfried NikitaKonovalov: is this WIP?
12:43 boris-42 yfried: it very important
12:43 NikitaKonovalov yfried: it is not WIP
12:44 yfried boris-42: re namespace - I'm not saying it isn't. just that I don't understand it...
12:44 NikitaKonovalov yfried: that huge diff is due to the rebase I guess
12:45 yfried NikitaKonovalov: I'm asking about pavel's comments. you haven't addressed them yet
12:46 NikitaKonovalov yfried: yes, I've added the checks he asked for
12:48 yfried NikitaKonovalov: sorry. my bad. I missed it. please ignore my nagging
12:48 yfried NikitaKonovalov: +2ed
12:48 NikitaKonovalov yfried: thanks
12:48 yingjun joined #openstack-rally
12:49 openstackgerrit Yair Fried proposed openstack/rally: [Sahara] More debug logging  https://review.openstack.org/170491
12:50 openstackgerrit Kirill Shileev proposed openstack/rally: Configurable timeout feature request  https://review.openstack.org/189691
12:51 openstackgerrit Merged openstack/rally: Feature request improve install script  https://review.openstack.org/185543
12:55 georgem1 joined #openstack-rally
12:55 e0ne joined #openstack-rally
12:57 yfried boris-42: https://review.openstack.org/#/c/189061/6
12:58 stpierre joined #openstack-rally
13:13 philibar joined #openstack-rally
13:14 openstackgerrit Boris Pavlovic proposed openstack/rally: Further improvment of plugin base  https://review.openstack.org/160142
13:14 openstackgerrit Boris Pavlovic proposed openstack/rally: Switch to plugin base deployengines and serverproviders  https://review.openstack.org/152612
13:14 openstackgerrit Boris Pavlovic proposed openstack/rally: Switch to plugin base: context, sla, runners  https://review.openstack.org/150647
13:16 agarciam joined #openstack-rally
13:23 boris-42 yfried: https://review.openstack.org/#/c/152612/
13:28 yfried boris-42: https://review.openstack.org/#/c/160142/14..15/rally/exceptions.py,cm what about these comments?
13:30 boris-42 yfried: uh I forgot to press review button
13:31 boris-42 yfried: done
13:31 yfried boris-42: why get red of notfound?
13:31 yfried boris-42: it's a useful superclass
13:34 boris-42 yfried: okay if you would prefer
13:34 boris-42 yfried: I don't care too much at this point about that
13:35 yfried boris-42: tnx. if you are pushing a new patch, there are some typo
13:35 yfried s
13:35 yfried boris-42: 1sec
13:37 openstackgerrit Boris Pavlovic proposed openstack/rally: Further improvment of plugin base  https://review.openstack.org/160142
13:37 openstackgerrit Boris Pavlovic proposed openstack/rally: Switch to plugin base deployengines and serverproviders  https://review.openstack.org/152612
13:37 openstackgerrit Boris Pavlovic proposed openstack/rally: Switch to plugin base: context, sla, runners  https://review.openstack.org/150647
13:38 boris-42 yfried: ^ too late my friend=)
13:39 yfried boris-42: are you going to fix those typos?
13:39 boris-42 yfried: lemme take a look
13:39 boris-42 yfried: sure
13:39 yfried boris-42: tnx
13:48 boris-42 yfried: https://review.openstack.org/#/c/160142/15/rally/common/plugin/plugin.py
13:48 exploreshaifali joined #openstack-rally
13:48 boris-42 yfried: please write full sentence you are asking me to change back to what I have to change to this one..
13:49 yfried boris-42: Function decorator that adds plugin behavior to function.
13:53 ajiang joined #openstack-rally
13:54 openstackgerrit Boris Pavlovic proposed openstack/rally: Further improvment of plugin base  https://review.openstack.org/160142
13:54 openstackgerrit Boris Pavlovic proposed openstack/rally: Switch to plugin base deployengines and serverproviders  https://review.openstack.org/152612
13:54 openstackgerrit Boris Pavlovic proposed openstack/rally: Switch to plugin base: context, sla, runners  https://review.openstack.org/150647
13:54 kiran-r joined #openstack-rally
13:55 boris-42 yfried: ^ done
13:56 yfried boris-42: LGTM +2
13:57 boris-42 81 online in IRC lol
13:57 boris-42 current record=)
14:13 asrangne joined #openstack-rally
14:30 openstackgerrit Roman Vasilets proposed openstack/rally: Remove deprecated code  https://review.openstack.org/188077
14:31 openstackgerrit Roman Vasilets proposed openstack/rally: Remove deprecated code  https://review.openstack.org/188077
14:45 openstackgerrit Kiran proposed openstack/rally: Add validator to check parameter inside a dictionary argument  https://review.openstack.org/188334
14:48 openstackgerrit Chris St. Pierre proposed openstack/rally: Add Heat scenario to test scaling policies  https://review.openstack.org/178436
14:54 georgem1 boris-42: I'm trying to run the boot-runcommand-delete.json task with a ping_test.sh and I get this error: http://pastebin.com/YePK5eB3
14:55 georgem1 if I run the http://ping_test.sh/ manually it outputs only json
15:01 frayedknot joined #openstack-rally
15:01 stpierre georgem1: does the JSON that it outputs validate against the RESULT_SCHEMA? https://github.com/openstack/rally/blob/master/rally/benchmark/runner.py#L116
15:02 stpierre i think it needs to match the scenario_output portion
15:04 georgem1 stpierre: thanks for reply, I changed the script to echo "{
15:04 georgem1 \"The Ping result is\": $ping_res}" and I'l try again
15:04 stpierre as long as $ping_res is a number that should work
15:05 stpierre i'm guessing the output schema is so restrictive so that SLAs can be applied to the output, but it'd sure be nice to have an alternative to boot_runcommand_delete() that didn't require very narrow JSON output
15:05 boris-42 stpierre: yep
15:14 nihilifer joined #openstack-rally
15:21 philibar left #openstack-rally
15:22 philibar joined #openstack-rally
15:23 e0ne joined #openstack-rally
15:25 boris-42 stpierre: btw it's not on level of benchmark*
15:25 boris-42 stpierre: it's level on scenario runner *
15:25 boris-42 stpierre: and forcing format of output is required by many things
15:25 boris-42 stpierre: including rally task report and rally task detailed commands
15:30 agarciam joined #openstack-rally
15:31 georgem1 stpierre and boris-42: the ping test failed again :( http://pastebin.com/YePK5eB3
15:31 stpierre $ping_res is empty, not a number
15:31 georgem1 the second run starts after the ==============================================================================
15:33 georgem1 stpierre: If I run the script locally the output is: {
15:33 georgem1 "The Ping result is": 0}
15:34 boris-42 georgem1: hm
15:34 boris-42 georgem1: that should work
15:35 boris-42 georgem1: ah no
15:35 boris-42 georgem1: https://github.com/openstack/rally/blob/master/rally/benchmark/runner.py#L129-L142
15:35 boris-42 georgem1:  {"data": {"The ping result is": 0}}
15:35 boris-42 georgem1: should be the output
15:36 stpierre that must be an older version of rally, the ScriptError message was fixed three months ago (425f8031)
15:36 openstackgerrit Andrey Kurilin proposed openstack/rally: Modify GetResourceErrorStatus exception  https://review.openstack.org/189777
15:36 stpierre i'd recommend updating at some point, too
15:36 boris-42 stpierre: this schema is old Like rally=)
15:36 stpierre rally is a very fast-moving target
15:36 boris-42 stpierre: but this schema is very very old=)
15:36 georgem1 boris-42: ok, I'll update, change the output of the script and try again, thanks for help
15:37 stpierre yeah, but a new version of rally would actually report the error instead of silently swallowing it :)
15:37 boris-42 stpierre: =)))
15:37 boris-42 stpierre: btw plugin base is comming!
15:37 boris-42 stpierre: https://review.openstack.org/#/c/160142/
15:38 stpierre i started to look at that, but got as far as metaclasses before i decided to let smarter people than me +2 it
15:40 boris-42 stpierre: +)))
15:41 aix joined #openstack-rally
15:41 boris-42 stpierre: so one base for all plugins will allow us to do magic)
15:42 georgem1 Can I use Rally to check the health of existing environment where I'm only a normal user? I've looked at http://boris-42.me/rally-can-generate-load-with-passed-users-now/ but it still requires admin creds
15:43 boris-42 georgem1: yep
15:43 boris-42 georgem1: I am working on dropping that
15:45 openstackgerrit Andrey Kurilin proposed openstack/rally: Remove 'pyc' files before running tests  https://review.openstack.org/189781
15:46 openstackgerrit Michal Rostecki proposed openstack/rally: Convert Rally to the new Devstack plugin model  https://review.openstack.org/189783
15:49 openstackgerrit Michal Rostecki proposed openstack/rally: Convert Rally to the new Devstack plugin model  https://review.openstack.org/184629
15:59 yfried joined #openstack-rally
16:04 PrashantS joined #openstack-rally
16:05 PrashantS joined #openstack-rally
16:06 kairat_kushaev boris-42: Hello
16:07 kairat_kushaev boris-42: Do you know which folder is current when I am launching heat templates with rally?
16:08 kairat_kushaev boris-42: Is it regarding this patch https://review.openstack.org/#/c/178751/. I tried to use your approach(use ~) and approach that works on my local env (patchset 13) but that doesn't work.
16:09 kairat_kushaev Unfortunately, I succeed with the full path only.
16:10 kairat_kushaev Perhaps you have some ideas about it
16:12 boris-42 kairat_kushaev: I will think about it
16:13 kairat_kushaev Ok
16:21 frayedknot joined #openstack-rally
16:25 openstackgerrit Merged openstack/rally: Further improvment of plugin base  https://review.openstack.org/160142
16:37 suneelb joined #openstack-rally
16:46 stpierre boris-42: do you know of any prior art for the hacking rule you've asked me to write? looking at pep8 plugins, this doesn't seem fun to write at all -- getting the logical line replaces all strings with 'xxxxxx', so i can't check the string itself for multiple %(...)s unless i reconstruct the string myself from physical lines.
16:51 nihilifer joined #openstack-rally
16:54 exploreshaifali joined #openstack-rally
16:54 boris-42 stpierre: hm
16:54 boris-42 stpierre: here are all hacking rules https://github.com/openstack/rally/blob/master/tests/hacking/checks.py
16:55 boris-42 stpierre: that we have in Rally specific
16:57 openstackgerrit Michal Rostecki proposed openstack/rally: Convert Rally to the new Devstack plugin model  https://review.openstack.org/184629
16:57 georgem1 hmm, I have a few questions about the security around rally tasks
16:58 georgem1 It seems that if I use the cirros image it's going to create a security group allowing wide access to the test instance and use ssh key to connect to it, but it doesn't really matter as the cirros has built-in known creds
16:59 boris-42 georgem1: first of all you can use any image that you want*
17:00 boris-42 georgem1: the second thing it's just plugin for Rally (it's not something hardcoded in Rally framework)
17:00 stpierre yeah, i've looked at the hacking rules for a number of projects and can't find anything similar. most rules are either fairly simple regexes (which would work if the pep8 logical line didn't do string replacement, or if i manually rebuilt a logical line myself) or AST parsers, which would just kick the can down the road -- i'd still have to reconstruct the string manually.
17:00 boris-42 georgem1: the third thing is that maybe I am wrong but without secruity group you won't be able to ssh instance?
17:00 georgem1 boris-42: I know, it's just that I was a bit surprised to see the wide open access
17:00 boris-42 stpierre: so why not making regexp check for covering that case?
17:01 boris-42 georgem1: it's only related to VMTask benchmark
17:01 stpierre because of the difficulty of reconstructing the entire string from multiple physical lines
17:01 stpierre but i think that's what i'm going to have to do
17:01 georgem1 boris-42: maybe limit to port 22 then?
17:01 boris-42 georgem1: it's limited no?
17:01 georgem1 right now is: {"remote_group_id": null, "direction": "ingress", "remote_ip_prefix": "0.0.0.0/0", "protocol": "tcp", "tenant_id": "xxx", "port_range_max": 65535, "security_group_id": "xxx", "port_range_min": 1, "ethertype": "IPv4", "id": "xxx"}
17:02 boris-42 georgem1: https://github.com/openstack/rally/blob/master/rally/plugins/openstack/context/secgroup.py#L89
17:02 boris-42 georgem1: so be free to report a bug and restrict it
17:02 jaypipes joined #openstack-rally
17:03 stpierre the 'allow_ssh' context is significantly more than it claims to be :)
17:03 boris-42 georgem1: btw does it make any sense? I mean this is test VM that will be deleted just after test is finished?
17:03 boris-42 georgem1: I mean it doesn't sound for me like something very critical?)
17:03 boris-42 maybe I am wrong..
17:04 georgem1 boris-42: the cleanup can fail and there is a window of vulnerability while anybody who scans the network will discover a cirros instance waiting there
17:05 stpierre if that's a concern, i'd suggest not using cirros
17:05 georgem1 if the instance is ubuntu is more secure as it only allows key-based access by default, but still not a good practice to open the sec group more than necessary
17:05 stpierre as it turns out, automatically determining what is necessary is deeply nontrivial
17:06 stpierre i looked at this briefly, but was quickly overwhelmed by the complexity that variance in network topology can add to the problem. it's by no means as simple as just opening the security group to the IP address(es) of the box running rally.
17:06 georgem1 I limit access to cirros instances to the admin, it's just that you should document what happens during a Rally task so users can asses the implications and choices they make in terms of images used, etc
17:10 boris-42 georgem1: stpierre okay guys
17:10 boris-42 I belive that we should make more strict rules
17:10 boris-42 for allow_ssh
17:10 georgem1 my use case for Rally is to run some simple tasks at regular intervals to deep test the health of the environment, the ping test which should be simple it's not working yet though :(
17:10 boris-42 but this is some kind of low priority bug =)
17:11 boris-42 georgem1: so what now happens?
17:11 georgem1 http://pastebin.com/dekq0kW6
17:12 georgem1 if you run the script you'll see the output generated, which should match rally's needs, but for some reason it's different in the html report's error output
17:13 boris-42 georgem1: so it says clear reason
17:13 boris-42 georgem1: {"data": {"The Ping result is": }}
17:14 boris-42 georgem1: ^ there is no value for "The Ping result is"
17:14 boris-42 seems like your $ping_res
17:14 boris-42 is empty
17:14 georgem1 can one of you please adapt the script so this task completes? I see there is no value, but please try to run the script locally
17:14 boris-42 georgem1: one moment
17:14 akuznetsova joined #openstack-rally
17:15 boris-42 georgem1: so your script is invalid =(
17:15 boris-42 it outputs
17:16 boris-42 what you would like to return exit code?
17:16 boris-42 georgem1: ^
17:18 georgem1 the output of that script should be: {"data": {"The Ping result is": 0}}  with exit status 0
17:19 georgem1 or I can change to ouput: {"data": {"The Ping packet loss to www.google.com is": 0}}
17:19 boris-42 georgem1: so why not using $?
17:19 boris-42 georgem1: for exit code
17:21 georgem1 boris-42: I'm not sure I understand how to use the exit code of the script… if there is packet loss I want that to be captured in the rally task as well, so if I go back to historical reports I can see that
17:21 boris-42 georgem1: ok
17:22 georgem1 how should my ping_test.sh script look like so the rally boot-runcommand-delete scenario pass?
17:23 boris-42 georgem1: as I said
17:23 boris-42 georgem1: your script is returning invalid output
17:23 boris-42 georgem1: {"data": {"The Ping result is": }}
17:23 boris-42 ^ this is what it returns
17:23 boris-42 georgem1: and it should return
17:23 boris-42 {"data": {"The Ping result is": 0}}
17:24 boris-42 ^ that will be valid
17:24 e0ne joined #openstack-rally
17:24 georgem1 ok, but why is returns ^ when running it manually it returns {"data": {"The Ping result is": 0}}
17:24 stpierre it works on my workstation (centos 7, bash 4.2.46) so i'm guessing there's something in the grep that's a newer feature
17:24 boris-42 georgem1: in macos it returns ""
17:25 boris-42 georgem1: seems like grep versions are different
17:25 georgem1 ok, so it is a problem with the grep inside the cirros image
17:25 boris-42 georgem1: so we need to tune grep stuff
17:25 stpierre has anyone actually tested it on cirros?
17:25 boris-42 stpierre: VMTask?
17:25 georgem1 I'll try with a ubuntu image, thanks again
17:25 stpierre your script
17:25 stpierre *the script
17:25 stpierre i've tested vmtask plenty on cirros :)
17:26 boris-42 stpierre: +)
17:26 boris-42 georgem1: so seems like usuing ubuntu is the best choice
17:26 boris-42 georgem1: to avoid some strange issues with old versions of various stuff
17:28 boris-42 georgem1: btw
17:28 georgem1 yeap, cirros doesn't know the -P option for grep
17:28 boris-42 georgem1: in rally we have place for contribution such scripts
17:29 stpierre compiling PCRE into cirros would probably triple the image size
17:29 boris-42 georgem1: https://github.com/openstack/rally/tree/master/samples/tasks/support
17:29 stpierre you could also use sed instead of grep: ping -c 5 -q 8.8.8.8 | sed -n '/packet loss/ { s/.*\?\([[:digit:]]\+\)% packet loss.*/\1/; p}'
17:31 boris-42 stpierre: ^ bash nazi =) at least here I can say that ^_^
17:31 georgem1 thanks stpierre and boris-42, I'm re-runing the scenario using a ubuntu image but I'm fairly confident it will work
17:32 boris-42 georgem1: so VMTaks benchmark is tested in our gates (CI)
17:32 boris-42 georgem1: very well
17:32 boris-42 georgem1: so there shouldn't be any big surprise
17:58 frayedknot joined #openstack-rally
17:59 boris-42 georgem1: so please contribute back your script=)
17:59 boris-42 georgem1: maybe sed version that works in cirros=)
18:02 georgem1 sure
18:13 openstackgerrit Merged openstack/rally: Remove 'pyc' files before running tests  https://review.openstack.org/189781
18:17 openstackgerrit Merged openstack/rally: Switch to plugin base: context, sla, runners  https://review.openstack.org/150647
18:19 amaretskiy joined #openstack-rally
18:25 harlowja joined #openstack-rally
18:26 mwagner_afk joined #openstack-rally
18:34 suneelb1 joined #openstack-rally
18:47 frayedknot joined #openstack-rally
18:48 openstackgerrit joined #openstack-rally
18:51 openstackgerrit Michal Rostecki proposed openstack/rally: Convert Rally to the new Devstack plugin model  https://review.openstack.org/184629
19:16 briandowns joined #openstack-rally
19:37 suneelb joined #openstack-rally
19:39 openstackgerrit Chris St. Pierre proposed openstack/rally: Eliminated string formatting with single mapping key  https://review.openstack.org/189355
19:39 openstackgerrit Chris St. Pierre proposed openstack/rally: Better mocking for self.[admin_]clients in Scenario tests  https://review.openstack.org/188554
19:39 stpierre boris-42: dude, this fucking hacking rule :(
19:39 boris-42 stpierre: ahahaha
19:39 boris-42 stpierre: what happend whole rally is broken?)
19:40 stpierre nah, there were only a dozen or so changes to make. but writing the rule was... very, very interesting.
19:41 openstackgerrit Boris Pavlovic proposed openstack/rally: Switch to plugin base deployengines and serverproviders  https://review.openstack.org/152612
19:42 boris-42 stpierre: =)
19:42 boris-42 stpierre: did you seem my rule that protects us from using ' ?)
19:43 boris-42 stpierre: https://github.com/openstack/rally/blob/master/tests/hacking/checks.py#L288-L337
19:43 stpierre yeah, it's like that.
19:43 boris-42 stpierre: hehe=)
19:43 boris-42 stpierre: what I can say
19:43 boris-42 stpierre: it's the only way if you would like to keep clean project
19:45 boris-42 stpierre: this will fail https://review.openstack.org/#/c/189355/2/rally/cli/commands/deployment.py
19:45 stpierre hah, d'oh
19:47 openstackgerrit Chris St. Pierre proposed openstack/rally: Eliminated string formatting with single mapping key  https://review.openstack.org/189355
19:47 openstackgerrit Chris St. Pierre proposed openstack/rally: Better mocking for self.[admin_]clients in Scenario tests  https://review.openstack.org/188554
19:48 boris-42 stpierre: yep it fails http://paste.openstack.org/show/278676/ =)
19:48 boris-42 stpierre: hehe
20:00 frayedknot joined #openstack-rally
20:05 openstackgerrit OpenStack Proposal Bot proposed openstack/rally: Updated from global requirements  https://review.openstack.org/189463
20:05 boris-42 stpierre: LOL https://review.openstack.org/#/c/189355/3/tests/hacking/checks.py
20:05 stpierre i told you
20:06 boris-42 stpierre: it's my stupid decorator LOL=)
20:07 stpierre hah, didn't realize that was yours. i figure i'll try to submit a follow-up patch to fix it (eventually)
20:07 boris-42 stpierre: it's not hard to fix it, but I had issues by adding *args
20:07 boris-42 stpierre: something at that point didn't work .... don't remember actually
20:08 stpierre yeah, since it requires logical_line it needs to be fairly clever
20:08 boris-42 stpierre: you can add lines/tokens to all hacking methods
20:08 boris-42 stpierre: and pass them through that skip_line...
20:09 boris-42 stpierre: and there is some issue with  %ids
20:09 boris-42 stpierre: it shouldn't pass ..
20:09 stpierre it's passing because '%ids' isn't a valid format string at all, so N353 doesn't apply here, and apparently that line isn't covered by unit tests
20:10 stpierre or rather, it is valid -- it's '%i', followed immediately by the literal 'ds'
20:13 boris-42 stpierre: ya seems like valid %i + ds
20:16 stpierre yeah, but not relevant to N353
20:20 MaxPC joined #openstack-rally
20:24 boris-42 joined #openstack-rally
20:31 openstackgerrit Chris St. Pierre proposed openstack/rally: Eliminated string formatting with single mapping key  https://review.openstack.org/189355
20:31 openstackgerrit Chris St. Pierre proposed openstack/rally: Better mocking for self.[admin_]clients in Scenario tests  https://review.openstack.org/188554
20:51 darkhuy_ joined #openstack-rally
20:56 frayedknot joined #openstack-rally
20:59 briandow_ joined #openstack-rally
21:01 suneelb joined #openstack-rally
21:10 stpierre joined #openstack-rally
21:35 karimb joined #openstack-rally
21:45 mwagner_afk joined #openstack-rally
21:49 georgem1 joined #openstack-rally
21:51 briandowns joined #openstack-rally
21:54 briandowns joined #openstack-rally
22:06 suneelb1 joined #openstack-rally
22:19 davideagnello joined #openstack-rally
22:31 Prashan__ joined #openstack-rally
23:08 briandowns joined #openstack-rally
23:43 harlowja joined #openstack-rally

| Channels | #openstack-rally index | Today | | Search | Google Search | Plain-Text | summary