Perl 6 - the future is here, just unevenly distributed

IRC log for #openstack-rally, 2016-01-28

| Channels | #openstack-rally index | Today | | Search | Google Search | Plain-Text | summary

All times shown according to UTC.

Time Nick Message
00:02 MaxPC joined #openstack-rally
00:49 arnoldje joined #openstack-rally
00:50 openstackgerrit li,chen proposed openstack/rally: Use new-style Python classes  https://review.openstack.org/267266
00:57 chenli joined #openstack-rally
01:00 harshs joined #openstack-rally
01:00 yingjun joined #openstack-rally
01:02 jjmb joined #openstack-rally
01:09 Liuqing joined #openstack-rally
01:14 diogogmt joined #openstack-rally
01:39 baker joined #openstack-rally
01:40 baker_ joined #openstack-rally
02:10 bochi-michael joined #openstack-rally
02:21 baker joined #openstack-rally
02:22 chenli joined #openstack-rally
02:41 e0ne joined #openstack-rally
02:50 e0ne joined #openstack-rally
02:53 openstackgerrit Li Yingjun proposed openstack/rally: Remove the extra 'g' in description for plugin show  https://review.openstack.org/273320
02:54 e0ne_ joined #openstack-rally
03:00 kjorgensen joined #openstack-rally
03:02 kjorgens_ joined #openstack-rally
03:37 psuriset_ joined #openstack-rally
03:50 kjorgensen joined #openstack-rally
04:08 e0ne joined #openstack-rally
04:18 harshs joined #openstack-rally
04:21 Liuqing joined #openstack-rally
05:15 harshs joined #openstack-rally
05:22 baker joined #openstack-rally
05:30 Aish joined #openstack-rally
05:33 Aish left #openstack-rally
06:07 psuriset_ joined #openstack-rally
06:13 tfreger joined #openstack-rally
06:33 baker joined #openstack-rally
07:11 psd joined #openstack-rally
07:13 _lnk_ joined #openstack-rally
07:16 bkopilov joined #openstack-rally
07:16 boris-42 joined #openstack-rally
07:17 baker joined #openstack-rally
07:30 anshul joined #openstack-rally
08:05 arxcruz joined #openstack-rally
08:13 yfried joined #openstack-rally
08:16 neeti joined #openstack-rally
08:17 ikhudoshyn_ joined #openstack-rally
08:24 amaretskiy joined #openstack-rally
08:29 adiantum joined #openstack-rally
08:36 yfried_ joined #openstack-rally
09:01 jaypipes joined #openstack-rally
09:05 baker joined #openstack-rally
09:32 openstackgerrit Sergey Skripnick proposed openstack/rally: Add heat siege workload scenario  https://review.openstack.org/272510
09:36 yfried_ joined #openstack-rally
09:47 shausy joined #openstack-rally
10:00 baker joined #openstack-rally
10:02 jjmb joined #openstack-rally
10:18 rcernin joined #openstack-rally
10:22 sverma joined #openstack-rally
10:25 kjorgensen joined #openstack-rally
10:30 openstackgerrit Sergey Skripnick proposed openstack/rally: Add heat siege workload scenario  https://review.openstack.org/272510
10:31 openstackgerrit Sergey Skripnick proposed openstack/rally: Add heat siege workload scenario  https://review.openstack.org/272510
10:42 aix joined #openstack-rally
10:42 openstackgerrit Sergey Skripnick proposed openstack/rally: Add heat siege workload scenario  https://review.openstack.org/272510
10:47 openstackgerrit Bo Chi proposed openstack/rally: Use dict and set comprehension instead of using dict() and set()  https://review.openstack.org/273449
10:57 openstackgerrit Merged openstack/rally: Remove the extra 'g' in description for plugin show  https://review.openstack.org/273320
10:59 openstackgerrit Merged openstack/rally: Default cinder to v2  https://review.openstack.org/272853
11:01 bkopilov joined #openstack-rally
11:11 yingjun joined #openstack-rally
11:12 tosky joined #openstack-rally
11:14 jaypipes joined #openstack-rally
11:22 openstackgerrit Sergey Skripnick proposed openstack/rally: Add heat siege workload scenario  https://review.openstack.org/272510
11:26 redixin amaretskiy ikhudoshyn please take a look: https://review.openstack.org/#/c/272510/17/rally/plugins/openstack/scenarios/vm/vmtasks.py
11:26 redixin we need to merge this today -_-
11:27 redixin please please
11:27 amaretskiy redixin: ok
11:27 amaretskiy redixin: looking.....
11:27 ikhudoshyn redixin: will do)) gimme couple minutes
11:28 redixin here is results https://rally-ci.tk/logs/_rci_task_FCNBGVlOZW/mos-7.0/rally-plot/report.html#/VMTasks.runcommand_heat/output
11:31 amaretskiy redixin: FYI patch https://review.openstack.org/#/c/272989/
11:31 amaretskiy redixin: mentioned patch fixes overlapping (long) Y-values
11:31 redixin amaretskiy: deal
11:31 amaretskiy redixin: also it makes description field optional
11:32 amaretskiy redixin: and has auto transformation grapth -> table if there is 1 iteration
11:32 amaretskiy redixin: all your requirements are there implemented :)
11:33 ikhudoshyn redixin amaretskiy https://review.openstack.org/#/c/264701/ )))
11:34 amaretskiy ikhudoshyn: i know I know :) will review today!!!
11:34 ikhudoshyn tnx )
11:35 ikhudoshyn redixin amaretskiy https://review.openstack.org/#/c/263759 this one is much easier -- just a docstring
11:40 amaretskiy ikhudoshyn: -1 for https://review.openstack.org/#/c/263759/ but I can re-review this patch immediately when you submit new patch set
11:49 baker joined #openstack-rally
11:50 ikhudoshyn amaretskiy: I guess you are right)) will do smth
11:52 openstackgerrit Illia Khudoshyn proposed openstack/rally: Add note about the fact that Rally won't use testtools' assertions  https://review.openstack.org/263759
11:52 ikhudoshyn amaretskiy: ^^ check this out
12:00 amaretskiy ikhudoshyn: done
12:00 ikhudoshyn tnx
12:06 e0ne joined #openstack-rally
12:17 aix joined #openstack-rally
12:27 e0ne joined #openstack-rally
12:35 akrzos joined #openstack-rally
12:43 baker joined #openstack-rally
13:00 psd joined #openstack-rally
13:17 asti joined #openstack-rally
13:32 Liuqing joined #openstack-rally
13:43 stpierre joined #openstack-rally
13:47 Liuqing joined #openstack-rally
13:50 openstackgerrit Sergey Skripnick proposed openstack/rally: Add heat siege workload scenario  https://review.openstack.org/272510
14:00 MaxPC joined #openstack-rally
14:19 e0ne joined #openstack-rally
14:28 gubouvier joined #openstack-rally
14:32 diogogmt joined #openstack-rally
14:48 openstackgerrit Sergey Skripnick proposed openstack/rally: Add heat siege workload scenario  https://review.openstack.org/272510
14:50 amaretskiy ikhudoshyn ping
14:50 ikhudoshyn amaretskiy: sup
14:51 amaretskiy ikhudoshyn I'm trying to check rally db upgrade
14:51 amaretskiy I recreate db
14:51 ikhudoshyn any issues?
14:51 amaretskiy then change Deployment model (add extra field)
14:52 amaretskiy what should I do more to make a real upgrade to new model?
14:52 boris-42 amaretskiy: you need to generate a migration script
14:53 ikhudoshyn see README: you should make a revision 'alembic --config .... revision' it will try to generate one ^^
14:53 ikhudoshyn recheck that script
14:53 ikhudoshyn so that it makes sense what does
14:53 ikhudoshyn then do rally-manage db upgrade
14:54 amaretskiy looks working
14:54 amaretskiy thanks
14:54 ikhudoshyn welcome
15:01 harshs joined #openstack-rally
15:02 ikhudoshyn andreykurilin boris-42: I'm about to move migrations README.rst to our doc and include it into source/index.rst. Any objections?
15:02 baker joined #openstack-rally
15:07 boris-42 ikhudoshyn: do just symlink
15:20 openstackgerrit Illia Khudoshyn proposed openstack/rally: Integrate Rally & Alembic  https://review.openstack.org/264701
15:21 diogogmt joined #openstack-rally
15:22 dsandler joined #openstack-rally
15:32 arnoldje joined #openstack-rally
15:39 openstackgerrit Illia Khudoshyn proposed openstack/rally: Integrate Rally & Alembic  https://review.openstack.org/264701
15:40 openstackgerrit Roman Vasilets proposed openstack/rally: [WIP]Add Image content upload context  https://review.openstack.org/266531
15:45 baker_ joined #openstack-rally
15:52 dspano joined #openstack-rally
15:53 ylobankov joined #openstack-rally
15:55 dspano joined #openstack-rally
16:02 diogogmt joined #openstack-rally
16:03 baker joined #openstack-rally
16:23 ylobankov joined #openstack-rally
16:43 sudhirverma joined #openstack-rally
16:58 kjorgensen joined #openstack-rally
16:58 kjorgensen joined #openstack-rally
17:05 openstackgerrit Sergey Skripnick proposed openstack/rally: Add heat siege workload scenario  https://review.openstack.org/272510
17:10 openstackgerrit Jordan Pittier proposed openstack/rally: Revert "Use assertTrue/False instead of assertEqual(T/F)"  https://review.openstack.org/273668
17:24 diogogmt joined #openstack-rally
17:31 acruz joined #openstack-rally
17:39 madhu_ak joined #openstack-rally
17:40 asti joined #openstack-rally
17:40 asti left #openstack-rally
18:34 e0ne joined #openstack-rally
18:44 openstackgerrit Kyle Jorgensen proposed openstack/rally: Ensure image['..'] does not throw KeyError  https://review.openstack.org/272865
18:55 pvaneck joined #openstack-rally
18:55 baker joined #openstack-rally
18:56 harshs joined #openstack-rally
19:24 Aish joined #openstack-rally
19:25 yfried_ joined #openstack-rally
19:30 psuriset_ joined #openstack-rally
19:50 josdotso joined #openstack-rally
20:09 yfried_ joined #openstack-rally
20:12 ylobankov joined #openstack-rally
20:59 KimJ joined #openstack-rally
21:22 madhu_ak joined #openstack-rally
21:27 rcernin joined #openstack-rally
22:08 yfried_ joined #openstack-rally
22:10 kjorgensen rvasilets: are you online?
22:37 rvasilets___ joined #openstack-rally
22:37 rvasilets__ joined #openstack-rally
22:38 rvasilets__ kjorgensen: Hi, why you decide to revert changes?)
22:39 kjorgensen Hi, I just added another comment on the review
22:39 kjorgensen Going through the code review process has helped me to fully understand the cause of the bug I am aiming to fix. The main change that is needed is to use the .get() method on 'image' variable to prevent KeyError. The 'or 0' is still needed for when the values are explicitly set to 'None'. I believe this is the simplest solution, without the need for changing the logic in any tests.
22:40 kjorgensen I believe this will pass the CI now, it was failing on my previous patches
22:40 rvasilets__ I have wrote you above changes in tests)
22:41 rvasilets__ You are writing tests to the code)
22:41 rvasilets__ This is strange reason not to change code=)
22:42 kjorgensen It's my first contribution, I was just trying to make a simple fix :)
22:42 rvasilets__ okey
22:42 kjorgensen didn't expect to need to change tests too
22:42 rvasilets__ but you was too close to the best solution)
22:43 rvasilets__ and then turn  back)
22:43 kjorgensen Did you see my comment here? https://review.openstack.org/#/c/272865/3/tests/unit/task/test_validation.py@479
22:44 kjorgensen I wasn't sure if it was best to change that or not? (with the solution you proposed)
22:45 rvasilets__ Yes I saw. I left you the code that you could just copy-paste-)
22:45 rvasilets__ Ok lets imagine 3th patchset
22:45 rvasilets__ the best solution is...
22:46 rvasilets__ https://review.openstack.org/#/c/272865/3/rally/task/validation.py delete line 259
22:47 rvasilets__ and https://review.openstack.org/#/c/272865/3/tests/unit/task/test_validation.py instead line 267 write...
22:47 rvasilets__ self.assertEqual({"image": "image_id", "min_disk": 0,"min_ram": 0, "size": 0}, result[1])
22:47 rvasilets__ thats all)
22:47 rvasilets__ Why the last is needed?
22:48 rvasilets__ because in assertEqual first argument should be expected
22:48 rvasilets__ second - actual
22:49 kjorgensen However on patch 3 I still had a CI failure http://logs.openstack.org/65/272865/3/check/gate-rally-python34/2064e1e/testr_results.html.gz
22:49 rvasilets__ And this would be shown in output of assertEqual in cause of assert
22:50 kjorgensen because of line 478 in test_validation.py it sets it explicitly to None
22:50 rvasilets__ Yes and this should be changed
22:50 rvasilets__ because after you patch
22:50 rvasilets__ 3th
22:51 rvasilets__ it can't be None
22:51 rvasilets__ and this is invalid  testcase
22:51 kjorgensen Ok, what should it be changed to?
22:51 rvasilets__ And you could remove 479-481 lines
22:53 kjorgensen ok, so just remove that validation test?
22:53 rvasilets__ line 479-481
22:55 kjorgensen thanks for the clarification! I will submit "best" patch now :)
22:55 rvasilets__ ok)
22:56 rvasilets__ I'll try to give you my +2 as fast as I can)
22:56 e0ne joined #openstack-rally
23:00 e0ne_ joined #openstack-rally
23:17 openstackgerrit Kyle Jorgensen proposed openstack/rally: Ensure image['..'] does not throw KeyError  https://review.openstack.org/272865
23:21 rvasilets__ kjorgensen: ok, great. you first approve, from me)
23:21 kjorgensen rvasilets__: thank you!
23:26 jjmb joined #openstack-rally
23:40 harshs joined #openstack-rally
23:44 akrzos joined #openstack-rally
23:55 openstackgerrit Merged openstack/rally: Add note about the fact that Rally won't use testtools' assertions  https://review.openstack.org/263759

| Channels | #openstack-rally index | Today | | Search | Google Search | Plain-Text | summary