Perl 6 - the future is here, just unevenly distributed

IRC log for #opentreeoflife, 2015-07-20

| Channels | #opentreeoflife index | Today | | Search | Google Search | Plain-Text | summary

All times shown according to UTC.

Time Nick Message
01:48 ilbot3 joined #opentreeoflife
01:48 Topic for #opentreeoflife is now Open Tree Of Life | opentreeoflife.org | github.com/opentreeoflife | http://irclog.perlgeek.de/opentreeoflife/today
12:34 jimallman joined #opentreeoflife
12:42 kcranstn joined #opentreeoflife
12:54 kcranstn joined #opentreeoflife
13:48 kcranstn joined #opentreeoflife
14:19 kcranstn joined #opentreeoflife
14:36 kcranstn joined #opentreeoflife
14:39 kcranstn jimallman?
14:39 jimallman good morning kcranstn
14:39 kcranstn mornin!
14:39 kcranstn Q about the feedback form
14:39 jimallman shoot
14:41 kcranstn I was looking for a way to add an option to the plugin so that we can control whether the form is by default open vs needing to click a button to open
14:41 kcranstn I assume here somewhere: https://github.com/OpenTreeOfLife/opentree/blob/51a96f3885c5eecc3a14547d6c664a0e714d49b8/webapp/controllers/plugin_localcomments.py
14:42 jimallman yes, taking a look now. i’m sorry to say, the plugin is coded in a funky way (early days in web2py) using its markup generators.
14:42 kcranstn yeah, I see the “adapted from the plugin_comments"
14:43 jimallman here’s the click behavior that normally shows the form: https://github.com/OpenTreeOfLife/opentree/blob/51a96f3885c5eecc3a14547d6c664a0e714d49b8/webapp/controllers/plugin_localcomments.py#L31-L37
14:45 jimallman let’s see if CSS is an easy option…
14:46 jimallman nope, the comment-form markup isn’t in the DOM until click (above) is triggered.
14:46 jimallman kcranstn: is your intention to make the form always-visible?
14:46 kcranstn in some places, for example https://tree.opentreeoflife.org/contact
14:47 kcranstn and we were talking about making it easier in the browser to give feedback
14:47 jimallman ok, so we’ll need to add an option to the plugin (on init, open or closed?)
14:48 kcranstn yup
14:48 kcranstn and may want to modify some of the options (but that is simpler)
14:49 kcranstn I can make an issue to track
14:49 jimallman sounds good. we can add something like {{= plugin_localcomments(filter=(‘url’,), url=request.url, visible=True) }}
14:50 jimallman (final arg is new)
14:50 kcranstn yup
14:50 kcranstn I can take an initial stab at this
14:50 jimallman ok, i’ll be here if you want another pair of eyes.
14:51 jimallman drat, i’m probably hitting the road around noon (helping a friend move today)
14:51 kcranstn np
14:53 kcranstn https://github.com/OpenTreeOfLife/opentree/issues/681
14:58 kcranstn actually, I don’t think that we want the same threaded comment behaviour in all places. It makes sense when you are leaving a comment about a particular node in the tree. It doesn’t make sense on the Feedback page, or for general comments
15:02 jimallman perhaps another option, threaded=False  (True by default?)
15:03 jimallman if False, just omit the Reply widgets and I think we’ll get the desired result (flat series of comments)
15:04 jimallman this might also drop the ‘topic’ vs. ‘comment’ verbiage, by which i meant to distinguish top-level “threads” from replies
15:04 kcranstn do all of the comments go to github *and* get displayed on the website?
15:04 jimallman yes, though threads on the website are initially collapsed (replies hidden) iirc
15:05 kcranstn is there a way to purge the comment when a github issue is resolved?
15:05 jimallman makes sense. i can’t recall if that’s the current behavior, but it seems likely
15:06 kcranstn I wonder if we need to be clearer about “leave a comment on this webpage” vs “send feedback to opentree”
15:06 jimallman confirmed, this API call specifies open issues only
15:06 jimallman https://github.com/OpenTreeOfLife/opentree/blob/51a96f3885c5eecc3a14547d6c664a0e714d49b8/webapp/controllers/plugin_localcomments.py#L693
15:06 kcranstn nice
15:07 kcranstn or that comments *will* be public on this page and on github
15:07 jimallman do you think there’s a “dangerous” potential misunderstanding here?
15:08 kcranstn dangerous is a bit strong
15:08 jimallman i guess that someone might not want their comment to bubble up in a GitHub search..
15:08 jimallman yeah, odd word choice. i mean “regrettable”, i guess.
15:08 kcranstn but I think it is currently unclear whether someone is leaving a comment in the “comments section” of a page, vs sending private feedback to opentree people
15:08 jimallman ah, i see your point.
15:09 jimallman that’s big.
15:09 kcranstn and on some pages, having a comments section seems wierd
15:09 kcranstn i.e. the Contact Us page
15:09 jimallman indeed, and to have these messages show up as GitHub issues.
15:10 jimallman it’s not wrong, exactly, but probably unexpected.
15:12 kcranstn I wonder if we need a way to specify that “this comment is about something on this page” vs “general feedback about the project in general"
15:13 kcranstn the former would show up as comment thread on the page (and get relevent info in the github issue) and the latter would not
15:14 jimallman i anticipated the Contact page gathering general kudos, complaints, etc. about the project
15:15 jimallman otherwise we’ll need to mark some GitHub issues to hide them, or route these comments someplace else entirely
15:16 kcranstn would general feedback ever become a closed issue?
15:16 kcranstn i.e. I expect that comments on a web page are permanent
15:17 jimallman i suppose it would act as a simple form of comment moderation (close issues to hide link spam, obscenity, etc.)
15:18 kcranstn are we committing to the issue list on the feedback repo containing an ever-growing list of issues that will never be closed?
15:19 jimallman perhaps (still one more) option to restrict the feedback types based on the page: …, feedback_types=[(‘General feedback’,’general’),]
15:21 kcranstn I am trying to wrap my head around the distinction between discussion on a web site that would be permanent (i.e. similar to comments on a blog post) vs bug reports / feature requests that get handled and closed
15:21 jimallman re: ever-growing list… in principle, yes, with filters (by label) to focus on just taxonomy, etc.
15:24 jimallman i realize the “open issues” total impliels tons of work to do, so that’s odd. maybe we can alter the logic here, so that general comments will keep showing up even when closed. perhaps an additional label (‘blocked by moderation’?) for comments we want to clobber, or truly delete them from the feedback repo.
15:27 kcranstn or, we could actually put a disqus-style comments plugin on some pages
15:28 kcranstn (just thinking aloud)
15:28 jimallman true
15:34 kcranstn looking at the VertNet pages (they are use GitHub for some feedback). They have a general feedback form: http://www.vertnet.org/feedback/contact.html
15:34 kcranstn which I don’t think goes to github
15:35 kcranstn and a “Submit data issue” button on each data page that does go to GitHub: http://portal.vertnet.org/o/am/herpetology?id=r_100002
15:36 kcranstn I like the highlighting of the data issue button
15:36 jimallman it looks like their feedback form uses a third-party service: http://www.jotform.com/
15:37 kcranstn I’ll keep pondering this
15:37 kcranstn have fun moving your friend!
15:38 jimallman mostly indoor work, happily
15:38 kcranstn not a good day for hauling boxes outside
15:38 jimallman meanwhile, working on single-collection editor! will post some progress (hopefully) tonight
15:38 kcranstn w00t!
17:23 kcranstn joined #opentreeoflife
17:46 jar286 joined #opentreeoflife
18:56 kcranstn joined #opentreeoflife
19:40 kcranstn joined #opentreeoflife
21:34 kcranstn joined #opentreeoflife
21:44 kcranstn joined #opentreeoflife
22:06 kcranstn joined #opentreeoflife

| Channels | #opentreeoflife index | Today | | Search | Google Search | Plain-Text | summary