| Time |
S |
Nick |
Message |
| 00:01 |
|
|
mateu left #padre |
| 00:18 |
|
|
teejay joined #padre |
| 00:46 |
|
|
user_6938 joined #padre |
| 00:52 |
|
user_6938 |
Hello.. |
| 00:54 |
|
jayk |
hi |
| 00:54 |
|
user_6938 |
Quick question: How can I change the colour for a particular font? (Through menu or config file) |
| 00:54 |
|
user_6938 |
(The font used for braces and assignemnts) |
| 00:55 |
|
jayk |
well - you can change the entire style via view->styles... |
| 00:55 |
|
jayk |
but the individual bit of the style, I'm not sure about. |
| 00:55 |
|
jayk |
anybody else? |
| 00:55 |
|
user_6938 |
I like the night style but the assignemnt colour is too dark |
| 00:55 |
|
user_6938 |
(the colour used in = and {} ) |
| 00:56 |
|
user_6938 |
can I change that in particular? |
| 00:57 |
|
Alias |
I've actually been discussing this problem |
| 00:57 |
|
Alias |
Night is badly maintained |
| 00:58 |
|
Alias |
ATM, I'm not entirely sure you can fix it at a user level |
| 00:58 |
|
user_6938 |
The style must be specified in some config? |
| 00:58 |
|
Alias |
It is |
| 00:58 |
|
Alias |
But it's system installed I think |
| 00:58 |
|
user_6938 |
Which one? |
| 00:58 |
|
Alias |
It's not a user-configurable file |
| 00:58 |
|
Alias |
Look for night.yaml |
| 00:58 |
|
Alias |
or Night.yml |
| 00:58 |
|
Alias |
Or something like that |
| 00:58 |
|
user_6938 |
ok thx |
| 00:58 |
|
Alias |
night.yml |
| 00:58 |
|
Alias |
That's the one |
| 00:59 |
|
Alias |
I believe we just picked up a new contributor today who users dark backgrounds |
| 00:59 |
|
jayk |
/usr/local/share/perl/5.10.0/auto/share/dist/Padre/styles is where it is on my machine |
| 00:59 |
|
user_6938 |
./Contents/Resources/perl5/auto/share/dist/Padre/styles/night.yml (OSX) |
| 00:59 |
|
user_6938 |
(In Padre.app) |
| 01:00 |
|
Alias |
For now, just edit that directly as root |
| 01:00 |
|
Alias |
Medium term, we should have a new alternative dark colour scheme (hopefully next release) |
| 01:00 |
|
jayk |
Alias: is it possible to add one's own inside the .padre dir in one's home dir? |
| 01:00 |
|
Alias |
Maybe we can add support for user-defined styles without actually having a whole Preferences thing for it |
| 01:00 |
|
Alias |
jayk: I don't think so |
| 01:01 |
|
Alias |
Might be a good idea to add that though |
| 01:01 |
|
jayk |
it would make things really nice. |
| 01:02 |
|
user_6938 |
Hmm... many display classes defined.. Will need to do some trial and error and will let you know |
| 01:02 |
|
user_6938 |
thanks for the help |
| 01:02 |
|
Alias |
n/p |
| 01:02 |
|
bricas |
...i always thought we had custom styles already. |
| 01:03 |
|
jayk |
Just being able to put them manually into .padre/styles/ or something would be enough I think. |
| 01:03 |
|
bricas |
i'm pretty sure that works now. |
| 01:04 |
|
Alias |
hrm |
| 01:04 |
|
Alias |
It might |
| 01:05 |
|
jayk |
sho nuff. |
| 01:05 |
|
jayk |
Maybe I'll work out how to convert my prefered color scheme over. |
| 01:06 |
|
jayk |
not today, though. I've got works to be doing. |
| 01:07 |
|
jayk |
question - I know there is the ability to save a session... |
| 01:08 |
|
jayk |
but has anyone done a 'project' panel type thing yet? |
| 01:18 |
|
user_6938 |
Can't find the appropriate class and cant spend more time on it now.. will use another profiel for now... thanks for the help |
| 01:19 |
|
Alias |
We already have one |
| 01:19 |
|
Alias |
That's what the directory is |
| 01:19 |
|
Alias |
Shows the "Implicit Project" structure |
| 01:50 |
|
|
beggars joined #padre |
| 01:53 |
|
beggars |
hi, after installing the .msi standalone, seems perldoc is broken, any help? http://fpaste.org/Zpbe/ |
| 02:35 |
|
Alias |
0.50 |
| 02:35 |
|
Alias |
? |
| 02:36 |
|
Alias |
Interesting |
| 02:36 |
|
Alias |
Does your XP actually have a cmd.exe? |
| 03:10 |
|
|
cognominal_ joined #padre |
| 03:41 |
|
szabgab |
gm |
| 03:41 |
|
szabgab |
Alias, so how was your talk? |
| 03:44 |
|
Hyppolit |
svn: r9305 | szabgab++ | http://padre.perlide.org/trac/changeset/9305 |
| 03:44 |
|
Hyppolit |
blog by Alias |
| 03:44 |
|
Hyppolit |
trunk/template.padre.perlide.org/data/ |
| 04:56 |
|
|
patspam joined #padre |
| 04:58 |
|
bje |
alias, what should I do to get the Mac OS X build available for others? |
| 05:00 |
|
|
holli joined #padre |
| 05:02 |
|
holli |
hi, is adamk around? what's his irc name? |
| 05:05 |
|
holli |
anyway, i extended Padre::Plugin::JavaScript a bit and added a Syntax-Checker (http://nopaste.info/10dcee6edb.html) |
| 05:06 |
|
holli |
saves quite some time when you don't have to load it in your browser to find out if the syntax is correct. |
| 05:16 |
|
Alias |
szabgab: I got good reviews, although I wasn't happy entirely with it |
| 05:16 |
|
Alias |
holli <--- ADAMK |
| 05:16 |
|
Alias |
bje: The Mac build has already been posted on my journal |
| 05:16 |
|
|
mikegrb joined #padre |
| 05:16 |
|
Alias |
We just need to change the website download page to point to it |
| 05:16 |
|
mikegrb |
Hi, I just wanted to say holy shit you guys are rocking |
| 05:16 |
|
Alias |
szabgab: I think I have some fairly decent slides for stealing by others though |
| 05:16 |
|
Alias |
mikegrb: Thanks :) |
| 05:17 |
|
mikegrb |
every time I check out padre, it's made amazing progress since last time |
| 05:17 |
|
mikegrb |
I think I'm gonna try using padre for real work vs playing at work for the week |
| 05:17 |
|
holli |
yeah, looks like herbert get more and more behind |
| 05:17 |
|
holli |
s/get/gets/ |
| 05:18 |
|
Alias |
holli: He will keep doing his thing, there's nothing wrong with that |
| 05:19 |
|
Alias |
holli: If nothing else, it prevents us from becoming complacent, and it provides a place for alternative solutions to be tried out (so we can steal them) |
| 05:19 |
|
Alias |
It was more of a sensitive subject in the early days, but I think we've reached the point where it's no longer an issue |
| 05:20 |
|
holli |
well then, i am too lazy to do something official about my tweaks to P:P:JavaScript and give them in your trustful hands |
| 05:21 |
|
Alias |
hrm? |
| 05:21 |
|
Alias |
You have commit? |
| 05:21 |
|
holli |
see above |
| 05:22 |
|
Alias |
I see you did some stuff to it |
| 05:22 |
|
Alias |
Did you commit the improvements? |
| 05:22 |
|
holli |
no i have no commit bit |
| 05:22 |
|
Alias |
Lets fix that |
| 05:22 |
|
beggars |
http://fpaste.org/DUNz/ any tips on this, this .50 standalone/msi and I cmd.exe exist on c:\windows\system32 |
| 05:23 |
|
holli |
beggars: what does "echo $PATH" say? |
| 05:23 |
|
Alias |
hrm |
| 05:23 |
|
Alias |
I wonder how you enable anonymous rego |
| 05:24 |
|
Alias |
How about I just make the account |
| 05:24 |
|
Alias |
username holli? |
| 05:24 |
|
mikegrb |
by the way, tried the padre stand alone on mac this time and everything went smooth |
| 05:24 |
|
holli |
k |
| 05:24 |
|
beggars |
holli: nothing the |
| 05:24 |
|
Alias |
holli: Name and email? |
| 05:24 |
|
beggars |
holli: this is windows btw |
| 05:24 |
|
holli |
Alaska Saedelere, alaska,saedelaere googlemail.com |
| 05:24 |
|
mikegrb |
Padre::Plugin::Git in cpan uses module::install but doesn't have inc/ needful |
| 05:25 |
|
holli |
i know beggars |
| 05:25 |
|
Alias |
That's a comma in your email? |
| 05:25 |
|
holli |
typo |
| 05:25 |
|
holli |
should have been . |
| 05:26 |
|
Alias |
Account added |
| 05:26 |
|
holli |
beggars: sorry, try "echo %PATH" |
| 05:26 |
|
Alias |
password is the username, log in and change it |
| 05:26 |
|
Alias |
mikegrb: Thanks for the report |
| 05:26 |
|
Alias |
Glad to hear SOMEONE has it working |
| 05:27 |
|
beggars |
holli: will just echo %PATH |
| 05:27 |
|
beggars |
holli: I just on environment variables settings under my computer properties |
| 05:28 |
|
holli |
good. is the windows directory in PATH? |
| 05:28 |
|
holli |
or better the path to cmd.exe? |
| 05:29 |
|
Hyppolit |
svn: r9306 | garu++ | http://padre.perlide.org/trac/changeset/9306 |
| 05:29 |
|
Hyppolit |
s/menu_plugins_simple/menu_plugins/ |
| 05:29 |
|
Hyppolit |
trunk/Padre-Plugin-Catalyst/ trunk/Padre-Plugin-Catalyst/lib/Padre/Plugin/ |
| 05:29 |
|
beggars |
holli: yes, this is present %SystemRoot%\system32 |
| 05:31 |
|
Hyppolit |
svn: r9307 | garu++ | http://padre.perlide.org/trac/changeset/9307 |
| 05:31 |
|
Hyppolit |
"start server" and "stop server" menu options now enable/disable each other |
| 05:31 |
|
Hyppolit |
trunk/Padre-Plugin-Catalyst/ trunk/Padre-Plugin-Catalyst/lib/Padre/Plugin/Catalyst/ |
| 05:31 |
|
holli |
then i'm out of ideas. maybe you look into the code where there error is and see what's going wrong. |
| 05:31 |
|
beggars |
holli: thank you,I appreciate your effort |
| 05:32 |
|
holli |
Alias: Seems I'm too dumb to find the repository url |
| 05:35 |
|
Hyppolit |
svn: r9308 | garu++ | http://padre.perlide.org/trac/changeset/9308 |
| 05:35 |
|
Hyppolit |
$VERSION++ |
| 05:35 |
|
Hyppolit |
trunk/Padre-Plugin-Catalyst/lib/Padre/Plugin/ trunk/Padre-Plugin-Catalyst/lib/Padre/Plugin/Catalyst/ |
| 05:35 |
|
alaska |
a never mind |
| 05:36 |
|
Hyppolit |
svn: r9309 | garu++ | http://padre.perlide.org/trac/changeset/9309 |
| 05:36 |
|
Hyppolit |
one less TODO thing to do. Yay! |
| 05:36 |
|
Hyppolit |
trunk/Padre-Plugin-Catalyst/ |
| 05:38 |
|
Alias |
holli: http://svn.perlide.org/padre/trunk |
| 05:43 |
|
garu |
who is Sebastian Willing? |
| 05:47 |
|
Hyppolit |
svn: r9310 | garu++ | http://padre.perlide.org/trac/changeset/9310 |
| 05:47 |
|
Hyppolit |
crediting unsung translators (charsbar++ sebastian_willing++) |
| 05:47 |
|
Hyppolit |
trunk/Padre-Plugin-Catalyst/ trunk/Padre-Plugin-Catalyst/lib/Padre/Plugin/ |
| 05:56 |
|
alaska |
Alias: I tried to commit using the credentials you gave me but i get a 403 |
| 05:56 |
|
alaska |
do i have to create a branch? |
| 06:01 |
|
Hyppolit |
svn: r9311 | adamk++ | http://padre.perlide.org/trac/changeset/9311 |
| 06:01 |
|
Hyppolit |
The Separator should have been in the Style sub-menu |
| 06:01 |
|
Hyppolit |
trunk/Padre/lib/Padre/Wx/Menu/ |
| 06:01 |
|
Alias |
garu: Sewi |
| 06:01 |
|
Alias |
alaska: No |
| 06:02 |
|
Alias |
alaska: We give everyone permissions to everything |
| 06:02 |
|
alaska |
neither svn commit nor that svn cp command in the faq works |
| 06:03 |
|
garu |
Alias, makes a lot of sense, yeah :) |
| 06:04 |
|
garu |
well, new version of Catalyst Plugin released, 4 am on a monday... gotta go |
| 06:04 |
|
garu |
g'night everyone |
| 06:04 |
|
garu |
& |
| 06:04 |
|
Hyppolit |
svn: r9312 | adamk++ | http://padre.perlide.org/trac/changeset/9312 |
| 06:04 |
|
Hyppolit |
Trimmed whitespace in the Changes file |
| 06:04 |
|
Hyppolit |
trunk/Padre/ |
| 06:05 |
|
Alias |
eep, weird |
| 06:05 |
|
alaska |
it asks for password and then 403's |
| 06:07 |
|
alaska |
complete: Der Server hat einen unerwarteten Rückgabewert (403 Forbidden) in Antwort auf die Anfrage MKACTIVITY für »/padre/!svn/act/75025f41-cbfe-4d95-8f31-04bd33f8edd7« zurückgeliefert |
| 06:09 |
|
szabgab |
what credentials ? |
| 06:09 |
|
szabgab |
am I out of the loop ? |
| 06:09 |
|
alaska |
Alias was so kind to create an account for me |
| 06:13 |
|
Alias |
szabgab: How do you enable registration? |
| 06:13 |
|
Alias |
I just added it server side |
| 06:16 |
|
szabgab |
Alias, http://padre.perlide.org/trac/wiki/PadreTracAdmin |
| 06:17 |
|
szabgab |
trac registration does not automatically give commit bit |
| 06:21 |
|
szabgab |
my suggestion was that we should ask the contributors to first send a few patches by opening a ticket and then attaching the patch to it |
| 06:22 |
|
szabgab |
and only then to give them commit bit |
| 06:25 |
|
alaska |
szabgab: first you know me from perlmonks and second the code in quiestion is posted above |
| 06:25 |
|
alaska |
(http://nopaste.info/10dcee6edb.html) |
| 06:26 |
|
szabgab |
alaska, sure I know you and I am trying to be offensive, sorry if it sounded like that |
| 06:27 |
|
alaska |
no offense taken, but i would like to commit this now. |
| 06:28 |
|
szabgab |
"I am NOT trying to be offensive" - if I knew how to type :-) |
| 06:28 |
|
|
Sewi joined #padre |
| 06:28 |
|
Sewi |
good morning |
| 06:28 |
|
szabgab |
alaska, could you please create a patch out of that ? |
| 06:28 |
|
szabgab |
Sewi, gm |
| 06:31 |
|
alaska |
ready, what to do with it? |
| 06:33 |
|
szabgab |
open a ticket and attach to it please |
| 06:34 |
|
alaska |
ok. mmh, the original file had mixed tab and spaced indentation |
| 06:35 |
|
alaska |
is there a project standard? |
| 06:35 |
|
Sewi |
alaska: Don't change this, there is a tidy script which process the whole Padre source. If you change it, your Patch will become really large |
| 06:36 |
|
Sewi |
and your real change would be lost (from a visible point of view) |
| 06:36 |
|
Alias |
Sewi: We really need to get the project-RC tidy stuff working |
| 06:37 |
|
Sewi |
Alias: It is working, but PerlTidy needs to get command line options from the config... |
| 06:53 |
|
Hyppolit |
svn: r9313 | szabgab++ | http://padre.perlide.org/trac/changeset/9313 |
| 06:53 |
|
Hyppolit |
[XL] add padre.sh |
| 06:53 |
|
Hyppolit |
trunk/Perl-Dist-XL/share/files/ |
| 06:54 |
|
|
kaare joined #padre |
| 06:54 |
|
Hyppolit |
svn: r9314 | szabgab++ | http://padre.perlide.org/trac/changeset/9314 |
| 06:54 |
|
Hyppolit |
[XL] remove old cpan configuration files |
| 06:54 |
|
Hyppolit |
trunk/Perl-Dist-XL/share/files/ |
| 07:07 |
|
szabgab |
alaska, I added the commit bit for you, please try to commit the changes to the JavaScript plugin |
| 07:08 |
|
szabgab |
and feel free to change that plugin to your liking |
| 07:08 |
|
szabgab |
but when you start patching the core of padre, please discuss it on the channel first |
| 07:10 |
|
|
mohsen joined #padre |
| 07:13 |
|
Hyppolit |
svn: r9315 | szabgab++ | http://padre.perlide.org/trac/changeset/9315 |
| 07:13 |
|
Hyppolit |
fix stupid test failure |
| 07:13 |
|
Hyppolit |
trunk/Padre/lib/Padre/Wx/Dialog/Preferences/ |
| 07:14 |
|
Sewi |
szabgab: Which test failed on this? |
| 07:14 |
|
szabgab |
12-pragma |
| 07:15 |
|
szabgab |
and we also have a failure in 04 |
| 07:15 |
|
Hyppolit |
svn: r9316 | adamk++ | http://padre.perlide.org/trac/changeset/9316 |
| 07:15 |
|
Hyppolit |
Stop committing config entries without updating the config test script |
| 07:15 |
|
Hyppolit |
trunk/Padre/t/ |
| 07:15 |
|
Alias |
szabgab: not any more |
| 07:15 |
|
* Alias |
wonders if timeouts should be in _HUMAN |
| 07:15 |
|
Alias |
Wouldn't timeout preferences usually be a bit more network-geometry related? |
| 07:16 |
|
szabgab |
I was not sure that this was the problem |
| 07:16 |
|
szabgab |
Maybe we should have a capital punishment for people who break the test suite |
| 07:17 |
|
Alias |
I think that is an excellent criteria |
| 07:17 |
|
Alias |
Although, since the goal is to get more tests... |
| 07:17 |
|
* Sewi |
hides |
| 07:17 |
|
szabgab |
and we should setup the freakin buildbot |
| 07:17 |
|
Alias |
yup |
| 07:17 |
|
szabgab |
an push the results to the public smolder - we have an account there |
| 07:17 |
|
Alias |
Sewi: szabgab and I have been discussing way to reduce the number of regressions without locking down access |
| 07:18 |
|
szabgab |
Sewi, I broke the test suite several times already - so it is not personal :-) |
| 07:18 |
|
Alias |
I was floating the idea of "If you break a feature, you have are forced to write a test script for that feature" |
| 07:19 |
|
Alias |
"(even if it's a really really hard one to test)" |
| 07:19 |
|
Sewi |
Alias: make tests runs for minutes here (Ubuntu) and even longer on Win. This is good, because it means we have many tests, but it's bad because it limits the number of tests being run. |
| 07:19 |
|
szabgab |
http://smolder.plusthree.com/a[…]/smoke_reports/11 |
| 07:20 |
|
Alias |
Sewi: Yeah, I don't think putting in commit hooks or some other really nasty blocking things is a good idea |
| 07:20 |
|
Alias |
I'd want to keep things as friendly and engaging as possible |
| 07:20 |
|
Sewi |
Sure. |
| 07:20 |
|
Sewi |
I don't need to run tests on commit of "messages.pot" or "Changes" :-) |
| 07:21 |
|
Alias |
If you get caught, you have to write more tests |
| 07:21 |
|
Alias |
or something |
| 07:21 |
|
Alias |
So every time you commit, you have to calculate the risk yourself :) |
| 07:21 |
|
Sewi |
What about sorting the tests? Some of them are really source-related, others are installation-related. Why should badcode.t run during cpan installation? |
| 07:21 |
|
Alias |
badcode runs during installation? |
| 07:21 |
|
Alias |
Oops |
| 07:21 |
|
Sewi |
I guess, yes, like some others. |
| 07:22 |
|
Alias |
oh dear |
| 07:22 |
|
Sewi |
Pragmas is also not needed at all (during cpan). |
| 07:22 |
|
Alias |
So yeah, we probably do need to sort the tests a bit better |
| 07:22 |
|
Alias |
But then again, you can't just put it into xt |
| 07:22 |
|
Alias |
We need some way to detect svn |
| 07:23 |
|
Sewi |
I added a ENV check for 94 :-) |
| 07:23 |
|
Alias |
if ( -d '.svn' ) { # Run the extended checks } |
| 07:23 |
|
Sewi |
There is a function for this in Padre::Util or Padre::Constant, I think. |
| 07:23 |
|
Alias |
hrm |
| 07:23 |
|
Alias |
M:I has it already |
| 07:23 |
|
Alias |
if ( author ) { ... } |
| 07:24 |
|
Alias |
Our problem with xt atm is it runs stuff like critic |
| 07:24 |
|
Alias |
hrm |
| 07:24 |
|
Alias |
Let me try something |
| 07:25 |
|
Sewi |
File/FTP.pm fails compilation test here in Class::XSAccessor: Reference found where even-sized liste expected, but the use XS looks good to me (a person who doesn't really understood XS usage at all). |
| 07:27 |
|
Hyppolit |
svn: r9317 | adamk++ | http://padre.perlide.org/trac/changeset/9317 |
| 07:27 |
|
Hyppolit |
ALL authors now run xt by default |
| 07:27 |
|
Hyppolit |
trunk/Padre/ |
| 07:28 |
|
Alias |
If this works, we can move badcode etc into xt |
| 07:28 |
|
Sewi |
How to run the author tests? |
| 07:28 |
|
Alias |
Standalone? |
| 07:29 |
|
Alias |
prove -Mblib -r xt |
| 07:29 |
|
Sewi |
ok |
| 07:29 |
|
Sewi |
What about a make authortest or make testall? |
| 07:29 |
|
Alias |
But I've made them run always in M:I author_context or $ENV{RELEASE_TESTING} |
| 07:29 |
|
Alias |
Because them nobody will run them |
| 07:30 |
|
Alias |
FAR better to run more tests with default "make test" |
| 07:30 |
|
Alias |
And then maybe alternative make quicktest |
| 07:30 |
|
Alias |
For more experienced people |
| 07:30 |
|
Sewi |
but this will include these tests in cpan installations, doesn't it? |
| 07:30 |
|
Alias |
no |
| 07:31 |
|
Sewi |
ok |
| 07:31 |
|
Alias |
author_context returns false during end-user installation |
| 07:31 |
|
Alias |
RELEASE_TESTING too |
| 07:32 |
|
Sewi |
Ignore the last test failure report, someone changes XSAccessor requirement to 1.05 - I have 1.03 |
| 07:32 |
|
Hyppolit |
svn: r9318 | adamk++ | http://padre.perlide.org/trac/changeset/9318 |
| 07:32 |
|
Hyppolit |
Include xt during AUTOMATED_TESTING as well |
| 07:32 |
|
Hyppolit |
trunk/Padre/ |
| 07:34 |
|
Alias |
OK, so which tests do we NOT want end-users running |
| 07:34 |
|
Sewi |
badcode, pragma |
| 07:34 |
|
Alias |
copyright? |
| 07:35 |
|
Sewi |
sure, add config, maybe eol |
| 07:36 |
|
Sewi |
Oh, and badcode's brother "75-perl-beginner". |
| 07:36 |
|
Alias |
config needs to stay |
| 07:36 |
|
Alias |
eol maybe |
| 07:36 |
|
Hyppolit |
svn: r9319 | adamk++ | http://padre.perlide.org/trac/changeset/9319 |
| 07:36 |
|
Hyppolit |
Reorganising tests, commit 1 |
| 07:36 |
|
Hyppolit |
trunk/Padre/t/ trunk/Padre/xt/ |
| 07:37 |
|
Sewi |
I'm unsure about 94, the padre-file-network tests |
| 07:37 |
|
Hyppolit |
svn: r9320 | adamk++ | http://padre.perlide.org/trac/changeset/9320 |
| 07:37 |
|
Hyppolit |
Reorganising tests, commit 2 |
| 07:37 |
|
Hyppolit |
trunk/Padre/t/ trunk/Padre/xt/ |
| 07:38 |
|
Alias |
Functionality stays, just cosmetic stuff moves |
| 07:38 |
|
Sewi |
ok |
| 07:39 |
|
Hyppolit |
svn: r9321 | adamk++ | http://padre.perlide.org/trac/changeset/9321 |
| 07:39 |
|
Hyppolit |
Reorganising tests, commit 3 |
| 07:39 |
|
Hyppolit |
trunk/Padre/xt/ |
| 07:39 |
|
Alias |
Flakey subsets can go into subdirectories, like t/win32 |
| 07:39 |
|
Alias |
Or you just do per-file skips |
| 07:39 |
|
Alias |
So, for example, all the numbered ones in xt always run |
| 07:39 |
|
Alias |
But the standard ones like critic etc only run during RELEASE_TESTING still |
| 07:40 |
|
Alias |
maybe "make t" |
| 07:40 |
|
Alias |
For the shortcutting one that only runs the functionality tests |
| 07:44 |
|
Alias |
Do the win32 tests pass for anyone any more? |
| 07:44 |
|
Alias |
They don't for me |
| 07:45 |
|
Alias |
OK, I'm heading home |
| 07:46 |
|
Alias |
... to hack on wxGlade plugin etc etc |
| 07:53 |
|
Hyppolit |
svn: r9322 | adamk++ | http://padre.perlide.org/trac/changeset/9322 |
| 07:53 |
|
Hyppolit |
Noting the xt usage |
| 07:53 |
|
Hyppolit |
trunk/Padre/ |
| 07:55 |
|
Hyppolit |
#775: Patch: Add Syntax Check to Padre::Plugin::JavaScript (new enhancement) [ http://padre.perlide.org/trac/ticket/775 ] |
| 07:57 |
|
Hyppolit |
svn: r9323 | szabgab++ | http://padre.perlide.org/trac/changeset/9323 |
| 07:57 |
|
Hyppolit |
add script to generate smoke reports |
| 07:57 |
|
Hyppolit |
trunk/tools/ |
| 07:58 |
|
alaska |
Alias, szasgab: ticket created (#775) |
| 07:58 |
|
Hyppolit |
#775: Patch: Add Syntax Check to Padre::Plugin::JavaScript (new enhancement) [ http://padre.perlide.org/trac/ticket/775 ] |
| 07:58 |
|
alaska |
cool |
| 07:58 |
|
Sewi |
congrats |
| 07:59 |
|
Sewi |
You should now "accept" it - otherwise someone else might start working on it while you're doing the same |
| 07:59 |
|
szabgab |
alaska, in the meantime Alias convinced me that it is better to give out commit bits and then punish people who break padre by making them write unit tests |
| 07:59 |
|
szabgab |
so you have your commit bit for use holli |
| 08:00 |
|
szabgab |
so you are welcome among the Padre committers ! |
| 08:01 |
|
Hyppolit |
svn: r9324 | holli++ | http://padre.perlide.org/trac/changeset/9324 |
| 08:01 |
|
Hyppolit |
Added Syntax Check |
| 08:01 |
|
Hyppolit |
trunk/Padre-Plugin-JavaScript/ trunk/Padre-Plugin-JavaScript/lib/Padre/Plugin/ |
| 08:02 |
|
Hyppolit |
svn: r9325 | szabgab++ | http://padre.perlide.org/trac/changeset/9325 |
| 08:02 |
|
Hyppolit |
add xt/ to smoke testing |
| 08:02 |
|
Hyppolit |
trunk/tools/ |
| 08:03 |
|
szabgab |
karma holli |
| 08:03 |
|
Hyppolit |
Karma of holli is 1 |
| 08:03 |
|
szabgab |
holli+ |
| 08:03 |
|
szabgab |
holli++ |
| 08:04 |
|
szabgab |
alaska, what I really would like to see is context sensitive help for Javascript - the same way as we have it for perl5-6 and PIR |
| 08:04 |
|
szabgab |
and for CSS :-) |
| 08:08 |
|
|
pece joined #padre |
| 08:09 |
|
Sewi |
szabgab: make test runs >5 min. here. :-( |
| 08:10 |
|
Hyppolit |
svn: r9326 | Sewi++ | http://padre.perlide.org/trac/changeset/9326 |
| 08:10 |
|
Hyppolit |
Add to action queue from command line |
| 08:10 |
|
Hyppolit |
trunk/Padre/lib/ trunk/Padre/script/ |
| 08:12 |
|
Hyppolit |
svn: r9327 | Sewi++ | http://padre.perlide.org/trac/changeset/9327 |
| 08:12 |
|
Hyppolit |
Added padre_dump action |
| 08:12 |
|
Hyppolit |
trunk/Padre/lib/Padre/ trunk/Padre/lib/Padre/Action/ |
| 08:12 |
|
szabgab |
Sewi, buy a faster computer :-) |
| 08:13 |
|
Sewi |
Besides make test, I'm happy with my netbook :-) |
| 08:14 |
|
Sewi |
I'm planning to set up a OpenVZ VE somewhere to run the tests, but I don't see this 2009 |
| 08:16 |
|
|
marcela joined #padre |
| 08:17 |
|
szabgab |
marcela, hi! |
| 08:17 |
|
marcela |
morning |
| 08:20 |
|
alaska |
ok, i've commited it. |
| 08:21 |
|
szabgab |
alaska, yes, we saw that above :-) |
| 08:22 |
|
szabgab |
I setup now a cron job that runs the test suite of padre and pushes the results out to http://smolder.plusthree.com/a[…]r_graphs/start/11 |
| 08:22 |
|
szabgab |
but being a cronjob it does not have a DISPLAY so it skips most of the tests |
| 08:23 |
|
szabgab |
I have to go to work now but this should be fixed somehow |
| 08:42 |
|
Hyppolit |
svn: r9328 | Sewi++ | http://padre.perlide.org/trac/changeset/9328 |
| 08:42 |
|
Hyppolit |
HOME_DIR using Padre::Constant |
| 08:42 |
|
Hyppolit |
trunk/Padre/lib/Padre/ |
| 08:42 |
|
Hyppolit |
svn: r9329 | Sewi++ | http://padre.perlide.org/trac/changeset/9329 |
| 08:42 |
|
Hyppolit |
Dump to file is more easy to use |
| 08:42 |
|
Hyppolit |
trunk/Padre/lib/Padre/Action/ |
| 08:51 |
|
|
rindolf joined #padre |
| 08:55 |
|
|
rindolf left #padre |
| 09:23 |
|
|
szabgab_mib joined #padre |
| 09:23 |
|
Sewi |
Hi szabgab_mib |
| 09:24 |
|
szabgab_mib |
rehi :-)\ |
| 11:11 |
|
Hyppolit |
#775: Patch: Add Syntax Check to Padre::Plugin::JavaScript (closed enhancement) [ http://padre.perlide.org/trac/[…]ket/775#comment:1 ] |
| 11:20 |
|
|
daxim joined #padre |
| 11:55 |
|
|
tsee joined #padre |
| 12:15 |
|
|
patspam joined #padre |
| 12:25 |
|
|
siegfri3d joined #padre |
| 13:02 |
|
Hyppolit |
svn: r9330 | Sewi++ | http://padre.perlide.org/trac/changeset/9330 |
| 13:02 |
|
Hyppolit |
Make Padre dump runnable |
| 13:02 |
|
Hyppolit |
trunk/Padre/lib/Padre/Action/ |
| 13:03 |
|
tsee |
I've done some CPAN research on virtual file systems, prompted by daxim's criticism a few days ago. |
| 13:03 |
|
szabgab_mib |
Sewi: could you try to write a test that demonstrates the bug that the view checkboxes don't get ticked after opening padre again? |
| 13:03 |
|
tsee |
Has anybody else done something similar? |
| 13:03 |
|
Sewi |
szabgab_mib: I'll try to get the time for it later, currently writing another test... |
| 13:03 |
|
tsee |
It seems most implementations aren't exactly... great. |
| 13:04 |
|
tsee |
If we want to reuse existing modules, http://search.cpan.org/~hanenk[…]File-System-1.16/ seems the best bet. |
| 13:04 |
|
tsee |
Though it doesn't run under win32 (yet). |
| 13:04 |
|
tsee |
And it doesn't do protocol:// => type mapping |
| 13:04 |
|
Sewi |
tsee: Padre::File is build exactly for Padre, it should fit :-) We may want to add a Padre::File::VFS* instead of replacing it... |
| 13:05 |
|
Sewi |
tsee++; # for writing Data::Dumper |
| 13:05 |
|
tsee |
I didn't write that! |
| 13:05 |
|
tsee |
I just picked it up for core<->cpan sync |
| 13:05 |
|
tsee |
Umm. Refactoring Padre::File rather than replacing. |
| 13:05 |
|
tsee |
Essentially, it *is* a sort of VFS implementation albeit a limited one. |
| 13:06 |
|
tsee |
(i.e. with a proper VFS, you could have the directory browser work for remote stuff, too) |
| 13:06 |
|
tsee |
Sewi, you wrote the existing Padre::File, right? |
| 13:06 |
|
Sewi |
tsee: This is one of my next topics :-) I'm currently working on a project on a remote FTP server and really need the browsing. |
| 13:06 |
|
Sewi |
Not having it yet made me using SSH and mcedit :-( |
| 13:06 |
|
tsee |
Then I'd suggest you give File::System a whirl. |
| 13:07 |
|
tsee |
Because I have a hunch that refactoring now may be much more manageable than in a few months. |
| 13:07 |
|
tsee |
Regarding your using mcedit over ssh: Too bad I didn't have the time and SSH fu to finish the SSH plugin. |
| 13:08 |
|
tsee |
Anyhow. I'm not trying to tell you what you need to do. Just advising. |
| 13:08 |
|
tsee |
daxim, ping? |
| 13:08 |
|
daxim |
I'm here |
| 13:08 |
|
Sewi |
tsee: I need to create/update templates which means working with many files. This doesn't work without browsing. |
| 13:09 |
|
tsee |
daxim, since you boldly claimed we should be reusing an existing, portable vfs implementation, do you have any idea what that portable vfs implementation could be? |
| 13:09 |
|
tsee |
I looked at GIO (gnome), but that's hardly portable. |
| 13:09 |
|
daxim |
KIO, but this needs perl bindings |
| 13:11 |
|
tsee |
daxim, is that a KDE library? |
| 13:11 |
|
tsee |
Seems like it is. Portable? |
| 13:12 |
|
tsee |
I know KDE runs on win32, in principle, nowadays, but requiring a KDE install on any computer that runs Padre... |
| 13:14 |
|
|
mohsen joined #padre |
| 13:16 |
|
tsee |
daxim, if I get this right, our only bet for using KIO would be if a) it's a standalone library within KDE and can be compiled separately, b) we can create an XS perl module that includes its own copy of libkio sources and does the perl bindings (a la DBD::SQLite). |
| 13:17 |
|
tsee |
Unfortunately, our downstream packagers won't like that, but IMO, that's a secondary concern that can be fixed IF the scheme works at all. |
| 13:18 |
|
daxim |
you're the C expert, I wouldn't know if my head compiled separately from my arse |
| 13:18 |
|
tsee |
I am by no means a C expert, sorry. |
| 13:19 |
|
tsee |
And things aren't looking good for my suggestion above. |
| 13:19 |
|
tsee |
I don't think you can separate this from the rest of KDE. |
| 13:20 |
|
Sewi |
the midnight commander (mc) also has a VFS system, but I never looked at the internals. It might be possible to create a Perl API for this |
| 13:20 |
|
tsee |
Same limitation: We need to be able to ship it all as a CPAN module. |
| 13:20 |
|
tsee |
Or else we won't be portable in the least. |
| 13:20 |
|
tsee |
Also, is mc itself portable at all? |
| 13:20 |
|
daxim |
portable to posix only |
| 13:21 |
|
tsee |
All of this is the reason why I suggested checking out File::System. |
| 13:21 |
|
Sewi |
Don't know if there is a win version |
| 13:21 |
|
tsee |
daxim, win32 is mostly posix, isn't it? |
| 13:21 |
|
daxim |
haha, with a big helping of cygwin, sure. |
| 13:22 |
|
tsee |
Sorry, I'm pretty win32 deprived. |
| 13:23 |
|
tsee |
Anyone of you using Windows? |
| 13:23 |
|
daxim |
nope |
| 13:23 |
|
tsee |
If so, could you try installing File::System? |
| 13:24 |
|
Sewi |
szabgab_mib: Does your rule also apply if the commit resulting in a failed test just introduced this test (and the failure is not within the test)? :-) |
| 13:24 |
|
Sewi |
tsee: I'll try... |
| 13:25 |
|
tsee |
Sewi, thanks! |
| 13:25 |
|
tsee |
I assume it's not going to work out of the box, but maybe it's just a few typical win32 mistakes |
| 13:25 |
|
Sewi |
For the logs: I'm not using Perl on Windows, I'm just testing there :-) |
| 13:25 |
|
tsee |
Strawberry Perl made it sufferable. |
| 13:27 |
|
Sewi |
tsee: Sure, but my win box has much more CPU power and RAM than my Linux netbook - and it is slower! Padre make test needs ~5 min. on Linux, but the last time I tried it on Win took more than 15min! |
| 13:27 |
|
szabgab_mib |
Sewi: we have to ask Alias what is my rule :-) |
| 13:27 |
|
Sewi |
szabgab_mib: He escaped some time ago :-) |
| 13:27 |
|
szabgab_mib |
I have an hour cron now: http://bit.ly/ |
| 13:28 |
|
tsee |
Don't worry, he'll be back. |
| 13:28 |
|
|
cognominal_ joined #padre |
| 13:28 |
|
szabgab_mib |
but I'll try to improve on that so it will smoke more often and will include all the test files |
| 13:29 |
|
szabgab_mib |
you could also try to set it up |
| 13:29 |
|
Sewi |
tsee: http://pastebin.de/2799 |
| 13:29 |
|
tsee |
Does anybody here have access to Adam's Microsoft smoking setup? |
| 13:29 |
|
daxim |
I checked out kio from svn, but this cmake stuff stymies me. |
| 13:30 |
|
szabgab_mib |
there is an IRC channel for the win32 farm |
| 13:30 |
|
tsee |
Good Lord. cmake. We use that at work. |
| 13:30 |
|
daxim |
the compilation depends on some macros which are defined in upper directories |
| 13:30 |
|
daxim |
so it's not as easy as I had hoped :( |
| 13:30 |
|
tsee |
daxim, that was, unfortunately, to be expected. |
| 13:31 |
|
tsee |
It's KDE after all. |
| 13:31 |
|
tsee |
But kudos to you for trying! |
| 13:31 |
|
tsee |
I just went as far as looking at the headers and seeing the #include<kde_macros.h> |
| 13:31 |
|
* tsee |
considers a full kde-libs CPAN distribution for a fraction of a second. |
| 13:33 |
|
Sewi |
Get ready to slap me... |
| 13:33 |
|
Hyppolit |
svn: r9331 | Sewi++ | http://padre.perlide.org/trac/changeset/9331 |
| 13:33 |
|
Hyppolit |
Added a first (sample) test using the action queue |
| 13:33 |
|
Hyppolit |
trunk/Padre/xt/ |
| 13:33 |
|
szabgab_mib |
one should be able to install a full linux distribution using just CPAN.pm |
| 13:34 |
|
Hyppolit |
svn: r9332 | Sewi++ | http://padre.perlide.org/trac/changeset/9332 |
| 13:34 |
|
Hyppolit |
...and fix the errors found by this test. |
| 13:34 |
|
Hyppolit |
trunk/Padre/lib/Padre/Action/ |
| 13:34 |
|
tsee |
szabgab, if you can install kde-libs, you got most of a modern linux distro already ;) |
| 13:35 |
|
tsee |
szabgab_mib, so if there's an IRC channel for the win32 farm, which one is it? not #win32? |
| 13:36 |
|
szabgab_mib |
let me dig it out from the journal of Alias |
| 13:36 |
|
tsee |
Oh, I can do that, too. |
| 13:37 |
|
szabgab_mib |
#msopensource |
| 13:37 |
|
Hyppolit |
svn: r9333 | Sewi++ | http://padre.perlide.org/trac/changeset/9333 |
| 13:37 |
|
Hyppolit |
Perl tidy |
| 13:37 |
|
Hyppolit |
trunk/Padre/ trunk/Padre/lib/ trunk/Padre/lib/Padre/ trunk/Padre/lib/Padre/Action/ trunk/Padre/lib/Padre/File/ trunk/Padre/lib/Padre/Wx/ trunk/Padre/lib/Padre/Wx/Dialog/Preferences/ trunk/Padre/lib/Padre/Wx/Menu/ trunk/Padre/script/ |
| 13:37 |
|
szabgab_mib |
http://use.perl.org/~Alias/journal/39318 |
| 14:07 |
|
Hyppolit |
svn: r9334 | Sewi++ | http://padre.perlide.org/trac/changeset/9334 |
| 14:07 |
|
Hyppolit |
Re-enabled beginner error tests. Not beautiful, but working. |
| 14:07 |
|
Hyppolit |
trunk/Padre/xt/ |
| 14:07 |
|
|
cognominal_ joined #padre |
| 14:09 |
|
Hyppolit |
svn: r9335 | Sewi++ | http://padre.perlide.org/trac/changeset/9335 |
| 14:09 |
|
Hyppolit |
Updated Changes |
| 14:09 |
|
Hyppolit |
trunk/Padre/ |
| 14:31 |
|
|
patspam joined #padre |
| 14:34 |
|
|
tsee joined #padre |
| 14:47 |
|
|
tsee_ joined #padre |
| 14:48 |
|
teejay |
so, Padre fails failed 79 tests of 146. when I run author_tests/pod-coverage.t |
| 14:48 |
|
tsee_ |
pod coverage in padre.... don't be silly ;) |
| 14:48 |
|
Hyppolit |
svn: r9336 | hashbangperl++ | http://padre.perlide.org/trac/changeset/9336 |
| 14:48 |
|
Hyppolit |
added |
| 14:48 |
|
Hyppolit |
trunk/Padre/t/ trunk/Padre/t/author_tests/ |
| 14:49 |
|
teejay |
as it happens I know a way to fix a lot of that |
| 14:49 |
|
teejay |
although I first need to add Class::XSAccessor support to autodia |
| 14:51 |
|
|
tsee__ joined #padre |
| 14:59 |
|
* teejay |
does the cpan update dance to make Makefile.PL happy |
| 15:04 |
|
|
Haarg joined #padre |
| 15:22 |
|
|
ingyfoo joined #padre |
| 15:25 |
|
|
pece2 joined #padre |
| 15:25 |
|
|
tsee_ joined #padre |
| 15:27 |
|
|
zamolxes joined #padre |
| 15:28 |
|
|
cognominal_ joined #padre |
| 15:28 |
|
|
kentnl joined #padre |
| 15:28 |
|
|
shadowpaste joined #padre |
| 15:28 |
|
|
Penfold joined #padre |
| 15:32 |
|
|
siegfri3d joined #padre |
| 15:33 |
|
|
jayk__ joined #padre |
| 15:33 |
|
|
BooK_ joined #padre |
| 15:33 |
|
|
c9s_ joined #padre |
| 15:33 |
|
|
daxim joined #padre |
| 15:33 |
|
|
Sewi joined #padre |
| 15:33 |
|
|
teejay joined #padre |
| 15:33 |
|
|
Hinrik joined #padre |
| 15:33 |
|
|
kthakore joined #padre |
| 15:33 |
|
|
kirillm joined #padre |
| 15:33 |
|
|
szabgab joined #padre |
| 15:33 |
|
|
gshank joined #padre |
| 15:33 |
|
|
Getty joined #padre |
| 15:33 |
|
|
Haarg joined #padre |
| 15:43 |
|
|
sri joined #padre |
| 15:45 |
|
|
tsee__ joined #padre |
| 15:47 |
|
|
dapatrick joined #padre |
| 15:47 |
|
|
jjore joined #padre |
| 15:49 |
|
|
PacoLinux joined #padre |
| 15:51 |
|
|
tsee_ joined #padre |
| 15:52 |
|
|
ruz joined #padre |
| 15:57 |
|
|
szabgab_mib joined #padre |
| 16:09 |
|
|
tsee_ joined #padre |
| 16:46 |
|
|
awnstudio joined #padre |
| 16:59 |
|
|
rindolf joined #padre |
| 18:42 |
|
Hyppolit |
svn: r9337 | szabgab++ | http://padre.perlide.org/trac/changeset/9337 |
| 18:42 |
|
Hyppolit |
update the smoke script to let it run in a loop with sleep between loops, fix skipping when nothing to do |
| 18:42 |
|
Hyppolit |
trunk/tools/ |
| 18:43 |
|
Hyppolit |
svn: r9338 | szabgab++ | http://padre.perlide.org/trac/changeset/9338 |
| 18:43 |
|
Hyppolit |
[perlide.org] add files of the previous poll |
| 18:43 |
|
Hyppolit |
trunk/perlide.org/ trunk/perlide.org/poll200910/ trunk/perlide.org/poll200911/ |
| 18:48 |
|
Hyppolit |
svn: r9339 | szabgab++ | http://padre.perlide.org/trac/changeset/9339 |
| 18:48 |
|
Hyppolit |
[Parrot] PIR example |
| 18:48 |
|
Hyppolit |
trunk/Padre-Plugin-Parrot/share/examples/pir/ |
| 19:13 |
|
|
isec joined #padre |
| 19:51 |
|
rindolf |
szabgab++ |
| 20:28 |
|
|
CromeDome joined #padre |
| 21:27 |
|
Hyppolit |
svn: r9340 | szabgab++ | http://padre.perlide.org/trac/changeset/9340 |
| 21:27 |
|
Hyppolit |
more comments for the smoke script |
| 21:27 |
|
Hyppolit |
trunk/tools/ |
| 21:39 |
|
Hyppolit |
svn: r9341 | szabgab++ | http://padre.perlide.org/trac/changeset/9341 |
| 21:39 |
|
Hyppolit |
fix one of the critic errors |
| 21:39 |
|
Hyppolit |
trunk/Padre/lib/Padre/ |
| 21:46 |
|
Hyppolit |
svn: r9342 | szabgab++ | http://padre.perlide.org/trac/changeset/9342 |
| 21:46 |
|
Hyppolit |
eliminate some return undef; calls and a few prototypes to make critic happy |
| 21:46 |
|
Hyppolit |
trunk/Padre/lib/Padre/ |
| 21:47 |
|
szabgab |
finally I manged to setup the Padre smoking on a VirtualBox Ubuntu 9.10 |
| 21:48 |
|
szabgab |
so if someone commits a tests that runs rm -rf it will only ruin my virtualbox image and not my desktop |
| 21:48 |
|
szabgab |
reports are here: http://smolder.plusthree.com/a[…]/smoke_reports/11 |
| 21:48 |
|
Sewi |
:-) |
| 21:49 |
|
szabgab |
I just enabled the Perl::Critic test by installing the Test::Perl::Critic module and it has several failing tests |
| 22:05 |
|
|
mib_0zpx3w joined #padre |
| 22:06 |
|
|
mib_0zpx3w left #padre |
| 22:08 |
|
Hyppolit |
svn: r9343 | szabgab++ | http://padre.perlide.org/trac/changeset/9343 |
| 22:08 |
|
Hyppolit |
configure the critic test to use the configuration file and stop checking for string eval for now |
| 22:08 |
|
Hyppolit |
trunk/Padre/xt/ |
| 22:15 |
|
Hyppolit |
svn: r9344 | szabgab++ | http://padre.perlide.org/trac/changeset/9344 |
| 22:15 |
|
Hyppolit |
fix some of the perl critic failures |
| 22:15 |
|
Hyppolit |
trunk/Padre/lib/Padre/ trunk/Padre/t/ |
| 22:22 |
|
Sewi |
gn8 |
| 23:05 |
|
Hyppolit |
svn: r9345 | szabgab++ | http://padre.perlide.org/trac/changeset/9345 |
| 23:05 |
|
Hyppolit |
fixing several critic related bugs (returning undef, prototypes, etc) |
| 23:05 |
|
Hyppolit |
trunk/Padre/lib/Padre/ trunk/Padre/lib/Padre/Document/ trunk/Padre/lib/Padre/File/ trunk/Padre/lib/Padre/HelpProvider/ trunk/Padre/lib/Padre/QuickFixProvider/Perl/ trunk/Padre/lib/Padre/Transform/Perl/ trunk/Padre/lib/Padre/Util/ trunk/Padre/lib/Padre/Wx/ trunk/Padre/lib/Padre/Wx/Dialog/ trunk/Padre/lib/Padre/Wx/Directory/ trunk/Padre/t/author_tests/ |
| 23:21 |
|
Hyppolit |
svn: r9346 | szabgab++ | http://padre.perlide.org/trac/changeset/9346 |
| 23:21 |
|
Hyppolit |
stop criticizing files that are deliberately broken |
| 23:21 |
|
Hyppolit |
trunk/Padre/xt/ |
| 23:21 |
|
Hyppolit |
svn: r9347 | szabgab++ | http://padre.perlide.org/trac/changeset/9347 |
| 23:21 |
|
Hyppolit |
eliminate two more critic issue |
| 23:21 |
|
Hyppolit |
trunk/Padre/lib/Padre/ trunk/Padre/lib/Padre/Wx/Dialog/ |
| 23:22 |
|
szabgab |
I think that's enough for yesterday |
| 23:23 |
|
szabgab |
critic tests are almost clean, the left over needs some more thinking |
