| Time |
S |
Nick |
Message |
| 00:05 |
|
|
Adam_ left #padre |
| 00:27 |
|
|
asarch left #padre |
| 00:35 |
|
|
Di-ima left #padre |
| 00:46 |
|
|
Di-ima joined #padre |
| 00:58 |
|
|
asarch joined #padre |
| 01:15 |
|
|
Alias joined #padre |
| 01:15 |
|
Alias |
The Replace stuff is still badly broken |
| 01:15 |
|
Alias |
I'm going to revert the code soon, because we can't release like this |
| 01:16 |
|
Alias |
If you replace a string, the search then jumps backwards in the file for the next replace instead of going forwards |
| 01:23 |
|
Alias |
It continues to be really flaky, so I think it's best if it is implemented in a branch instead |
| 01:36 |
|
Hyppolit |
svn: r14423 | adamk++ | http://padre.perlide.org/trac/changeset/14423 |
| 01:36 |
|
Hyppolit |
Reverted Replace in Selection implementation before the next release, as it was making several different functions flaky. To be readded in a branch where it can be more thoroughly tested, or just to be readded once the implementation is better and tested. |
| 01:36 |
|
Hyppolit |
trunk/Padre/lib/Padre/ trunk/Padre/lib/Padre/Wx/ trunk/Padre/lib/Padre/Wx/Dialog/ trunk/Padre/t/ |
| 01:38 |
|
|
asarch left #padre |
| 01:38 |
|
Alias |
I think I'm going to start being a little more ruthless about reverting changes that break basic functionality |
| 01:39 |
|
Alias |
(At least, in ways that can't be fixed trivially) |
| 01:39 |
|
Alias |
I don't want to discourage people from committing to trunk or anything, I just want core features to stay relatively stable |
| 01:39 |
|
Alias |
Rollback seems preferable to encouraging branching |
| 01:40 |
|
|
asarch joined #padre |
| 01:40 |
|
|
estranho joined #padre |
| 02:13 |
|
|
asarch left #padre |
| 02:52 |
|
|
asarch joined #padre |
| 03:17 |
|
Hyppolit |
svn: r14424 | szabgab++ | http://padre.perlide.org/trac/changeset/14424 |
| 03:17 |
|
Hyppolit |
Update the messages.pot file |
| 03:17 |
|
Hyppolit |
trunk/Padre/share/locale/ |
| 03:45 |
|
|
alnewkirk left #padre |
| 03:52 |
|
|
estranho left #padre |
| 04:10 |
|
|
Sno| joined #padre |
| 04:10 |
|
|
pece joined #padre |
| 04:14 |
|
|
|Sno| left #padre |
| 04:15 |
|
garu |
Alias: sorry :( |
| 04:15 |
|
garu |
haven't had the time to work on this |
| 04:15 |
|
Alias |
That's fine |
| 04:16 |
|
garu |
I'll make sure it gets thoroughly tested before pushing to trunk again |
| 04:16 |
|
Alias |
I had a bit of a look, and I think you might have levered the functionality in the wrong place |
| 04:16 |
|
garu |
how come? |
| 04:16 |
|
Alias |
And that, combined with how many different weird failures I'm seeing, made me think I couldn't just fix it |
| 04:17 |
|
Alias |
I think maybe you tried to conflate separate things into one place |
| 04:18 |
|
garu |
hmm |
| 04:18 |
|
Alias |
You threaded support for a different search/replace modality (replace in selection) through the code to do the normal case |
| 04:18 |
|
Alias |
I think perhaps it's better done as a separate set of methods |
| 04:18 |
|
garu |
right |
| 04:18 |
|
garu |
I agree |
| 04:18 |
|
Alias |
And I already put in a precedent for that in the Padre::Search code |
| 04:19 |
|
garu |
with the find x search and replace, yes |
| 04:19 |
|
Alias |
Then the dialog would "if ( in selection ) { one_method } else { other_method } |
| 04:19 |
|
garu |
I'll do that, yeah |
| 04:19 |
|
Alias |
Rather than optional param passing |
| 04:20 |
|
garu |
at that time I thought it would be more straightforward to just use the same code |
| 04:20 |
|
Alias |
If you stay out of the code path for the existing search and replace, it should also be much more amenable to committing to trunk |
| 04:20 |
|
garu |
since the original was replacing from 0 to document_end |
| 04:20 |
|
garu |
I'd just pass a "from" and "to" |
| 04:20 |
|
garu |
but (as you saw) it didn't work out that way |
| 04:21 |
|
garu |
any clues as to why it broke search&replace in your work computer? |
| 04:21 |
|
Alias |
The behaviour was too flaky to locate |
| 04:22 |
|
Alias |
Possibly something to do with not updating the from-->to ranges when the length of a replaced thing inside it changes? |
| 04:22 |
|
Alias |
It has the feel of state tracking mistakes |
| 04:22 |
|
Alias |
Just can't figure out what |
| 04:23 |
|
Alias |
The inline search is also completely fubared |
| 04:23 |
|
|
asarch left #padre |
| 04:23 |
|
Alias |
I'm going to disable it from the Ctrl-F escalation until it works |
| 04:24 |
|
garu |
inline search? |
| 04:25 |
|
garu |
you mean the firefox thingie? |
| 04:25 |
|
Alias |
yeah |
| 04:25 |
|
Alias |
oh wait, it's the regex option |
| 04:25 |
|
Alias |
Regex searching might be a bit overkill for a quick search |
| 04:28 |
|
Alias |
hrm, and the gui code is a bit buggy |
| 04:28 |
|
Alias |
I might do some cleaning on it once I get Aspect 1.00 out the door |
| 04:56 |
|
waxhead |
did anyone see my email to the list about the failing test? |
| 04:56 |
|
waxhead |
it's the mimetype one... it's picking up that broken.bin file as perl mimetype... |
| 04:57 |
|
waxhead |
the test expects an undef returned, but because the "text" is parse and something triggers it as a perl file, the test fails. |
| 04:57 |
|
waxhead |
I've been looking at the code and I can't see how the binary data in the $text variable can be detected that it's from a binary file.. |
| 05:13 |
|
|
toi joined #padre |
| 05:14 |
|
|
asarch joined #padre |
| 05:21 |
|
|
pece left #padre |
| 05:40 |
|
|
Sewi joined #padre |
| 06:18 |
|
|
asarch left #padre |
| 06:21 |
|
|
danlucraft joined #padre |
| 06:27 |
|
|
danlucraft left #padre |
| 06:31 |
|
|
toi left #padre |
| 06:33 |
|
|
Sewi left #padre |
| 06:35 |
|
|
Sewi joined #padre |
| 06:41 |
|
|
Sno| left #padre |
| 06:41 |
|
|
Sno| joined #padre |
| 06:41 |
|
|
perlite_ joined #padre |
| 06:43 |
|
|
perlite left #padre |
| 06:44 |
|
|
perlite_ is now known as perlite |
| 07:02 |
|
|
toi joined #padre |
| 07:04 |
|
|
marcela joined #padre |
| 07:11 |
|
|
dolmen joined #padre |
| 07:24 |
|
|
mj41 joined #padre |
| 07:29 |
|
|
Sewi left #padre |
| 07:35 |
|
|
danlucraft joined #padre |
| 07:43 |
|
|
Alias left #padre |
| 07:43 |
|
|
Sewi joined #padre |
| 07:50 |
|
|
Adam_ joined #padre |
| 08:03 |
|
|
Sugar joined #padre |
| 09:47 |
|
|
katofiad left #padre |
| 10:43 |
|
|
Di-ima left #padre |
| 11:01 |
|
|
bowtie joined #padre |
| 11:34 |
|
|
danlucraft left #padre |
| 11:37 |
|
|
danlucraft joined #padre |
| 13:08 |
|
|
bowtie left #padre |
| 13:18 |
|
|
bowtie joined #padre |
| 13:40 |
|
|
Adam_ left #padre |
| 13:56 |
|
|
marcela left #padre |
| 14:09 |
|
|
toi left #padre |
| 14:32 |
|
|
estranho joined #padre |
| 14:54 |
|
|
dapatrick joined #padre |
| 14:56 |
|
|
kaare joined #padre |
| 14:59 |
|
|
Sewi1 joined #padre |
| 14:59 |
|
|
Sewi left #padre |
| 15:09 |
|
|
dodathome joined #padre |
| 15:34 |
|
|
pece joined #padre |
| 15:40 |
|
|
sniper joined #padre |
| 16:03 |
|
|
asarch joined #padre |
| 16:08 |
|
|
kaare left #padre |
| 16:09 |
|
|
kaare joined #padre |
| 16:15 |
|
|
toi joined #padre |
| 16:18 |
|
|
Sugar left #padre |
| 16:36 |
|
|
kaare left #padre |
| 16:38 |
|
|
danlucraft left #padre |
| 16:40 |
|
|
danlucraft joined #padre |
| 16:46 |
|
|
danlucraft left #padre |
| 16:53 |
|
|
asarch left #padre |
| 17:02 |
|
|
toi left #padre |
| 17:08 |
|
|
dolmen left #padre |
| 17:25 |
|
|
mj41 left #padre |
| 17:49 |
|
|
sniper left #padre |
| 17:49 |
|
|
dapatrick left #padre |
| 18:05 |
|
|
dapatrick joined #padre |
| 18:09 |
|
|
dapatrick1 joined #padre |
| 18:11 |
|
|
dapatrick left #padre |
| 18:15 |
|
|
dapatrick1 left #padre |
| 18:37 |
|
|
sniper joined #padre |
| 18:37 |
|
|
danlucraft joined #padre |
| 19:07 |
|
|
dapatrick joined #padre |
| 20:05 |
|
|
pece left #padre |
| 20:31 |
|
|
dodathome left #padre |
| 20:35 |
|
|
pece joined #padre |
| 20:36 |
|
|
Sewi1 left #padre |
| 20:37 |
|
|
toi joined #padre |
| 20:38 |
|
|
danlucraft left #padre |
| 20:41 |
|
|
mj41 joined #padre |
| 20:44 |
|
|
toi left #padre |
| 21:37 |
|
|
asarch joined #padre |
| 21:38 |
|
mj41 |
Hi. I just implemented prototype of scp_put https://github.com/mj41/Padre-Plugin-ReDevel |
| 21:38 |
|
mj41 |
now I need a bit sleep |
| 21:59 |
|
|
katofiad joined #padre |
| 22:04 |
|
|
dapatrick left #padre |
| 22:15 |
|
|
mj41 left #padre |
| 22:27 |
|
|
Di-ima joined #padre |
| 23:18 |
|
|
katofiad left #padre |
| 23:24 |
|
|
katofiad joined #padre |
| 23:44 |
|
|
asarch left #padre |
| 23:58 |
|
|
bowtie left #padre |
