Camelia, the Perl 6 bug

IRC log for #parrot, 2008-03-15

Parrot | source cross referenced

| Channels | #parrot index | Today | | Search | Google Search | Plain-Text | summary

All times shown according to UTC.

Time Nick Message
00:03 Infinoid kid51: hey, while we're on the subject of codingstd tests... last Wednesday, I added perl_language_files to the list of stuff trailing_space.t checks, and fixed up 32 .pm and .pl files that were failing the test (in r26349)
00:03 Infinoid there was some mention here of adding .pir files to the list, too, and there are a couple hundred of those which fail.  but that'll wait until after the release
00:04 Infinoid it's probably worth a review at some point to see if there's any other codingstd coverage tweaks we can do
00:10 Infinoid hmm, s/last Wednesday/yesterday/
00:21 kid51 Infinoid:  I'm not really the expert on t/codingstd tests; ptc wrote most of them, I think.  So I mostly just do little fixes on them.
00:22 kid51 I don't know enough about the coding standards to be able to say how we should measure their "coverage".  I don't think it's as "simple" as applying Devel::Cover or gcov.
00:23 Infinoid heh
00:23 Infinoid it has to be handled on a test-by-test basis, I think
00:23 Infinoid for c_header_guards.t, 100% would be each and every *.h file
00:24 Infinoid for trailing_space.t, probably everything in text format applies (except for test .output files)
00:25 Infinoid anyway, just thinking out loud I suppose
00:26 kid51 As I understand them, the "test" fails if >=1 particular file fails the standard; and then those files are identified.  And that's the sum total of the design.
00:26 Infinoid yep
00:27 kid51 So getting good "coverage" means (a) identifying all the source files which ought to pass a particular test, then (b) ensuring that each file passes that test.
00:27 kid51 Hence, it's not measured by %age of lines exercised by test suite; it's more file-focused than statement-focused.
00:28 Infinoid the question is whether the list of files tested by each test is comprehensive
00:28 Infinoid anyway, I'll start making noise about this next week
00:28 * kid51 examines http://parrotvm.org/svn/parrot/revision/?rev=26349
00:29 kid51 Infinoid:  Was it actually the case that perl language files were *not* covered by the no-trailing-whitespace standard until your patch?  IIRC, I've been nailed repeatedly by that standard -- and everything I write is Perl 5.
00:29 Infinoid yes.  actually, after I fussed with line numbering in that test, Coke nopasted a patch to add perl-language files, and also pir files
00:30 Infinoid there were quite a lot of pir files which failed it.  I'm of the opinion that pretty much everything should pass it, unless it has a good reason not to.  hell, Makefiles, yaml files, the whole bit
00:31 Infinoid anyway, r26349 is the first stage result of Coke's patch :)
00:33 Infinoid if you've been bit by it before, could it be that perl language files were recently removed from the test?
00:33 kid51 Hmm, I see.  I haven't paid too much attention to these tests because ptc was on top of them and because I've been focused elsewhere (configuration and build tools tests).
00:34 kid51 Infinoid:  Dunno.  I'd have to do a checkout of that test from 3-6 months ago to see.
00:34 kid51 Oh wait, let's see what svn log tells us.
00:37 kid51 Well, I guess my memory was wrong.  r21509 2007-09-24 only has my @files = @ARGV ? @ARGV : $DIST->get_c_language_files();
00:38 Infinoid versions previous to r15477 had broken it out a bit more (pmc, yacc, lex, etc) but it was still pretty focused on C
00:39 Infinoid anyway, we'll soon fix that
00:40 Infinoid along similar lines, pdd07 says cuddled elses are forbidden, but we're only checking C sources for that.
00:40 kid51 So, let me see if I understand this:  the patch you're proposing in 51718 is consistent with the approach these files take, i.e., every file must pass the coding standard for the test to pass -- correct?
00:41 Infinoid yes, and it boils it all down to one test at the end
00:41 Infinoid and provides some nifty diagnostics (which are now *consistent*) if the test did fail
00:42 Infinoid the goal is reduced code duplication and consistent output, the behavior is otherwise unchanged.
00:42 kid51 per mjd:  Repeated Code Is A Mistake
00:43 svnbotl r26371 | chromatic++ | trunk:
00:43 svnbotl : [t] Avoid false negatives when checking for isxxx() functions.  (The mention
00:43 svnbotl : here was previously a test failure, even though it's obviously not a C function
00:43 svnbotl : call.  The C compiler will tell us if someone accidentally passes no arguments
00:43 svnbotl : to these functions.  We only care if someone passes one, and that without a
00:43 svnbotl : cast).
00:43 svnbotl r26372 | chromatic++ | trunk:
00:43 svnbotl : [Rakudo] Cleaned up the use if isxxx() functions in Perl6Str PMC to pass the
00:43 svnbotl : coding standards tests.
00:43 svnbotl diff: http://parrotvm.org/svn/parrot/revision/?rev=26372
00:44 diakopter interesting
00:44 kid51 I think I remember now what was happening with those trailing spaces.  ptc would run perltidy over the entire distribution, catching some trailing space in my files.  When I would 'svn up', I'd be surprised to see that files I had written had changed.  Inevitably, it was ptc catching me on trailing whitespace, cuddled elses, etc.
00:44 Infinoid ptc++
00:45 kid51 Ah, looks like c has fixed that file.  I will re-test.
01:32 kid51 Infinoid:  ping
01:32 Infinoid kid51: hi!
01:33 kid51 Can you take a look at how chromatic patched t/codingstd/check_isxxx.t?  After I did svn up with his commit, and then tried to apply your patch, the section of your patch pertaining to that file didn't apply cleanly.
01:34 Infinoid yeah, I saw he had changed it.  I'll reissue the patch
01:34 kid51 Cool.
01:37 diakopter er, what killed svnbotl
01:38 kid51 What always kills svnbotl.
01:38 kid51 A big movement.  In this case, my refreshing the tcif branch from trunk.
01:38 kid51 This is the same problem it's had for months; nothing new.
01:39 svnbotl joined #parrot
01:39 diakopter poor pugs
01:39 diakopter it can't keep up :D
01:40 kid51 And that was basically just a big 'svn copy'.  Watch, it will go out again when I do a big 'svn commit'.
01:43 diakopter hrm. at one point I thought it died when its call to SVN::Web timed out (and SVN::Web failures would sort of explain the correlation with "large" commits).  but I guess that's not it.
01:46 kid51 diakopter:  Would we get any better results if we re-implemented it in Perl 5?  (I doubt Audrey's going to be available to revise the Pugs.)
01:47 Infinoid that sounds like a fun project.
01:50 kid51 Hey, Infinoid.  I like the trailing space test.  It just caught two files of mine in the 'tcif' branch.
01:50 kid51 # Trailing space or tab char found in 2 files:#   /home/jimk/work/tcif/lib/Parr​ot/Configure/Options/Test.pm: 78 168# #   /home/jimk/work/tcif/lib/Parro​t/Configure/Parallel/Trace.pm: 63 100 132 134 145 166 188 210 236 260 284 316 357
01:50 kid51 Very useful output.
01:50 Infinoid awesome!
01:50 purl hmmm... awesome is a plug for chicken broth rice.
01:51 Infinoid if svnbotl had proper child process handling so it wasn't blocked waiting for svn, it wouldn't time out like that, right?
01:51 cotto_home purl, forget awesome
01:51 purl cotto_home: I forgot awesome
01:52 Infinoid I don't know enough perl6 to do that.  but I can write it in perl5, if it would help
01:53 kid51 Now, watch me make svnbotl disappear ...
01:54 lola22 joined #parrot
01:58 kid51 purl svnbotl
01:58 purl svnbotl is a bit labil today, it committed suicide twice today ;)
02:02 diakopter <sigh>
02:03 kid51 It will be back.
02:03 diakopter kid51: actually all it needs to do is parse this: http://www.parrotvm.org/svn/parrot/log
02:04 diakopter er, I mean, http://www.parrotvm.org/svn/parrot/rss
02:04 diakopter if you wanted to reimplement it, I mean
02:05 diakopter Infinoid: you too
02:05 * kid51 has avoided learning rss ... for years
02:06 Infinoid awesome
02:06 Infinoid kid51: I'm sure we can find something on CPAN for that :)
02:07 diakopter yep, looks like SVN::Web's timing out on r26377
02:07 diakopter don't anyone (additional) try it, please
02:07 * diakopter waits while feather crawls
02:08 kid51 Is the problem that it has to parse HTML?  If so, couldn't it parse a plaintext version of the log instead?
02:10 diakopter no; it's rss or atom; I dunno
02:10 * kid51 wonders whether feather is just a Dell box sitting under somebody's desk
02:10 diakopter all you need to do is write an HTML::Template-style template for its output
02:10 diakopter for SVN::Web's output
02:10 diakopter and I can add it as a theme
02:10 diakopter or something like that
02:11 diakopter if you wanted yaml or something
02:11 kid51 well, I can't think about it anymore tonight, because ...
02:11 * kid51 must sleep
02:11 purl $kid51->sleep(8 * 3600);
02:11 Infinoid sleep well kid51
02:11 * Infinoid tosses something together to find out how hard polling rss really is
02:13 Coke joined #parrot
02:26 diakopter Infinoid: good luck
02:27 Infinoid ooh, foreboding
02:27 diakopter I wasn't being sarcastic
02:28 Infinoid :)
02:29 Infinoid XML::RAI looks pretty simple, so I'm trying that
02:34 svnbotl joined #parrot
02:34 diakopter http://www.parrotvm.org/svn​/parrot/revision?rev=26377 is finally ready/cached
02:34 Infinoid I didn't do it!
02:35 svnbotl joined #parrot
02:39 Infinoid I have a 50 line perl5 script that seems to poll and parse http://www.parrotvm.org/svn/parrot/rss just fine
02:39 Infinoid waiting for someone to check something in, tho, to see whether it outputs a line for new checkins
02:40 diakopter well, I'll implement it as a plugin to this (cool) perl irc bot framework I found
02:41 diakopter whose coolness I can explain at some later time
02:42 diakopter dalek: ping
02:42 diakopter dalek: you're still alive :)
02:43 nopaste "Infinoid" at 75.31.90.47 pasted "diakopter: here's what I got" (52 lines) at http://nopaste.snit.ch/12513
02:43 Infinoid obviously, you're going to want to handle the polling loop in a different way.
02:44 Infinoid and replace print("new item: $last_top_id\n"); with something nifty and irc-ish :)
02:44 diakopter the framework has its own timer/callback system
02:44 Infinoid yeah, I figured
02:45 Infinoid the rss object is $item, and its an XML::RAI::Item, so you'll want $item->contributor, $item->title, $item->link
02:46 Infinoid hope it helps.
02:46 diakopter cool
02:46 diakopter ->contributor gives the 'creator' attribute?
02:47 Infinoid oh, you're right.  $item->creator
02:47 diakopter ah
02:47 Infinoid http://search.cpan.org/~tima/XML​-RAI-1.3022/lib/XML/RAI/Item.pm has a list of methods and the rss tags it pulls that data from (in order of precedence)
02:47 Infinoid this module seems to be a catchall to handle all the various flavors of rss-ish things.  seems neat
02:49 * diakopter also waits for someone to commit something
02:51 * Infinoid looks around for something trivial to fix :)
02:57 Infinoid here we go
02:58 Infinoid looks like it worked here!
03:03 svnbotl r26378 | infinoid++ | trunk:
03:03 svnbotl : [tools] fix the following t/codingstd/perlcritic.t errors in tools/dev/vtablize.pl:
03:03 svnbotl : * TestingAndDebugging::RequireUseStrict
03:03 svnbotl : * TestingAndDebugging::RequireUseWarnings
03:03 svnbotl diff: http://parrotvm.org/svn/parrot/revision/?rev=26378
03:11 spinclad 'i have a lot of lines with just a single C<}> on them.  does this count as repeated code?'
03:16 Infinoid heh
03:17 Infinoid yes, we should add a #define PARROT_NAKED_RIGHT_CURLY_BRACE and replace them all
03:28 parrot-poke mmm, curly braces
03:43 spinclad no, that would still count as repeated code.  we need PARROT_NAKED_RIGHT_CURLY_BRACE_<int++> to distinguish them.
03:44 Infinoid heh
03:44 Infinoid nono, see, we should just remove them entirely, and then write a special preprocessor to guess where to reinsert them before passing off to the compiler
04:03 TimToady_ actually, it's the whitespace that is redundant, so you should just remove all of that.
04:05 Infinoid that'll certainly make the guessing more interesting :)
04:15 natacha29 joined #parrot
05:44 svnbotl r26379 | chromatic++ | trunk:
05:44 svnbotl : [GC] Minor speed improvements and consolidations.
05:44 svnbotl diff: http://parrotvm.org/svn/parrot/revision/?rev=26379
06:13 cotto_home what's tcif?
06:14 cotto_home Thank Cthulhu it's Friday?
06:44 kid51 joined #parrot
07:51 Ademan joined #parrot
08:07 svnbotl r26380 | chromatic++ | trunk:
08:07 svnbotl : [PMC] Removed ancient /*NN*/ annotations from vtable entries in the Key PMC.
08:07 svnbotl : These were getting in the way of METHOD parameter parsing (and like I said,
08:07 svnbotl : they're ancient).
08:07 svnbotl diff: http://parrotvm.org/svn/parrot/revision/?rev=26380
08:15 svnbotl r26381 | chromatic++ | trunk:
08:15 svnbotl : [lib/PMC] Modified :named parameter syntax in METHODs to match PDD03, per RT
08:15 svnbotl : #42292.  Note that this required substantial modifications to the PMC parser.
08:15 svnbotl : O frabjous day.
08:15 svnbotl diff: http://parrotvm.org/svn/parrot/revision/?rev=26381
08:29 AndyA joined #parrot
08:50 barney joined #parrot
09:10 mire joined #parrot
10:04 barney What the name of the markup used in NEWS? =:)
10:50 svnbotl r26382 | bernhard++ | trunk:
10:50 svnbotl : [docs]
10:50 svnbotl : Elaborate on changes since Parrot 0.5.3
10:50 svnbotl r26383 | bernhard++ | trunk:
10:50 svnbotl : Let SVN ignore generated files.
10:59 barney Shouldn't the t/harness calls be prepended with '-' in Makefile ?
11:00 barney Don't make 'make fulltest' exit early.
11:10 svnbotl r26384 | bernhard++ | trunk:
11:10 svnbotl : Get rid of hard tabs.
11:10 svnbotl : Some beautifications.
11:10 svnbotl r26385 | bernhard++ | trunk:
11:10 svnbotl : Remove obsolete target 'testbench' in root Makefile.
11:10 svnbotl diff: http://parrotvm.org/svn/parrot/revision/?rev=26385
11:14 Coke joined #parrot
11:29 svnbotl r26386 | bernhard++ | trunk:
11:29 svnbotl : Update last verified date for linux-x86-gcc4.1.3
11:29 svnbotl diff: http://parrotvm.org/svn/parrot/revision/?rev=26386
11:32 mire joined #parrot
12:01 svnbotl r26387 | bernhard++ | trunk:
12:01 svnbotl : [codingstd]
12:01 svnbotl : Remove trailing spaces.
12:01 svnbotl diff: http://parrotvm.org/svn/parrot/revision/?rev=26387
12:09 nopaste "barney" at 84.58.172.65 pasted "Does that look sane, for making 'make fulltest' always complete ?" (41 lines) at http://nopaste.snit.ch/12516
12:14 svnbotl r26388 | bernhard++ | trunk:
12:14 svnbotl : [codingstd]
12:14 svnbotl : Quiet Perl::Critic policy Bangs::ProhibitFlagComments.
12:14 svnbotl : Some beautifications.
12:14 svnbotl diff: http://parrotvm.org/svn/parrot/revision/?rev=26388
12:21 svnbotl r26389 | bernhard++ | trunk:
12:21 svnbotl : [codingstd]
12:21 svnbotl : Make Perl::Critic happy, WRT conditional declaration.
12:21 svnbotl diff: http://parrotvm.org/svn/parrot/revision/?rev=26389
12:53 svnbotl r26390 | petergibbs++ | trunk:
12:53 svnbotl : Prevent overrun of array. Found using valgrind while chasing down tcl test
12:53 svnbotl : failures on linux x86-64.
12:53 svnbotl diff: http://parrotvm.org/svn/parrot/revision/?rev=26390
13:11 Psyche^ joined #parrot
13:31 kid51 joined #parrot
15:07 kid51 joined #parrot
15:12 Sartak joined #parrot
15:19 Andy joined #parrot
16:04 adc joined #parrot
16:12 peeps[work] joined #parrot
16:17 svnbotl r26391 | particle++ | trunk:
16:17 svnbotl : [donors] add mozilla foundation
16:17 svnbotl diff: http://parrotvm.org/svn/parrot/revision/?rev=26391
17:02 adc joined #parrot
17:04 cotto_home anyone know what the tcif branch is?
17:19 Limbic_Region joined #parrot
17:56 apple-gunkies joined #parrot
18:34 Psyche^ joined #parrot
19:20 mire joined #parrot
19:35 svnbotl r26392 | chromatic++ | trunk:
19:35 svnbotl : [docs] Removed some deprecated and removed features from DEPRECATED.pod.
19:35 svnbotl r26393 | chromatic++ | trunk:
19:35 svnbotl : [src] Minor cleanups and reformatting.
19:35 svnbotl diff: http://parrotvm.org/svn/parrot/revision/?rev=26393
19:55 buchetc joined #parrot
20:07 cognominal joined #parrot
20:07 chromatic joined #parrot
20:11 svnbotl r26394 | rgrjr++ | trunk:
20:11 svnbotl : * src/embed.c:
20:11 svnbotl :    + (Parrot_readbc):  Make I/O error check really work.
20:11 svnbotl diff: http://parrotvm.org/svn/parrot/revision/?rev=26394
20:18 svnbotl r26395 | rgrjr++ | trunk:
20:18 svnbotl : * src/packdump.c:
20:18 svnbotl :    + (pobj_flag_dump, flag_bit_names):  Do hex & symbolic display of
20:18 svnbotl :      object flags.  Needs better abstraction, though.
20:18 svnbotl :    + (PackFile_Constant_dump):  Use pobj_flag_dump for strings, keys,
20:18 svnbotl :      and PMCs.  Dump closures as subs.  Add a missing "'" to the PFC_KEY
20:18 svnbotl :      output.  Remove bogus slice_bits update; this var is unused, and
20:18 svnbotl :      appears to have been causing stuff to be printed inappropriately.
20:18 svnbotl : * include/parrot/pobj.h:
20:18 svnbotl :    + (enum PObj_enum):  Add a doc ref to flag_bit_names.
20:18 svnbotl diff: http://parrotvm.org/svn/parrot/revision/?rev=26395
20:19 nowhere_man joined #parrot
20:26 adc joined #parrot
20:41 chromatic Rakudo: http://rt.perl.org/rt3/Tic​ket/Display.html?id=51350
20:49 svnbotl r26396 | chromatic++ | trunk:
20:49 svnbotl : [t] Don't check for SVN metadata in git-svn check outs (Matt Kraai, RT #51334).
20:49 svnbotl diff: http://parrotvm.org/svn/parrot/revision/?rev=26396
20:56 svnbotl r26397 | chromatic++ | trunk:
20:56 svnbotl : [pbc_to_exe] Use cc_o_out configuration value to specify output file instead of
20:56 svnbotl : -Fo, for cross platform goodness (Matt Kraii, RT #51172).
20:56 svnbotl diff: http://parrotvm.org/svn/parrot/revision/?rev=26397
20:57 guru joined #parrot
20:58 guru left #parrot
21:10 dalek joined #parrot
21:14 rdice joined #parrot
21:15 svnbotl r26398 | chromatic++ | trunk:
21:15 svnbotl : [src] Various Cygwin tweaks:
21:15 svnbotl : * jit.pm, exec.h: enabled EXEC_CAPABLE with EXEC_COFF on cygwin
21:15 svnbotl : * added config/auto/jit/test_exec_cygwin.in
21:15 svnbotl : * dynext get_path(): replace leading "lib" with "cyg".
21:15 svnbotl : * dynext pirs: added special cygwin dll name tweaks for SDL, ncurses, Pg
21:15 svnbotl : (no optional versioning yet)
21:15 svnbotl : * fixed and enabled tests for t/native_pbc/header.t, t/src/compiler.t,
21:15 svnbotl : t/stm/basic_mt.t, t/stm/llqueue.t
21:15 svnbotl : * added a README_cygwin.pod
21:15 svnbotl : (Reini Urban, RT #51328).
21:15 svnbotl diff: http://parrotvm.org/svn/parrot/revision/?rev=26398
21:23 dakkar joined #parrot
21:32 jrt4 joined #parrot
21:37 Theory joined #parrot
21:38 chromatic joined #parrot
21:40 svnbotl r26399 | chromatic++ | trunk:
21:40 svnbotl : [tools] Tidied code.
21:40 svnbotl : Removed dependency on Regexp::Common by inlining the C and C++ comment regular
21:40 svnbotl : expressions.  (I'm not sure we use the latter type, however.)
21:40 svnbotl : Resolves RT #43835.
21:40 svnbotl diff: http://parrotvm.org/svn/parrot/revision/?rev=26399
21:42 jrt4 joined #parrot
21:55 spinclad diakopter: strange:  sometimes svnbotl makes it through a long log, well paced; sometimes cuts off after 5 lines, as if throttled at server.  first five lines appear together, regardless.
21:56 spinclad (compare r26398 and r26399 here)
21:56 spinclad dunno if this provides any clues
22:02 adc joined #parrot
22:24 marmic joined #parrot
22:31 kid51 joined #parrot
22:49 svnbotl r26400 | chromatic++ | trunk:
22:49 svnbotl : [t] Skipped the dynoplibs event test under the CGP core, as there's some
22:49 svnbotl : weirdness with dynops and multiple interpreters.
22:49 svnbotl diff: http://parrotvm.org/svn/parrot/revision/?rev=26400
23:08 svnbotl r26401 | chromatic++ | trunk:
23:08 svnbotl : [src] Minor cleanups in formatting.
23:08 svnbotl diff: http://parrotvm.org/svn/parrot/revision/?rev=26401
23:13 diakopter spinclad: yes, the server throttling is occuring.  I keep trying to get pugs to put a 1 second delay between lines, but I think autothreading is preempting my efforts
23:13 diakopter either that or output buffering
23:14 diakopter Infinoid wrote up a nice POC that polls the rss log; I'm trying to write a botnix plugin
23:16 diakopter which is at http://svn.inspircd.org/repository/trunk/botnix if you're interested
23:16 diakopter dalek: you're a botnix instance, aren't you?
23:16 diakopter (yes)
23:16 Infinoid ooo
23:47 zarchne joined #parrot

| Channels | #parrot index | Today | | Search | Google Search | Plain-Text | summary

Parrot | source cross referenced