Camelia, the Perl 6 bug

IRC log for #parrot, 2009-03-05

Parrot | source cross referenced

| Channels | #parrot index | Today | | Search | Google Search | Plain-Text | summary

All times shown according to UTC.

Time Nick Message
00:00 NotFound integer_4.pbc gives 0 entries to me, so the failure is in my code.
00:01 rg the _4 would be amd64, right.
00:01 jsut|w3rk joined #parrot
00:01 NotFound moritz: can you try with t/native_pbc/integer_1.pbc ?
00:01 moritz NotFound: that gives me Directory entries: 5
00:02 moritz and a listing of the five things
00:02 NotFound Fine
00:02 moritz bed&
00:09 AndyA joined #parrot
00:11 japhb joined #parrot
00:19 NotFound t/native_pbc/integer_3.pbc seems to have an invalid signature
00:20 rg that one is probably pretty old
00:21 NotFound I've managed to make pbc_check work with the opcode size 8 files, but I don't think the way it works is matching the doc.
00:22 NotFound Some things are aligned to 32 bytes, not 16
00:22 rg i thought all things are supposed to be aligned to at least 32bit now
00:23 NotFound I don't think, just read the documents and write code ;)
00:24 rg good, but please take up all differences between docs and reality up with rurban ;)
00:24 NotFound No problem with changing the docs, provided there is some logic.
00:25 rg since i haven't read the docs (at least not yet ;)), i can't say.
00:31 Infinoid Coke: Ok.  Leaving aside the whole stable / supported / development / monthly / whatever naming debacle, can I get a "latest" symlink so I can link to docs without having to update them monthly?
00:34 Infinoid I'm going to bounce the old links for www.parrotcode.org/cage-cleaners/guide.html, www.parrotcode.org/faq/, www.parrotcode.org/glossary.html and so forth to docs.parrot.org.  Having those always go to the latest release (if not a daily snapshot via cron) would probably be a good thing
00:37 japhb joined #parrot
00:40 tetragon joined #parrot
00:49 davidfetter joined #parrot
00:53 bacek_ joined #parrot
01:04 japhb joined #parrot
01:37 Tene joined #parrot
01:46 cotto should pbc_dump and pbc_disassemble segfault on pbc_to_exe.pbc?
01:47 kid51 joined #parrot
01:47 rg nothing should segfault. you've probably found a bug.
01:47 justin joined #parrot
01:49 cotto I'll have to check first to make sure it's not something I broke.  Recently I don't seem to have a good track record in that area.
01:49 rg hmm this even happens on i386
01:49 rg nope, i can confirm it's nothing you (just) broke.
01:51 cotto It looks like it has to do with some Key ATTR code I missed.
01:51 cotto which means it's not covered by the test suite
01:51 cotto (or at least not by make test)
01:52 cotto shouldn't be hard, though
01:59 cotto should be fixed now unless make test breaks
02:00 dalek parrot: r37113 | cotto++ | trunk (3 files):
02:00 dalek parrot: [PBC] fix pbc_dump and pbc_disassemble after Key ATTR conversion
02:00 dalek parrot: review: https://trac.parrot.org/parrot/changeset/37113/
02:01 rg you'll see the smoke in a few hours (or hopefully not) ;))
02:01 rg coke: ping?
02:02 cotto The problem is that the breakage didn't cause any test failures.
02:02 cotto I'm filing a tt now.
02:04 dalek parrot: r37114 | coke++ | trunk (3 files):
02:04 dalek parrot: TT #400 - codingstd fixes
02:04 dalek parrot: Courtesy mikeh++
02:04 dalek parrot: review: https://trac.parrot.org/parrot/changeset/37114/
02:08 rg btw could anybody look at my patch for tt #386?
02:10 Infinoid rg: Looks sane, I'll see about testing it here
02:12 kid51 rg:  Is there any way you could provide a test for that patch?
02:13 kid51 rg:  Otherwise, I'd have to do a fresh checkout into a directory with a .ext in its name.
02:13 kid51 i.e., a test that would fail until your patch was applied.
02:13 rg i've wondered too. unfortunately the function is not exposed in any way, so i can't think of how to test it.
02:18 rg it's also only used by the loadlib code. we could rename the runtime/parrot/dynext directory, but i don't think that's a viable option
02:22 Infinoid maybe mock up a fake one for testing somehow?
02:23 kid51 ... with File::Temp::tmpdir() perhaps?
02:23 kid51 We/I do that in a lot of the configuration and build tests.
02:29 ron joined #parrot
02:31 TiMBuS joined #parrot
02:35 rg tempdir ... i see
02:38 kid51 The function in which that appears, parrot_split_path_ext, is never called in our current test suite.
02:39 kid51 So we would benefit from *any* tests thereof.
02:39 rg well it is called by loadlib, that's why the dynpmc/foo.t test fails
02:41 kid51 But it's not explicitly tested ... unit-tested.
02:43 Coke if someone makes an index.html that redirects nicely to http://docs.parrot.org/par​rot/devel/html/index.html, I will push it out.
02:43 rg well it's not really exposed, which makes it hard to test. you'd need to have a pmc or something to call to exercise it.
02:44 Coke Infinoid: allison wins. it'll be devel for the monthlies, stable for the semi-annuals.
02:44 Coke rg:pong
02:45 rg coke: are you aware that a number of tests are still checking the old runcore flags? are you looking for help on converting them?
02:45 cotto I'm glad that's settled.
02:45 Coke rg: I'm aware of no such tests.
02:45 Coke other than the one that was reported failing.
02:45 Coke patches welcome, or you can tell me which tests, or...
02:46 Coke Infinoid: I created aliases for devel and latest that both curently point to 0.9.1
02:46 Coke guess we can have devel/latest/stable all three, and just update the appropriate ones.
02:46 rg lots of them. grep for TEST_PROG_ARGS
02:47 Infinoid great, thanks
02:47 rg lots == about 10 or so
02:48 Coke rg: those are bad checks, as it's been possible for some time to get the same effect with -R jit or --runcore jit
02:48 rg that's very well possible.
02:48 Coke (or by just passing the arg to parrot directly and not using TEST_PROG_ARGS at all.
02:49 rg so what's the preferred way for a test to figure out which runcore it's being executed with?
02:49 Coke There isn't one. =-)
02:49 Coke if it's a PIR test, you might be able to interrogate parrot.
02:49 Coke (the running copy)
02:50 rg no it's for skipping or todoing the tests
02:50 Coke rg: some tests are /written in pir/
02:50 purl Hmm.  No matches for that, Coke.
02:50 Coke (likely none  of the ones that use TEST_PROG_ARGS, though)
02:51 Coke we could just punt and say that you need to use t/harness to get the skips working for that sort of thing, and then standardize there.
02:51 rg well t/harness is setting the variable in the first place, so that's fine
02:52 Coke ah, t/harness is just using that var.
02:53 Coke If I were paranoid, I'd add a method that let you specify a list of cores to skip/todo
02:53 Coke (and have that method check all variants).
02:54 Coke however, for a stopgap, good enough to just use whatever lib/Parrot/Harness/Options.pm uses.
02:54 Coke (so, /-j/ -> /--runcore=jit/), etc.
02:54 rg which is a lot better to match anyway
02:57 rg so would you like me to prepare a patch?
02:57 Coke rg: that would be awesome.
03:02 mikehh dalek has left us again
03:02 Coke added a crappy HTML redirect to http://docs.parrot.org/
03:02 Infinoid poor feather
03:03 cotto If anyone wants to pretend to be dalek, now's the time.
03:03 dalek EXTERMINATE
03:03 purl EXTERMINATE! EXTERMINATE! EXTERMINATE!
03:03 * dalek floats about the room on his retconned lifters.
03:04 dalek joined #parrot
03:05 * Infinoid starts moving all the links on http://www.parrot.org/docs/, as that table of contents doesn't seem to be autogenerated
03:07 Coke Infinoid: it's probably a copy of parrotcode.org/docs
03:07 Coke which was hardcoded.
03:07 Coke parrot.org/docs should -> docs.parrot.org, IMO.
03:08 polyglotbot joined #parrot
03:09 leo joined #parrot
03:09 pmichaud joined #parrot
03:10 estrabd joined #parrot
03:10 Infinoid I can do that.
03:10 chip joined #parrot
03:10 Infinoid I kinda wish the index.html looked a little nicer... but I know where to fix that.
03:15 Util joined #parrot
03:15 PerlJam joined #parrot
03:15 Coke Infinoid: if you're in 'make html', perhaps you could claim TT #402
03:15 jonathan joined #parrot
03:20 Infinoid Apparently drupal needed two bounces, one for /docs and one for /docs/ ... both done.
03:21 Infinoid rg: TT #386 bug and fix verified on linux/x86-64
03:22 rg infinoid: care to commit or do we need to find a way to test it?
03:24 Infinoid I dunno.  It seems like the obviously correct fix to me, but I trust kid51's judgement on this sort of thing.
03:24 Infinoid I have heard complaints recently about not enough added tests being included in bugfix commits
03:25 rg and i'd be happy to add a test if you tell me a good way to do so
03:26 rg an indirect test through loadlib doesn't seem the right way to go
03:27 Infinoid we already have the indirect test
03:29 rg well you need to test your parrot in a directory with a dot (not followed by a number) to trigger the bug right now.
03:29 Infinoid it looks like the packfile code uses this too... maybe placing uuid.pbc into a specially named tmpdir would be sufficient
03:29 Infinoid I don't really know.  I do lots of testing on the perl level, but I'm not an expert at testing C stuff from perl
03:30 Infinoid or maybe just bug kid51 for an example :)
03:30 rg well he left the discussion when i was talking to coke :(
03:32 rg i can copy and/or modify the test to create a dir and copy the foo.so into it. it feels a bit hackish, though.
03:33 Coke I think if we add a test for that, it should NOT be run by default.
03:33 Coke actually, I take that back.
03:33 Coke nevermind.
03:35 mikehh when I picked up that bug I had copied my parrot dir to parrot.noopt
03:36 mikehh because at the time I was testing a optimized build against a build with no optimize
03:37 rg mikehh: the question is not how to trigger the problem, but how to make sure it doesn't resurface
03:38 mikehh I gathered that - I was just musing
03:39 Infinoid mikehh: it's a good catch
03:39 mikehh I thought your patch looked ok
03:39 Infinoid the code's logic previous to rg's fix was pretty silly.
03:42 dalek parrot: r37115 | coke++ | failed to fetch changeset:
03:42 dalek parrot: [t] Fix test count broken in r36074.
03:42 dalek parrot: review: https://trac.parrot.org/parrot/changeset/37115/
03:44 Coke EXTERMINATE
03:44 purl EXTERMINATE! EXTERMINATE! EXTERMINATE!
03:44 Coke "failed to fetch changeset" ?
03:44 rg trac was too slow ... again
03:46 Infinoid purl, failed to fetch changeset?
03:46 purl i think failed to fetch changeset is because dalek timed out (60 seconds) fetching the link to scrape the list of changed files
03:46 * Infinoid pats purl
03:46 * purl pats Infinoid back, harder
03:48 janus joined #parrot
03:50 dalek parrot: r37116 | coke++ | trunk (3 files):
03:50 dalek parrot: [examples] Remove old example that no longer compiles and would take some
03:50 dalek parrot: effort to retool.  (also, written in PASM, not PIR)
03:50 dalek parrot: review: https://trac.parrot.org/parrot/changeset/37116/
03:53 rg coke: tt#403
03:55 Coke rg: looks good.
03:55 purl O_O
03:55 Coke someone apply that puppy.
03:55 rg well you do it. i can't ;)
03:58 * rg needs to sleep
03:59 * rg must sleep
03:59 purl $rg->sleep(8 * 3600);
03:59 rg that's the one :)
04:06 * Coke tries to install sdl.
04:10 dalek parrot: r37117 | Infinoid++ | trunk/src/packdump.c:
04:10 dalek parrot: [cage] Tweak whitespace to pass t/codingstd/c_parens.t.
04:10 dalek parrot: review: https://trac.parrot.org/parrot/changeset/37117/
04:23 cotto Infinoid++ #making code happy
04:44 japhb joined #parrot
05:23 dalek parrot: r37118 | Util++ | trunk/docs/book (7 files):
05:23 dalek parrot: [book] Typos in docs/book/ch*.pod
05:23 dalek parrot:     afficianados
05:23 dalek parrot:     consonent
05:23 dalek parrot:     constucts
05:23 dalek parrot:     continution
05:24 dalek parrot:     encapuslated
05:24 dalek parrot:     insideous
05:24 dalek parrot:     lanuages
05:24 dalek parrot:     occurance
05:24 dalek parrot:     parallism
05:24 purl i heard parallism was getting cheaper
05:24 dalek parrot:     represention
05:24 dalek parrot:     specifed
05:24 dalek parrot:     stuctures
05:24 dalek parrot:     untennable
05:24 dalek parrot:     unweildy
05:24 dalek parrot:     utlities
05:24 dalek parrot: review: https://trac.parrot.org/parrot/changeset/37118/
05:27 cotto Util++, you don't really need to list all the misspellings (although the fixes are appreciated).
05:27 dalek parrot: r37119 | cotto++ | trunk/t (9 files):
05:27 dalek parrot: [t] update runcore-related switches to the parrot exectuable
05:27 dalek parrot: patch courtesy of rg++, closes TT #403
05:27 dalek parrot: review: https://trac.parrot.org/parrot/changeset/37119/
05:32 Util cotto: It was done with an eye towards automating t/ scans for future common typos. I did not think that dalek showed more than the first line, though!
05:33 Util The next batch is too big to ennumerate, anyway. Thanks, cotto!
05:34 cotto That sounds a lot like enumerating badness.
05:34 magnachef joined #parrot
05:47 dalek parrot: r37120 | Util++ | trunk/docs/pdds (9 files):
05:47 dalek parrot: [pdds] Typos in docs/pdds/pdd*.pod and docs/pdds/draft/pdd*.pod
05:47 dalek parrot: review: https://trac.parrot.org/parrot/changeset/37120/
05:55 dalek parrot: r37121 | Util++ | trunk/docs/project (3 files):
05:55 dalek parrot: [docs] Typos in docs/project/*.pod
05:55 dalek parrot: review: https://trac.parrot.org/parrot/changeset/37121/
06:02 dalek parrot: r37122 | Util++ | trunk/docs (8 files):
06:02 dalek parrot: [docs] Typos in docs/*.pod
06:02 dalek parrot: review: https://trac.parrot.org/parrot/changeset/37122/
06:13 masak joined #parrot
06:29 szabgab joined #parrot
06:32 tetragon joined #parrot
06:49 Theory joined #parrot
07:08 uniejo joined #parrot
07:18 Patterner joined #parrot
09:26 bacek joined #parrot
10:07 alvar joined #parrot
10:18 justin joined #parrot
10:33 dalek parrot: r37123 | cotto++ | trunk (14 files):
10:33 dalek parrot: [PMC] use ATTRs in Continuation family PMCs
10:33 dalek parrot: --This line, and those[PMC] below, will be ignored--
10:33 dalek parrot: M    src/ops/core.ops
10:33 dalek parrot: M    src/debug.c
10:33 dalek parrot: M    src/pic.c
10:33 dalek parrot: M    src/pmc/retcontinuation.pmc
10:33 dalek parrot: M    src/pmc/continuation.pmc
10:33 dalek parrot: M    src/pmc/exceptionhandler.pmc
10:33 dalek parrot: M    src/exceptions.c
10:33 dalek parrot: M    src/sub.c
10:33 dalek parrot: M    src/call/ops.c
10:33 dalek parrot: M    src/call/pcc.c
10:33 dalek parrot: M    lib/Parrot/Pmc2c/PMCEmitter.pm
10:33 dalek parrot: M    include/parrot/sub.h
10:33 dalek parrot: M    config/auto/pmc.pm
10:33 dalek parrot: M    config/gen/makefiles/root.in
10:33 dalek parrot: review: https://trac.parrot.org/parrot/changeset/37123/
10:34 cotto That's not how it's supposed to work.
10:34 cotto svn--
10:36 cotto Where I come from, there are penalties when a svn client lies.
10:39 moritz cotto: it would have worked if you didn't add the [PMC] to that line :-)
10:39 moritz I use vim to write the commit message, and the hilighting shows quite well if that line is still intact
10:39 cotto I didn't bother erasing it because I thought svn would ignore it.
10:40 moritz it seems it checks rather strictly
10:40 cotto seems so
10:40 cotto at least the commit didn't (appear to) break anything
11:37 baest joined #parrot
12:14 rob joined #parrot
12:16 rob I don't seem to be able to make squaak anymore, the root.in as changed and its now looking for everying in /usr/local/lib/parrot
12:16 rob has*
12:16 rob is some way of overriding this?
12:16 rob there*
12:33 rg1 joined #parrot
12:41 justin joined #parrot
13:19 Infinoid strange.  I created https://trac.parrot.org/parrot/report/15 so I could do the equivalent of www.parrotcode.org/openpatches.html for parrot.org, but I'm not sure I created that report in the right way.
13:19 Infinoid https://trac.parrot.org/parrot/report/9's url is preserved in the URL bar, and doesn't show the additional Filters and Columns widgets that report 15 does
13:20 Infinoid (I'm also not sure it's a problem... just a curiosity.)
13:31 Infinoid Also, "make html"'s output is missing some files.  It doesn't seem to be generating docs/project/cage_cleaners_guide.pod.html, others may be missing as well.
13:33 Coke make html probably suffers from the same thing that plagued parrotcode.org
13:33 Coke (manual tracking of files.)
13:34 Infinoid I'll see what I can fix after work today, and take a stab at TT #402 as well
13:34 Coke does 402 make sense ?
13:34 Infinoid Yeah, seems simple and useful.
13:36 Infinoid I think the best place for it is probably to put a "Parrot 0.9.1 »" prefix before the file path (the "Contents » PMCs » Abstract root class" stuff)
13:36 Infinoid or maybe to just replace "Contents" with that.
13:38 Infinoid If I end up checking anything in, I'll apply the same patch to 0.9.1 and send you a tarball of its output
13:44 Coke eh. we don't have to retrofit 0.9.1;
13:44 Coke 1.0 will be here soon enough.
13:44 Coke perhaps I can setup your cron job.
13:48 Infinoid well, my roadmap item is on the list of stuff for 1.0, so I'd prefer to get it done before 1.0 hits :)
13:51 Tene joined #parrot
13:59 gryphon joined #parrot
14:04 dalek parrot: r37124 | Infinoid++ | trunk (3 files):
14:04 dalek parrot: [pmc] Un-TODO the PackfileDirectory.set_pmc_keyed_str test
14:04 dalek parrot: This is a modified version of add_packfile_segment.patch from chromatic++'s
14:04 dalek parrot: post on 2009-02-20 to the parrot-dev list.  I've made some additional
14:04 dalek parrot: initializer fixes to get it working.
14:04 dalek parrot: review: https://trac.parrot.org/parrot/changeset/37124/
15:07 ron joined #parrot
15:38 NotFound left #parrot
15:39 NotFound joined #parrot
15:39 NotFound hi
15:42 Theory joined #parrot
16:03 nopaste "NotFound" at 213.96.228.50 pasted "pbc_chekcer.cpp - now dump fixups and constants" (560 lines) at http://nopaste.snit.ch/15780
16:03 dalek parrot: r37125 | coke++ | failed to fetch changeset:
16:03 dalek parrot: [t] pass t/examples/streams.t again
16:03 dalek parrot:  -  try to future proof with a warning in the file that it uses.
16:03 dalek parrot: review: https://trac.parrot.org/parrot/changeset/37125/
16:08 dalek parrot: r37126 | coke++ | trunk (2 files):
16:08 dalek parrot: [docs] update the verbiage slightly.
16:08 dalek parrot: review: https://trac.parrot.org/parrot/changeset/37126/
16:17 * Coke wonders why the example tests are mucking with parrot options.
16:17 Coke if we care about running the examples tests under multiple cores, we should do that in "fulltest".
16:30 particle1 well, benchmark tests muck with parrot options to run quicker
16:30 Tene joined #parrot
16:30 particle1 it's possible some examples tests followed that meme
16:30 particle1 or, that they were set up that way as a 'sanity' test for other runcores
16:36 justin joined #parrot
16:41 Coke particle1: none of which are good reasons to keep them this way. =-)
16:42 Coke I will probably rip out the runcore twiddling from the examples tests and instead add the examples_tests to a fulltest run through each core.
16:42 Coke (but if you run, say, 'testj')
16:42 Coke *not if
16:47 particle1 better.
16:51 dalek parrot: r37127 | Util++ | trunk/docs/book/ch09_pct.pod:
16:51 dalek parrot: [book] Correction - Property "pasttyle" is really "pasttype"
16:51 dalek parrot: review: https://trac.parrot.org/parrot/changeset/37127/
16:59 dalek parrot: r37128 | Util++ | trunk/docs (5 files):
16:59 dalek parrot: [docs] Typos
16:59 dalek parrot: review: https://trac.parrot.org/parrot/changeset/37128/
17:11 NotFound I'm starting to think that both implementation and documentation of pbc file formar are wrong.
17:15 mikehh joined #parrot
17:22 mikehh wrt TT#405 - ok builds with --optimize om Kubuntu Intrepid AMD64 - first time I have managed that
17:22 mikehh running make test now
17:26 mikehh oI got 3 tests failed and 1 TODO passed with 11701 tests
17:29 dalek rakudo: fe2bc86 | pmichaud++ | docs/spectest-progress.csv:
17:29 dalek rakudo: spectest-progress.csv update: 317 files, 7121 passing, 0 failing
17:29 dalek rakudo: review: http://github.com/rakudo/rakudo/commit/f​e2bc8646f1fd0f771df8617724a97f110a3b633
17:29 shorten dalek's url is at http://xrl.us/beifcc
17:31 GeJ joined #parrot
17:55 rdice joined #parrot
18:04 barney joined #parrot
18:36 Psyche^ joined #parrot
18:42 bacek joined #parrot
18:45 dalek parrot: r37129 | rurban++ | trunk (2 files):
18:45 dalek parrot: [core] TT #405 fix amd64 --optimize
18:45 dalek parrot: patch idea by andy dougherty, tested ok 2x
18:45 dalek parrot: review: https://trac.parrot.org/parrot/changeset/37129/
18:57 dalek parrot: r37130 | rurban++ | trunk/config (2 files):
18:57 dalek parrot: [config] TT #364 no 8byte ptr_alignment for Sparc64/solaris
18:57 dalek parrot: - add -xmemalign=4s to hints
18:57 dalek parrot: - On 8-byte ptr_alignment we cannot read 4-byte pbc's.
18:57 dalek parrot:   Warn the user about it
18:57 dalek parrot: review: https://trac.parrot.org/parrot/changeset/37130/
18:58 rurban joined #parrot
19:06 rg1 rurban: thanks for the hints patch. the comment "# Don't know how to do this for gcc." (i guess you copied it from the -xlibmieee) is not quite correct. "don't need this on gcc" or "gcc always emulates bad aligned access" would be more correct
19:07 NotFound What's the commit message prefix for packfile related things? [pbc] ?
19:07 rurban why not, I used core I think
19:08 rurban rg: the gcc comment is just copy paste from someone else
19:08 rg1 that's what i thought. would you mind to change it?
19:09 rurban but thanks for gcc update. what's the gcc ptr_alignment on the UltraSparc? 1 or 2 or 4?
19:09 rg1 good question. i'll need a moment to check.
19:13 dalek parrot: r37131 | NotFound++ | trunk/src/packfile.c:
19:13 dalek parrot: [pbc] avoid duplicating filename string constant for each debug mapping
19:13 dalek parrot: review: https://trac.parrot.org/parrot/changeset/37131/
19:16 rg1 hmm it says 8 bytes?!
19:17 rurban not good.
19:18 dalek parrot: r37132 | rurban++ | trunk/lib/Parrot/Harness/Smoke.pm:
19:18 dalek parrot: [t] TT #323 better smoke reports, html and smolder
19:18 dalek parrot: - list locally modified files
19:18 dalek parrot: - report the branch
19:18 dalek parrot: - rename sun4 to sparc on smolder (TT #396)
19:18 dalek parrot: - add the 32/64 bit suffix to the cpuarch (TT #396)
19:18 dalek parrot: - better gcc detection and print msvc version
19:18 dalek parrot: review: https://trac.parrot.org/parrot/changeset/37132/
19:18 rurban does it pass the t/native_pbc tests? you probably have to run mk_native_pbc --noconf because PBC_COMPAT changed again
19:19 rg1 for its own arch? it did last time i checked
19:20 moritz (whoever fixed --optimize on amd64)++
19:20 rg1 ok, now that you also fixed smolder reporting i'm running out of excuses not to also run smolder tests on the sparc ;)
19:20 rg1 moritz: well they really just worked around it ;)
19:21 rurban rgl: good
19:21 rurban moritz: it was andy dougherty. I just cleaned it up a bit.
19:21 moritz rg1: I can't say I care too much. My rakudo now runs noteably faster, that's forth a ++ any day
19:21 rurban -j -O2 is broken and gets no test coverage, -O1 neither
19:22 rurban implementing freeze_size will make parrot even more faster, and implementing pmc's as pir even more :)
19:23 rg what's broken?
19:23 rurban Implementing the missing non-jitted ops also
19:23 rg jit on an optimized build?
19:23 rurban -O2 assumes all ops to be jitted
19:24 mikehh rurban: building at r37132 with --optimize on AMD64 - will smoke too
19:24 rg mikehh: smoke only covers the default core
19:24 nopaste "rurban" at 93.210.224.181 pasted "improving jit optimize coverage" (14 lines) at http://nopaste.snit.ch/15786
19:25 mikehh that I know - j is not build on AMD64
19:25 rurban yes, that's a major project for the next year
19:26 mikehh just wanted to see how r37132 works
19:27 mikehh will look at i386 later
19:31 riffraff joined #parrot
19:33 dalek parrot: r37133 | rurban++ | trunk/config/gen/platform/cygwin/math.c:
19:33 dalek parrot: [core] Add cygwin fallback to correct POSIX math
19:33 dalek parrot: behaviour (for atan2) if -DSTRICT_ANSI
19:33 dalek parrot: review: https://trac.parrot.org/parrot/changeset/37133/
19:36 mikehh dalek is not very responsive - I got the email 3 minutes before (he/she/it?) posted here
19:37 dalek parrot: r37134 | rurban++ | trunk/src/pmc_freeze.c:
19:37 dalek parrot: [cage] whitespace: align comments
19:37 dalek parrot: review: https://trac.parrot.org/parrot/changeset/37134/
19:38 mikehh that was only a 1 minute delay
19:39 rg dalek is only polling the rss feed every 5 minutes (iirc)
19:40 rurban so why is t/pmc/packfile.t and t/pmc/packfilesegment.t failing on amd64? set_integer_keyed_str both
19:43 rg are you referring to those smolder reports?
19:43 rurban yes
19:43 rurban http://smolder.plusthree.com/app/​public_projects/tap_archive/18605
19:43 shorten rurban's url is at http://xrl.us/beifzr
19:44 rurban and the next one passed 100%
19:44 rg i was wondering if it's something in their setup, because i can't reproduce it and it is fine on 18601, which was the same revision as 18602
19:45 mikehh It is failing on my linux system Kubuntu Intrepid BUT seems to be passing on freebsd
19:45 rurban the failing is using --optimize the passing one not
19:45 rg 18602 has no --optimize, still failing
19:46 mikehh that was also mine
19:46 rurban I know that 64 still aligns packfiles not properly. But I'll fix that later, post-1.0
19:47 rg mikehh: are you sure your checkout is clean?
19:47 mikehh It passes on 18604 on freebsd
19:47 rg that's mine and that's why i said i can't reproduce
19:47 mikehh well I did a make realclean
19:48 rg can you check svn diff or svn status?
19:49 rurban That's why I added r37132 !
19:49 rg ok, so his latest report was at 37132.
19:50 rurban All local modifications would have been printed in the smolder report. If its a svn checkout
19:50 rg rurban: where?
19:50 mikehh svn status -> ? languages/punie-- svn diff ok
19:51 NotFound rurban: I'm starting to think that may be better to solve all packfile problems before 1.0
19:51 rurban rg: in the header. see http://smolder.plusthree.com/app/pu​blic_projects/report_details/18536
19:51 shorten rurban's url is at http://xrl.us/beif26
19:51 rurban NotFound: But I have no 64bit to test :(
19:51 rg rurban: ah. nice :)
19:52 NotFound rurban: that's a problem, certainly.
19:52 rg so it's possible to simply add headers?
19:52 rurban But I can produce a shorter patch to etst, smaller that the one in my ticket TT #254
19:52 rurban rg: sure
19:53 rg i'd really like to have the possibility to add a reporter header. or the login and/or machine name.
19:53 rurban good idea! in one line please.
19:53 rurban username@machine
19:54 rg something like that.
19:54 purl i think something like that. is that true?
19:55 rurban just see https://trac.parrot.org/parrot/attach​ment/ticket/323/tt323-submitter.patch
19:55 shorten rurban's url is at http://xrl.us/beif3k
19:59 mikehh I am also getting a TODO passed in t/pmc/exception.t
19:59 purl okay, mikehh.
19:59 mikehh ok 30 - catch ex from C-level MULTI function # TODO broken
20:00 contingencyplan joined #parrot
20:01 rurban that could be because of the new -O2 in the gc
20:02 rg mikehh: what's your compiler? can you do a cc --version?
20:03 nopaste "NotFound" at 213.96.228.50 pasted "pbc_chekcer.cpp - updated" (633 lines) at http://nopaste.snit.ch/15787
20:04 rurban_ joined #parrot
20:05 mikehh cc (Ubuntu 4.3.2-1ubuntu12) 4.3.2
20:05 dalek parrot: r37135 | fperrad++ | trunk/config/gen/makefiles/languages.in:
20:05 dalek parrot: punie is gone
20:05 dalek parrot: review: https://trac.parrot.org/parrot/changeset/37135/
20:07 rg notfound: i'm getting '  135FAILED: Error reading directory segment' when running it against pbc_to_exe.pbc
20:07 dalek pipp: 6181f54 | (Bernhard Schmalhofer)++ | build/templates/ (2 files):
20:07 dalek pipp: Check dependencies for src/pmc/pipp_group.so
20:07 dalek pipp: review: http://github.com/bschmalhofer/pipp/commit​/6181f54c5bef3c8bc139fa7e3056c5b778ebbf1b
20:07 shorten dalek's url is at http://xrl.us/beif5p
20:08 NotFound rg: What platform?
20:08 rg notfound: freebsd/amd64
20:08 NotFound rg: Can you send me the file?
20:09 rg sure, where to?
20:09 dalek parrot: r37136 | fperrad++ | trunk/languages/lisp (4 files):
20:09 NotFound rg: look for Julian Albo in CREDITS
20:09 dalek parrot: [lisp] update PIR syntax :
20:09 dalek parrot: - replace store/find_global by set/get_global
20:09 dalek parrot: - problem when the namespace is a variable
20:09 dalek parrot: review: https://trac.parrot.org/parrot/changeset/37136/
20:11 rg on it's way
20:12 NotFound rg: received, thanks
20:14 rg does anyone else use gcc 4.3.x?
20:14 NotFound 4.3.2 here
20:14 rg (preferably on a 64bit platform)
20:14 moritz 4.3.2 on amd64 here
20:14 NotFound linux i386
20:15 rg moritz: are you seeing the same packfile failures as mikehh?
20:15 moritz rg: I didn't pay attention... 'make test' is clean as of r37131
20:15 rurban gcc-4.3.2 on cygwin here
20:16 moritz I do have some 'make fulltest' failures (build with --optimize)
20:17 rg it already failed on r37128 without optimize, so it's not the compiler either.
20:18 nopaste "rurban" at 93.210.224.181 pasted "Add username to smolder also" (33 lines) at http://nopaste.snit.ch/15788
20:18 rurban that logic is from perlbug
20:18 rurban but the $^O eq 'macos' is something I don't know
20:19 rurban MacOS it is, okay
20:20 rg rurban: that's nice. what i think would be great was an override to specify a real email address. like 'Submitter'    => $ENV{"SMOLDER_SUBMITTER"} || "$me\@$domain"
20:20 mikehh I got them on r37128 and r r37132 with or without --optimize
20:21 rg i'd also use my $domain = 'unknown';
20:21 Coke macos is not supported. =-)
20:21 Coke (that's pre- OS X)
20:21 rurban ok.
20:22 dalek parrot: r37137 | rurban++ | trunk/lib/Parrot/Harness/Smoke.pm:
20:22 dalek parrot: [t] TT #323 also add Submitter to smolder (less privacy)
20:22 dalek parrot: review: https://trac.parrot.org/parrot/changeset/37137/
20:22 nopaste "NotFound" at 213.96.228.50 pasted "pbc_chekcer.cpp - fix" (634 lines) at http://nopaste.snit.ch/15789
20:22 Coke nor do we support os2.
20:22 mikehh both failures I got were with set_integer_keyed_str - received: Aborted expected not-equal
20:23 mikehh not equal -- Exited with error code: 134
20:23 NotFound rg: I think that fixes the problem
20:24 rg so .. no override i guess
20:24 NotFound rurban: this pbc_checker shows some problems with alignment, and does not match several things in pdd13
20:25 rurban NotFound: which checker?
20:25 NotFound My lasr nopaste
20:25 NotFound last
20:25 rurban I lost my net for a minute...
20:26 rurban http://nopaste.snit.ch/15787 got it
20:26 NotFound http://nopaste.snit.ch/15789
20:26 rg notfound: next "bug": when i run it on t/native_pbc/number_4.pbc i get "FAILED: Unimplemented" ;)
20:26 NotFound rg: not a bug, is a feature ;)
20:26 rg (same for number_1.pbc for that matter)
20:27 isop joined #parrot
20:27 NotFound rg: floating point constants are not yet readed.
20:28 rg ok, i'm just testing ;)
20:29 rg mikehh: i'm running out of ideas what could be causing your failures.
20:30 mikehh I have had a couple of wierd things happenibg on this computer recently
20:32 mikehh I am going to reboot into i386 and see if I have any problems there
20:32 rurban mikehh: cannot just use --m=32 to Configure.pl?
20:33 rg rurban: i don't think that's going to work
20:34 dalek parrot: r37138 | rurban++ | trunk/lib/Parrot/Harness/Smoke.pm:
20:34 dalek parrot: [t] TT #323 one more smolder optimization
20:34 dalek parrot: - MacOS and os2 not supported.
20:34 dalek parrot: - default domain "unknown"
20:34 mikehh I could but I am trying to test on different platfprms - today was the first time I managed to get an --optimize to build
20:34 dalek parrot: review: https://trac.parrot.org/parrot/changeset/37138/
20:35 mikehh on AMD64 and the failures seem to be consistant
20:35 rg mikehh: but it seems you're the only one who's seeing them
20:35 mikehh with or without --optimize
20:36 mikehh as I said some weird things - maybe I should try Suse 11.1
20:37 mikehh I have some free boot partitions but had problems with the wireless connection with Suse 11.0
20:38 Coke ooh. I just thought of an interesting mini project. yah.
20:38 rurban we also have the new buildbot on amd64 http://buildbot.eigenstate.net:8040/
20:39 rurban and this fedora amd64 also passes all packfile tests
20:42 nopaste "NotFound" at 213.96.228.50 pasted "pbc_chekcer.cpp - skip number constants" (661 lines) at http://nopaste.snit.ch/15790
20:43 NotFound rg: "feature" disabled ;)
20:43 mikehh I am going to see if I can track it down - but later - I need some sleep before I do something realy stupid
20:43 mikehh really
20:43 rg notfound: ah, don't disable it on my account ;)
20:44 rg notfound: i hope you're documenting all the differences between spec and reality you're finding
20:45 NotFound rg: I'm still thinking if is better to document it or change the reality
20:45 rurban NotFound: This huge PMC starting with '\xfePBC\x0d\x0a\x1a is the interpreter pmc
20:46 NotFound rurban: No need to check that, I think, showing the stringfied version is enough.,
20:46 rg i'd decide that on a case by case basis, whatever is considered "better"
20:47 rurban But this bugger causes the most headaches, so its worthy to name it in your tool, if you want to
20:47 NotFound rg: better IMO is to have a comprehensible specification without lots of special cases.
20:47 rurban it's the hack to pass the pf->header down to freeze only.
20:48 rurban so that the freeze/thaw unpackers know the wordsize, ...
20:48 NotFound rurban: if there is a fast way to obtain that information without an interpreter, I'll do it.
20:48 rurban I'll have to talk to chromatic to get rid of this pmc
20:50 NotFound I think will be better to add pbc_check to the repo. What can be a good place? tools? examples?
20:51 rurban the other pbc utils are in src, but this looks like a example/pbc
20:51 NotFound Better in examples, I agree, given that it does not use, and must not use, the parrot infrastructure.
20:52 rurban and it's ugly c++
20:52 NotFound That's the better part ;)
20:52 rurban and it prints ugly xml
20:52 NotFound Not yet
20:52 rurban why not be consistent and convert everything to xml?
20:53 NotFound rurban: because I'm lazy ;)
20:53 rurban pbc_xml would be a good name then
20:53 rg that would be even less readable
20:53 NotFound The seudo-xml was just a fast way to mark the end of some sections.
20:54 rurban of course it's bette this way. But i'm sure the question will come up...
20:55 rg so we'll say apache does the same thing for their config ;)
20:55 NotFound I'm not interested in beauty at this point, just in identifying and maybe solving pbc format and documentation pitfalls.
20:55 rurban well, you ignu
20:55 rurban well, you ignu
20:55 NotFound I'm the beast ;)
20:55 rurban uuid_data, numbers
20:56 rurban if (pbc_version <= 0x0325 && opcode_size == 8)
20:56 rurban pbcfile.ignore(16);
20:56 rurban what is this?
20:56 purl i guess this is some kind of revenge for Dick Van Dyke's accent in Mary Poppins.
20:57 NotFound rurban: Is what make the program work.
20:57 rurban I changed that?
20:57 NotFound The pbc_version is a hope that in the future things change
20:58 rurban if so, it should advance major, not minor. I'm confused
20:59 NotFound That is one of the points I want to discuss. The change in version required if we fix the problems.
21:00 NotFound In the meantime, the 0x0325 is easily searchable.
21:00 rurban if we change the bytecode format structure which is incompatible to now we must advance major.
21:01 rurban but we didn't do that, because we have a very good format for now, which can be easily extended within major==3
21:01 NotFound Well, if the current way is wrong, surely fixing it will be incompatible.
21:01 rurban even if we change the pmc index from int to name we can still do with 3.x
21:02 rurban I believe just the readers are wrong, the writers are okay.
21:02 NotFound rurban: but fixing the alignment problems will be an icompatible change.
21:02 rurban for 64bit reading 32bit we can do better.
21:02 rurban e.g. writge everything as 8-byte, not 4-byte
21:02 rurban or use --64compat to write 64bit on a 32-bit parrot
21:03 rurban or use the alignment relaxment as now. it's just an optimization, nothing serious
21:04 rg with all that discussion, i really have to ask: why the decision to use an arch-dependent bytecode format at all?
21:04 rurban for now we are safe, I believe
21:04 NotFound rurban: If we found a reasonable way, fine. I'm not interested in forcing incompatible changes.
21:04 rurban make native fast, foreign slow
21:04 rurban reading and writing native is fastest now, only reading foreign is slow
21:04 moritz why not make them all fast? ;-) (just kidding)
21:04 rg but a single pass when reading the file anyway won't really slow things down
21:05 rurban it's mmap'ed anyway.
21:05 rurban the real bottleneck is the big number of unneccessary malloc/free for the pmc sizes
21:05 NotFound rurban: first question; What is the alignment after the segment size? If I'm not making some mistake, is not the same in all segment types.
21:05 rurban esp. with perl6
21:06 rg it's always mmap'ed and number converted for every access??
21:06 rurban before and after any segment we always force 16-byte
21:06 rurban rg: every pbc's is only mmap'ed once, and number converted onyl for foreign code which needs it.
21:07 NotFound rurban: the segment start with the segment size. What is the alignment, if any, after it?
21:07 rurban native is a single run-through, even with ptr advance, much faster than byte-advance
21:07 rurban after the size, the first element alignment is lost, it's 16+wordsize
21:08 rurban we pad only at the end
21:08 rurban we only pad strings to wordsize also, the rest is native
21:08 NotFound rurban: It does not look that way in pbc_checker
21:08 rurban segment padding is 16-bytes though
21:08 rurban because you are skipping some parts
21:09 NotFound rurban: Then we must identify and document that parts.
21:09 rurban you have to turn around the padding section in all your functions to pad at the end, not at the beginning
21:11 NotFound rurban: the paddings insertd is what makes it work.
21:11 rurban yes, because the padded end of the first, is the beginning if the next. this is where you pad.
21:12 NotFound rurban: dump_segment starts by positioning the file pointer at the start of the segment
21:12 rurban ok, I'll rewrite it
21:12 NotFound pbcfile.seekg(entry.getOffset() * opcode_size);
21:14 rurban NotFound: did you try that on 64bit and 32bit?
21:15 NotFound rurban: yes, that is the reason of the if opcode_size == 8
21:15 rurban and what did I change in 3.25 writing?
21:16 rurban chromatic will kill me
21:16 NotFound rurban: I don't know, probably in older version several of this problems already existed.
21:17 NotFound Or was worse
21:18 rurban your logic is not pdd13 compliant
21:18 rurban but it works, so there's a flaw somewhere
21:18 NotFound rurban: yes, that is one of the problems
21:18 dalek parrot: r37139 | fperrad++ | trunk/docs/book (2 files):
21:18 dalek parrot: [book] cleanups, apply patch from TT #404.
21:18 dalek parrot: review: https://trac.parrot.org/parrot/changeset/37139/
21:18 rurban good, maybe it was really the writer which was broken.
21:19 NotFound I wrote it with a mix of pdd13 reading and inverseengineerig
21:19 particle1 pbc isn't pdd13-compliant
21:19 moritz should it be? or should pdd13 be pbc-compliant?
21:19 rurban particle: I believe not. what is wrong?
21:19 rurban cross-version is just not possible this way, yes
21:19 NotFound particle1: we must fix pdd13, the pbc reading/writing, or both.,
21:20 particle1 the pdd hasn't been (fully) implemented yet
21:20 particle1 it's still the future spec, not current.
21:20 rurban just the full pmc access, yes
21:20 rurban but the format is fixed. uuid_data check is missing, yes
21:20 particle1 infinoid and jonathan have done some work on the implementation, but i don't know what remains
21:20 rg t/op/lexicals.t suggests there's still some things missing
21:21 rurban some parts of pmc methods are missing
21:21 NotFound particle1: that is the point. We must know what we are doing.
21:21 particle1 yes, agreed. so email infinoid, jonathan, and the list with questions.
21:21 rurban I tried hard not to touch the writer in any way.
21:22 rurban I can byte-compare the pbcs before and after
21:22 mikehh joined #parrot
21:22 rurban or use pbc_checker and pbc_dump
21:22 NotFound The main question is: must we fix this mess before 1.0?
21:23 mikehh at least the i386 build seems ok
21:23 rurban I don't think so. just 64bit cannot read 32bit
21:23 rurban because the ALIGN_16 logic is wrong
21:24 rurban I didn't want to touch that pre-1.0
21:24 rurban it's only used for reading
21:24 NotFound rurban: yeah, but trying to fix platform interoperability without doing some cleaning before can be a nightmare.
21:25 rurban I'll analyze your code...
21:25 NotFound rurban: I'm sorry for the c++, but is the language with I can do that type of things fast,
21:26 rurban I wonder if we really should add this logic to the reader...
21:26 rg i don't think we need to get there for 1.0. we only need a big note saying 1.0 bytecode is neither portable nor forward compatible
21:26 rurban It's quite portable with some bugs
21:27 rurban but it's not cross-version portable at all.
21:28 NotFound rg: Well, in that case will be better to stop worrying and losing time on the issue.
21:28 rurban cross-PBC_COMPAT portable it means. 1.0.1 can read 1.0 code of course. 1.1 maybe also.
21:28 NotFound That was really the big question.
21:28 rurban it just depends on changing the ops interfaces and pmc deprecations,
21:29 rurban we already promides that pmc deprecations will not happen after 1.0, in the pbc format
21:29 rurban promised
21:29 rurban so the pmc indices are fixed, and new ones get added at the end
21:30 rurban and old ones keep staying there, even if deprecated
21:30 NotFound rurban: but the current problem has nothing to do with adding or deprecating features, is on fixing or clarifying some problems.
21:30 rurban yes, for 64bit
21:31 NotFound rurban: I'm not sure is just for 64
21:31 NotFound Look at the first lines of PbcFile::dump_segment_pir_debug
21:32 rurban since we cannot read <3.25 anyway (pmc deprecations), we dont need to use your logic in the actual code
21:32 NotFound Theres is a ignore(8) that I don't understand what is needed.
21:33 NotFound rurban: 0x325 is not 3.25, is just major/minor together in hex
21:33 Infinoid NotFound: hi
21:33 purl hello, Infinoid.
21:33 NotFound purl: you are not my agent
21:33 purl ...but purl is a she. or captain obvious or so corny sometimes or creepy or a he or is also is also is also or retarded or NOT STEVAN or kd's quotefile|<reply>i am funny|<reply>My mother's name is Eliza...
21:33 rurban sorry, its 3.37 then
21:34 particle1 joined #parrot
21:34 rurban yes, with 3.37 I changed a padding macro for the reader
21:34 Infinoid NotFound: the Bytecode PMC API is mostly implemented in read-only mode, as a layer on top of the src/packfile.c implementation
21:34 Infinoid everything is there according to pdd13 except for the new annotations stuff, which does not match pdd13 and thus the spec needs to be updated
21:35 Infinoid very little of the write code is there yet.  I did commit one of chromatic's patches to implement one of the write functions, this morning
21:35 NotFound Infinoid: the program I wrote does not use any parrot code, just read the pbc in the lowest level to check the specification.
21:36 Infinoid I was just describing the state of the pdd13 implementation work done so far.  what's this you're working on?
21:36 NotFound Well, to check something, I'm not sure what.
21:37 NotFound Infinoid: http://nopaste.snit.ch/15790
21:38 Infinoid ok, so you're running into issues where the files don't match the spec?
21:38 rurban No, he found the 64bit bug.
21:39 Infinoid jonathan++ would know more about spec stuff than I... I've just been exposing the internal API as PMCs
21:39 NotFound Infinoid: What I'm doing is looking at what must be done to read pbc files, and checking if the result match the docs.
21:40 particle1 would somebody assign jonathan a 1.0 milestone ticket to update pdd13 wrt annotations?
21:41 NotFound In fact the other way, reading the specs and found where they don't match reality.
21:42 rurban we should rather fix the writer than, and not the spec.
21:42 rurban the spec is sound.
21:42 NotFound I'm still not sure.
21:44 NotFound The PIR debug section description is not clear, and does not match reality.
21:44 rurban so we a problem with the debug segment writer, right?
21:45 NotFound Writer and reader, I suppose,
21:46 rurban Looks like a wrong debug segment padding. or rather of the segment before
21:46 rurban well, something to do for tomorrow
21:47 NotFound rurban: pbc_checker starts reading at segment's offset. If there is a flaw in padding, is also in the directory.
21:51 rurban okay, rephrasing: before bc 3.37 the 64bit writer was wrong, it added a wrong 16 skip.
21:51 rurban this did not match the pdd13
21:53 rg so for one we should only be testing with current pbc files, right?
21:53 rurban We only can, we cannot read older or newer pbcs anyway
21:54 rurban for now
21:54 rurban because the pmc's and ops are indexed by number
21:55 rurban from 1.0 on we should be able to read older pbc's though.
21:57 rg well for notfound's reader it wouldn't matter that much, but if the whole structure changed that's a different thing.
21:58 particle1 is the reader written in pir?
21:58 particle1 nqp?
21:58 purl rumour has it nqp is not quite perl (6) or http://svn.perl.org/parrot/trunk/compilers/nqp
21:58 NotFound The checker can be adapted, is just a helper tool
21:58 Infinoid particle1: C++, http://nopaste.snit.ch/15790
22:02 NotFound particle1: my idea was to make it completely out of parrot, to be free of inadverted assumptions.
22:05 nopaste "rurban" at 93.210.224.181 pasted "post1.0-pf-logic.patch" (42 lines) at http://nopaste.snit.ch/15791
22:07 rurban notfound proved that the padding changed
22:07 rurban for 64bit only
22:11 skv joined #parrot
22:14 GeJ Good morning everyone
22:33 rurban Okay, TT #407 tt407-post1.0-pf-logic.patch reflects the PBC_COMPAT policy change
22:37 dalek parrot: r37140 | NotFound++ | trunk (4 files):
22:37 dalek parrot: [examples] add pbc_checker tool
22:37 dalek parrot: review: https://trac.parrot.org/parrot/changeset/37140/
22:40 cotto rurban, do you have a link to the rejected patch you mentioned in TT #401?
22:41 cotto (or the thread where you submitted it)
22:42 rurban it was in the pdd30install_stage3 branch which got deleted. I'll attach it to the ticket
22:43 bacek joined #parrot
22:44 cotto Thanks.
22:47 rurban_ joined #parrot
22:49 rurban cott, here they are, in random order. TT#97 and TT #101
22:50 cotto rurban++
22:51 rurban that's wy I got angry at allison when she single-handed rejected about 30 of my tickets and patches
22:54 rurban RT#40817 "track all generated files" was also finished. I have no time for that now
23:05 allison rurban: I did explain why they weren't applied at the time, and what you needed to do to get them ready to be applied
23:06 rurban sure, but it was a lot of work, and it much more work now to rearrange the patches
23:07 rurban same goes for the library.c changes
23:13 dalek rakudo: e47c348 | pmichaud++ | src/parser/actions.pm:
23:13 dalek rakudo: Default lexicals as Perl6Scalar instead of Failure.
23:13 dalek rakudo: review: http://github.com/rakudo/rakudo/commit/e​47c348771d2372384b57b8b2645aa02f03533fe
23:13 shorten dalek's url is at http://xrl.us/beigzw
23:18 bacek joined #parrot
23:19 cognominal joined #parrot
23:22 allison rurban: the library.c changes are done, but slightly differently
23:26 allison hmmm.... maybe we could use a "philosophy of code review" document in docs/project...
23:27 Infinoid hooray for code review
23:28 cotto (code review)++
23:30 dalek parrot: r37141 | NotFound++ | trunk/examples/tools/pbc_checker.cpp:
23:30 dalek parrot: [examples] spell fix and cosmetic changes
23:30 dalek parrot: review: https://trac.parrot.org/parrot/changeset/37141/
23:37 NotFound joined #parrot

| Channels | #parrot index | Today | | Search | Google Search | Plain-Text | summary

Parrot | source cross referenced