Perl 6 - the future is here, just unevenly distributed

IRC log for #parrot, 2014-11-10

Parrot | source cross referenced

| Channels | #parrot index | Today | | Search | Google Search | Plain-Text | summary

All times shown according to UTC.

Time Nick Message
00:20 janus joined #parrot
01:00 kurahaupo joined #parrot
01:30 kid51 joined #parrot
02:50 kurahaupo joined #parrot
04:48 particle1 joined #parrot
07:23 FROGGS joined #parrot
08:25 bighugedog joined #parrot
08:53 mirjam joined #parrot
08:59 rurban Do we have a policy for translated error messages? I see some _() strings
09:00 rurban I'll remove the ones I added. Doesn't sound needed, and adds a call in the exception chain
10:39 kurahaupo joined #parrot
11:20 kurahaupo joined #parrot
12:44 dalek parrot/smoke-me/array-splice-gh766+1126+1127: ec7e1ac | rurban++ | src/pmc/ (3 files):
12:44 dalek parrot/smoke-me/array-splice-gh766+1126+1127: [pmc] fix splice overflows with negative count
12:45 dalek parrot/smoke-me/array-splice-gh766+1126+1127:
12:45 dalek parrot/smoke-me/array-splice-gh766+1126+1127: Fixes GH #766.
12:45 dalek parrot/smoke-me/array-splice-gh766+1126+1127: Throw illegal argument with negative count arguments for now.
12:45 dalek parrot/smoke-me/array-splice-gh766+1126+1127:
12:45 dalek parrot/smoke-me/array-splice-gh766+1126+1127: TODO: Implement support for negative count argument for splice.
12:45 dalek parrot/smoke-me/array-splice-gh766+1126+1127: Add more splice methods.
12:45 dalek parrot/smoke-me/array-splice-gh766+1126+1127: review: https://github.com/parrot/parrot/commit/ec7e1ac62d
12:45 dalek parrot/smoke-me/array-splice-gh766+1126+1127: d36da0f | rurban++ | / (22 files):
12:45 dalek parrot/smoke-me/array-splice-gh766+1126+1127: [pmc] harmonize and combine out of bounds exception strings
12:45 dalek parrot/smoke-me/array-splice-gh766+1126+1127:
12:45 dalek parrot/smoke-me/array-splice-gh766+1126+1127: use less static string memory. no special context.
12:45 dalek parrot/smoke-me/array-splice-gh766+1126+1127: Use only "illegal argument" for unsupported negative arguments.
12:45 dalek parrot/smoke-me/array-splice-gh766+1126+1127: GH #1126
12:45 dalek parrot/smoke-me/array-splice-gh766+1126+1127:
12:45 dalek parrot/smoke-me/array-splice-gh766+1126+1127: * index out of bounds,
12:45 dalek parrot/smoke-me/array-splice-gh766+1126+1127: * illegal argument (for illegal negative args),
12:45 dalek parrot/smoke-me/array-splice-gh766+1126+1127: * can't resize (for fixed*pmcs or size=0 arguments)
12:45 dalek parrot/smoke-me/array-splice-gh766+1126+1127: * StopIteration
12:45 dalek parrot/smoke-me/array-splice-gh766+1126+1127: review: https://github.com/parrot/parrot/commit/d36da0fdde
12:45 dalek parrot/smoke-me/array-splice-gh766+1126+1127: 054781d | rurban++ | / (25 files):
12:45 dalek parrot/smoke-me/array-splice-gh766+1126+1127: More error message harmonization  #1126
12:45 dalek parrot/smoke-me/array-splice-gh766+1126+1127:
12:45 dalek parrot/smoke-me/array-splice-gh766+1126+1127: Do not end the exception string with ".", "!" or "\n".
12:45 dalek parrot/smoke-me/array-splice-gh766+1126+1127: review: https://github.com/parrot/parrot/commit/054781d977
12:45 dalek parrot/smoke-me/array-splice-gh766+1126+1127: d079d16 | rurban++ | / (9 files):
12:45 dalek parrot/smoke-me/array-splice-gh766+1126+1127: [pmc] allow negative array key indices
12:45 dalek parrot/smoke-me/array-splice-gh766+1126+1127:
12:45 dalek parrot/smoke-me/array-splice-gh766+1126+1127: Fixes GH #1127
12:45 dalek parrot/smoke-me/array-splice-gh766+1126+1127: currently we throw "index out of bounds" when getting or setting $P0[-1]
12:45 dalek parrot/smoke-me/array-splice-gh766+1126+1127: the added code is only:
12:45 dalek parrot/smoke-me/array-splice-gh766+1126+1127:         if (key < 0)
12:45 dalek parrot/smoke-me/array-splice-gh766+1126+1127:             key += size;
12:45 dalek parrot/smoke-me/array-splice-gh766+1126+1127: so it is hard to argue for performance reasons.
12:45 dalek parrot/smoke-me/array-splice-gh766+1126+1127: ditto for resizable*array for consistency if not already implemented.
12:45 dalek parrot/smoke-me/array-splice-gh766+1126+1127: review: https://github.com/parrot/parrot/commit/d079d16e11
12:45 dalek parrot/smoke-me/array-splice-gh766+1126+1127: 3ca4d64 | rurban++ | t/ (14 files):
12:45 dalek parrot/smoke-me/array-splice-gh766+1126+1127: [test] change array tests to new harmonized out of bounds exceptions
12:45 dalek parrot/smoke-me/array-splice-gh766+1126+1127: review: https://github.com/parrot/parrot/commit/3ca4d6486a
12:45 dalek parrot/smoke-me/array-splice-gh766+1126+1127: dc140f1 | rurban++ | t/stress/gc.t:
12:45 dalek parrot/smoke-me/array-splice-gh766+1126+1127: t/stress/gc.t doc
12:45 dalek parrot/smoke-me/array-splice-gh766+1126+1127: review: https://github.com/parrot/parrot/commit/dc140f13f2
12:45 dalek parrot/smoke-me/array-splice-gh766+1126+1127: 6839b09 | rurban++ | ChangeLog:
12:45 dalek parrot/smoke-me/array-splice-gh766+1126+1127: ChangeLog for the 3 array changes
12:45 dalek parrot/smoke-me/array-splice-gh766+1126+1127: review: https://github.com/parrot/parrot/commit/6839b09c6c
12:55 dalek parrot/smoke-me/bsdmake-gh1125: f38599d | rurban++ | config/gen/makefiles/docs.in:
12:55 dalek parrot/smoke-me/bsdmake-gh1125: [docs] fix $< gnuism in docs makefile
12:55 dalek parrot/smoke-me/bsdmake-gh1125:
12:55 dalek parrot/smoke-me/bsdmake-gh1125: Fixes GH #1125
12:55 dalek parrot/smoke-me/bsdmake-gh1125: review: https://github.com/parrot/parrot/commit/f38599d5b3
13:01 travis-ci joined #parrot
13:01 travis-ci parrot/parrot#1247 (smoke-me/array-splice-gh766+1126+1127 - 6839b09 : Reini Urban): The build passed.
13:01 travis-ci Change view : https://github.com/parrot/p​arrot/compare/ec7e1ac62d0c^...6839b09c6c8e
13:01 travis-ci Build details : http://travis-ci.org/parrot/parrot/builds/40536010
13:01 travis-ci left #parrot
13:12 travis-ci joined #parrot
13:12 travis-ci parrot/parrot#1248 (smoke-me/bsdmake-gh1125 - f38599d : Reini Urban): The build passed.
13:12 travis-ci Change view : https://github.com/parrot/​parrot/commit/f38599d5b3df
13:12 travis-ci Build details : http://travis-ci.org/parrot/parrot/builds/40537043
13:12 travis-ci left #parrot
13:21 dalek parrot: 3f902ac | rurban++ | / (2 files):
13:21 dalek parrot: [docs] fix $< gnuism in docs makefile
13:21 dalek parrot:
13:21 dalek parrot: Fixes GH #1125
13:21 dalek parrot: review: https://github.com/parrot/parrot/commit/3f902acbfd
13:40 travis-ci joined #parrot
13:40 travis-ci parrot/parrot#1249 (master - 3f902ac : Reini Urban): The build passed.
13:40 travis-ci Change view : https://github.com/parrot/parrot/c​ompare/a03cfa0a2fd8...3f902acbfd02
13:40 travis-ci Build details : http://travis-ci.org/parrot/parrot/builds/40539263
13:40 travis-ci left #parrot
13:43 dalek parrot: bb36c3c | rurban++ | src/runcore/trace.c:
13:43 dalek parrot: trace: better array traces, print size also
13:43 dalek parrot: review: https://github.com/parrot/parrot/commit/bb36c3cafc
13:43 dalek parrot: b6a87f1 | rurban++ | / (3 files):
13:43 dalek parrot: [test] t/stress/rpa-splice.t: reproducible testcases for GH #766
13:43 dalek parrot:
13:43 dalek parrot: with asan:
13:43 dalek parrot: t/stress/rpa-splice.t (Wstat: 10752 Tests: 225 Failed: 42)
13:43 dalek parrot:   Failed tests:  11-12, 16, 36-37, 41, 61-62, 66, 81-82
13:43 dalek parrot:                 86-87, 91, 106-107, 111-112, 116, 131-132
13:43 dalek parrot:                 136-137, 141, 151-152, 156, 161-162, 166
13:43 dalek parrot:                 176-177, 181, 186-187, 191, 201-202, 206
13:43 dalek parrot:                 211-212, 216
13:43 dalek parrot: review: https://github.com/parrot/parrot/commit/b6a87f1e5c
13:43 dalek parrot: 441b785 | rurban++ | lib/Parrot/Test.pm:
13:43 dalek parrot: [test] less verbose exit_code test. check $ENV{TEST_VERBOSE}
13:43 dalek parrot: review: https://github.com/parrot/parrot/commit/441b785de7
13:43 dalek parrot/smoke-me/array-splice-gh766+1126+1127: f898fa5 | rurban++ | src/pmc/ (3 files):
13:43 dalek parrot/smoke-me/array-splice-gh766+1126+1127: [pmc] fix splice overflows with negative count
13:43 dalek parrot/smoke-me/array-splice-gh766+1126+1127:
13:43 dalek parrot/smoke-me/array-splice-gh766+1126+1127: Fixes GH #766.
13:43 dalek parrot/smoke-me/array-splice-gh766+1126+1127: Throw illegal argument with negative count arguments for now.
13:43 dalek parrot/smoke-me/array-splice-gh766+1126+1127:
13:43 dalek parrot/smoke-me/array-splice-gh766+1126+1127: TODO: Implement support for negative count argument for splice.
13:43 dalek parrot/smoke-me/array-splice-gh766+1126+1127: Add more splice methods.
13:43 dalek parrot/smoke-me/array-splice-gh766+1126+1127: review: https://github.com/parrot/parrot/commit/f898fa5efb
13:43 dalek parrot/smoke-me/array-splice-gh766+1126+1127: 7de5a35 | rurban++ | / (22 files):
13:43 dalek parrot/smoke-me/array-splice-gh766+1126+1127: [pmc] harmonize and combine out of bounds exception strings
13:43 dalek parrot/smoke-me/array-splice-gh766+1126+1127:
13:43 dalek parrot/smoke-me/array-splice-gh766+1126+1127: use less static string memory. no special context.
13:43 dalek parrot/smoke-me/array-splice-gh766+1126+1127: Use only "illegal argument" for unsupported negative arguments.
13:43 dalek parrot/smoke-me/array-splice-gh766+1126+1127: GH #1126
13:43 dalek parrot/smoke-me/array-splice-gh766+1126+1127:
13:43 dalek parrot/smoke-me/array-splice-gh766+1126+1127: * index out of bounds,
13:43 dalek parrot/smoke-me/array-splice-gh766+1126+1127: * illegal argument (for illegal negative args),
13:44 dalek parrot/smoke-me/array-splice-gh766+1126+1127: * can't resize (for fixed*pmcs or size=0 arguments)
13:44 dalek parrot/smoke-me/array-splice-gh766+1126+1127: * StopIteration
13:44 dalek parrot/smoke-me/array-splice-gh766+1126+1127: review: https://github.com/parrot/parrot/commit/7de5a35bac
13:44 dalek parrot/smoke-me/array-splice-gh766+1126+1127: df59cb2 | rurban++ | / (25 files):
13:44 dalek parrot/smoke-me/array-splice-gh766+1126+1127: More error message harmonization  #1126
13:44 dalek parrot/smoke-me/array-splice-gh766+1126+1127:
13:44 dalek parrot/smoke-me/array-splice-gh766+1126+1127: Do not end the exception string with ".", "!" or "\n".
13:44 dalek parrot/smoke-me/array-splice-gh766+1126+1127: review: https://github.com/parrot/parrot/commit/df59cb2df8
13:44 dalek parrot/smoke-me/array-splice-gh766+1126+1127: dbaffa4 | rurban++ | / (9 files):
13:44 dalek parrot/smoke-me/array-splice-gh766+1126+1127: [pmc] allow negative array key indices
13:44 dalek parrot/smoke-me/array-splice-gh766+1126+1127:
13:44 dalek parrot/smoke-me/array-splice-gh766+1126+1127: Fixes GH #1127
13:44 dalek parrot/smoke-me/array-splice-gh766+1126+1127: currently we throw "index out of bounds" when getting or setting $P0[-1]
13:44 dalek parrot/smoke-me/array-splice-gh766+1126+1127: the added code is only:
13:44 dalek parrot/smoke-me/array-splice-gh766+1126+1127:         if (key < 0)
13:44 dalek parrot/smoke-me/array-splice-gh766+1126+1127:             key += size;
13:44 dalek parrot/smoke-me/array-splice-gh766+1126+1127: so it is hard to argue for performance reasons.
13:44 dalek parrot/smoke-me/array-splice-gh766+1126+1127: ditto for resizable*array for consistency if not already implemented.
13:44 dalek parrot/smoke-me/array-splice-gh766+1126+1127: review: https://github.com/parrot/parrot/commit/dbaffa4409
13:44 dalek parrot/smoke-me/array-splice-gh766+1126+1127: 73af982 | rurban++ | t/ (14 files):
13:44 dalek parrot/smoke-me/array-splice-gh766+1126+1127: [test] change array tests to new harmonized out of bounds exceptions
13:44 dalek parrot/smoke-me/array-splice-gh766+1126+1127: review: https://github.com/parrot/parrot/commit/73af982116
13:44 dalek parrot/smoke-me/array-splice-gh766+1126+1127: 0289e09 | rurban++ | ChangeLog:
13:44 dalek parrot/smoke-me/array-splice-gh766+1126+1127: ChangeLog for the 3 array changes
13:44 dalek parrot/smoke-me/array-splice-gh766+1126+1127: review: https://github.com/parrot/parrot/commit/0289e098de
13:54 rurban I need an opinion on smoke-me/array-splice-gh766+1126+1127 and the 3 tickets
13:58 travis-ci joined #parrot
13:58 travis-ci parrot/parrot#1250 (master - 441b785 : Reini Urban): The build passed.
13:58 travis-ci Change view : https://github.com/parrot/parrot/c​ompare/3f902acbfd02...441b785de782
13:58 travis-ci Build details : http://travis-ci.org/parrot/parrot/builds/40541399
13:58 travis-ci left #parrot
14:12 travis-ci joined #parrot
14:12 travis-ci parrot/parrot#1251 (smoke-me/array-splice-gh766+1126+1127 - 0289e09 : Reini Urban): The build passed.
14:12 travis-ci Change view : https://github.com/parrot/parrot/c​ompare/6839b09c6c8e...0289e098dee6
14:12 travis-ci Build details : http://travis-ci.org/parrot/parrot/builds/40541495
14:12 travis-ci left #parrot
15:15 FROGGS rurban: how do I get the vtable for pipes? the Parrot_io_get_vtable symbol is not exported...
15:15 dalek parrot/smoke-me/lstat-gh1129: 652dc4a | rurban++ | / (4 files):
15:15 dalek parrot/smoke-me/lstat-gh1129: Added lstat io op for nqp, fixed os.lstat method. #1129
15:15 dalek parrot/smoke-me/lstat-gh1129:
15:15 dalek parrot/smoke-me/lstat-gh1129: nqp used stat on a symlink, which is wrong. provide the proper lstat pirop.
15:15 dalek parrot/smoke-me/lstat-gh1129: also fix the os.pmc lstat method which called stat()!.
15:15 dalek parrot/smoke-me/lstat-gh1129: Fixes GH #1129
15:15 dalek parrot/smoke-me/lstat-gh1129: review: https://github.com/parrot/parrot/commit/652dc4aa9a
15:29 dalek parrot/smoke-me/seek-exc-gh1130: e110b23 | rurban++ | / (2 files):
15:29 dalek parrot/smoke-me/seek-exc-gh1130: [io] hrow errors on illegal seek arguments, no assertions
15:29 dalek parrot/smoke-me/seek-exc-gh1130:
15:29 dalek parrot/smoke-me/seek-exc-gh1130: Fixes #1130 and the relevant nqp test.
15:29 dalek parrot/smoke-me/seek-exc-gh1130: review: https://github.com/parrot/parrot/commit/e110b23576
15:34 dalek parrot/smoke-me/seek-exc-gh1130: a07b7af | rurban++ | / (2 files):
15:34 dalek parrot/smoke-me/seek-exc-gh1130: [io] throw errors on illegal seek arguments, no assertions
15:34 dalek parrot/smoke-me/seek-exc-gh1130:
15:34 dalek parrot/smoke-me/seek-exc-gh1130: Fixes #1130 and the relevant nqp test.
15:34 dalek parrot/smoke-me/seek-exc-gh1130: review: https://github.com/parrot/parrot/commit/a07b7af87a
15:36 mirjam joined #parrot
15:36 FROGGS https://github.com/parrot/parrot/pull/1131
15:36 travis-ci joined #parrot
15:36 travis-ci parrot/parrot#1252 (smoke-me/lstat-gh1129 - 652dc4a : Reini Urban): The build passed.
15:36 travis-ci Change view : https://github.com/parrot/​parrot/commit/652dc4aa9a47
15:36 travis-ci Build details : http://travis-ci.org/parrot/parrot/builds/40550804
15:36 travis-ci left #parrot
15:37 dalek parrot: d547e20 | (Tobias Leich)++ | / (2 files):
15:37 dalek parrot: export symbol Parrot_io_get_vtable
15:37 dalek parrot:
15:37 dalek parrot: Parrot_io_get_vtable is part of the public api so we have to make it available.
15:37 dalek parrot: review: https://github.com/parrot/parrot/commit/d547e20935
15:37 dalek parrot: c5dfae6 | rurban++ | / (2 files):
15:37 dalek parrot: Merge pull request #1131 from FROGGS/export_io_get_vtable
15:37 dalek parrot:
15:37 dalek parrot: export symbol Parrot_io_get_vtable
15:37 dalek parrot: review: https://github.com/parrot/parrot/commit/c5dfae6f73
15:39 dalek parrot: 6d8687c | rurban++ | ChangeLog:
15:39 dalek parrot: ChangeLog for Export Parrot_io_get_vtable #1131
15:39 dalek parrot: review: https://github.com/parrot/parrot/commit/6d8687cc13
15:39 FROGGS ohh thank you!
15:40 mirjam I'm fixing a couple more nqp bugs, which need more parrot support
15:43 travis-ci joined #parrot
15:43 travis-ci parrot/parrot#1253 (smoke-me/seek-exc-gh1130 - e110b23 : Reini Urban): The build has errored.
15:43 travis-ci Change view : https://github.com/parrot/​parrot/commit/e110b2357666
15:43 travis-ci Build details : http://travis-ci.org/parrot/parrot/builds/40552250
15:43 travis-ci left #parrot
15:54 Reini joined #parrot
15:59 travis-ci joined #parrot
15:59 travis-ci parrot/parrot#1254 (smoke-me/seek-exc-gh1130 - a07b7af : Reini Urban): The build passed.
15:59 travis-ci Change view : https://github.com/parrot/parrot/c​ompare/e110b2357666...a07b7af87af2
15:59 travis-ci Build details : http://travis-ci.org/parrot/parrot/builds/40553160
15:59 travis-ci left #parrot
16:09 dalek parrot: e2dfe60 | rurban++ | / (4 files):
16:09 dalek parrot: Added lstat io op for nqp, fixed os.lstat method. #1129
16:09 dalek parrot:
16:09 dalek parrot: nqp used stat on a symlink, which is wrong. provide the proper lstat pirop.
16:09 dalek parrot: also fix the os.pmc lstat method which called stat()!.
16:09 dalek parrot: Fixes GH #1129
16:09 dalek parrot: review: https://github.com/parrot/parrot/commit/e2dfe60faf
16:09 dalek parrot: b0f48b7 | rurban++ | / (2 files):
16:09 dalek parrot: [io] throw errors on illegal seek arguments, no assertions
16:09 dalek parrot:
16:09 dalek parrot: Fixes #1130 and the relevant nqp test.
16:09 dalek parrot: review: https://github.com/parrot/parrot/commit/b0f48b777c
16:13 dalek parrot/smoke-me/array-splice-gh766+1126+1127: cc28c94 | rurban++ | src/pmc/ (3 files):
16:13 dalek parrot/smoke-me/array-splice-gh766+1126+1127: [pmc] fix splice overflows with negative count
16:13 dalek parrot/smoke-me/array-splice-gh766+1126+1127:
16:13 dalek parrot/smoke-me/array-splice-gh766+1126+1127: Fixes GH #766.
16:13 dalek parrot/smoke-me/array-splice-gh766+1126+1127: Throw illegal argument with negative count arguments for now.
16:13 dalek parrot/smoke-me/array-splice-gh766+1126+1127:
16:13 dalek parrot/smoke-me/array-splice-gh766+1126+1127: TODO: Implement support for negative count argument for splice.
16:13 dalek parrot/smoke-me/array-splice-gh766+1126+1127: Add more splice methods.
16:13 dalek parrot/smoke-me/array-splice-gh766+1126+1127: review: https://github.com/parrot/parrot/commit/cc28c94662
16:13 dalek parrot/smoke-me/array-splice-gh766+1126+1127: e6dd153 | rurban++ | / (22 files):
16:13 dalek parrot/smoke-me/array-splice-gh766+1126+1127: [pmc] harmonize and combine out of bounds exception strings
16:13 dalek parrot/smoke-me/array-splice-gh766+1126+1127:
16:14 dalek parrot/smoke-me/array-splice-gh766+1126+1127: use less static string memory. no special context.
16:14 dalek parrot/smoke-me/array-splice-gh766+1126+1127: Use only "illegal argument" for unsupported negative arguments.
16:14 dalek parrot/smoke-me/array-splice-gh766+1126+1127: GH #1126
16:14 dalek parrot/smoke-me/array-splice-gh766+1126+1127:
16:14 dalek parrot/smoke-me/array-splice-gh766+1126+1127: * index out of bounds,
16:14 dalek parrot/smoke-me/array-splice-gh766+1126+1127: * illegal argument (for illegal negative args),
16:14 dalek parrot/smoke-me/array-splice-gh766+1126+1127: * can't resize (for fixed*pmcs or size=0 arguments)
16:14 dalek parrot/smoke-me/array-splice-gh766+1126+1127: * StopIteration
16:14 dalek parrot/smoke-me/array-splice-gh766+1126+1127: review: https://github.com/parrot/parrot/commit/e6dd153884
16:14 dalek parrot/smoke-me/array-splice-gh766+1126+1127: 589364a | rurban++ | / (25 files):
16:14 dalek parrot/smoke-me/array-splice-gh766+1126+1127: More error message harmonization  #1126
16:14 dalek parrot/smoke-me/array-splice-gh766+1126+1127:
16:14 dalek parrot/smoke-me/array-splice-gh766+1126+1127: Do not end the exception string with ".", "!" or "\n".
16:14 dalek parrot/smoke-me/array-splice-gh766+1126+1127: review: https://github.com/parrot/parrot/commit/589364a286
16:14 dalek parrot/smoke-me/array-splice-gh766+1126+1127: affc05c | rurban++ | / (9 files):
16:14 dalek parrot/smoke-me/array-splice-gh766+1126+1127: [pmc] allow negative array key indices
16:14 dalek parrot/smoke-me/array-splice-gh766+1126+1127:
16:14 dalek parrot/smoke-me/array-splice-gh766+1126+1127: Fixes GH #1127
16:14 dalek parrot/smoke-me/array-splice-gh766+1126+1127: currently we throw "index out of bounds" when getting or setting $P0[-1]
16:14 dalek parrot/smoke-me/array-splice-gh766+1126+1127: the added code is only:
16:14 dalek parrot/smoke-me/array-splice-gh766+1126+1127:         if (key < 0)
16:14 dalek parrot/smoke-me/array-splice-gh766+1126+1127:             key += size;
16:14 dalek parrot/smoke-me/array-splice-gh766+1126+1127: so it is hard to argue for performance reasons.
16:14 dalek parrot/smoke-me/array-splice-gh766+1126+1127: ditto for resizable*array for consistency if not already implemented.
16:14 dalek parrot/smoke-me/array-splice-gh766+1126+1127: review: https://github.com/parrot/parrot/commit/affc05c294
16:14 dalek parrot/smoke-me/array-splice-gh766+1126+1127: 76a60f2 | rurban++ | t/ (14 files):
16:14 dalek parrot/smoke-me/array-splice-gh766+1126+1127: [test] change array tests to new harmonized out of bounds exceptions
16:14 dalek parrot/smoke-me/array-splice-gh766+1126+1127: review: https://github.com/parrot/parrot/commit/76a60f2c22
16:14 dalek parrot/smoke-me/array-splice-gh766+1126+1127: 6a4992e | rurban++ | ChangeLog:
16:14 dalek parrot/smoke-me/array-splice-gh766+1126+1127: ChangeLog for the 3 array changes
16:14 dalek parrot/smoke-me/array-splice-gh766+1126+1127: review: https://github.com/parrot/parrot/commit/6a4992eb78
16:23 travis-ci joined #parrot
16:23 travis-ci parrot/parrot#1255 (master - c5dfae6 : Reini Urban): The build passed.
16:23 travis-ci Change view : https://github.com/parrot/parrot/c​ompare/441b785de782...c5dfae6f7308
16:23 travis-ci Build details : http://travis-ci.org/parrot/parrot/builds/40553488
16:23 travis-ci left #parrot
16:47 Reini joined #parrot
16:51 travis-ci joined #parrot
16:51 travis-ci parrot/parrot#1257 (master - b0f48b7 : Reini Urban): The build passed.
16:51 travis-ci Change view : https://github.com/parrot/parrot/c​ompare/6d8687cc133d...b0f48b777c7a
16:51 travis-ci Build details : http://travis-ci.org/parrot/parrot/builds/40557102
16:51 travis-ci left #parrot
17:18 dalek parrot: cc28c94 | rurban++ | src/pmc/ (3 files):
17:18 dalek parrot: [pmc] fix splice overflows with negative count
17:18 dalek parrot:
17:18 dalek parrot: Fixes GH #766.
17:18 dalek parrot: Throw illegal argument with negative count arguments for now.
17:18 dalek parrot:
17:18 dalek parrot: TODO: Implement support for negative count argument for splice.
17:18 dalek parrot: Add more splice methods.
17:18 dalek parrot: review: https://github.com/parrot/parrot/commit/cc28c94662
17:18 dalek parrot: e6dd153 | rurban++ | / (22 files):
17:18 dalek parrot: [pmc] harmonize and combine out of bounds exception strings
17:18 dalek parrot:
17:18 dalek parrot: use less static string memory. no special context.
17:18 dalek parrot: Use only "illegal argument" for unsupported negative arguments.
17:18 dalek parrot: GH #1126
17:18 dalek parrot:
17:19 dalek parrot: * index out of bounds,
17:19 dalek parrot: * illegal argument (for illegal negative args),
17:19 dalek parrot: * can't resize (for fixed*pmcs or size=0 arguments)
17:19 dalek parrot: * StopIteration
17:19 dalek parrot: review: https://github.com/parrot/parrot/commit/e6dd153884
17:19 dalek parrot: 589364a | rurban++ | / (25 files):
17:19 dalek parrot: More error message harmonization  #1126
17:19 dalek parrot:
17:19 dalek parrot: Do not end the exception string with ".", "!" or "\n".
17:19 dalek parrot: review: https://github.com/parrot/parrot/commit/589364a286
17:19 dalek parrot: affc05c | rurban++ | / (9 files):
17:19 dalek parrot: [pmc] allow negative array key indices
17:19 dalek parrot:
17:19 dalek parrot: Fixes GH #1127
17:19 dalek parrot: currently we throw "index out of bounds" when getting or setting $P0[-1]
17:19 dalek parrot: the added code is only:
17:19 dalek parrot:         if (key < 0)
17:19 dalek parrot:             key += size;
17:19 dalek parrot: so it is hard to argue for performance reasons.
17:19 dalek parrot: ditto for resizable*array for consistency if not already implemented.
17:19 dalek parrot: review: https://github.com/parrot/parrot/commit/affc05c294
17:19 dalek parrot: 76a60f2 | rurban++ | t/ (14 files):
17:19 dalek parrot: [test] change array tests to new harmonized out of bounds exceptions
17:19 dalek parrot: review: https://github.com/parrot/parrot/commit/76a60f2c22
17:19 dalek parrot: 6a4992e | rurban++ | ChangeLog:
17:19 dalek parrot: ChangeLog for the 3 array changes
17:19 dalek parrot: review: https://github.com/parrot/parrot/commit/6a4992eb78
17:19 dalek parrot: fa6f019 | rurban++ | / (61 files):
17:19 dalek parrot: Merge branch 'smoke-me/array-splice-gh766+1126+1127'
17:19 dalek parrot:
17:19 dalek parrot: tested ok with nqp and perl6 also
17:19 dalek parrot: review: https://github.com/parrot/parrot/commit/fa6f019cb3
17:20 travis-ci joined #parrot
17:20 travis-ci parrot/parrot#1258 (smoke-me/array-splice-gh766+1126+1127 - 6a4992e : Reini Urban): The build passed.
17:20 travis-ci Change view : https://github.com/parrot/parrot/c​ompare/0289e098dee6...6a4992eb782d
17:20 travis-ci Build details : http://travis-ci.org/parrot/parrot/builds/40557703
17:20 travis-ci left #parrot
17:47 travis-ci joined #parrot
17:47 travis-ci parrot/parrot#1259 (master - fa6f019 : Reini Urban): The build passed.
17:47 travis-ci Change view : https://github.com/parrot/parrot/c​ompare/b0f48b777c7a...fa6f019cb3f1
17:47 travis-ci Build details : http://travis-ci.org/parrot/parrot/builds/40564508
17:47 travis-ci left #parrot
18:12 FROGGS joined #parrot
20:57 Reini joined #parrot
21:46 kshannon joined #parrot
23:16 kid51 joined #parrot

| Channels | #parrot index | Today | | Search | Google Search | Plain-Text | summary

Parrot | source cross referenced