Perl 6 - the future is here, just unevenly distributed

IRC log for #perl6-lwp-gsoc, 2014-05-27

| Channels | #perl6-lwp-gsoc index | Today | | Search | Google Search | Plain-Text | summary

All times shown according to UTC.

Time Nick Message
08:16 sergot moritz: Can I pass an argument to .Str? Does this make sense?
08:17 moritz sergot: yes, as long as it's optional
08:18 sergot thanks :)
08:22 sergot moritz: I want to use .Str as you said, but I think, we should keep the "old one", so as_string will call .Str, does this make sense for you?
08:23 sergot and. this won't work map(*.fmt("%s: %s\n")).join - because we have lists as the values which elements should be separated by ", ".
08:25 dalek http-headers: bb78e97 | sergot++ | lib/HTTP/Headers.pm6:
08:25 dalek http-headers: [lib/HTTP/Headers.pm6] we dont have to check if Positional #2
08:25 dalek http-headers: review: https://github.com/sergot/http-headers/commit/bb78e97ce0
08:28 moritz sergot: I don't see much sense in having both as_string as Str, but do as you wish :-)
08:33 sergot Ok :)
08:50 dalek http-headers: d3bbaf9 | sergot++ | lib/HTTP/Headers.pm6:
08:50 dalek http-headers: [lib/HTTP/Headers.pm6] .Str instead of as_string
08:50 dalek http-headers: review: https://github.com/sergot/http-headers/commit/d3bbaf999a
08:50 dalek http-headers: 847dd53 | sergot++ | lib/HTTP/Headers.pm6:
08:50 dalek http-headers: [lib/HTTP/Headers.pm6] unnecessary []
08:50 dalek http-headers: review: https://github.com/sergot/http-headers/commit/847dd5353d
08:52 dalek http-headers: 24c8b55 | sergot++ | t/01-basic.t:
08:52 dalek http-headers: [lib/HTTP/Headers.pm6] s/as_string/Str/
08:52 dalek http-headers: review: https://github.com/sergot/http-headers/commit/24c8b55ddd
08:56 dalek http-headers: 43ab7ac | (Filip Sergot)++ | README.md:
08:56 dalek http-headers: [README.md] doc updated
08:56 dalek http-headers: review: https://github.com/sergot/http-headers/commit/43ab7acd42
09:10 dalek http-headers: 55f6be4 | sergot++ | / (3 files):
09:10 dalek http-headers: richer documentation
09:10 dalek http-headers: review: https://github.com/sergot/http-headers/commit/55f6be46e5
09:10 dalek http-headers: 62a3f70 | sergot++ | test.p6:
09:10 dalek http-headers: test.p6 deleted
09:10 dalek http-headers: review: https://github.com/sergot/http-headers/commit/62a3f70b7b
09:26 dalek http-message: 30b81c2 | sergot++ | lib/HTTP/Message.pm6:
09:26 dalek http-message: [lib/HTTP/Message.pm6] Str instead of as_string
09:26 dalek http-message: review: https://github.com/sergot/http-message/commit/30b81c2b9d
09:26 dalek http-message: e21e36e | sergot++ | t/01-basic.t:
09:26 dalek http-message: [lib/HTTP/Message.pm6] Str instead of as_string, headers improvements
09:26 dalek http-message: review: https://github.com/sergot/http-message/commit/e21e36e404
09:35 dalek http-message: 42cb0b2 | sergot++ | / (2 files):
09:35 dalek http-message: $content argument to new added
09:35 dalek http-message: review: https://github.com/sergot/http-message/commit/42cb0b23d8
09:39 dalek http-message: 1b895b9 | sergot++ | / (2 files):
09:39 dalek http-message: clear() added
09:39 dalek http-message: review: https://github.com/sergot/http-message/commit/1b895b98c0
09:59 * sergot reading about http cookies
10:18 dalek http-cookies: f76dc89 | sergot++ | / (3 files):
10:18 dalek http-cookies: init
10:18 dalek http-cookies: review: https://github.com/sergot/http-cookies/commit/f76dc891ca
10:27 dalek http-cookies: e5766a1 | sergot++ | / (2 files):
10:27 dalek http-cookies: prototypes
10:27 dalek http-cookies: review: https://github.com/sergot/http-cookies/commit/e5766a15b8
10:27 sergot moritz: what do you think about those prototypes?
10:27 sergot I mean, is it 6ish enough?
10:28 sergot extract_cookies and add_cookie_header
10:31 sergot they are supposed to add/get cookie headers to/from request/response.
10:41 moritz sergot: add_cookie_header looks a bit fishy
10:41 moritz sergot: I'd simply write a method cookie_header
10:42 moritz sergot: and adding that to a request is the responsibility of the caller
10:46 sergot So, does Request object should do this?
10:46 sergot yea... should request object do this?
10:50 dalek http-request: 90bbe26 | sergot++ | / (2 files):
10:50 dalek http-request: Str instead of as_string
10:50 dalek http-request: review: https://github.com/sergot/http-request/commit/90bbe26a5a
10:54 dalek http-response: fc50e46 | sergot++ | / (2 files):
10:54 dalek http-response: Str instead of as_string
10:54 dalek http-response: review: https://github.com/sergot/http-response/commit/fc50e46726
10:57 moritz sergot: probably, yes
10:58 dalek lwp-useragent: 22ff0b8 | sergot++ | l (2 files):
10:58 dalek lwp-useragent: Str instead of as_string
10:58 dalek lwp-useragent: review: https://github.com/sergot/lwp-useragent/commit/22ff0b8068
10:59 sergot moritz: ok, I'll think it over :)
10:59 sergot thanks a lot
14:17 dalek http-cookies: 23a294d | sergot++ | lib/HTTP/Cookies.pm6:
14:17 dalek http-cookies: set_cookie, save added
14:17 dalek http-cookies: review: https://github.com/sergot/http-cookies/commit/23a294d1cf
14:19 moritz doesn't .spurt override the file?
14:20 sergot ok, I should have checked this.
14:21 sergot moritz: yes, you're right
14:29 sergot moritz: I copied the structure of %.cookies, but I dont like it, any ideas how can this be improved?
14:30 dalek http-cookies: 94739c6 | sergot++ | lib/HTTP/Cookies.pm6:
14:30 dalek http-cookies: say instead of spurt
14:30 dalek http-cookies: review: https://github.com/sergot/http-cookies/commit/94739c62c4
14:39 sergot Do we need Net::HTTP in this project? I think we can do this as optional goal (later), what do you moritz, FROGGS think?
14:41 moritz sergot: sorry, which commit copies the structure of %.cookies?
14:41 moritz (no idea if Net::HTTP is needed)
14:43 sergot iirc, I add Net::HTTP to my project as a nice module to have, but it's not so important, can I modify my goals?
14:44 sergot moritz: https://github.com/sergot/http-cookies/commit/23a294d1cf#diff-2d1a51a63e3a1e3e7a965a277054b84aR29
14:44 sergot I added*
14:44 FROGGS joined #perl6-lwp-gsoc
14:45 sergot FROGGS: \o/
14:45 FROGGS hi sergot
14:45 sergot http://irclog.perlgeek.de/perl6-lwp-gsoc/2014-05-27#i_8780804
14:46 sergot FROGGS: will be great if you read today log
14:46 FROGGS I'm already doing this :o)
14:46 FROGGS (was the first thing I did after getting hotel wifi)
14:47 sergot awesome! thanks
14:47 moritz sergot: set_cookie doesn't make much sense to me on a cookie object
14:48 moritz oh, it's a Cookie*s* object
14:48 moritz maybe we need a Cookie object, and a Cookies object to manage them
14:48 moritz then you can set-cookie with a cookie object
14:48 moritz or
14:48 moritz use named params
14:49 sergot I was thinking about using named params. I like your first idea too.
14:49 FROGGS sergot: http://deps.cpantesters.org/depended-on-by.pl?module=Net%3A%3AHTTP
14:49 FROGGS sergot: so it looks like as if LWP-Protocol-https depends on Net::HTTP, but perhaps we do not have that dependency?
14:49 sergot FROGGS: I can see LWP there, so we need this.
14:50 sergot hmm
14:50 sergot Acutally, we dont, you're right
14:50 FROGGS I see that this requires it: http://cpansearch.perl.org/src/MSCHILLI/LWP-Protocol-https-6.06/lib/LWP/Protocol/https.pm
14:50 sergot Actually*
14:50 FROGGS but I have no idea for what
14:51 FROGGS ahh
14:51 FROGGS if ( $Net::HTTPS::SSL_SOCKET_CLASS->can('start_SSL')) {
14:52 sergot hmm
14:53 sergot FROGGS: what do you think then?
14:53 sergot Can I modify my goals and make Net::HTTP as an optional one?
14:53 FROGGS sergot: I think so...
14:55 sergot Is it wrong?
14:55 sergot I mean, in gsoc term.
14:55 FROGGS no
14:56 sergot terms*
14:56 FROGGS I is just a little detail
14:56 FROGGS the goal it to provide LWP+TLS, and Net::HTTP is just a thingy on your schedule that seems not needed
15:08 sergot ok, anyway I'll try to do optional goals too :-)
15:10 sergot FROGGS: do you have any ideas in case of Cookies? :-)
15:11 sergot I wanted to do this today.
15:11 sergot would be great.
15:11 moritz where is set_cookie called from?
15:18 sergot this is only a prototype, it'll be called from http::{request,response}
15:19 moritz why don't they simply pass along the cookie as text, and let ::Cookie parse it?
15:22 sergot oh, good idea !
15:24 sergot thanks
19:48 FROGGS joined #perl6-lwp-gsoc

| Channels | #perl6-lwp-gsoc index | Today | | Search | Google Search | Plain-Text | summary