Perl 6 - the future is here, just unevenly distributed

IRC log for #perl6-lwp-gsoc, 2014-06-03

| Channels | #perl6-lwp-gsoc index | Today | | Search | Google Search | Plain-Text | summary

All times shown according to UTC.

Time Nick Message
01:44 FROGGS joined #perl6-lwp-gsoc
06:25 FROGGS joined #perl6-lwp-gsoc
06:26 FROGGS o/
07:05 sergot morning! o/
07:14 ilbot3 joined #perl6-lwp-gsoc
07:14 Topic for #perl6-lwp-gsoc is now logs at http://irclog.perlgeek.de/perl6-lwp-gsoc/
10:57 sergot FROGGS: we have a problem in HTTP::Message again, I think.
10:57 sergot with .header() method
10:57 sergot I mean:
10:58 sergot It only overwrites specific header, we cannot push a new value to it.
11:00 sergot hmm, it can be done in http-headers tho
11:09 FROGGS can you give me an example?
11:10 d4l3k_ joined #perl6-lwp-gsoc
11:11 dalek http-message: 2ddaa68 | sergot++ | / (2 files):
11:11 dalek http-message: remove_header added
11:11 dalek http-message: review: https://github.com/sergot/http-message/commit/2ddaa68503
11:11 sergot joined #perl6-lwp-gsoc
11:12 FROGGS sergot: does that fix you problem?
11:13 FROGGS otherwise, I do not really understand what the problem is, so a example would be nice
11:13 FROGGS (I'm back in a bit, will read backlog)
11:15 sergot FROGGS: I had some connection problems, I couldn't explain
11:16 sergot If we have such header: Vary: Accept-Encoding
11:17 sergot and now, we cannot add another value to that header. If we run .header(Vary => 'another vary field'); we'll get Vary: another vary field - so we lost previous value.
11:18 sergot We cannot modify existing headrs, we can only overwrite them.
11:23 sergot We can only do this using HTTP::Headers.
12:01 FROGGS joined #perl6-lwp-gsoc
12:08 FROGGS can't we just do: $msg.headers<Vary>.push: 'an additional value' ?
12:09 FROGGS that would mean we implement a method postcircumfix:<{ }> for HTTP::Header
12:09 moritz at_key should be enough for that
12:09 FROGGS ahh, k
12:17 sergot FROGGS: we can, I just wanted to provide a module, that makes it as simple as possible.
12:18 FROGGS sergot: you can still keep the setters as they are
12:18 FROGGS but setters are setters, I think nobody expects that a setter in fact appends a value
12:20 sergot FROGGS: hmm, right
12:20 sergot btw
12:20 sergot http://filip.sergot.pl/en/blog/perl6/gsoc_http_cookies_message_datetime_parse/
12:21 sergot Is it ok?
12:25 sergot dinner &
12:26 FROGGS my $c = HTTP::Cookies.new(
12:26 FROGGS file     => $file,
12:26 FROGGS autosave => 1,
12:26 FROGGS );
12:27 FROGGS this might be written as: my $c = HTTP::Cookies.new( :$file, :autosave )
12:29 FROGGS sergot: good post :o)
12:53 sergot FROGGS++: thanks
12:54 sergot is everything ok with the language in this post?
12:57 FROGGS this does not sound right: HTTP::Request and HTTP::Response will be using this module for cookies handling, so we'll be able e.g. to log into a website etc.
12:57 FROGGS HTTP::Request and HTTP::Response will use this module for cookies handling, so we'll be able to e.g. log into a website etc.
12:57 FROGGS perhaps more like this --^
12:58 FROGGS (I hanged two things)
13:00 sergot oh, right , thanks :)
13:01 FROGGS changed*
13:12 sergot I should add syntax highlighting
13:26 dalek http-useragent: 383e49a | sergot++ | / (2 files):
13:26 dalek http-useragent: if useragent is not predefined in HTTP::UserAgent::Common list, use argument as a useragent
13:26 dalek http-useragent: review: https://github.com/sergot/http-useragent/commit/383e49a9e4
13:32 sergot FROGGS: moritz: take a look at the comment under this post: http://filip.sergot.pl/en/blog/perl6/gsoc_http_cookies_message_datetime_parse/
13:33 FROGGS yeah, HTTP::Client is also nice
13:33 FROGGS (and shorter)
13:33 moritz IMHO a user agent does more than a client
13:34 moritz for example I'd expect a user agent to follow redirect, and process cookies during the redirect etc.
13:35 FROGGS that is what I expect from any client too
13:41 sergot hmm
14:18 FROGGS sergot: what shall I review? https://github.com/sergot/http-useragent/issues/18
14:19 moritz let's ask ourselves: where does the job of a user agent differ from that of a client?
14:19 moritz probably if you want a to write a proxy, you have a client and a server part, but the client just does one dumb request, not behave as a fully-fledged user agent
14:20 moritz (in the end it doesn't matter much how it's named, as long as the name is easily recognizable)
14:20 FROGGS I don't really see a difference between a UA and a client
14:21 moritz in my world view, an agent is somewhat more autonomous
14:21 moritz it does more stuff for you than a client
14:21 moritz unless you want the client to be a (user) agent :-)
14:23 FROGGS it is hard for me to imagine a difference when it is about a module that I have under my full control...
14:24 dalek http-request: c957012 | sergot++ | / (2 files):
14:24 dalek http-request: content added
14:24 dalek http-request: review: https://github.com/sergot/http-request/commit/c957012399
14:24 FROGGS I mean, I want to be able to fetch data, following redirects (unless I disable it explicitly) and so on
14:25 sergot FROGGS: it's assigned to HTTP::Message milestone
14:25 sergot every milestone has 4 issues - Documentation, tests, functionality and review.
14:27 sergot FROGGS: https://github.com/sergot/http-useragent/issues/milestones
14:27 FROGGS I see...
14:27 FROGGS I thought there was already an issue about reviewing HTTP::Message
14:28 sergot Actually it was assigned to HTTP::Headers, iirc you added HTTP::Message to its name
14:29 sergot I'm doing some cleaning right now.
14:29 FROGGS ohh, okay
14:31 sergot https://github.com/sergot/http-useragent/issues/20 - here is a review for HTTP::Headers (it is assigned to headrs milestone)
14:32 sergot yea, I've changed it again
14:33 sergot I'll let you know when I'm done
14:41 sergot Ok
14:41 sergot FROGGS: https://github.com/sergot/http-useragent/issues/milestones
14:41 FROGGS that looks quite nice :o)
14:43 sergot Each milestone has 4 issues, 3(functionality, documentation and tests) for me, 1 (review) for mentors.
14:55 dalek http-request: 1efd01d | (Filip Sergot)++ | README.md:
14:55 dalek http-request: Str instead of as_string
14:55 dalek http-request: review: https://github.com/sergot/http-request/commit/1efd01dba9

| Channels | #perl6-lwp-gsoc index | Today | | Search | Google Search | Plain-Text | summary