Perl 6 - the future is here, just unevenly distributed

IRC log for #perl6-lwp-gsoc, 2014-08-16

| Channels | #perl6-lwp-gsoc index | Today | | Search | Google Search | Plain-Text | summary

All times shown according to UTC.

Time Nick Message
00:48 dalek joined #perl6-lwp-gsoc
01:28 FROGGS__ joined #perl6-lwp-gsoc
03:13 FROGGS__ joined #perl6-lwp-gsoc
03:13 sergot joined #perl6-lwp-gsoc
10:01 FROGGS[mobile] joined #perl6-lwp-gsoc
10:05 FROGGS[mobile] today I'll do an excessive code and will open issues as needed
11:00 moritz code review?
11:36 sergot ok :)
11:36 sergot I'm going to end the documentation today.
11:39 FROGGS[mobile] ahh, yes :o)
11:40 sergot But will be great if you do the review
11:40 sergot moritz: if you have some time, could you do this too?
11:41 sergot I'm adding examples to doc
11:46 moritz sergot: I'm reading HTTP::UserAgent, and I don't see the error objects documented
11:47 moritz sergot: also, even on errors, the server can deliver a page (like a 404 page); make that accessible from the X::HTTP::Response error maybe?
11:47 sergot oh, this is a nice idea
11:49 moritz HTTP::Cookie doesn't document the rw attributes
11:50 sergot moritz: I thought doc about those rw attributes can be in method .new section.
11:51 sergot I'll add a note about they are rw there
11:53 dalek http-useragent: 3dbf4f6 | (Tobias Leich)++ | lib/HTTP/Header.pm6:
11:53 dalek http-useragent: use dash in method name of synopsis to match implementation
11:53 dalek http-useragent: review: https://github.com/sergot/http-useragent/commit/3dbf4f6c60
11:56 FROGGS should the @.fields array in HTTP::Headers documented?
12:00 dalek http-useragent: 6db406b | (Tobias Leich)++ | lib/HTTP/Message.pm6:
12:00 dalek http-useragent: use double quotes to interpolate backslash sequences in synopsis
12:00 dalek http-useragent: review: https://github.com/sergot/http-useragent/commit/6db406b16f
12:06 moritz HTTP::Cookies docs could use a SYNOPSIS seciton
12:07 moritz sorry, it has one
12:07 moritz never mind
12:08 moritz :autosave(1) prettier written as :autosave
12:08 FROGGS this could state that add-content concats to the existing content: https://github.com/sergot/http-useragent/blob/master/lib/HTTP/Message.pm6#L125
12:09 FROGGS that is not a valid signature, is it? multi method field(HTTP::Message:, HTTP::Header:, Str $s) returns HTTP::Header::Field
12:09 FROGGS fwiw, I'd strip the mentioned HTTP::Header:
12:09 sergot oh, fact
12:11 FROGGS also, HTTP::Message.clear and .parse could need a better explanation, like: clears all header fields and message body...
12:12 moritz (it's actually True, not 1, which suits the purpose here)
12:13 moritz (damn laggy internet connection)
12:14 dalek http-useragent: a9ad3c3 | sergot++ | lib/HTTP/Cookie (2 files):
12:14 dalek http-useragent: cookie better doc
12:14 dalek http-useragent: review: https://github.com/sergot/http-useragent/commit/a9ad3c3b6b
12:14 FROGGS this does not fit the implementation (the Int constraint) https://github.com/sergot/http-useragent/blob/master/lib/HTTP/Response.pm6#L61
12:15 FROGGS you should describe what successful means at: https://github.com/sergot/http-useragent/blob/master/lib/HTTP/Response.pm6#L72
12:17 dalek http-useragent: d3b5a9d | sergot++ | lib/HTTP/Message.pm6:
12:17 dalek http-useragent: signatures correction
12:17 dalek http-useragent: review: https://github.com/sergot/http-useragent/commit/d3b5a9d6e1
12:24 FROGGS was it necessary to do that after the sub declaration? https://github.com/sergot/io-socket-ssl/blob/master/lib/IO/Socket/SSL.pm6#L11-L13
12:25 sergot I was, when I've used is native(..) then it couldn't find my .c library.
12:25 sergot it*
12:25 sergot using panda
12:25 FROGGS ahh
12:25 FROGGS I see
12:26 sergot https://github.com/sergot/openssl/issues/1
12:26 FROGGS the current form happens at runtime, where the previous form would happen at compile time
12:55 dalek http-useragent: bc375a8 | sergot++ | lib/HTTP/ (2 files):
12:55 dalek http-useragent: examples added
12:55 dalek http-useragent: review: https://github.com/sergot/http-useragent/commit/bc375a8634
13:24 dalek http-useragent: e488bfb | sergot++ | lib/HTTP/Re (2 files):
13:24 dalek http-useragent: doc fixes
13:24 dalek http-useragent: review: https://github.com/sergot/http-useragent/commit/e488bfb121
15:24 moritz sergot: btw I liked your code very well
16:20 sergot moritz++ thanks! :)
17:38 FROGGS[mobile] what I like about the code is that it is very clean and structured
17:39 FROGGS[mobile] this will make maintenance easy
17:39 FROGGS[mobile] sergot++
19:50 FROGGS joined #perl6-lwp-gsoc
19:50 sergot joined #perl6-lwp-gsoc
21:58 sergot is everything ok in this project? :)

| Channels | #perl6-lwp-gsoc index | Today | | Search | Google Search | Plain-Text | summary