Perl 6 - the future is here, just unevenly distributed

IRC log for #pr-challenge, 2016-06-23

| Channels | #pr-challenge index | Today | | Search | Google Search | Plain-Text | summary

All times shown according to UTC.

Time Nick Message
00:11 aherzog joined #pr-challenge
00:17 kid51 joined #pr-challenge
00:18 kid51 Has github eliminated the "Clone on Github" button?
00:18 kid51 Oh, I guess I want the Fork button
00:37 Jayce^ PR sent
00:47 sivoais joined #pr-challenge
00:47 kid51 Let's say I have a .t file in which I have a subroutine, and the last statement in that subroutine is:
00:47 kid51 note("NNTP dialog done");
00:47 kid51 Is it possible for that subroutine's return value to be undefined?
00:52 devin depends on what note() returns
00:58 kid51 Hmm, that may be the case.
00:58 kid51 If, in blead, a module says 'use Test::More;' it's now really running Test2 -- correct?
01:00 kid51 In cpan/Test-Simple/lib/Test/More.pm, we have:
01:01 kid51 sub note {return Test::More->builder->note(@_);}
01:01 Exodist kid51, correct, if you have updated to the latest Test-Simple
01:01 kid51 Well, I'm observing these uninit warnings in blead
01:02 kid51 In cpan/Test-Simple/lib/Test/Builder.pm, I see:
01:02 Exodist kid51, I will be sending another patch, probably friday for more Test2 updates. However they should not be effecting Test::More::note
01:02 kid51 sub note {
01:02 kid51 ...    $ctx->release;
01:02 kid51 }
01:03 Exodist yes. it is possible that TB-> ote used to return a value other than undef, release will return undef
01:03 kid51 And in cpan/Test-Simple/lib/Test2/API/Context.pm , I see:
01:03 kid51 sub release ends with
01:03 kid51 return;
01:04 devin so, yes, when evaluated in scalar context, that would return undef.  in list context, returns the empty list.
01:04 Exodist kid51, looks like old Test::Builder would have always returned 0 from TB->note, and now it will return undef
01:04 Exodist so if you want to submit a pr to fix that :-)
01:05 devin or... the real bug is having code that actually depends on the return value
01:06 Exodist devin, I am commited to not breaking shit, so I consider this a thing for me to fix
01:06 kid51 exodist:  Can you look at the subroutine starting at https://github.com/steve-m-hay/perl-libnet/blob/master/t/nntp_ipv6.t#L48 ?
01:08 kid51 devin: Would you like to look at that link as well?  Thanks.
01:08 Exodist looking
01:09 kid51 I think it's rather peculiar to end a subroutine with a Test::More::note() -- even inside a test file -- but the person who wrote that probably had a reason to do so
01:09 kid51 But it means that the test file is calling:
01:09 kid51 exit(undef);
01:09 kid51 Hence, the uninit value warning.
01:10 kid51 (This occurs in each of the 3 t/..._ipv6.t files in that distro.
01:10 devin so, yeah, exit(nntp_server()) means we care what nntp_server() returns
01:10 devin so it would be best to explicitly return something
01:11 Exodist agreed
01:12 devin or... just change it to exit(0)
01:16 Jayce^ bah, why doesn't travis-ci have a 5.24 in their image yet?
01:22 kid51 Exodist: filed p.r. with Steve Hay, who appears to be the maintainer:  https://github.com/steve-m-hay/perl-libnet/pull/28
01:52 aherzog joined #pr-challenge
02:09 ether Jayce^: they only just added 5.22, like a month or two ago :/
02:51 kid51 joined #pr-challenge
03:31 rvandam joined #pr-challenge
04:36 veryrusty joined #pr-challenge
06:12 jacoby_ joined #pr-challenge
06:15 mje_ joined #pr-challenge
06:16 sivoais joined #pr-challenge
06:17 dolmen joined #pr-challenge
06:52 dod joined #pr-challenge
06:55 dod joined #pr-challenge
07:12 dod joined #pr-challenge
07:36 neilb joined #pr-challenge
08:14 neilb joined #pr-challenge
08:52 amalia joined #pr-challenge
09:13 kid51 joined #pr-challenge
12:59 veryrusty joined #pr-challenge
14:03 veryrusty joined #pr-challenge
14:47 Skarn joined #pr-challenge
15:27 rvandam joined #pr-challenge
15:35 neilb joined #pr-challenge
17:37 choroba joined #pr-challenge
18:16 dod joined #pr-challenge
20:12 jevin joined #pr-challenge
20:34 choroba My June assignment is endangered:https://rt.cpan.org/Public/Bug/Display.html?id=114301#txn-1640008
20:35 gansh joined #pr-challenge
20:50 sivoais I don't know if it would help, but you could also look at running tests under Appveyor's Windows CI. It is hard to work with since you can't run a debugger on their systems.
20:54 neilb_ joined #pr-challenge
21:23 neilb_ joined #pr-challenge
21:34 gansh joined #pr-challenge
23:17 aherzog joined #pr-challenge
23:32 veryrusty joined #pr-challenge

| Channels | #pr-challenge index | Today | | Search | Google Search | Plain-Text | summary