Perl 6 - the future is here, just unevenly distributed

IRC log for #puppet-openstack, 2013-05-29

| Channels | #puppet-openstack index | Today | | Search | Google Search | Plain-Text | summary

All times shown according to UTC.

Time Nick Message
01:15 openstackgerrit Mathieu Gagné proposed a change to stackforge/puppet-tempest: Add .gitreview  https://review.openstack.org/30813
01:29 dachary1 joined #puppet-openstack
01:31 openstackgerrit Dan Bode proposed a change to stackforge/puppet-openstack_dev_env: update rabbit_user  https://review.openstack.org/30806
01:31 openstackgerrit A change was merged to stackforge/puppet-openstack_dev_env: update rabbit_user  https://review.openstack.org/30806
01:32 openstackgerrit Dan Bode proposed a change to stackforge/puppet-openstack_dev_env: update default version to grizzly  https://review.openstack.org/30807
01:49 openstackgerrit Dan Bode proposed a change to stackforge/puppet-openstack: refactor db connections for compute  https://review.openstack.org/30782
01:51 openstackgerrit Dan Bode proposed a change to stackforge/puppet-openstack: refactor db connections for compute  https://review.openstack.org/30782
01:54 openstackgerrit A change was merged to stackforge/puppet-openstack_dev_env: update default version to grizzly  https://review.openstack.org/30807
01:56 bodepd_ otherwiseguy: np, that code is obviously needed, sorry it took me so long to get it merged
03:47 dachary joined #puppet-openstack
05:42 openstackgerrit A change was merged to stackforge/puppet-glance: Use boolean instead of string  https://review.openstack.org/28761
06:33 mruza joined #puppet-openstack
07:13 mruza joined #puppet-openstack
07:13 dachary joined #puppet-openstack
07:28 dachary1 joined #puppet-openstack
08:24 derekh joined #puppet-openstack
08:52 mgagne1 joined #puppet-openstack
09:40 dachary joined #puppet-openstack
10:39 openstackgerrit Radim K proposed a change to stackforge/puppet-swift: Customizable allowed_sync_hosts in container-server.conf  https://review.openstack.org/29932
11:59 dprince joined #puppet-openstack
12:14 needcoffee joined #puppet-openstack
12:17 needcoffee joined #puppet-openstack
12:20 needcoffee joined #puppet-openstack
13:18 dachary joined #puppet-openstack
14:09 otherwiseguy joined #puppet-openstack
14:51 dachary joined #puppet-openstack
14:53 dachary joined #puppet-openstack
15:57 openstackgerrit Mathieu Gagné proposed a change to stackforge/puppet-tempest: Add .gitreview  https://review.openstack.org/30813
15:58 digicloseup joined #puppet-openstack
18:01 dachary joined #puppet-openstack
18:10 digicloseup joined #puppet-openstack
18:11 digicloseup joined #puppet-openstack
18:14 otherwiseguy joined #puppet-openstack
18:14 dachary joined #puppet-openstack
18:22 digicloseup joined #puppet-openstack
18:48 digicloseup joined #puppet-openstack
19:05 openstackgerrit Dan Bode proposed a change to stackforge/puppet-openstack: refactor db connections for compute  https://review.openstack.org/30782
19:17 openstackgerrit A change was merged to stackforge/puppet-openstack: refactor db connections for compute  https://review.openstack.org/30782
19:24 dachary joined #puppet-openstack
19:59 dachary joined #puppet-openstack
20:55 openstackgerrit Dan Bode proposed a change to stackforge/puppet-openstack_dev_env: Do not install anything form the forge  https://review.openstack.org/30937
20:55 openstackgerrit A change was merged to stackforge/puppet-openstack_dev_env: Do not install anything form the forge  https://review.openstack.org/30937
20:58 openstackgerrit Dan Bode proposed a change to stackforge/puppet-openstack_dev_env: update db params for compute  https://review.openstack.org/30940
21:20 openstackgerrit A change was merged to stackforge/puppet-openstack_dev_env: update db params for compute  https://review.openstack.org/30940
22:10 mruza joined #puppet-openstack
22:25 openstackgerrit Terry Wilson proposed a change to stackforge/puppet-quantum: root_helper shouldn't be set in the agent ini files in grizzly  https://review.openstack.org/30960
22:26 digicloseup joined #puppet-openstack
22:33 digicloseup joined #puppet-openstack
22:45 mruza joined #puppet-openstack
23:06 otherwiseguy so, is it impolite to fix a simple one-line change a reviewer requests in someone else's patch if the review has been sitting for a while? It seems like doing a amended commit would leave them as the author of the commit, right?
23:07 otherwiseguy for example: https://review.openstack.org/#/c/28335/3 hasn't moved since May 22 because of a comment for basically doing s/'True'/true/ in a few places.
23:07 mgagne1 otherwiseguy: they will still be considered the author and you the committer.
23:08 otherwiseguy mgagne: so not an impolite thing to do?
23:08 mgagne otherwiseguy: I don't know if it's polite or not. I did it myself with those quantum patches for RHEL support.
23:08 otherwiseguy just wanted to make sure I wouldn't step on anyone's toes if I fixed something like that to get things moving.
23:08 otherwiseguy mgagne: and I was glad you did. :)
23:09 mgagne As I said, I don't know the etiquette
23:09 otherwiseguy just wanted to make sure that it wouldn't do something weird like take away authorship or something.
23:09 mgagne or if it's considered rude
23:09 mgagne It won't
23:09 mgagne I probably don't have my name in those commits I modified =)
23:09 * otherwiseguy checks
23:10 mgagne checking too
23:10 mgagne https://github.com/stackforge/puppet-quantum/c​ommit/fcd4b2e9af5ec4ebe19debb4dead5d2ea8b65bd1
23:10 mgagne Terry Wilson authored a month ago mgagne committed 11 days ago
23:10 otherwiseguy That's crazy since you wrote pretty much all of it. I'm not sure if any of my code was actually in that.
23:11 mgagne hehe, personally, I don't really care as long as things are moving and as long as it does not become an habit.
23:11 otherwiseguy you totally should have amended the author before committing or something.
23:12 openstackgerrit Terry Wilson proposed a change to stackforge/puppet-quantum: Changes the example files and modifies the README  https://review.openstack.org/28335
23:12 otherwiseguy mgagne: people will think I'm smarter than I am. :p
23:13 mgagne hehe
23:15 mgagne I have to go, I'll try to find some time this week to check reviews. they seem to just pile up. :-/
23:15 otherwiseguy mgagne: a good problem to have, I suppose.
23:15 otherwiseguy have a good night
23:15 mgagne see you
23:15 openstackgerrit A change was merged to stackforge/puppet-quantum: Changes the example files and modifies the README  https://review.openstack.org/28335

| Channels | #puppet-openstack index | Today | | Search | Google Search | Plain-Text | summary