Perl 6 - the future is here, just unevenly distributed

IRC log for #puppet-openstack, 2014-05-29

| Channels | #puppet-openstack index | Today | | Search | Google Search | Plain-Text | summary

All times shown according to UTC.

Time Nick Message
00:00 dtalton joined #puppet-openstack
00:00 dtalton left #puppet-openstack
00:09 meylor joined #puppet-openstack
00:21 ilbot3 joined #puppet-openstack
00:21 Topic for #puppet-openstack is now Place to collaborate on Puppet/OpenStack tools: logs at http://irclog.perlgeek.de/puppet-openstack/today
00:22 openstackgerrit Ricardo Rocha proposed a change to stackforge/puppet-ceph: add ceph-extras repository.  https://review.openstack.org/96065
00:25 longguang how to install  a  special version  like 3.0.0
00:26 dvorak_ joined #puppet-openstack
00:28 longguang i install 4.0.0, but my intended openstack version is havana.   official website of puppet-openstack tells '4.0.0         -> 2014.1.0          -> Icehouse'
00:28 longguang how to solve that?
00:28 dvorak longguang: use the stable/havana branch
00:29 dvorak or are you installing from puppetforge?
00:30 longguang my OS is centos6.3,  it is for production environment, so better not to install from source code
00:32 longguang 'puppet module install puppetlabs/openstack'  , puppet module list  tells 'puppetlabs-openstack (v4.0.0)',
00:32 longguang dvorak:how to install from forge?
00:32 openstackgerrit Ricardo Rocha proposed a change to stackforge/puppet-ceph: add ceph-extras repository.  https://review.openstack.org/96065
00:32 sputnik13 joined #puppet-openstack
00:35 dvorak longguang: 'puppet module install' installs from forge
00:36 longguang dvorak,  that means  modules installed are form forge. so what to do next?
00:41 longguang puppetlabs,fedorapeople, epel  , each one has its own repo, which one to choose?
00:43 ozialien joined #puppet-openstack
00:48 abramley joined #puppet-openstack
01:07 longguang how to subscibe mail?
01:13 britthouser joined #puppet-openstack
01:21 rmoe joined #puppet-openstack
01:40 mmaglana joined #puppet-openstack
01:54 mmaglana joined #puppet-openstack
02:08 britthouser joined #puppet-openstack
03:36 daneyon joined #puppet-openstack
03:42 longguang what is data network?
03:48 shakamunyi joined #puppet-openstack
03:56 daneyon joined #puppet-openstack
04:03 xarses joined #puppet-openstack
04:15 sputnik13 joined #puppet-openstack
04:23 starmer joined #puppet-openstack
05:02 shakamunyi joined #puppet-openstack
05:03 mmaglana joined #puppet-openstack
05:20 ricardorocha joined #puppet-openstack
05:40 shakamunyi joined #puppet-openstack
05:41 sanjayu joined #puppet-openstack
06:47 shakamunyi joined #puppet-openstack
07:03 rickerc joined #puppet-openstack
07:03 artem_panchenko joined #puppet-openstack
07:23 dgollub joined #puppet-openstack
07:25 shakamunyi joined #puppet-openstack
07:26 bogdando joined #puppet-openstack
07:33 longguang Local ip for ovs agent must be set when tunneling is enabled at /etc/puppet/modules/neutron/manifests/agents/ovs.pp
07:33 longguang Error
07:40 dgollub joined #puppet-openstack
07:48 starmer joined #puppet-openstack
07:51 longguang joined #puppet-openstack
08:03 shakamunyi joined #puppet-openstack
08:09 openstackgerrit A change was merged to stackforge/puppet-ceph: Support for RedHat in ceph::mon  https://review.openstack.org/94287
08:10 openstackgerrit A change was merged to stackforge/puppet-ceph: Fixed removal command in ceph::osd  https://review.openstack.org/95955
08:12 openstackgerrit A change was merged to stackforge/puppet-ceph: Remove unnecessary if statement in ceph::mon  https://review.openstack.org/96213
08:25 derekh_ joined #puppet-openstack
08:26 longguang how to print a message?
08:36 mmagr joined #puppet-openstack
08:40 shakamunyi joined #puppet-openstack
08:42 ricardorocha joined #puppet-openstack
08:50 longguang ip_for_network  return a null. why ?
09:05 mattymo dvorak, thanks for the link
09:19 shakamunyi joined #puppet-openstack
09:40 aldavud joined #puppet-openstack
09:48 aldavud joined #puppet-openstack
09:51 aldavud joined #puppet-openstack
09:52 michchap longguang: print a message in puppet? http://stackoverflow.com/questions/4135426/how-to-print-something-when-running-puppet-client
09:58 shakamunyi joined #puppet-openstack
10:03 longguang file {
10:03 longguang "/etc/sudoers"
10:03 longguang }
10:03 longguang if that means  client gets server's '/etc/suders'?
10:04 berendt joined #puppet-openstack
10:05 shakamunyi joined #puppet-openstack
10:10 morazi joined #puppet-openstack
10:10 shakamunyi joined #puppet-openstack
10:12 michchap longguang: it means puppet is managing a file resource at the path '/etc/sudoers', where it gets the data from is determined by the 'contents' or 'source' attributes
10:13 longguang michchap:what if both attributes are absent?
10:14 michchap longguang: do you have an example?
10:14 longguang yes. it is above
10:20 michchap I don't believe that will do anything. The resource may have other attributes coming from elsewhere.
10:23 longguang puppet-openstack  configures node's repo  or  manually by ourself?
10:25 michchap longguang: puppet can configure it. Here's some examples: https://github.com/stackforge/puppet-openstack/tree/master/manifests/repo
10:40 longguang https://github.com/stackforge/puppet-horizon/blob/stable/havana/manifests/init.pp  , line 152
10:44 longguang stackforge and puppetlabs  which one to choose ?
10:47 shakamunyi joined #puppet-openstack
10:48 longguang michchap: how to use repo  puppet-openstack supply
11:03 michchap longguang: use the puppetlabs-openstack module if you need to get started
11:03 michchap longguang: it is simpler than most of the alternatives
11:03 longguang i have wait the install of controller for a while, what shows if it is ended?
11:04 michchap if you are running puppet agent or puppet apply in the foreground, just wait until the process returns
11:04 longguang i use puppet module install,  i do not know which project it choose?
11:04 michchap puppet module install will take from the puppet forge
11:05 longguang in foreground. it does not go ahead.
11:05 michchap it's not printing any output?
11:06 michchap use ps -aux to see if it is doing something that takes a while, like installing a large package (mysql or rabbit)
11:06 longguang yum install puppetlabs-openstack. it only install files into /usr/share/puppet.
11:06 longguang no new output
11:08 michchap have you used puppet before?
11:10 longguang few days, but i have read one book
11:11 michchap try to follow the instrtuctions here: https://github.com/puppetlabs/puppetlabs-openstack
11:13 longguang that is what i am doing.
11:14 longguang i am installing controller.   the above question occurs.
11:15 longguang i am curious that why controller node has openvswitch package?  i think ovs should be installed on computer node
11:17 prad_ joined #puppet-openstack
11:22 prad__ joined #puppet-openstack
11:27 shakamunyi joined #puppet-openstack
11:35 openstackgerrit Ricardo Rocha proposed a change to stackforge/puppet-ceph: define ceph::rgw.  https://review.openstack.org/96060
11:36 ricardorocha joined #puppet-openstack
11:52 openstackgerrit David Moreau Simard proposed a change to stackforge/puppet-swift: Include swift::params in swift::client  https://review.openstack.org/96286
11:53 openstackgerrit David Moreau Simard proposed a change to stackforge/puppet-swift: Include swift::params in swift::client  https://review.openstack.org/96289
11:55 dmsimard aldavud: Don't be shy to add me (David Moreau Simard), dachary (Loic Dachary) and xarses (Andrew Woodward) to your commits, we are the core reviewers for puppet-ceph :)
12:00 prad_ joined #puppet-openstack
12:02 dachary dmsimard: puppet-ceph CI is busy, not broken ;-) For some reason the centos integration tests take 1h. The same tests take 17min on ubuntu.
12:02 dmsimard dachary: oh, okay.
12:03 dachary at 83/125 in the centos series
12:04 dachary it's really nice to see multi os integration tests :-)
12:04 dmsimard yup.
12:07 shakamunyi joined #puppet-openstack
12:15 prad_ joined #puppet-openstack
12:20 aldavud ^ I was surprised that centos takes twice as long as ubuntu though
12:21 longguang why controller install qemu and libvirt? but compute does not ?
12:21 aldavud dmsimard: ok, I will add you :)
12:23 dprince joined #puppet-openstack
12:26 aldavud dmsimard: dachary: I was just rereading https://wiki.openstack.org/wiki/Puppet-openstack/ceph-blueprint#osd as well as https://wiki.openstack.org/wiki/Puppet-openstack/ceph-blueprint#Support_scenario_based_deployment
12:27 michchap longguang: controller should not install qemu or libvirt.
12:27 dachary aldavud: that needs work (i'm not sure it works at the moment) but it's still something I care about
12:28 aldavud hmm
12:28 aldavud OK, I was thinking about doing some refactoring into that direction
12:29 longguang michchap:yes, but it does.
12:29 aldavud because I noticed that 1. bootstrap-osd key handling and 2. creating multiple OSDs using create_resources is what I implemented in https://review.openstack.org/#/c/94195/9/manifests/profile/osd.pp
12:29 longguang node 'agent1.com' { include ::openstack::role::controller }
12:30 dachary aldavud: there is an overlap between the two indeed
12:30 aldavud so I was thinking of moving bootstrap-osd keyhandling into ceph::osd
12:30 michchap longguang: It doesn't. https://github.com/puppetlabs/puppetlabs-openstack/blob/master/manifests/role/controller.pp
12:31 michchap longguang: none of those classes include libvirt. it is in openstack::profiles::nova::compute, which is not included in the controller role.
12:31 aldavud dachary: I'm not sure if the dependency of ceph::osd on ceph::key is a good thing though
12:32 longguang michchap: but that controller is fresh installed?
12:33 aldavud dachary: second thing I was thinking about was adding a ceph::osds, similar to ceph::mons
12:33 longguang modules is install throught 'puppet module install puppetlabs-openstack'.  and compute node does not has qemu package. i have no idea why
12:35 michchap the compute node should be node compute { include ::openstack::role::compute }
12:35 dachary https://review.openstack.org/#/c/94195/9/manifests/profile/osd.pp : I'm not able to comment usefully because I don't know what are the good patterns for profiles/roles.
12:35 dachary aldavud: ^
12:35 dgollub joined #puppet-openstack
12:36 michchap longguang: puppet module install will download the puppet module but will not run puppet for you. You need to create a site.pp and configure hiera to use the modules.
12:37 dachary aldavud: adding ceph::osds is certainly something useful. Even better would be an integration tests showing how it must be used with https://github.com/bodepd/scenario_node_terminus
12:37 morazi joined #puppet-openstack
12:38 longguang dachchap:please take alook at the link. https://dpaste.de/MqvT
12:38 michchap longguang: and hiera?
12:39 michchap longguang: you need something like: https://github.com/puppetlabs/puppetlabs-openstack/blob/master/examples/common.yaml
12:40 michchap longguang: and you need to copy the hiera.yaml from the examples directory to /etc/puppet
12:40 openstackgerrit A change was merged to stackforge/puppet-ceph: Adding spec tests for RedHat family where needed  https://review.openstack.org/96214
12:41 britthouser joined #puppet-openstack
12:41 aldavud dachary: ok, so I will look into doing this. as this means refactoring the roles/profiles, and as it needs integration tests for redhat family anyways, I'll break it up into small patches which are easier to review
12:42 longguang it seems yes.   i follow './openstack/examples/multinode/11_setup_havana.sh'
12:42 dachary aldavud: cool :-)
12:42 longguang michchap: i have a common.yaml
12:44 longguang michchap:that link has any problems?
12:46 michchap longguang: those scripts are designed to be used with Vagrant, I don't know how well they work in other environments
12:49 longguang whatever,  vagrant aim to launch 'puppet agent' on each node
12:50 longguang how to subscribe  mail.
12:50 cbaesema joined #puppet-openstack
12:51 michchap longguang: https://groups.google.com/a/puppetlabs.com/forum/#!forum/puppet-openstack
12:54 longguang go home. we talk next time. thanks michchap.
12:54 sputnik13 joined #puppet-openstack
12:54 michchap longguang: good luck :)
12:54 aldavud dmsimard: we didn't reach a conclusion on the whole params issue, right?
12:55 dmsimard aldavud: I'm fine with keeping the module 2.7 supported since that seems to be the consensus
12:55 longguang michchap:if all nodes need to sync  at the same time?
12:56 dmsimard aldavud: I guess what was left is to ideally bring all the hiera calls in params and use params as a source for parameters inside the profile classes
12:56 michchap longguang: not all nodes need to run puppet agent at the same time. Do the controller first, then the compute nodes.
12:56 openstackgerrit Loic Dachary proposed a change to stackforge/puppet-ceph: obsolete cuttlefish and add firefly  https://review.openstack.org/96451
12:56 longguang ok. i am right. bye
12:59 aldavud dmsimard: so I think the question is now to decide between this: http://paste.openstack.org/show/82019/ and how it currently is.
13:01 aldavud and then refactor once 2.7 support can be dropped
13:01 dmsimard There is no way to avoid that undef hiera issue ? I've never encountered that problem before.
13:02 dmsimard Let me see
13:02 dmsimard Oh, well.. http://projects.puppetlabs.com/issues/20923
13:05 dmsimard hiera autolookup doesn't work in 2.7, that was what you were saying, right ?
13:06 aldavud yes
13:11 dmsimard eh. I guess that'll do. Perhaps add a comment that the hiera calls are there to satisfy 2.7 support
13:16 shakamunyi joined #puppet-openstack
13:18 shakayumi joined #puppet-openstack
13:19 aldavud dmsimard: ok, I'll do it that way. thank you for your input :)
13:21 dmsimard np. I think these are really good and make the module more approachable, a bit akin to what puppet-openstack does for the various openstack modules
13:21 dmsimard And if they're spec/integration tested it makes them that much more awesome
13:21 dmsimard The challenge is to keep them in working order and add the missing pieces are they're added to puppet-ceph (pool, rgw, mds, etc.)
13:22 dmsimard dachary: once the roles/profiles go in, are these going to be taxing on the gerritexec box ?
13:23 dmsimard I mean, it's a lot of testing.
13:26 dmsimard Are multiple gerritexec boxes something that is possible ?
13:28 aldavud from my experience of running the tests locally, i expect gerritexec to take around 2 times as long.
13:28 dmsimard dachary was saying that adding the CentOS tests were pretty heavy, too.
13:28 aldavud so in the last line of the latest run (which only targeted ubuntu) found here http://paste.ubuntu.com/7515785/ the ubuntu tests took twice as long
13:29 aldavud and as centos takes twice as long as ubuntu
13:29 aldavud we're looking at runtimes of around 2 hours :(
13:30 dmsimard I told dachary maybe I can help, just need to know what's the range of possibilities
13:39 sputnik13 joined #puppet-openstack
13:47 shakayumi joined #puppet-openstack
13:49 prad_ joined #puppet-openstack
13:50 morazi joined #puppet-openstack
13:56 openstackgerrit A change was merged to stackforge/puppet_openstack_builder: Configure MySQL before db sync runs  https://review.openstack.org/88033
13:58 openstackgerrit A change was merged to stackforge/puppet_openstack_builder: Add variables for active-passive Galera HA proxy  https://review.openstack.org/94738
14:00 openstackgerrit A change was merged to stackforge/puppet_openstack_builder: Allow rabbitmq erlang cookie to be set  https://review.openstack.org/94902
14:00 prad_ joined #puppet-openstack
14:01 openstackgerrit A change was merged to stackforge/puppet_openstack_builder: Supress default vhost creation in HA scenarios  https://review.openstack.org/94959
14:03 openstackgerrit A change was merged to stackforge/puppet_openstack_builder: Horizon login failing due to incorrect endpoint  https://review.openstack.org/94956
14:03 prad__ joined #puppet-openstack
14:06 aldavud dachary: I have some generic problem concerning scenario_node_terminus
14:09 aldavud afaik its only available as git repository, but not on a forge. so I would need to install it via librarian-puppet(-simple)
14:12 aldavud so I would need to include that as well and change the setup process to ensure it is installed and in the path
14:15 aldavud do you know of an alternative way to do this?
14:15 aldavud bodepd: can you provide some input on this ^
14:26 openstackgerrit Chris Ricker proposed a change to stackforge/puppet_openstack_builder: Set charset and collation order parameters  https://review.openstack.org/95248
14:27 mmagr joined #puppet-openstack
14:29 rickerc joined #puppet-openstack
14:33 openstackgerrit Chris Ricker proposed a change to stackforge/puppet_openstack_builder: Set charset and collation order parameters  https://review.openstack.org/95248
14:40 mmaglana joined #puppet-openstack
14:48 mmaglana joined #puppet-openstack
14:48 dvorak aldavud: the bootstrap in POB uses librarian-puppet-simple to do just that.
14:50 dvorak personally I wouldn't recommend anyone use SNT at this point, it appears to be mostly abandoned.  Michael Chapman and I have both had open pull requests against it for months.
14:50 dvorak we moved off of it about a month ago
14:54 mmagr joined #puppet-openstack
14:55 aldavud dvorak: i'm just reading through the POB bootstrap.
14:56 aldavud installing lps via gem, installing modules via lps and then moving the modules directory into place. not very elegant :/
14:57 berendt joined #puppet-openstack
14:58 dvorak lps?
14:58 aldavud librarian-puppet-simple
14:58 dvorak ah, nod
14:58 kkirkpatrick joined #puppet-openstack
14:59 aldavud so if i want to run some integration tests on some very bare-bone system, I start with installing gems/rubygems via package manager, just to add another step
15:02 aldavud dvorak: so what would you recommend as the current approach instead of snt? roles/profiles as in puppetlabs-openstack?
15:03 dvorak aldavud: unfortunately I don't have a recommendation right now, since we're still running a gross mashup of the Cisco coi/coe modules from pob and trying to refactor that into something less gross
15:04 dvorak I would probably look at puppetlabs-openstack though, yes
15:33 rharrison joined #puppet-openstack
15:38 mdorman joined #puppet-openstack
15:41 mmaglana joined #puppet-openstack
15:46 starmer joined #puppet-openstack
15:46 mmaglana quick update on aviator. i'm just waiting for a 2nd +2 to this openstack infra patch: https://review.openstack.org/#/c/96056/
15:50 openstackgerrit Yanis Guenane proposed a change to stackforge/puppet-swift: Avoid duplication error when ringserver and storage are on the same node  https://review.openstack.org/96505
16:00 openstackgerrit Chris Ricker proposed a change to stackforge/puppet_openstack_builder: Set up Apache on build server for HA  https://review.openstack.org/96508
16:05 sputnik13 joined #puppet-openstack
16:15 rmoe joined #puppet-openstack
16:15 aimon joined #puppet-openstack
16:16 rmoe joined #puppet-openstack
16:16 EmilienM dmsimard: hey, if you have some time to have a look at https://review.openstack.org/#/c/96505/
16:17 EmilienM oops already done, sorry :-)
16:19 dmsimard Looked over briefly, I'd like it to have tests at least before actually testing it
16:20 dmsimard I'm guessing this is purely for testing/integration ? You probably wouldn't have this in production ?
16:23 spredzy dmsimard, normally not, since it's not an optimal setup
16:24 spredzy dmsimard, what kind of test would you like to see exactly there ?
16:25 openstackgerrit Emilien Macchi proposed a change to stackforge/puppet-neutron: Configure OVS Agent when using ML2 plugin  https://review.openstack.org/82353
16:25 openstackgerrit Emilien Macchi proposed a change to stackforge/puppet-neutron: Configure OVS Agent when using ML2 plugin  https://review.openstack.org/82353
16:25 xarses joined #puppet-openstack
16:27 dmsimard spredzy: for example if rsync::server is already in the manifest, it does not contain class rsync::server
16:27 dmsimard spredzy: Test that the code behaves like it should
16:29 britthouser joined #puppet-openstack
16:30 morazi joined #puppet-openstack
16:37 mattymo EmilienM, for your ML2 change, I asked our neutron puppet expert to review and check it out too
16:37 mattymo expect some updates in the next few days
16:37 EmilienM cool
16:37 mattymo we're really excited you did the hard work :)
16:38 EmilienM lol
16:38 EmilienM it was not hard !
16:38 EmilienM just copy paste and adapt
16:42 openstackgerrit Emilien Macchi proposed a change to stackforge/puppet-cinder: Storage availability zone support  https://review.openstack.org/92993
17:00 spredzy dmsimard, http://paste.openstack.org/show/82067/
17:00 spredzy I tried two things to ensure the class is not included but none work, could I get your input on the paste I just posted
17:01 sputnik13 joined #puppet-openstack
17:08 openstackgerrit Yanis Guenane proposed a change to stackforge/puppet-swift: Avoid duplication error when ringserver and storage are on the same node  https://review.openstack.org/96505
17:08 spredzy dmsimard, found a way to test it ^
17:10 aldavud dachary: ok, I think I found a way how to have a common layer which supports both scenario_node_terminus as well as roles/profiles. I'll shortly commit the code for ceph::mons.
17:11 openstackgerrit Loic Dachary proposed a change to stackforge/puppet-ceph: obsolete cuttlefish and add firefly  https://review.openstack.org/96451
17:12 xarses_ joined #puppet-openstack
17:23 aimon joined #puppet-openstack
17:30 openstackgerrit Ivan Chavero proposed a change to stackforge/puppet-ceilometer: Fixes agent_notification_service_name  https://review.openstack.org/95519
17:51 ozialien joined #puppet-openstack
17:51 bodepd aldavud: hey, lemme look
17:53 bodepd aldavud: yep, not forge module. honestly I'm about to rewrite it to make it hiera-compatible
17:53 bodepd aldavud: so I'm not very motivated to publish it
17:53 bodepd aldavud: you may want to talk to michchap about that
17:53 bodepd aldavud: he is leading that effort atm
17:59 aldavud bodepd: ok. thank you :)
18:47 rmoe joined #puppet-openstack
18:55 bodepd joined #puppet-openstack
18:57 hogepodge joined #puppet-openstack
18:58 rharrison joined #puppet-openstack
19:02 starmer joined #puppet-openstack
19:07 openstackgerrit joined #puppet-openstack
19:27 derekh_ joined #puppet-openstack
19:35 openstackgerrit joined #puppet-openstack
19:42 mgagne for people using Nginx to do proxying or SSL termination for Glance, make sure underscores_in_headers is On or Nginx will silently strip headers with underscores such as is_public, disk_format, etc.
19:46 xarses joined #puppet-openstack
20:01 imcsk8 joined #puppet-openstack
20:11 aldavud joined #puppet-openstack
20:18 mdorman joined #puppet-openstack
20:27 aldavud review is down?
20:44 kitp joined #puppet-openstack
20:52 shakamunyi joined #puppet-openstack
20:54 ozialien joined #puppet-openstack
20:58 rmoe joined #puppet-openstack
20:59 xarses joined #puppet-openstack
21:01 hogepodge_ joined #puppet-openstack
21:03 hogepodge joined #puppet-openstack
21:07 dmsimard mgagne: ouch
21:11 xarses joined #puppet-openstack
21:11 rmoe joined #puppet-openstack
21:11 aldavud dachary: can you have a look at this: https://review.openstack.org/#/c/96580/
21:12 aldavud dmsimard: obviously you can too, but it's currently more of a gerritexec configuration thing than anything else ;)
21:24 cwolferh joined #puppet-openstack
21:26 starmer joined #puppet-openstack
21:33 hogepodge joined #puppet-openstack
21:34 aldavud dmsimard: I just figured out that I can work around using the hiera commaned for 2.7 after all, I would just need to pass working defaults to all parameters
21:34 openstackgerrit joined #puppet-openstack
21:42 dachary aldavud: I'm not sure why puppet-librarian is needed outside of the virtual machines running the tests ?
21:43 * dachary having trouble looking at https://review.openstack.org/#/c/96580/ because it's very slow
21:43 ricardorocha joined #puppet-openstack
21:45 dachary aldavud: https://review.openstack.org/#/c/96580/2/spec/spec_helper_system.rb makes sense though
21:46 aldavud dachary: you are right, it's not necessary outside. but it's convenient
21:46 dachary how so ?
21:47 aldavud so I can install it into the VM the way I suggested here  https://review.openstack.org/#/c/96580/2/spec/spec_helper_system.rb
21:49 aldavud it's not available as a puppet module, so I can either transfer it from outside, or I need to start installing a toolchain (rubygems/librarian-puppet/Puppetfile) inside the VM first
21:54 dachary oh
21:57 aldavud hmm, actually I could also do a git checkout. but then I would need to install git first
21:58 dtalton joined #puppet-openstack
21:59 dtalton left #puppet-openstack
21:59 dachary I can install it locally
21:59 dachary proj_root does not seem the right location though
22:01 dachary done
22:01 aldavud yes, proj_root is indeed not a good location
22:02 dachary aldavud: it is either in scenario_node_terminus (gerritexec runs from the directory in which git clone was done) or proj_root/../scenario_node_terminus
22:03 dachary I'm not sure what the current working directory is when https://review.openstack.org/#/c/96580/2/spec/spec_helper_system.rb runs
22:03 dachary proj_root/../scenario_node_terminus is probably a safe bet : it is in the same directory as the ceph module being tested
22:04 dachary aldavud: ^
22:04 aldavud good, I'll adapt it then.
22:06 aldavud I'll put a "git clone..." into the README, so people can run it themselves
22:11 shakamunyi joined #puppet-openstack
22:21 shakayumi joined #puppet-openstack
22:26 aldavud dachary: changes are commited, but I think the integration test system is experiencing issues again
22:26 * dachary checking
22:31 dachary aldavud: for some reason, sometimes, vagrant fails to cleanup the virtual machines. I'm yet to figure out the pattern :-/
22:32 aldavud dachary: I'm experiencing the same issue when testing locally
22:38 xarses joined #puppet-openstack
22:44 aldavud dachary: is there a way to enforce dependencies in scenario_node_terminus?
22:44 aldavud dachary: or does it need to be handled entirely in the module?
22:45 dachary bodepd: knows better. But I think it's only in the module indeed.
22:45 michchap aldavud: must be in the modules
22:46 aldavud michchap: thanks for clearing this up
22:47 aldavud ok, then I'll need to introduce a bunch of additional dependencies :/
22:50 kkirkpatrick joined #puppet-openstack
22:51 bodepd aldavud: what do you mean by deps?
22:52 bodepd first pass at updating the spec template: https://review.openstack.org/#/c/96627
22:52 kkirkpatrick joined #puppet-openstack
22:52 bodepd michchap: mgagne I'd love to have you guys involved. I already want to write a spec!
22:54 aldavud bodepd: things like Package['foo'] -> Service['bar']
22:54 starmer joined #puppet-openstack
22:58 bodepd you could need to add those in a separate class, then include that class either as a class or in a class group
22:58 dachary aldavud: there should not be too many of them. The only dependency that really matters is that conf files are written before the service starts
22:58 dachary osd can start before the mon and will block until it becomes available
22:59 michchap aldavud: Is this because you wanted to use deps between classes to avoid doing it for individual resources?
23:02 aldavud aldavud: mostly yes. I feel putting require/before/-> everywhere adds unnecessery coupling
23:02 aldavud michchap: ^
23:02 aldavud also it has huge potential for errors
23:03 michchap aldavud: I agree in one sense, but in another sense it's probably less error prone as the manifests change over time, because class dependencies are not always apparent to someone making a patch.
23:03 aldavud dachary: and repository is available before the package, and the package before the conf, and the conf before mons/osds
23:04 aldavud dachary: and then it gets annoying when trying to remove them, because you get circular dependencies
23:04 dachary right
23:05 dachary repo -> package -> mon / osd
23:05 dachary conf -> mon / osd
23:05 bodepd aldavud: you can specify conditional deps (dep on it, if it exists in the catalog)
23:06 bodepd aldavud: the syntax is kind of ugly, but we use it all over the place in the OS code (my fault :) )
23:06 * dachary out for the night
23:06 aldavud bodepd: oh! good to know :)
23:08 aldavud bodepd: so basically you do an "if defined(Class['foo']) { $foo = Class['foo'] }" and the "require => $foo" ?
23:09 michchap aldavud: https://github.com/michaeltchapman/puppet-openstacklib/blob/master/manifests/loadbalance/haproxy.pp#L112
23:09 derekh_ joined #puppet-openstack
23:10 bodepd yep, michchap's got it. use collections to specify conditional deps
23:10 michchap aldavud: This is how I make haproxy go before rabbitmq/mysql if they are present in the catalog. It will have no effect if they are not. defined() is parse order dependent afaik, which makes it very difficult to use.
23:10 bodepd I think it's the best of both worlds. reasonable default deps without couplling
23:11 bodepd it *probably* has performance implications b/c I'm not sure if Puppet is really meant to be used like that
23:11 dvorak aldavud: consider doing the dependencies using resource collectors.  they'll add the dependencies if the resources exist, and degrade gracefully if they don't
23:11 dvorak apparently I should read slightly more scrollback before commenting :)
23:12 dvorak I agree with everything michchap said
23:13 aldavud ah, I was using collectors, but the issue was I was doing them too broad, i.e Package<| |> -> ...
23:14 aldavud which interfered too much with unrelated modules
23:14 michchap bodepd: aldavud: the collector style can be a bit fragile if you're collecting on title, because there is a small change titles may change.
23:15 michchap s/small change/small chance
23:16 dvorak aldavud: please don't do wildcard package collectors, they're evil :)
23:17 starmer joined #puppet-openstack
23:17 dvorak michchap: is that any different than if he did the explicit name?
23:17 michchap dvorak: it will fail silently instead of failing to compile
23:18 dvorak ah, nod
23:18 dvorak but the semantics are the same otherwise, right?
23:19 michchap dvorak: yeah. Fragile was not a great choice of word.
23:20 aldavud dvorak: yes. I guess my issue was not to think of the middle way of using collectors on titles
23:21 dvorak aldavud: I didn't find it real intuitive and I've not see a lot of good examples, but it's a technique that seems to work well
23:39 rharrison joined #puppet-openstack

| Channels | #puppet-openstack index | Today | | Search | Google Search | Plain-Text | summary