Perl 6 - the future is here, just unevenly distributed

IRC log for #puppet-openstack, 2015-01-08

| Channels | #puppet-openstack index | Today | | Search | Google Search | Plain-Text | summary

All times shown according to UTC.

Time Nick Message
00:00 markvoelker joined #puppet-openstack
00:07 openstackgerrit Emilien Macchi proposed stackforge/puppet-ceilometer: Implement Ceilometer-API as a WSGI process support  https://review.openstack.org/145638
00:07 EmilienM sbadia: something new^
00:20 openstackgerrit Merged stackforge/puppet-keystone: Use openstackclient for keystone_endpoint  https://review.openstack.org/143385
00:34 crinkle ^ finally
00:37 EmilienM lol
00:40 crinkle hrm, ceilometer still seems broken :(
00:41 EmilienM crinkle: I would need to rebase?
00:41 EmilienM let me check!
00:47 xarses joined #puppet-openstack
00:57 crinkle :( others are broken too
00:58 crinkle when I print $LOAD_PATH it seems like it should be able to find puppet/util/openstack, it doesn't make sense that it can't
01:00 markvoelker joined #puppet-openstack
01:01 EmilienM we fixed puppet-keystoen, we broke all other modules!
01:10 crinkle :(
01:16 rmoe joined #puppet-openstack
01:38 britthou_ joined #puppet-openstack
01:53 crinkle EmilienM: I think I have two possible solutions
01:54 crinkle my coworker helped me figure out that there is a bug in either puppet or rspec-puppet or both that causes the $LOAD_PATH to append a colon-separated list of the lib dirs, which doesn't work
01:54 crinkle it means that things can't be found in lib/puppet/util
01:55 crinkle one thing I just tried that works is adding a line like https://github.com/gentoo/puppet-portage/blob/​master/lib/puppet/type/package_keywords.rb#L1 to the top of every type
01:55 crinkle actually three possible solutions
01:57 crinkle the second suggestion is to monkey with one of the rspec-puppet methods that's setting up the load path in the rspec module in spec/spec_helper.rb in every module
01:57 crinkle which seems unappealing to me
01:57 crinkle the last thing I think we could do is move lib/puppet/util/openstack.rb into lib/puppet/type/openstack.rb
01:58 crinkle I haven't tried it yet but I think that might help it find it
01:58 crinkle not sure yet
01:58 EmilienM I like #3 and #1
02:00 EmilienM crinkle: if #3 works, I would go for that one.
02:01 markvoelker joined #puppet-openstack
02:02 crinkle EmilienM: it doesn't seem to work :(
02:06 EmilienM crinkle: is #1 a big deal?
02:07 crinkle I think it would be fine, just a little hacky
02:07 crinkle I'm also looking at rspec-puppet to see if there's something I could fix there
02:27 ericpeterson joined #puppet-openstack
02:35 openstackgerrit Mike Dorman proposed stackforge/puppet-nova: Add Nova Aggregate support  https://review.openstack.org/70344
02:47 xarses joined #puppet-openstack
02:50 badiane_ka joined #puppet-openstack
03:03 markvoelker joined #puppet-openstack
03:08 openstackgerrit Colleen Murphy proposed stackforge/puppet-keystone: Add lib directories to $LOAD_PATH if not present  https://review.openstack.org/145677
03:09 crinkle EmilienM: ^ I think that will fix it
03:10 EmilienM crinkle: looking
03:38 aimon joined #puppet-openstack
03:52 EmilienM sbadia: michchap_ : this is an urgent one (if you around): https://review.openstack.org/#/c/145677
04:22 fandi joined #puppet-openstack
04:23 fandi joined #puppet-openstack
04:26 fandi joined #puppet-openstack
04:51 markvoelker joined #puppet-openstack
04:52 subscope joined #puppet-openstack
05:08 fedexo_ joined #puppet-openstack
05:08 fedexo joined #puppet-openstack
05:16 sanjayu joined #puppet-openstack
05:21 fedexo__ joined #puppet-openstack
05:21 fedexo joined #puppet-openstack
05:26 saju_m joined #puppet-openstack
05:52 markvoelker joined #puppet-openstack
06:53 markvoelker joined #puppet-openstack
06:56 stamak joined #puppet-openstack
07:58 berendt joined #puppet-openstack
08:17 mmagr joined #puppet-openstack
08:21 rcallawa_ joined #puppet-openstack
08:22 qba73 joined #puppet-openstack
08:23 tfz joined #puppet-openstack
08:54 markvoelker joined #puppet-openstack
09:10 jistr joined #puppet-openstack
09:17 derekh joined #puppet-openstack
09:22 arnaud_orange joined #puppet-openstack
09:26 dalgaaf joined #puppet-openstack
09:56 markvoelker joined #puppet-openstack
10:02 rcallawa joined #puppet-openstack
10:39 dgurtner joined #puppet-openstack
10:46 stamak joined #puppet-openstack
11:01 openstackgerrit Merged stackforge/puppet-keystone: Add lib directories to $LOAD_PATH if not present  https://review.openstack.org/145677
11:18 openstackgerrit Sebastien Badia proposed stackforge/puppet-sahara: Migrate postgresql backend to use openstacklib::db::postgresql  https://review.openstack.org/145511
11:18 openstackgerrit Sebastien Badia proposed stackforge/puppet-sahara: fixtures: Unpin puppetlabs-mysql module  https://review.openstack.org/145510
11:18 openstackgerrit Sebastien Badia proposed stackforge/puppet-sahara: Rewrite puppet-sahara from scratch  https://review.openstack.org/145509
11:49 social joined #puppet-openstack
12:02 EmilienM good morning!
12:11 EmilienM crinkle: it's fixed, other patches pass jenkins - thanks sbadia for merge!
12:32 pasquier-s joined #puppet-openstack
12:39 openstackgerrit sajuptpm proposed stackforge/puppet-heat: added option to configure flavor in heat.conf  https://review.openstack.org/104795
12:44 jpena joined #puppet-openstack
12:52 derekh joined #puppet-openstack
13:07 markvoelker joined #puppet-openstack
13:10 dprince joined #puppet-openstack
13:18 morazi joined #puppet-openstack
13:21 openstackgerrit Merged stackforge/puppet-nova: rpc_backend: simplify parameters  https://review.openstack.org/144649
13:22 pasquier-s joined #puppet-openstack
13:32 sbadia EmilienM: ah cool! for wsgi patchs \o
13:32 sbadia (hi here)
13:33 sbadia EmilienM: héhé, you also add concat to fixtures, this will conflit with my pending patchs on postgres, but it's not a problem :)
13:34 EmilienM sbadia: my patch on p-ceilometer?
13:34 EmilienM sbadia: I'll rebase, go ahead
13:34 sbadia yup yup ;)
13:34 sbadia crinkle: thanks for the fix/patch (on keystone)
13:35 sbadia rharwood: seems ok, I've just addressed Sergey comments
13:35 sbadia rharwood: thx
13:42 rcallawa joined #puppet-openstack
14:14 britthouser joined #puppet-openstack
14:17 openstackgerrit Lukas Bezdicka proposed stackforge/puppet-nova: Add support for nova Pci passthrough  https://review.openstack.org/145787
14:18 EmilienM social: reviewing now ^
14:19 social EmilienM: I still expect issues with it but yeah should work
14:19 EmilienM social: I'm doing inline review
14:28 rharwood sbadia: awesome, thanks
14:29 richm joined #puppet-openstack
14:33 EmilienM social: reviewed !
14:37 social EmilienM: I don't understand the I would drop this code to let people using it in their composition layer via Hiera for example:
14:40 dvorak since a bunch of neutron database migrations are conditional on certain plugin features being configured, shouldn't neutron-db-sync depend on Neutron_Config<||> ?
14:40 dvorak I guess it'd have to depend on all the plugin specific config options also...
14:41 EmilienM social: you can let it, I would not argue too long.
14:41 EmilienM but I think you should move the code to nova::compute namespace
14:44 social EmilienM: but it has to be called on compute and api nodes
14:44 social pci_passhtrough_whitelist is for compute
14:44 social pci_alias is for api
14:45 EmilienM so pci_alias needs to go in nova::api
14:45 EmilienM we need consistency in our modules
14:45 mschmitt joined #puppet-openstack
14:45 social EmilienM: I was looking more into what nova::network::neutron does
14:45 social EmilienM: that also should be called on api and compute nodes
14:48 social EmilienM: anyway split is possible I just preffered compact setting for passthrough
15:13 berendt joined #puppet-openstack
15:44 mdorman joined #puppet-openstack
16:04 saju_m joined #puppet-openstack
16:06 richm EmilienM: for the puppet-keystone openstackclient commits - can I use the gerrit ui and just Cherry Pick To stable/juno?  Or will this require something else?
16:07 EmilienM richm: yes, #1
16:13 mmagr joined #puppet-openstack
16:43 openstackgerrit Merged stackforge/puppet-glance: Fix typo  https://review.openstack.org/145490
16:44 openstackgerrit Merged stackforge/puppet-neutron: /etc/default/neutron-server file is only on Ubuntu packages  https://review.openstack.org/145191
16:47 badiane_ka joined #puppet-openstack
16:59 tfz joined #puppet-openstack
17:03 richm I need some help with gerrit git
17:03 EmilienM richm: shoot
17:03 richm I'm trying to create a chain of commits based on https://review.openstack.org/#/c/145635/
17:04 richm this review was created from colleen's master branch keystone_tenant review by using Cherry Pick To stable/juno
17:04 richm so now I want to cherry pick the other changes on top of this one in the same order
17:04 EmilienM create a branch
17:05 richm right
17:05 EmilienM cherry-pick -x
17:05 richm right
17:05 EmilienM each one after each
17:05 richm do all of the changes have to be on separate branches?
17:05 richm e.g. can I do git review -d 145635 to pull down the base commit (tenant), then just cherry pick all of the other changes on top of that one in the same branch?
17:06 EmilienM I don't think so
17:08 richm do I also need commit 031300546a104377623a96506b5d1b8eabc5b4c9 Add lib directories to $LOAD_PATH if not present ?
17:10 openstackgerrit Merged stackforge/puppet-ceilometer: Fix syntax error with postgresql database string  https://review.openstack.org/145126
17:10 crinkle richm: yes
17:10 crinkle https://github.com/stackforge/puppet-ke​ystone/commit/6af8ac6320c8e93a8dae73aa2​86350d98d3972f1#commitcomment-9203942 :(
17:11 EmilienM oops
17:24 rmoe joined #puppet-openstack
17:24 richm git review -d 145635 # now on branch review/richard_megginson/145635
17:24 richm git cherry-pick -x 72a02aa70880bb5cb07d0a2b1e828fffbae5d0ed
17:24 richm $ git review
17:25 richm You are about to submit multiple commits blah blah blah
17:25 richm e1ea2cf (HEAD, osc-juno) Use openstackclient for keystone_service
17:25 richm a09bc1b Use openstackclient for keystone_tenant
17:25 richm ! [remote rejected] HEAD -> refs/publish/master/bp/use-open​stackclient-in-module-resources (change 142608 closed)
17:25 richm what the?
17:27 richm what am I doing wrong?  do I need to remove the "blueprint use-openstackclient-in-module-resources" from the git commit messages for the backports?
17:29 richm nope - now I get a different error:
17:29 richm ! [remote rejected] HEAD -> refs/publish/master/osc-juno (change 142608 closed)
17:30 richm Do I need a different Change-ID?  Note that the gerrit cherry picked commit has the same Change-ID as the commit on master
17:34 richm google says gerrit allows each change-id to exist once on each branch
17:35 openstackgerrit Matt Fischer proposed stackforge/puppet-keystone: Fix deprecated LDAP config options  https://review.openstack.org/145847
17:38 nosleep77 joined #puppet-openstack
17:40 richm hmm - but also if the change has been closed before cherry-picking, the cherry-picked change will be rejected by Gerrit
17:41 openstackgerrit Richard Megginson proposed stackforge/puppet-keystone: Use openstackclient for keystone_tenant  https://review.openstack.org/145848
17:41 openstackgerrit Richard Megginson proposed stackforge/puppet-keystone: Use openstackclient for keystone_service  https://review.openstack.org/145851
17:42 openstackgerrit Richard Megginson proposed stackforge/puppet-keystone: Use openstackclient for keystone_role  https://review.openstack.org/145853
17:43 openstackgerrit Richard Megginson proposed stackforge/puppet-keystone: Use openstackclient for keystone_user  https://review.openstack.org/145854
17:43 openstackgerrit Richard Megginson proposed stackforge/puppet-keystone: Use openstackclient for keystone_user_role  https://review.openstack.org/145855
17:43 openstackgerrit Richard Megginson proposed stackforge/puppet-keystone: Use openstackclient for keystone_endpoint  https://review.openstack.org/145856
17:44 openstackgerrit Richard Megginson proposed stackforge/puppet-keystone: Add lib directories to $LOAD_PATH if not present  https://review.openstack.org/145857
17:45 sbadia richm: hum your cherry-pick seem wrong (from master to master)
17:45 sbadia (for each cherry-pick in fact :s)
17:45 richm arg
17:45 richm why????
17:46 richm what am I doing wrong????
17:46 sbadia you used the cherry-pick button of gerrit ?
17:47 richm sbadia: for the initial base commit - https://review.openstack.org/145635
17:47 richm sbadia: all of the other cherry picked commits depend on that one
17:47 sbadia hum strange :s indeed, the root-one (145635) is ok
17:47 richm I suppose I could just use the cherry-pick button of gerrit for all of them, then we can ignore the jenkins failures?
17:48 sbadia yep, and abandon those submited in master
17:49 richm sbadia: note that my local git says that all of the commits are branched from stable/juno . . .
17:49 sbadia :s
17:50 richm ah, crap
17:50 richm forgot to git-review [branch] :-(
17:50 richm I keep assuming git-review is smart enough to know which branch I'm on . . .
17:50 sbadia it's a topic for http://openstackreactions.enovance.com/ :-D
17:51 sbadia Related changes nightmare \o/
17:54 openstackgerrit Colleen Murphy proposed stackforge/puppet-keystone: Remove keystone.rb provider for keystone_endpoint  https://review.openstack.org/145861
17:56 crinkle that ^ will need to be cherry-picked too
17:56 crinkle I'm trying to verify whether this is broken on ubuntu
17:57 tfz joined #puppet-openstack
18:02 fandi joined #puppet-openstack
18:09 imcsk8 joined #puppet-openstack
18:19 EmilienM sbadia: lol
18:22 saju_m joined #puppet-openstack
18:32 EmilienM sbadia: crinkle richm I +2 all backports - if you want to review/merge them (except if the Ubuntu bug is blocking)
18:41 ericpeterson joined #puppet-openstack
18:50 xarses joined #puppet-openstack
18:54 aimon joined #puppet-openstack
19:41 mdorman joined #puppet-openstack
20:00 rmoe joined #puppet-openstack
20:00 xarses joined #puppet-openstack
20:01 ericpete_ joined #puppet-openstack
20:10 rcallawa_ joined #puppet-openstack
20:16 subscope_ joined #puppet-openstack
20:21 mdorman joined #puppet-openstack
20:23 beddari joined #puppet-openstack
20:32 ericpeterson joined #puppet-openstack
20:47 openstackgerrit Matt Fischer proposed stackforge/puppet-keystone: Fix deprecated LDAP config options  https://review.openstack.org/145847
21:03 openstackgerrit Matt Fischer proposed stackforge/puppet-keystone: Fix deprecated LDAP config options  https://review.openstack.org/145847
21:06 openstackgerrit Dan Prince proposed stackforge/puppet-swift: Correct proxy::authtoken docs  https://review.openstack.org/145933
21:13 openstackgerrit Matt Fischer proposed stackforge/puppet-cinder: Don't configure admin URI using fragments  https://review.openstack.org/145333
21:13 EmilienM mfisch: https://review.openstack.org/#/c/145847/ - reviewed
21:14 mfisch EmilienM: merci mon ami
21:14 EmilienM :)
21:14 mfisch that was painful BTW
21:14 mfisch but deprecations always are
21:14 EmilienM yeah
21:14 EmilienM thanks for taking care of that
21:15 EmilienM I would suggest to backport it to stable/jundo
21:15 EmilienM I would suggest to backport it to stable/juno
21:15 EmilienM and you redo a patch in deleting the deprecation
21:15 EmilienM what do you think?
21:15 EmilienM mfisch: ^^^^
21:16 mfisch I think we'd keep the deprecations for awhile
21:16 mfisch since they're new
21:16 mfisch maybe until after kilo?
21:17 mfisch so I need to check for that fail() call
21:17 mfisch is that just raise_error(Puppet::Error, ????)
21:17 mfisch expect raise error I mean
21:18 rcallawa joined #puppet-openstack
21:19 EmilienM okay
21:19 EmilienM mfisch: yeah, you should find some examples
21:20 mfisch yep
21:23 mfisch almost ready
21:23 EmilienM crinkle: do you think we can merge richm 's backports?
21:23 openstackgerrit Matt Fischer proposed stackforge/puppet-keystone: Fix deprecated LDAP config options  https://review.openstack.org/145847
21:24 EmilienM whouhoo
21:24 EmilienM mfisch: looking
21:24 mfisch argh I forgot a word
21:24 mfisch "new"
21:24 EmilienM lol
21:24 mfisch let me fix
21:25 mfisch just in the test description but still
21:25 openstackgerrit Matt Fischer proposed stackforge/puppet-keystone: Fix deprecated LDAP config options  https://review.openstack.org/145847
21:25 EmilienM waiting for jenkins then +2
21:25 mfisch mb
21:25 EmilienM mfisch: please take care of the backport to stable/juno
21:25 mfisch yeah will do
21:29 openstackgerrit Matt Fischer proposed stackforge/puppet-cinder: Don't configure admin URI using fragments  https://review.openstack.org/145333
21:36 crinkle EmilienM: I'm working on a fix for ubuntu, will have it out in a bit
21:37 crinkle then we can backport things
21:37 EmilienM ack
21:37 crinkle but I don't think there's a rush since we can dev v3 stuff against master for now
21:37 EmilienM crinkle: I'm curious how you fix it
21:37 EmilienM yup
21:37 EmilienM crinkle: it's because I wanted to run our CI against these patches ASAP, and our CI runs stable/juno
21:37 crinkle oh I see
21:38 EmilienM but nevermind
21:51 openstackgerrit Dan Prince proposed stackforge/puppet-swift: Add seed parameter to ringbuilder::rebalance.  https://review.openstack.org/145941
21:57 dprince joined #puppet-openstack
21:57 EmilienM dprince: back in the game :-)
21:58 dprince dprince: ha!
21:58 dprince EmilienM: ha!
21:58 EmilienM good to see you again working on Puppet
21:59 dprince EmilienM: I've been poking around a bit
22:02 dprince EmilienM: re your comment here: https://review.openstack.org/#/c/145941/. If we use false/undef wouldn't I need two separate Exec blocks which we choose with a conditional if $seed is set?
22:03 EmilienM checking
22:06 dprince EmilienM: gotta run out. will check back...
22:06 EmilienM dprince: I'll review online
22:06 EmilienM inline*
22:09 EmilienM crinkle: can you confirm my comment on https://review.openstack.org/#/c/1459​41/1/manifests/ringbuilder/rebalance.pp,cm ?
22:11 crinkle EmilienM: hrm undef is funny
22:11 crinkle I think either will work though
22:11 crinkle let me test
22:13 EmilienM false?
22:14 crinkle don't use false
22:14 crinkle http://paste.openstack.org/show/156031/
22:17 EmilienM ok
22:17 EmilienM dprince: undef then
22:19 rcallawa_ joined #puppet-openstack
22:30 dprince EmilienM: thanks, undef it is
22:31 gildub joined #puppet-openstack
22:36 openstackgerrit Dan Prince proposed stackforge/puppet-swift: Add seed parameter to ringbuilder::rebalance.  https://review.openstack.org/145941
23:17 rcallawa joined #puppet-openstack
23:19 rcallawa joined #puppet-openstack
23:30 mdorman joined #puppet-openstack

| Channels | #puppet-openstack index | Today | | Search | Google Search | Plain-Text | summary