Perl 6 - the future is here, just unevenly distributed

IRC log for #puppet-openstack, 2015-02-18

| Channels | #puppet-openstack index | Today | | Search | Google Search | Plain-Text | summary

All times shown according to UTC.

Time Nick Message
00:18 derekh joined #puppet-openstack
00:37 xingchao joined #puppet-openstack
00:37 markvoelker joined #puppet-openstack
01:11 badiane_ka joined #puppet-openstack
01:17 aimon joined #puppet-openstack
01:28 rmoe joined #puppet-openstack
01:36 xingchao joined #puppet-openstack
01:39 openstackgerrit Richard Megginson proposed stackforge/puppet-keystone: support for keystone v3 api  https://review.openstack.org/146926
01:59 markvoelker joined #puppet-openstack
02:02 aimon joined #puppet-openstack
02:07 ericpeterson joined #puppet-openstack
02:41 xingchao joined #puppet-openstack
02:48 ilbot3 joined #puppet-openstack
02:48 Topic for #puppet-openstack is now Place to collaborate on Puppet/OpenStack tools: logs at http://irclog.perlgeek.de/puppet-openstack/today
03:04 aimon joined #puppet-openstack
03:20 xingchao joined #puppet-openstack
03:21 openstackgerrit Emilien Macchi proposed stackforge/puppet-ceph: Add EL7 support  https://review.openstack.org/156458
03:51 starmer joined #puppet-openstack
04:13 _nick joined #puppet-openstack
04:25 mfisch michchap: is it possible to run spec tests on defined types? if so, whats the trick
04:41 xingchao joined #puppet-openstack
04:53 michchap mfisch: I believe so, I'll find an example
04:54 michchap mfisch: https://github.com/solarkennedy/puppet-consul/​blob/master/spec/defines/consul_watch_spec.rb
04:54 michchap mfisch: let(:title) is the main difference I see from a class spec test.
05:04 xingchao joined #puppet-openstack
05:05 sanjayu joined #puppet-openstack
05:48 openstackgerrit Spencer Krum proposed stackforge/puppet-keystone: Beaker tests  https://review.openstack.org/155873
05:56 saju_m joined #puppet-openstack
06:04 markvoelker joined #puppet-openstack
06:33 xingchao joined #puppet-openstack
06:38 xingchao joined #puppet-openstack
06:47 stamak joined #puppet-openstack
06:53 markvoelker joined #puppet-openstack
07:03 rissmann joined #puppet-openstack
07:14 xingchao joined #puppet-openstack
07:31 ddmitriev joined #puppet-openstack
07:53 IvanBerezovskiy joined #puppet-openstack
07:54 markvoelker joined #puppet-openstack
08:01 mmagr joined #puppet-openstack
08:08 jistr joined #puppet-openstack
08:09 stamak joined #puppet-openstack
08:23 dgurtner joined #puppet-openstack
08:26 tfz joined #puppet-openstack
08:31 aimon joined #puppet-openstack
08:39 dvorak joined #puppet-openstack
08:49 jpena joined #puppet-openstack
08:55 markvoelker joined #puppet-openstack
09:21 rissmann Can one of the core developers please review my change https://review.openstack.org/#/c/155232/
09:25 derekh joined #puppet-openstack
09:31 dgurtner xarses: dachary good morning!
09:31 dachary howdy
09:31 dgurtner xarses: dachary alas it seems the quick fix yesterday is buggy
09:32 dgurtner it's missing an "end" statement
09:33 * dachary chuckles
09:33 dgurtner :P
09:33 dgurtner I'll rebase and push my change ;)
09:33 dachary I am to blame
09:34 dachary great example to tell someone next time I'm told : "but this is trivial ! there is no need to run tests !".
09:35 xingchao joined #puppet-openstack
09:37 dgurtner haha... well at least our tests always tell us when we make mistakes and let us quickly amend them
09:38 dgurtner also keeps us from being greedy with just merging stuff
09:44 openstackgerrit David Gurtner proposed stackforge/puppet-ceph: Refactor the pool tests to only test pool  https://review.openstack.org/156827
09:53 stamak joined #puppet-openstack
09:56 markvoelker joined #puppet-openstack
10:17 aimon joined #puppet-openstack
10:25 britthou_ joined #puppet-openstack
10:27 saju_m joined #puppet-openstack
10:30 abramley joined #puppet-openstack
10:41 ddmitriev joined #puppet-openstack
10:43 jgr Good morning.
10:44 jgr There is a bit of an issue with https://review.openstack.org/#/c/151314/ as Steven Hardy pointed out.
10:45 jgr At the time I figured since it's a bug in stable/juno submission for stable/juno would be appropriate - in retrospect this like a less than great idea.
10:45 jgr How would I go about rectifying it - just submit the same patch for the master branch?
10:46 jgr (and link to the stable/juno patch to clarify matters, of course)
10:54 higgins joined #puppet-openstack
11:12 stamak joined #puppet-openstack
11:13 kbyrne joined #puppet-openstack
11:13 cdent joined #puppet-openstack
11:14 xingchao joined #puppet-openstack
11:31 spredzy crinkle, I rebased my PR (#38) on top of yours (#39), and in fact it solves the issue I had, hence my PR is ready for modulesync
11:32 saju_m joined #puppet-openstack
11:56 xingchao joined #puppet-openstack
12:01 EmilienM good morning
12:04 openstackgerrit Lukas Bezdicka proposed stackforge/puppet-neutron: Fixes plugin.ini error  https://review.openstack.org/156961
12:04 dgurtner EmilienM: o/
12:12 jistr joined #puppet-openstack
12:18 openstackgerrit Lukas Bezdicka proposed stackforge/puppet-ceilometer: Add manage_service feature  https://review.openstack.org/156964
12:19 openstackgerrit Lukas Bezdicka proposed stackforge/puppet-heat: Add manage_service feature  https://review.openstack.org/156965
12:36 openstackgerrit Lukas Bezdicka proposed stackforge/puppet-swift: Add manage_service feature  https://review.openstack.org/156969
12:42 openstackgerrit Lukas Bezdicka proposed stackforge/puppet-glance: Add manage_service feature  https://review.openstack.org/156971
12:50 openstackgerrit Lukas Bezdicka proposed stackforge/puppet-neutron: Fixed manage_service feature  https://review.openstack.org/156973
12:52 openstackgerrit Lukas Bezdicka proposed stackforge/puppet-nova: --vlan is not the same as --vlan_start  https://review.openstack.org/156974
12:56 openstackgerrit Lukas Bezdicka proposed stackforge/puppet-neutron: Fix the subnet dhcp enable/disable param  https://review.openstack.org/156976
12:59 sanjayu joined #puppet-openstack
13:00 ikke-t joined #puppet-openstack
13:07 fwdit joined #puppet-openstack
13:11 markvoelker joined #puppet-openstack
13:47 EmilienM dgurtner: hey, what's the status of puppet-ceph CI ? Can I recheck https://review.openstack.org/#/c/156458/ ?
13:55 aimon joined #puppet-openstack
13:56 openstackgerrit Emilien Macchi proposed stackforge/puppet-nova: params: update libvirt  https://review.openstack.org/151324
13:57 dgurtner EmilienM: there was an issue in some other change which got accidentally which failed all tests
13:57 dgurtner EmilienM: now running CI on the fix. once this returns i'll change the CI and tell you :)
13:59 EmilienM dgurtner: ack, thx
14:01 rcallawa joined #puppet-openstack
14:03 openstackgerrit Risto Laurikainen proposed stackforge/puppet-neutron: Fix catalog compilation when not configuring endpoint  https://review.openstack.org/156999
14:09 openstackgerrit Risto Laurikainen proposed stackforge/puppet-nova: Fix catalog compilation when not configuring endpoint  https://review.openstack.org/157002
14:09 rcallawa crinkle: could you please look at https://review.openstack.org/137534 again whenever you get a minute? it is blocking the merge of another patch in packstack that is dependent on it. thanks!
14:10 openstackgerrit Igor Gajsin proposed stackforge/puppet-cinder: set parameter host in vmdk.pp  https://review.openstack.org/157004
14:16 mmagr joined #puppet-openstack
14:17 xingchao joined #puppet-openstack
14:18 openstackgerrit Risto Laurikainen proposed stackforge/puppet-glance: Fix catalog compilation when not configuring endpoint  https://review.openstack.org/157009
14:21 richm joined #puppet-openstack
14:32 rissmann Hi there. I fixed a small bug in neutron_l3_ovs_bridge/neutron.rb Can one of the Core Developers review please? https://review.openstack.org/#/c/155232/
14:33 mmagr joined #puppet-openstack
14:35 EmilienM rissmann: hey, I'm looking now
14:35 EmilienM rissmann: your commit message is not good
14:36 EmilienM rissmann: a bit of doc: https://wiki.openstack.org/wiki/GitCommitMessages
14:37 rissmann OK, Ill try to fix it
14:45 imcsk8 joined #puppet-openstack
14:46 spredzy EmilienM, on this review https://review.openstack.org/#/c/156458/4 any reason why we can't rely on the epel module ?
14:51 * social has opinion that puppet should never ever touch repos
14:54 EmilienM spredzy: I'm not trying to refactor, but just adding EPEL7 support
14:56 openstackgerrit Ruediger Rissmann proposed stackforge/puppet-neutron: Corrects "ip link set" command  https://review.openstack.org/155232
14:57 dvorak social: funny, I have the opinion that nothing but puppet should :)
14:59 mfisch michchap: thanks
15:02 spredzy EmilienM, ok
15:03 rcallawa joined #puppet-openstack
15:04 social dvorak: yes but how puppet works in terms of constucting catalog? you can't just add repo in same puppet as you for example ensure latest (I know usually you don't do that)
15:05 dvorak we're talking about package repos, yes?
15:05 ericpeterson joined #puppet-openstack
15:06 dvorak We mirror external repos into versioned mirrors.
15:07 dvorak we manage what version of the repo we're using by setting versions in hiera, then when we want to do upgrades, we change the versions, which updates the apt source
15:08 dvorak in those cases we usually ensure => latest so that puppet will do the upgrade for us
15:09 cdent_ joined #puppet-openstack
15:09 dvorak for the most part that's how we did our upgrade from icehouse -> juno
15:11 social dvorak: last time I checked puppet constucted catalog with list of packages to update which means if you added new repo during the puppet run it wouldn't update any package from that repo as it didn't know that there will be update
15:11 dvorak nope, that works fine
15:11 dvorak we do it all the time
15:12 dvorak you do have to ensure that the repos are updated before it tries to install the packages
15:12 social if the package is installed already?
15:13 dvorak whether it's installed or not
15:22 openstackgerrit Merged stackforge/puppet-monasca: Fix resource warnings  https://review.openstack.org/156697
15:26 rlaurika_ dvorak: about your comment to my puppet-glance patch: i tried adding a test for the relationship with "that_notifies", but it gives me "NoMethodError: undefined method `[]' for nil:NilClass"
15:26 dvorak the reason I suggested that is that I'm not sure that collector is actually working
15:26 rlaurika_ here is the full line: "it { should contain_keystone_endpoint('RegionOne/glan​ce').that_notifies('Service[glance-api]') }"
15:26 dvorak usually you'd do something like Service<| title == 'glance-api' |>
15:26 dvorak but it's doing name ==
15:26 dvorak which in my experience tends not to work, but I may be wrong
15:27 rlaurika_ dvorak: could that be why my test is failing?
15:27 dvorak perhaps, I'd try changing name == to title == and see if that fixes it
15:27 dvorak I think you may end up fixing two bugs
15:27 openstackgerrit Merged stackforge/puppet-monasca: Removes all checks unmanged by puppet  https://review.openstack.org/145291
15:28 rcallawa_ joined #puppet-openstack
15:29 openstackgerrit Clayton O'Neill proposed stackforge/puppet-designate: WIP: Add virtualenv support  https://review.openstack.org/157032
15:30 rlaurika_ dvorak: still fails if i use "title" instead of "name"
15:30 rlaurika_ i also tried "with_notify", but that seems to fail as well
15:30 dvorak hrm, I ran into something similar a few days ago, and I ended up working around it in a way that probably won't work for you
15:31 rlaurika_ is there a difference between "with_notify" and "that_notifies"? the rspec-puppet docs only talk about "that_notifies".
15:31 dvorak I think the issue is that the class that contains Service['glance-api'] isn't in the catalog compiled by the test
15:31 dvorak rlaurika_: yeah,with_notify requires an exact match
15:31 dvorak so if it notifies an array of things, then you have to specify all o ftghem
15:32 dvorak that_notifies will match if just the one thing you listed is in the list
15:32 dvorak I learned that this morning :)
15:34 rlaurika_ hmm. so i wonder if there is really a way to test the relationship in that module?
15:37 rlaurika_ dvorak: do the catalogs that the tests use always just contain the class tested? in that case i don't know how i could test relationships between resources in two different classes.
15:49 aimon joined #puppet-openstack
15:51 dvorak I think so, I have to think there is a way to have it include additional classes
16:10 mschmitt joined #puppet-openstack
16:14 dgurtner xarses: dmsimard can I have you take a look at https://review.openstack.org/#/c/156827/
16:14 dgurtner thanks :)
16:15 xarses yep
16:15 xarses merge?
16:16 dgurtner xarses: would be awesome :)
16:17 dmsimard xarses beat me to it
16:17 dmsimard I commented nonetheless :p
16:18 dgurtner thanks for the quick reaction to both of you!
16:19 dmsimard Yeah, feel free to ping me if you need one off reviews... I know there's a queue I need to look at but prod's been keeping me busy
16:20 mdorman joined #puppet-openstack
16:22 openstackgerrit Merged stackforge/puppet-ceph: Refactor the pool tests to only test pool  https://review.openstack.org/156827
16:22 xarses back in a bit
16:24 pradk joined #puppet-openstack
16:26 dgurtner joined #puppet-openstack
16:26 dgurtner joined #puppet-openstack
16:27 dgurtner EmilienM: finally ready to recheck your changes :)
16:28 dgurtner EmilienM: to only run CI you can comment a "run gerritexec"
16:28 EmilienM dgurtner: done, thx
16:28 EmilienM ok
16:28 IvanBerezovskiy left #puppet-openstack
16:33 dgurtner EmilienM: hmm, I just noticed a big issue...
16:33 dgurtner EmilienM: the interfaces get the new naming on centos7
16:34 dgurtner EmilienM: but the tests still expect eth0/eth1
16:36 dgurtner ipaddress_enp0s3 => 10.0.2.15
16:36 dgurtner ipaddress_enp0s8 => 192.168.56.101
16:38 aimon joined #puppet-openstack
16:38 dgurtner I'll have a look later...
16:54 dmsimard Ubuntu is a culprit of that too
16:54 dmsimard I've seen interfaces like em1, p6p1, etc :p
16:56 rcallawa joined #puppet-openstack
16:56 social joined #puppet-openstack
17:01 ericpeterson joined #puppet-openstack
17:03 mdorman mfisch, others:  finally getting back to https://review.openstack.org/#/c/151746/1 , which was a patch to how we’re calling augeas to manage policy.json files.  i need to add a test to make sure it’s actually generating policy.json correctly.  but i’m not quite sure how to do that in rspec
17:03 mdorman right now the test validates that the augeas resource itself is defined correctly, but i also want to check that augeas actually generates a correct file output.
17:05 openstackgerrit Mike Dorman proposed stackforge/puppet-openstacklib: Properly handle policy values containing spaces  https://review.openstack.org/151746
17:05 xarses joined #puppet-openstack
17:06 mdorman also i believe https://review.openstack.org/#/c/149701/ should be ready to merge.  earlier test failures were due to gate issues.
17:07 aimon joined #puppet-openstack
17:09 dprince joined #puppet-openstack
17:11 openstackgerrit Mike Dorman proposed stackforge/puppet-openstacklib: Properly handle policy values containing spaces  https://review.openstack.org/151746
17:14 rcallawa mfisch, fc__, EmilienM: could i bug one of you to please take a look at https://review.openstack.org/#/c/137534/ and +2/+1 it through at your earliest convenience, as its blocking a merge of a packstack change. thanks!
17:15 mfisch I can look in probably 30min
17:15 rcallawa mfisch: thanks!
17:18 mfisch rcallawa: did you add me to the review?
17:19 rcallawa mfisch: was just doing that.
17:19 mfisch ok
17:20 rmoe joined #puppet-openstack
17:20 mfisch I feel like an indirect packstack contributor at this point ;)
17:21 rcallawa mfisch: you should have it now; thx
17:23 openstackgerrit Mike Dorman proposed stackforge/puppet-openstacklib: Properly handle policy values containing spaces  https://review.openstack.org/151746
17:27 openstackgerrit Mike Dorman proposed stackforge/puppet-openstacklib: Properly handle policy values containing spaces  https://review.openstack.org/151746
17:32 openstackgerrit Merged stackforge/puppet-manila: Change share server config details  https://review.openstack.org/137534
17:43 tfz joined #puppet-openstack
17:43 rcallawa mfisch: many thanks for the review
17:44 mfisch I didnt review it yet ;)
17:45 mfisch rcallawa: geuss I'm off the hook
17:45 rcallawa mfisch: sebastien did... haha
17:45 rcallawa sorry for the fire drill, just saw the merge note and thought you had hit +2
17:56 mfisch crinkle: sbadia: whats the +2 policy on backports, still need 2?
17:56 _ryanv_ joined #puppet-openstack
17:57 crinkle that's been my understanding
18:04 flaviof joined #puppet-openstack
18:10 openstackgerrit Bradley Klein proposed stackforge/puppet-monasca: Add script to manage stack services starts/stops  https://review.openstack.org/157091
18:11 openstackgerrit Bradley Klein proposed stackforge/puppet-monasca: Add script to manage stack services starts/stops  https://review.openstack.org/157091
18:33 dgurtner joined #puppet-openstack
18:33 dgurtner joined #puppet-openstack
18:34 britthouser joined #puppet-openstack
18:53 saju_m joined #puppet-openstack
19:02 openstackgerrit Merged stackforge/puppet-monasca: Add script to manage stack services starts/stops  https://review.openstack.org/157091
19:21 xarses joined #puppet-openstack
19:25 pradk joined #puppet-openstack
19:50 openstackgerrit Ivan Chavero proposed stackforge/puppet-keystone: support for keystone v3 api  https://review.openstack.org/146926
20:02 ericpeterson joined #puppet-openstack
20:17 fandi joined #puppet-openstack
20:20 fandi joined #puppet-openstack
20:30 stamak joined #puppet-openstack
20:48 jamespd joined #puppet-openstack
20:57 rcallawa_ joined #puppet-openstack
20:57 rcallaw__ joined #puppet-openstack
21:08 dontalton joined #puppet-openstack
21:22 dgurtner EmilienM: hei. I'm disabling CI tests for CentOS 7 again, I'll need to get a preliminary fix tested (removing all references to eth0/eth1), which is a requirement for the CentOS 7 test to be able to run.
21:22 EmilienM dgurtner: ack
21:29 openstackgerrit David Gurtner proposed stackforge/puppet-ceph: Fix to allow for arbitrary interface naming  https://review.openstack.org/157151
21:36 rcallawa joined #puppet-openstack
21:38 rcallawa joined #puppet-openstack
21:39 aimon_ joined #puppet-openstack
21:39 aimon joined #puppet-openstack
21:42 EmilienM mdorman: ping
21:53 nosleep77 joined #puppet-openstack
22:09 openstackgerrit David Gurtner proposed stackforge/puppet-ceph: Fix to allow for arbitrary interface naming  https://review.openstack.org/157151
22:22 openstackgerrit Richard Megginson proposed stackforge/puppet-keystone: support for keystone v3 api  https://review.openstack.org/146926
22:36 mdorman EmilienM:  hey what’s up
22:38 mdorman replied to that comment
22:51 EmilienM mdorman: k
22:52 EmilienM mdorman: +2
22:52 mdorman ty
23:00 openstackgerrit joined #puppet-openstack
23:08 openstackgerrit David Gurtner proposed stackforge/puppet-ceph: Fix to allow for arbitrary interface naming  https://review.openstack.org/157151
23:23 gildub joined #puppet-openstack

| Channels | #puppet-openstack index | Today | | Search | Google Search | Plain-Text | summary