Perl 6 - the future is here, just unevenly distributed

IRC log for #puppet-openstack, 2015-06-15

| Channels | #puppet-openstack index | Today | | Search | Google Search | Plain-Text | summary

All times shown according to UTC.

Time Nick Message
00:34 ferest joined #puppet-openstack
00:37 aimon_ joined #puppet-openstack
01:16 imcsk8_ joined #puppet-openstack
01:24 imcsk8 joined #puppet-openstack
01:38 ducttape_ joined #puppet-openstack
01:48 ilbot3 joined #puppet-openstack
01:48 Topic for #puppet-openstack is now Puppet/OpenStack http://irclog.perlgeek.de/puppet-openstack/today - Weekly meeting (every Tuesday 13:00 UTC): https://wiki.openstack.org/wiki/Meetings/PuppetOpenStack - On going efforts: https://trello.com/puppetopenstack
02:39 bdemers joined #puppet-openstack
02:44 bdemers joined #puppet-openstack
03:07 bdemers joined #puppet-openstack
03:22 bdemers joined #puppet-openstack
03:30 bdemers joined #puppet-openstack
05:10 gildub joined #puppet-openstack
06:07 hostranger joined #puppet-openstack
06:08 hostranger left #puppet-openstack
07:06 tshtilma joined #puppet-openstack
07:08 openstackgerrit Gilles Dubreuil proposed openstack/puppet-keystone: support for keystone v3 api - v3 domain utility code  https://review.openstack.org/178385
07:09 jtomasek joined #puppet-openstack
07:10 alex_bh joined #puppet-openstack
07:28 jpena joined #puppet-openstack
07:28 tfz joined #puppet-openstack
07:32 dgurtner joined #puppet-openstack
07:32 dgurtner joined #puppet-openstack
07:42 prad joined #puppet-openstack
08:59 gfidente joined #puppet-openstack
09:45 paramite joined #puppet-openstack
09:52 openstackgerrit vsaienko proposed openstack/puppet-horizon: Add cache_backend and cache_options params  https://review.openstack.org/190548
09:53 saneax joined #puppet-openstack
11:12 dgurtner joined #puppet-openstack
11:12 dgurtner joined #puppet-openstack
11:22 arnaud_orange joined #puppet-openstack
11:37 iurygregory joined #puppet-openstack
11:39 ddmitriev joined #puppet-openstack
11:39 aarefiev joined #puppet-openstack
11:46 alex_bh2 joined #puppet-openstack
11:47 saneax joined #puppet-openstack
12:03 degorenko joined #puppet-openstack
12:08 alex_bh joined #puppet-openstack
12:08 alex_bh left #puppet-openstack
12:11 arnaud_orange joined #puppet-openstack
12:18 vinsh joined #puppet-openstack
12:32 aimon joined #puppet-openstack
12:45 saneax joined #puppet-openstack
12:46 morazi joined #puppet-openstack
12:46 zerda joined #puppet-openstack
12:50 saneax joined #puppet-openstack
12:53 xarses joined #puppet-openstack
12:54 petems left #puppet-openstack
13:06 ducttape_ joined #puppet-openstack
13:08 cdent joined #puppet-openstack
13:14 saneax joined #puppet-openstack
13:23 prad joined #puppet-openstack
13:24 vinsh joined #puppet-openstack
13:25 vinsh joined #puppet-openstack
13:29 ferest joined #puppet-openstack
13:43 bdemers joined #puppet-openstack
13:51 social what's the plan with modules and openstackclient?
13:51 social are we switching to it?
14:03 zigo joined #puppet-openstack
14:04 rcallawa joined #puppet-openstack
14:12 stevemar joined #puppet-openstack
14:21 xarses social: I thought it already was
14:22 xarses afaik puppet-keystone is using it already
14:24 openstackgerrit joined #puppet-openstack
14:27 social xarses: well puppet-cinder is not using it nor is neutron
14:27 xarses maybe still in progress then
14:28 xarses I've been in a hole for a while
14:29 kkirkpatrick joined #puppet-openstack
14:35 morazi joined #puppet-openstack
14:37 jpena crinkle, if you have a sec, can you check my latest comment on https://review.openstack.org/173327 ? I can make the rspec test work for Puppet 3.x or Puppet 4.x, but not for both. I'm not sure if there is a syntax that will  please both
14:46 mdorman joined #puppet-openstack
14:49 xingchao joined #puppet-openstack
14:53 mwhahaha jpena: you could cheat and in the rspec have different checks based on the version of puppet
14:54 mwhahaha http://paste.openstack.org/show/284205/ does something like that where it only does one type of check if puppet >= 3.5
14:54 jpena mwhahaha: it makes sense, I'll give that a try. Thanks!
15:06 ducttape_ joined #puppet-openstack
15:13 openstackgerrit Javier Peña proposed openstack/puppet-horizon: Add support for WEBROOT in local_settings  https://review.openstack.org/173327
15:33 xingchao joined #puppet-openstack
15:37 nosleep77 joined #puppet-openstack
15:40 xarses_ joined #puppet-openstack
15:41 xarses_ joined #puppet-openstack
15:52 degorenko Hi guys! I have some question: why puppet-sahara doesn't have any tags? Who is responsible for this module?
15:56 morazi joined #puppet-openstack
16:03 saneax joined #puppet-openstack
16:09 xarses joined #puppet-openstack
16:10 xarses joined #puppet-openstack
16:12 xarses joined #puppet-openstack
16:17 openstackgerrit Rajini Ram proposed openstack/puppet-cinder: Added support for DellStorageCenter ISCSI cinder driver  https://review.openstack.org/189372
16:20 hogepodge joined #puppet-openstack
16:27 xarses joined #puppet-openstack
16:28 xarses joined #puppet-openstack
16:34 dprince joined #puppet-openstack
16:57 richm joined #puppet-openstack
16:57 openstackgerrit Jonathan Proulx proposed openstack/puppet-keystone: Pull in upstream stable/kilo wsgi script  https://review.openstack.org/191886
16:59 rcallawa_ joined #puppet-openstack
17:02 richm hello
17:03 richm Is there an official code formatting for puppet openstack projects ruby code?
17:03 richm e.g. use 2 spaces for indent
17:07 xarses_ joined #puppet-openstack
17:18 aimon joined #puppet-openstack
17:29 mgagne richm: better look at other code and see if there is any convention
17:29 mgagne richm: but I think we should adopt rubocop so we can settle on one style once and for all
17:30 mgagne I explored the idea a couple of months ago but there is a long of work to make it happen in term of style standardization
17:31 richm mgagne: everywhere I can see, we use 2 spaces
17:31 mgagne I guess it's a same bet to say our convention is 2 spaces
17:31 richm but a recent review used tabs, which got me to thinking
17:32 mgagne tabs are usually avoid
17:32 richm https://review.openstack.org/#/c/178385/12/lib/puppet/provider/keystone/util.rb
17:33 mgagne yea, better convert them to spaces
17:33 mgagne I don't watch changes that often anymore but it would be something I would ask to change
17:39 RichardRaseley joined #puppet-openstack
17:42 openstackgerrit Denis Egorenko proposed openstack/puppet-sahara: Enable tests for oslo_messaging_rabbit/rabit_host parameter  https://review.openstack.org/191913
17:44 openstackgerrit Denis Egorenko proposed openstack/puppet-sahara: Enable tests for oslo_messaging_rabbit/rabbit_hosts parameter  https://review.openstack.org/191913
17:51 openstackgerrit Richard Megginson proposed openstack/puppet-keystone: support for keystone v3 api - v3 domain utility code  https://review.openstack.org/178385
17:54 openstackgerrit Richard Megginson proposed openstack/puppet-keystone: support for keystone v3 api - the domain resource  https://review.openstack.org/174439
17:56 xarses_ joined #puppet-openstack
17:56 openstackgerrit Richard Megginson proposed openstack/puppet-keystone: support for keystone v3 api - the project resource  https://review.openstack.org/174468
17:57 xarses joined #puppet-openstack
17:57 RichardRaseley Can someone in the 'puppet-openstack' Launchpad group kick the maintainership of 'puppet-zaqar' back to me until I finish setting it up? I seem to have locked myself out.
17:57 tfz joined #puppet-openstack
18:02 openstackgerrit Richard Megginson proposed openstack/puppet-keystone: support for keystone v3 api - the user resource  https://review.openstack.org/174976
18:08 rcallawa joined #puppet-openstack
18:09 stevemar2 joined #puppet-openstack
18:09 rcallawa joined #puppet-openstack
18:19 openstackgerrit Richard Megginson proposed openstack/puppet-keystone: support for keystone v3 api - the user_role resource  https://review.openstack.org/174999
18:21 openstackgerrit Richard Megginson proposed openstack/puppet-keystone: support for keystone v3 api - keystone and keystone::roles::admin  https://review.openstack.org/175060
18:22 openstackgerrit Richard Megginson proposed openstack/puppet-keystone: support for keystone v3 api - add domains to service_identity  https://review.openstack.org/180586
18:23 openstackgerrit Richard Megginson proposed openstack/puppet-keystone: support for keystone v3 api - beaker tests  https://review.openstack.org/178828
18:25 xarses_ joined #puppet-openstack
18:42 RichardRaseley crinkle: With regard to the new Zaqar module, what would be the appropriate set of tests to populate first, following the model in openstack-infra/project-config/jenkins/jobs/projects.yaml ? All Puppet modules appear the same save for their inclusion of 'puppet-beaker-jobs' ...
18:43 nosleep77 left #puppet-openstack
18:58 dmsimard Is there a quick howto to convert existing reviews to the new repos/review config ?
18:58 dmsimard Can't seem to figure it out ..
19:00 crinkle RichardRaseley: they should all have beaker jobs
19:01 openstackgerrit David Moreau Simard proposed openstack/puppet-keystone: Synchronize Keystone WSGI script with upstream  https://review.openstack.org/191212
19:01 dmsimard Ah nevermind, think I figured it out
19:02 openstackgerrit David Moreau Simard proposed openstack/puppet-keystone: Synchronize Keystone WSGI script with upstream  https://review.openstack.org/191212
19:11 RichardRaseley crinkle: OK. For example, puppet-monasca does not.
19:12 RichardRaseley and puppet-gnocchi - but I didn't know if that was because they
19:12 RichardRaseley was by design*
19:12 xarses joined #puppet-openstack
19:59 openstackgerrit Rajini Ram proposed openstack/puppet-cinder: Added support for DellStorageCenter ISCSI cinder driver  https://review.openstack.org/189372
19:59 openstackgerrit Rajini Ram proposed openstack/puppet-cinder: Added support for DellStorageCenter ISCSI cinder driver  https://review.openstack.org/189372
20:02 cwolferh joined #puppet-openstack
20:21 dgurtner joined #puppet-openstack
20:21 dgurtner joined #puppet-openstack
20:52 krotscheck joined #puppet-openstack
20:58 mgagne RichardRaseley: do you know if there is a better construct than the one proposed here? https://review.openstack.org/#/c/184646/20/manifests/server/notifications.pp
20:58 mgagne RichardRaseley: to check for empty stirng
20:58 mgagne string*
20:59 mgagne -> ! ($nova_admin_password and $nova_admin_password != '') this is difficult to read and uses double negation
20:59 openstackgerrit Colleen Murphy proposed openstack/puppet-keystone: Use zuul-cloner and clone map to clone dependencies  https://review.openstack.org/190839
21:03 stevemar2 joined #puppet-openstack
21:10 mwhahaha mgagne: if !pick($nova_admin_password, false)
21:10 mwhahaha as pick will use the second value if the first is undef or an empty string
21:11 mgagne _ody: ^ ?
21:12 mwhahaha not sure if better, but it might work :D
21:15 mwhahaha yup works
21:16 _ody mgagne: I've been doing the annoying double negation thing.
21:16 mgagne _ody: sure, I'm looking for a way to improve it
21:16 _ody mwhahaha's would work for things that aren't going to be set to "false" (as a string) at some point.
21:17 mwhahaha it only breaks down for false
21:18 _ody Which is what I've been dealing with lately with getting Puppet 3.x code to pass on Puppet 4.x.
21:18 mwhahaha :(
21:19 mwhahaha does validate_string work for those?
21:19 _ody For things that might be set to false, I tried str2bool but the new Puppet 4.x function API gets angry if you feed a bool into the fuction.
21:24 rcallawa joined #puppet-openstack
21:25 openstackgerrit Colleen Murphy proposed openstack/puppet-keystone: Use zuul-cloner and clone map to clone dependencies  https://review.openstack.org/190839
21:25 rcallawa joined #puppet-openstack
21:31 _ody mgagne: ah, you are actually looking through my puppet-neutron patch set...hmm. Tomorrow is my Puppet OpenStack day...going to try and not get lost in it right now.
21:31 mgagne alright
21:35 _ody mgagne: Did a quick look anyway.  Might just be a consequence of the test for which we can easily fix.  The line here is probably a bad way to test the case where no admin password is provided, https://github.com/ody/puppet-neutron/blob/make_tests_pass_on_4/spec/classes/neutron_server_notifications_spec.rb#L96.
21:36 mgagne _ody: cool, as long as we make the manifest more readable, I'm fine
21:37 RichardRaseley mgagne: Sorry for the delay. Does validate_string work for checking on an empty or undef?
21:37 RichardRaseley I would defer to _ody on that one though.
21:39 _ody Yean.  I'll hack on it more tomorrow...
21:39 RichardRaseley mgagne: Ah, looks like that would cause a compilation failure.
21:39 RichardRaseley OK
21:39 iurygregory joined #puppet-openstack
21:51 RichardRaseley mgagne: if $nova_admin_password and $nova_admin_password != '' <- Seems like a sane test, no?
21:51 mgagne the double negation makes it hard to understand
21:52 mgagne if ! ($nova_admin_password and $nova_admin_password != '') {}
21:54 RichardRaseley My test isn't double negated, right?
21:54 RichardRaseley if the variable exists (not undef) and is not equal to an empty string, then use the provided value.
21:54 RichardRaseley if $password and $password != "" { notice("password is set") } else { notice("password is not set") }
21:55 RichardRaseley mgagne: ^
21:55 mgagne My question was related to line #79 and #83, not #98 https://review.openstack.org/#/c/184646/20/manifests/server/notifications.pp
21:55 tfz joined #puppet-openstack
21:57 RichardRaseley mgagne: Yes...
21:57 mgagne I think we could benefit from a function here
21:58 mgagne but it's not a show stopper unless this construct ends up in all our modules
22:01 RichardRaseley mgagne: What about something like this https://gist.github.com/richardraseley/faac6243d314fe17d159
22:01 mgagne really? =)
22:02 RichardRaseley mgagne: Or an unless? https://gist.github.com/richardraseley/29b269111df4042f5ea3
22:02 RichardRaseley Yeah, why not?
22:03 mgagne yea, I was looking at unless and when it got introduced
22:03 mgagne btw, why not undef? why false?
22:03 mgagne anything special with undef?
22:03 RichardR_ joined #puppet-openstack
22:04 RichardR_ sorry, disconnected
22:04 RichardR_ mgagne: ^
22:04 mgagne yea, I was looking at unless and when it got introduced
22:04 mgagne 6:03
22:04 mgagne btw, why not undef? why false?
22:04 mgagne 6:03
22:04 mgagne anything special with undef?
22:04 RichardR_ mgagne: Not sure, that is just the way that I am used to testing for undef.
22:05 RichardR_ I don't know a good reason to not call it out specifically though.
22:05 RichardR_ I think unless looks pretty clean.
22:05 mgagne yes
22:05 mgagne but I still don't understand why we can't have a helper here
22:06 mgagne it used to be short and clear, now it's twice as long and less clear
22:06 RichardR_ What is the reason for creating a helper? I assume you mean a function.
22:06 mgagne yes functio
22:06 RichardR_ (Always keep in mind that you're speaking to a non-developer when you talk to me.) =]
22:07 RichardR_ I generally prefer to have a little bit longer native language construct. Might just be personal preference.
22:07 mgagne RichardR_: just for the sake of readability
22:08 RichardR_ mgagne: Gotta run to a meeting, interesting conversation I'd like to hear other input.
22:08 RichardR_ TTYL!
22:08 mgagne sure
22:13 djm68 joined #puppet-openstack
22:16 mdorman is there someplace that defines what version of openstack client is require for the different keystone providers (in master)?  or do i just assume ‘kilo'?
22:18 crinkle mdorman: the version available for kilo in both ubuntu and rhel should be sufficient, i believe it's >=1.0.3
22:20 mdorman cool thanks
22:26 openstackgerrit Colleen Murphy proposed openstack/puppet-keystone: Use zuul-cloner and clone map to clone dependencies  https://review.openstack.org/190839
22:33 djm68 joined #puppet-openstack
22:45 saneax joined #puppet-openstack
23:04 openstackgerrit Mathieu Gagné proposed openstack/puppet-nova: Introduce public_url, internal_url and admin_url (and v3/ec2)  https://review.openstack.org/70458
23:07 ducttape_ joined #puppet-openstack
23:08 openstackgerrit Mike Dorman proposed openstack/puppet-nova: Declare package with $package_name, not $nova_title  https://review.openstack.org/192009
23:19 hogepodge joined #puppet-openstack
23:23 djm68 joined #puppet-openstack
23:37 openstackgerrit Merged openstack/puppet-tempest: spec: pin rspec-puppet to 1.0.1  https://review.openstack.org/191470
23:38 openstackgerrit Merged openstack/puppet-designate: Change spec tests to use puppetlabs/concat  https://review.openstack.org/191468
23:42 openstackgerrit Merged openstack/puppet-sahara: Update spec_helper_acceptance for project renames  https://review.openstack.org/191338
23:42 openstackgerrit Merged openstack/puppet-cinder: Update spec_helper_acceptance for project renames  https://review.openstack.org/191327
23:43 openstackgerrit Merged openstack/puppet-openstacklib: Update spec_helper_acceptance for project renames  https://review.openstack.org/191337
23:43 openstackgerrit Merged openstack/puppet-trove: Update spec_helper_acceptance for project renames  https://review.openstack.org/191340
23:45 openstackgerrit Merged openstack/puppet-swift: Update spec_helper_acceptance for project renames  https://review.openstack.org/191339
23:46 openstackgerrit Merged openstack/puppet-vswitch: Update spec_helper_acceptance for project renames  https://review.openstack.org/191341
23:47 openstackgerrit Merged openstack/puppet-manila: Update spec_helper_acceptance for project renames  https://review.openstack.org/191334
23:47 openstackgerrit Merged openstack/puppet-glance: Update spec_helper_acceptance for project renames  https://review.openstack.org/191329
23:47 openstackgerrit Merged openstack/puppet-heat: Update spec_helper_acceptance for project renames  https://review.openstack.org/191330
23:48 openstackgerrit Merged openstack/puppet-ironic: Update spec_helper_acceptance for project renames  https://review.openstack.org/191332
23:48 openstackgerrit Merged openstack/puppet-horizon: Update spec_helper_acceptance for project renames  https://review.openstack.org/191331
23:49 openstackgerrit Merged openstack/puppet-keystone: Update spec_helper_acceptance for project renames  https://review.openstack.org/191333
23:49 openstackgerrit Merged openstack/puppet-nova: Update spec_helper_acceptance for project renames  https://review.openstack.org/191336
23:51 openstackgerrit Merged openstack/puppet-neutron: Update spec_helper_acceptance for project renames  https://review.openstack.org/191335
23:54 openstackgerrit Merged openstack/puppet-tempest: Update .gitreview file for project rename  https://review.openstack.org/191460
23:55 aimon joined #puppet-openstack
23:57 aimon_ joined #puppet-openstack
23:59 djm68 joined #puppet-openstack

| Channels | #puppet-openstack index | Today | | Search | Google Search | Plain-Text | summary