Perl 6 - the future is here, just unevenly distributed

IRC log for #puppet-openstack, 2015-08-13

| Channels | #puppet-openstack index | Today | | Search | Google Search | Plain-Text | summary

All times shown according to UTC.

Time Nick Message
00:02 v1k0d3n joined #puppet-openstack
00:03 nibalizer hello
00:09 gildub joined #puppet-openstack
00:15 v1k0d3n joined #puppet-openstack
00:15 markvoelker joined #puppet-openstack
00:17 aimon joined #puppet-openstack
00:19 severion joined #puppet-openstack
00:24 xingchao_ joined #puppet-openstack
00:39 openstackgerrit Merged openstack/puppet-keystone: Move openstackclient install to keystone::client  https://review.openstack.org/209965
00:43 openstackgerrit liaonanhai proposed openstack/puppet-nova: Set reserved_host_memory_mb to 0 using ironic  https://review.openstack.org/211872
00:58 xingchao_ joined #puppet-openstack
00:58 jeblair joined #puppet-openstack
01:03 richm joined #puppet-openstack
01:10 v1k0d3n joined #puppet-openstack
01:28 mesamoo joined #puppet-openstack
01:30 gildub joined #puppet-openstack
01:45 tiswanso joined #puppet-openstack
01:46 openstackgerrit Gilles Dubreuil proposed openstack/puppet-keystone: Resource keystone_group for Keystone V3 API  https://review.openstack.org/202409
01:46 openstackgerrit Gilles Dubreuil proposed openstack/puppet-keystone: Keystone Role/Group resource provider  https://review.openstack.org/211444
01:48 tiswanso joined #puppet-openstack
02:05 markvoelker joined #puppet-openstack
02:08 sergmelikyan joined #puppet-openstack
02:54 openstackgerrit Michael Chapman proposed openstack/puppet-keystone: Clarify the origin of provider warning messages  https://review.openstack.org/212290
03:06 ducttape_ joined #puppet-openstack
03:12 saneax joined #puppet-openstack
03:16 openstackgerrit Merged openstack/puppet-ironic: Rely on autorequire for config resource ordering  https://review.openstack.org/211898
03:36 openstackgerrit Timothy Swanson proposed openstack/puppet-neutron: Update Cisco ML2 classes and templates  https://review.openstack.org/197181
04:22 saneax joined #puppet-openstack
04:27 xarses_ joined #puppet-openstack
04:57 topshare joined #puppet-openstack
05:13 cdelatte joined #puppet-openstack
05:34 dgurtner joined #puppet-openstack
05:34 dgurtner joined #puppet-openstack
05:35 dgurtner joined #puppet-openstack
05:35 dgurtner joined #puppet-openstack
05:36 dgurtner joined #puppet-openstack
05:37 openstackgerrit Gilles Dubreuil proposed openstack/puppet-keystone: Keystone Role/Group resource provider  https://review.openstack.org/211444
05:41 delattec joined #puppet-openstack
05:57 sergmelikyan joined #puppet-openstack
06:07 cdelatte joined #puppet-openstack
06:15 linkedinyou joined #puppet-openstack
06:41 markvoelker joined #puppet-openstack
06:51 dgurtner joined #puppet-openstack
07:00 dgurtner joined #puppet-openstack
07:22 jpena joined #puppet-openstack
07:27 mtreinish joined #puppet-openstack
07:40 linkedinyou joined #puppet-openstack
07:42 jpena joined #puppet-openstack
07:42 openstackgerrit joined #puppet-openstack
07:42 pabelanger joined #puppet-openstack
07:42 hogepodge joined #puppet-openstack
07:42 bogdando joined #puppet-openstack
07:42 Madkiss joined #puppet-openstack
07:42 colby_ joined #puppet-openstack
07:42 tdb joined #puppet-openstack
07:42 mattymo joined #puppet-openstack
07:42 crinkle joined #puppet-openstack
07:42 ric` joined #puppet-openstack
07:42 joshsamuelson joined #puppet-openstack
07:44 Madkiss_ joined #puppet-openstack
07:44 crinkle_ joined #puppet-openstack
07:47 tdb joined #puppet-openstack
07:51 jprs joined #puppet-openstack
07:52 pabelanger joined #puppet-openstack
07:54 mattymo joined #puppet-openstack
07:58 colby_ joined #puppet-openstack
08:00 jpena joined #puppet-openstack
08:00 bogdando joined #puppet-openstack
08:00 topshare joined #puppet-openstack
08:00 openstackgerrit joined #puppet-openstack
08:03 openstackgerrit Yanis Guenane proposed openstack/puppet-glance: Rely on autorequire for config resource ordering  https://review.openstack.org/211937
08:05 EmilienM good morning
08:07 rochaporto joined #puppet-openstack
08:09 vinsh joined #puppet-openstack
08:17 openstackgerrit Emilien Macchi proposed openstack/puppet-tempest: do not create tempest.conf from .sample file  https://review.openstack.org/210784
08:22 jpena joined #puppet-openstack
08:26 jistr joined #puppet-openstack
08:29 gfidente joined #puppet-openstack
08:32 openstackgerrit Merged openstack/puppet-ceilometer: acceptance: clean an old FIXME in manifest  https://review.openstack.org/209321
08:39 jpena joined #puppet-openstack
08:42 markvoelker joined #puppet-openstack
08:43 hogepodge joined #puppet-openstack
09:08 openstackgerrit Merged stackforge/puppet-ceph: Allow customization of OSDs journal size via class param  https://review.openstack.org/211329
09:09 openstackgerrit Merged openstack/puppet-gnocchi: Rely on autorequire for config resource ordering  https://review.openstack.org/211891
09:13 openstackgerrit Merged openstack/puppet-designate: Rely on autorequire for config resource ordering  https://review.openstack.org/211890
09:15 openstackgerrit Merged openstack/puppet-cinder: Rely on autorequire for config resource ordering  https://review.openstack.org/211886
09:18 openstackgerrit Merged openstack/puppet-ceilometer: Rely on autorequire for config resource ordering  https://review.openstack.org/211884
09:18 openstackgerrit Merged openstack/puppet-keystone: Rely on autorequire for config resource ordering  https://review.openstack.org/211900
09:18 openstackgerrit Merged openstack/puppet-keystone: Rely on autorequire for config resource ordering  https://review.openstack.org/211900
09:21 openstackgerrit Merged openstack/puppet-heat: Rely on autorequire for config resource ordering  https://review.openstack.org/211894
09:26 openstackgerrit Merged openstack/puppet-nova: Rely on autorequire for config resource ordering  https://review.openstack.org/211909
09:34 openstackgerrit Yanis Guenane proposed openstack/puppet-neutron: Make package change run the db_sync  https://review.openstack.org/202920
09:37 gildub joined #puppet-openstack
09:49 openstackgerrit Emilien Macchi proposed openstack/puppet-heat: acceptance: bump to Liberty release  https://review.openstack.org/209290
09:50 openstackgerrit Emilien Macchi proposed openstack/puppet-manila: acceptance: bump to Liberty release  https://review.openstack.org/209293
09:59 openstackgerrit Emilien Macchi proposed openstack/puppet-ceilometer: WSGI: make it work, and test it with acceptance  https://review.openstack.org/209320
10:02 saneax joined #puppet-openstack
10:04 degorenko spredzy, hey o/ why nobody is review your patch https://review.openstack.org/#/c/202574/ ?
10:06 spredzy degorenko, o/ I dont know ... People are busy or in vacation I guess. August is always a slow time. Although I did have some review. Will ping richm later today to know if he thinks the test are enough :)
10:07 degorenko spredzy, oh, okay, will wait then :) thanks
10:09 EmilienM degorenko, spredzy: have you tried this patch on another module using Depends-On ?
10:09 degorenko EmilienM, spredzy good idea
10:09 EmilienM so people would actually see it works
10:10 spredzy EmilienM, all modules were green this morning before Rely on autorequire got merged. Not its in merged conflict. Else the patch is ready to merge.https://review.openstack.org/#/c/209882/
10:10 spredzy EmilienM, all puppet-openstack modules have been patched with this review (puppet-openstacklib) as a Depends-On https://review.openstack.org/#/q/status:open+branch:master+topic:inifile_proxy_provider,n,z
10:11 spredzy Look at the acceptance test in each of them :)
10:11 EmilienM ah
10:12 EmilienM spredzy: https://review.openstack.org/#/c/209882/4/spec/acceptance/heat_config_spec.rb,cm
10:12 EmilienM excellent
10:12 spredzy :)
10:12 spredzy Will rebase the on in conflict later today
10:13 EmilienM spredzy: though I have suggestions on the acceptance patch, I'll +2 the openstacklib
10:13 spredzy EmilienM, shoot either here or on a review I will need to amend all the reviews anyway :)
10:15 EmilienM spredzy: done - brb
10:16 jeblair joined #puppet-openstack
10:17 spredzy EmilienM, ack
10:19 degorenko EmilienM, can you review my patch https://review.openstack.org/205987 ? :) it has already +2 and +1 from Sahara team. Do we need +1 from Sahara PTL? :)
10:23 EmilienM degorenko: looking now and commenting
10:27 degorenko EmilienM, so, if parameters absolutely wrong, have never been used in sahara and was added by mistake (why?) - they should be deprecated?
10:28 EmilienM degorenko: because they have been added, we need to support them
10:28 EmilienM I know it's bizarre
10:28 EmilienM but we have an interface, we need to support it
10:28 EmilienM we can't just "drop parameters"
10:29 degorenko EmilienM, then, i just drop those parameters from config, but left warning message and mark them as deprecated, is it right?
10:29 EmilienM degorenko: yeah, like you do with other deprecated params in init.pp
10:29 EmilienM degorenko: and a nice warning explaining the params are useless :)
10:30 degorenko EmilienM, in init.pp were just only deprecated and renamed, but there are different case. Okay, i'll upload new patch.
10:30 EmilienM degorenko: after that, I'll +2
10:33 EmilienM spredzy: do you think we can drop these parameters?
10:33 EmilienM degorenko: wait
10:33 spredzy EmilienM, let me refind a link I used to +2 this
10:33 degorenko spredzy, https://review.openstack.org/#/c/205987
10:34 EmilienM spredzy: this is my question ^
10:34 EmilienM spredzy: what do you think about my comment
10:34 degorenko EmilienM, btw, should i use one 'if' for all of them or per each 'if' ?
10:35 EmilienM degorenko: wait a sec, I'm just asking some feedback from other reviewers - maybe we can move forward with this one
10:35 spredzy Well based on https://github.com/openstack/sahara/blob/stable/kilo/etc/sahara/sahara.conf.sample-basic and https://github.com/openstack/sahara/blob/master/etc/sahara/sahara.conf.sample-basic
10:36 EmilienM I'm not talking about OpenStack functional
10:36 EmilienM I'm talking about Puppet interface here
10:36 spredzy those parameters have never been used, so basically if someone was using them s/he didn't know what s/he was doing
10:36 EmilienM if anyone is running a manifest with this parameter
10:36 EmilienM the catalog will fail
10:36 spredzy It will since those parameters doesn't exist anymore
10:36 EmilienM that's my point
10:37 spredzy So yes I guess the safest path will be to deprecate them for some tie
10:37 spredzy time*
10:37 degorenko EmilienM, spredzy my point for this - that is using of this parameters - mistake and it should failed. Because it wrong parameters. But, i can left waring message
10:37 degorenko s/waring/warning
10:38 degorenko okay, i'll prepare new patch
10:38 degorenko and again: EmilienM, btw, should i use one 'if' for all of them or per each 'if' ?
10:39 EmilienM degorenko: you can use OR
10:39 degorenko so i can use one if?
10:42 EmilienM I guess?
10:43 EmilienM if $param or $param2 ...
10:43 degorenko okay, i will use per each if
10:43 degorenko it will be more informative and have no spam
10:43 degorenko s/have/has
10:43 markvoelker joined #puppet-openstack
10:48 openstackgerrit Denis Egorenko proposed openstack/puppet-sahara: Update parameters for Sahara  https://review.openstack.org/205987
10:49 degorenko EmilienM, spredzy ^ take a look please
10:49 EmilienM degorenko: sure
10:51 EmilienM degorenko: +2
10:51 degorenko EmilienM, thanks!
10:54 xingchao joined #puppet-openstack
11:07 degorenko spredzy, EmilienM https://review.openstack.org/#/c/205987/ tests passed :) let
11:07 degorenko let's merge :D
11:08 degorenko EmilienM, spredzy also, this patch is actual for kilo, can i cherry-pick them?
11:08 EmilienM degorenko: you'll have yes
11:09 EmilienM degorenko: and drop the warnings in master ;)
11:09 degorenko EmilienM, this patch is for master now :(
11:09 EmilienM degorenko: yes
11:09 EmilienM but later
11:09 degorenko oh, okay :)
11:14 openstackgerrit Gilles Dubreuil proposed openstack/puppet-keystone: Keystone Role/Group resource provider  https://review.openstack.org/211444
11:30 myatsenko joined #puppet-openstack
11:44 markvoelker joined #puppet-openstack
11:47 openstackgerrit Emilien Macchi proposed openstack/puppet-sahara: acceptance: bump to Liberty release  https://review.openstack.org/212496
11:53 markvoelker joined #puppet-openstack
11:59 jpena joined #puppet-openstack
12:04 ducttape_ joined #puppet-openstack
12:13 iurygregory good morning
12:20 xingchao joined #puppet-openstack
12:20 ducttape_ joined #puppet-openstack
12:29 degorenko morning o/
12:30 iurygregory \o
12:34 mattymo_ markvoelker, hey
12:51 sergmelikyan joined #puppet-openstack
12:53 richm joined #puppet-openstack
12:56 richm joined #puppet-openstack
12:57 EmilienM pabelanger: hello !
13:02 openstackgerrit joined #puppet-openstack
13:09 saneax joined #puppet-openstack
13:16 openstackgerrit Gilles Dubreuil proposed openstack/puppet-keystone: Public endpoint without API version  https://review.openstack.org/212523
13:18 openstackgerrit Andrey Yevsyukov proposed openstack/puppet-neutron: Add support for neutron-agent-mlnx deployment  https://review.openstack.org/209997
13:19 tiswanso joined #puppet-openstack
13:22 sergmelikyan joined #puppet-openstack
13:26 openstackgerrit Gilles Dubreuil proposed openstack/puppet-keystone: Public endpoint without API version  https://review.openstack.org/212523
13:27 v1k0d3n joined #puppet-openstack
13:27 mattymo_ hey EmilienM
13:27 EmilienM mattymo: o/
13:28 mattymo_ you wouldn't happen to know if gildub comes on irc often? he seems to be avoiding it
13:29 EmilienM mattymo: it's very late for him at this time, I suspect he's offline - though he's sending patches
13:29 mattymo_ yeah from tactical range, it seems
13:29 mattymo_ EmilienM, do you happen to know where he is located?
13:30 EmilienM mattymo: australia
13:30 mattymo_ oh that explains a lot
13:36 sergmelikyan joined #puppet-openstack
13:37 prad_ joined #puppet-openstack
13:38 dfisher joined #puppet-openstack
13:50 tiswanso joined #puppet-openstack
13:59 spredzy clayton, if around can I ask for reviews on https://review.openstack.org/#/q/status:open+branch:master+topic:autorequire_package_or_file,n,z
14:01 degorenko spredzy, hey, can you merge this? https://review.openstack.org/#/c/205987/ :)
14:02 dgurtner joined #puppet-openstack
14:03 openstackgerrit Emilien Macchi proposed openstack/puppet-manila: acceptance: bump to Liberty release  https://review.openstack.org/209293
14:05 openstackgerrit Yanis Guenane proposed openstack/puppet-ceilometer: Reflect provider change in puppet-openstacklib  https://review.openstack.org/209868
14:06 ferest joined #puppet-openstack
14:09 openstackgerrit Gilles Dubreuil proposed openstack/puppet-keystone: Public endpoint without API version  https://review.openstack.org/212523
14:13 aviramb joined #puppet-openstack
14:13 pabelanger EmilienM: morning
14:15 EmilienM pabelanger: hey
14:15 EmilienM pabelanger: can you see https://review.openstack.org/210089 and tell me what you think?
14:16 dfisher can I ask a general puppet question in here, or should I go try #puppet?
14:16 dfisher I rarely have any luck in #puppet :/
14:16 tiswanso joined #puppet-openstack
14:17 EmilienM dfisher: go ahead! We'll add it to the beer list :P
14:17 dfisher shit, at this point, I just need to wheel a keg in.
14:17 dfisher or 3
14:17 dfisher ok, so, I have a puppet environment.  configured as /etc/puppet/environment/foo
14:18 dfisher if I still something in …/foo/manifests/site.pp  like "notify { message => 'hello world' }" it works
14:18 dfisher i see that.
14:18 dfisher in foo/manifests/site.pp, I have import statements for nodes.
14:18 dfisher import "…/foo/manifests/nodes/node1.pp"
14:19 dfisher all I have in node1.pp is:
14:19 dfisher node 'openstack-1.us.oracle.com' {
14:19 dfisher mysql::db { 'cinder':
14:19 dfisher user            => 'cinder',
14:19 dfisher password        => 'cinder',
14:19 dfisher host            => 'localhost',
14:19 dfisher }
14:19 dfisher }
14:19 pabelanger EmilienM: commented added
14:19 EmilienM pabelanger: looking
14:19 dfisher just … make me a cinder database.
14:19 dfisher nothing complicated.
14:19 EmilienM pabelanger: cool!, feel free to take over :)
14:19 dfisher in the agent log, I get:
14:19 dfisher 2015-08-13 14:15:56 +0000 Puppet (notice): Starting Puppet client version 3.6.2
14:19 dfisher 2015-08-13 14:16:00 +0000 Puppet (err): Could not retrieve catalog from remote server: Error 400 on SERVER: Invalid parameter provider on Mysql_database[cinder] on node openstack-kz-1.us.oracle.com
14:19 EmilienM pabelanger: see other comments from crinkle on other patches - maybe we can move forward those things this week
14:20 dfisher but when I run 'puppet apply' with the same code, it works fine.
14:20 dfisher root@:/var/log/puppet# puppet apply --noop -e "mysql::db { 'cinder': user => 'cinder', password => 'cinder',}"
14:20 dfisher Notice: /Stage[main]/Main/Mysql::Db[cinder]/Mysql_user[cinder@localhost]/ensure: current_value absent, should be present (noop)
14:20 dfisher Notice: /Stage[main]/Main/Mysql::Db[cinder]/Mysql_database[cinder]/ensure: current_value absent, should be present (noop)
14:20 dfisher Notice: /Stage[main]/Main/Mysql::Db[cinder]/Mysql_grant[cinder@localhost/cinder.*]/ensure: current_value absent, should be present (noop)
14:20 dfisher Notice: Mysql::Db[cinder]: Would have triggered 'refresh' from 3 events
14:20 dfisher Notice: Class[Main]: Would have triggered 'refresh' from 1 events
14:20 EmilienM dfisher: please use paste
14:20 pabelanger jebus
14:20 dfisher sorry.
14:20 dfisher will paste.
14:21 EmilienM dfisher: it's likely your puppet master node missing some modules or?
14:21 pabelanger EmilienM: Ya, I have some fedora 22 stuff I'm working on this week. So, not sure if I'll have the time this week to focus on puppet-openstack-integration.  Also trying to get msync patchset signed off too
14:21 EmilienM pabelanger: I have time. Can I do that?
14:21 EmilienM pabelanger: so we can make progress
14:21 dfisher puppet module list shows the mysql module
14:22 EmilienM pabelanger: I'll take your bits and add Co-Authored-By stuff
14:24 pabelanger EmilienM: if you want, but won't be able to review until next week
14:24 pabelanger or until I get fedora 22 dibs going
14:24 EmilienM pabelanger: at least prepare the patch and see how gate works
14:24 EmilienM pabelanger: and get crinkle's feedback
14:25 EmilienM pabelanger: you'll have time to review it won't land before next week anyway
14:25 EmilienM just to make progress on that
14:25 aviramb dfisher does "puppet apply /etc/puppet/environment/foo/manifests/nodes/node1.pp" fails too?
14:25 dfisher it's on a different system.
14:25 dfisher i can easily scp it over
14:25 dfisher and try it
14:26 dfisher http://paste.openstack.org/show/412891/
14:26 dfisher paste of above.  apologies for that
14:28 dfisher aviramb:  if I scp node1.pp over to the agent system, yes, it works
14:29 aviramb and if you work in production/default env using master-agent?
14:31 dfisher i'm pretty sure it'll work if I move back to default
14:31 dfisher give me a sec.
14:35 ducttape_ joined #puppet-openstack
14:37 dfisher ok, might need more than a sec.  I think I hosed something :)
14:40 bklei joined #puppet-openstack
14:42 linkedinyou joined #puppet-openstack
14:47 vmbrasseur joined #puppet-openstack
14:54 bklei crinkle are you cool with https://review.openstack.org/#/c/211736/ and https://review.openstack.org/#/c/212117/ now?
14:58 sergmelikyan joined #puppet-openstack
15:03 mdorman joined #puppet-openstack
15:19 bklei_ joined #puppet-openstack
15:23 xingchao joined #puppet-openstack
15:23 paramite joined #puppet-openstack
15:23 angdraug joined #puppet-openstack
15:28 morazi joined #puppet-openstack
15:30 darkxploit joined #puppet-openstack
15:32 darkxploit joined #puppet-openstack
15:34 darkxploit joined #puppet-openstack
15:43 crinkle bklei_: looks good
15:47 dprince joined #puppet-openstack
15:49 EmilienM crinkle: I dropped some comments on https://review.openstack.org/#/c/210784/ & https://review.openstack.org/#/c/210380/
15:51 myatsenko left #puppet-openstack
15:51 myatsenko joined #puppet-openstack
15:51 openstackgerrit Eric Peterson proposed openstack/puppet-keystone: Adding wsgi log formatting  https://review.openstack.org/212091
15:56 ducttape_ EmilienM - I knew I was going to need unit test  ;)
15:56 * ducttape_ curses unit tests
15:56 EmilienM ducttape_: ;)
15:57 darkxploit joined #puppet-openstack
15:58 ducttape_ and if crinkle is happy, does that mean everyone is happy?
15:58 EmilienM :)
16:02 openstackgerrit Merged openstack/puppet-monasca: Allow config of check idle connection for persister  https://review.openstack.org/211736
16:03 openstackgerrit Merged openstack/puppet-monasca: Fix template variable scoping  https://review.openstack.org/212117
16:09 dfisher EmilienM:  aviramb helped me figure everything out.   My version of puppet (3.6.2) needs PUP-1515 (fixed in 3.7.5/4.0.0)
16:10 EmilienM dfisher: cool
16:10 dfisher so, i either need to figure out how to work with 3.6.2 or go through the worst process ever to update puppet in solaris
16:10 dfisher are the openstack modules 4.x compliant?
16:14 openstackgerrit Eric Peterson proposed openstack/puppet-keystone: Adding wsgi log formatting  https://review.openstack.org/212091
16:14 spredzy crinkle, ping. With EmilienM we're not sure for this series (https://review.openstack.org/#/q/status:open+branch:master+topic:inifile_proxy_provider,n,z) if it is worth having a separate acceptance test scenarios. We would like to have your opinion
16:14 * ducttape_ adds unit test, still curses them
16:15 spredzy ie. for modules with a single configuration provider it might be not worth it. But when modules have a lot of config providers (like neutron) - it seems like we are better off leaving them on their file https://review.openstack.org/#/c/209875/9/spec/acceptance/neutron_config_spec.rb,cm
16:18 crinkle spredzy: i would think the tests we already have would generally catch config issues?
16:18 spredzy crinkle, those test are meant to ensure the new behavior is working as expected
16:18 spredzy crinkle, the behavior that if we specify a specific keyword it is then absent from the file
16:19 crinkle oh i see
16:19 crinkle ¯\_(ツ)_/¯
16:19 crinkle I feel like acceptance tests should just be checking whether the stuff is generally working, not inspecting the contents of config files
16:20 crinkle maybe an acceptance test in openstacklib?
16:20 openstackgerrit Emilien Macchi proposed openstack/puppet-openstack-integration: scenario001: configure and run tempest  https://review.openstack.org/207078
16:20 spredzy crinkle, in openstacklib we have a unittest, since openstack_config can not be instantiated itself we can't test the behavior there
16:20 EmilienM crinkle: +1
16:20 spredzy hence the tests in the respective modules
16:20 crinkle spredzy: hrm yeah
16:21 EmilienM pabelanger: both patches in https://review.openstack.org/207078
16:21 crinkle spredzy: but it seems overkill to add that test to all the modules, if one is workin they're all probably working
16:21 crinkle spredzy: idk i don't have a good answer
16:21 EmilienM maybe write acceptance test in the openstacklib module
16:22 EmilienM by creating a fake provider
16:22 EmilienM and see how it behaves
16:24 mwoodson joined #puppet-openstack
16:25 pabelanger EmilienM: ack
16:25 EmilienM spredzy: ^
16:29 spredzy EmilienM, hmmm How do you create fake providers in acceptance test ? I could do what you suggest, but the openstacklib patch will need to go first (as-is), then the keystone patch (minus the acceptance), then a new openstacklib patch that demostrates the behavior once the keystone patch has been merged
16:30 EmilienM spredzy: you can do dependencies
16:30 EmilienM but the idea would be to create a fake_config provider
16:30 EmilienM and test it
16:30 spredzy but how do you create a fake config provider in acceptance test ?
16:30 spredzy A fake config provider has already been created in the unit test to demostrate the behavior
16:31 spredzy acceptance test are plain puppet code as far as I know
16:31 EmilienM spredzy: maybe you can create an actual provider?
16:31 EmilienM and consume this provider from acceptance
16:31 spredzy EmilienM, nop, that is not the point, the openstacklib is supposed to be a fully transparent proxy
16:31 EmilienM maybe it's overkill
16:32 spredzy what I can do is create another review (with an acceptance test only) that will depend on the keystone (inifilx_proxy_provider), that will depend on the actual code for the proxy in openstacklib
16:32 spredzy would you guys be ok with that ? EmilienM crinkle ?
16:32 openstackgerrit joined #puppet-openstack
16:32 crinkle haha
16:32 EmilienM it does not solve our problem of testing the code
16:32 crinkle i think that will work
16:33 spredzy EmilienM, why not ? It will prove that the provider works
16:33 spredzy as expected
16:33 EmilienM spredzy: what about if, later I want to patch your code? how is it tested?
16:33 spredzy in the openstacklib acceptance test
16:33 spredzy every config provider will be children of openstack_config
16:34 spredzy so if you change anything there every module will be impacted and the acceptance test of openstacklib will fail
16:34 EmilienM spredzy: but you still need to write a fake provider, isn't?
16:34 spredzy no at all
16:34 bklei_ thx for the merges crinkle
16:35 spredzy I will rely on one of our providers (be it keystone, nova or whichever)
16:35 EmilienM spredzy: go ahead with your proposal, I guess I'm missing something
16:35 EmilienM ahh
16:35 spredzy hence the 3 review dance
16:35 EmilienM but you need to install keystone then
16:35 EmilienM in openstacklib acceptance
16:36 spredzy well not instanciating the keystone class but yes installing it in the module path
16:36 spredzy well if you stand by the -1 earlier when you didn't like the File { '/etc/keystone/keystone.conf' : } resource for testing, yes I will have to instantiate keystone
16:37 EmilienM spredzy: brb lunch
16:37 EmilienM spredzy: send it, I'll see :)
16:37 spredzy EmilienM, ack
16:41 EmilienM pabelanger: it works: https://jenkins05.openstack.org/job/gate-puppet-openstack-integration-dsvm-centos7/16/console
16:42 aimon joined #puppet-openstack
16:42 pabelanger EmilienM: scary!
16:52 openstackgerrit Matthew Mosesohn proposed openstack/puppet-keystone: Update get_endpoint to use credentials auth_url first  https://review.openstack.org/207890
16:58 sergmelikyan joined #puppet-openstack
17:02 ddmitriev joined #puppet-openstack
17:04 openstackgerrit Benedikt von St. Vieth proposed openstack/puppet-glance: solve duplicate declaration issue for python-openstackclient  https://review.openstack.org/211863
17:19 EmilienM crinkle: could you please revisit https://review.openstack.org/#/c/209320/ ?
17:32 openstackgerrit Emilien Macchi proposed openstack/puppet-ceilometer: WSGI: make it work, and test it with acceptance  https://review.openstack.org/209320
17:32 EmilienM crinkle: thx^
17:35 dfisher how would i check gerrit to see if there are any outstanding reviews against a specific file in a specific branch?  Can I do that/
17:37 gfidente joined #puppet-openstack
17:37 gfidente joined #puppet-openstack
17:39 xingchao joined #puppet-openstack
17:39 openstackgerrit Dmitry Ilyin proposed openstack/puppet-neutron: Add retries to nova_admin_tenant_id_setter  https://review.openstack.org/194673
17:45 openstackgerrit Emilien Macchi proposed openstack/puppet-manila: api: require ::keystone::python  https://review.openstack.org/212680
17:45 EmilienM spredzy: ^
17:46 openstackgerrit Emilien Macchi proposed openstack/puppet-manila: acceptance: bump to Liberty release  https://review.openstack.org/209293
17:54 openstackgerrit Matthew Mosesohn proposed openstack/puppet-keystone: Update get_endpoint to use credentials auth_url first  https://review.openstack.org/207890
17:57 mattymo_ dfisher, you'll have to do some awk magic, but you can dump it with this command:
17:57 mattymo_ ssh -p 29418 review.openstack.org gerrit query --files --current-patch-set project:openstack/puppet-keyston
17:57 mattymo_ +e
17:58 sergmelikyan joined #puppet-openstack
18:04 openstackgerrit Richard Raseley proposed openstack/puppet-zaqar: puppet-zaqar: Initial commit  https://review.openstack.org/204225
18:06 chem joined #puppet-openstack
18:07 imcsk8 joined #puppet-openstack
18:19 angdraug joined #puppet-openstack
18:30 dfisher thanks!
19:02 tiswanso joined #puppet-openstack
19:12 sergmelikyan joined #puppet-openstack
19:14 chem joined #puppet-openstack
19:21 v1k0d3n left #puppet-openstack
19:21 v1k0d3n joined #puppet-openstack
19:21 Hunner v1k0d3n: hi
19:21 v1k0d3n left #puppet-openstack
19:22 mesamoo joined #puppet-openstack
19:43 imcsk8 joined #puppet-openstack
19:45 tiswanso joined #puppet-openstack
19:56 tiswanso joined #puppet-openstack
20:35 openstackgerrit Timothy Swanson proposed openstack/puppet-neutron: Update Cisco ML2 classes and templates  https://review.openstack.org/197181
20:42 xingchao joined #puppet-openstack
20:54 v1k0d3n joined #puppet-openstack
21:02 v1k0d3n Hunner: question...i was talking to david about this last week, is there a good vagrant deployment of puppet pe similar to the SE one you guys use internally? of the one's that i've found on github, many are outdated and pretty broken (and none are 2015.2 versions).
21:03 Hunner v1k0d3n: https://atlas.hashicorp.com/puppetlabs is where I would look to find the latest vagrant vms. Looks like the PE ones are 3.8.1 currently.
21:05 v1k0d3n Hunner: of course i left the big part out...(sorry)...are you guys using a vagrant version for auto-creation of r10k with github/gitlab etc environments? sort of a puppet dev workflow in a box?
21:08 Hunner v1k0d3n: Oh, there is also the acceptance tests for the modules
21:11 Hunner v1k0d3n: One of the gating jobs runs `bundle install && bundle exec rspec spec/acceptance` on modules, which runs specs like https://github.com/openstack/puppet-keystone/blob/master/spec/acceptance/basic_keystone_spec.rb on nodepool machines. You can also run it locally and it will vagrant up a test machine
21:12 Hunner v1k0d3n: I don't think I know what you mean... PL runs beaker tests on all of our modules, usually pointing at an internal VM infrastructure, and openstack does the same thing pointed at nodepool
21:13 Hunner Neither of those use vagrant, though beaker can do vagrant for local dev & testing
21:13 v1k0d3n Hunner: david and i first started talking about the r10k workflow hooks with github/gitlab, whatever.
21:13 v1k0d3n i am using gitlab for testing.
21:13 Hunner Also, we usually use the *-nocm machines that don't come with puppet installed, and install puppet as part of the test run https://github.com/openstack/puppet-keystone/blob/master/spec/spec_helper_acceptance.rb#L4
21:14 Hunner v1k0d3n: It looks like the openstack puppet project uses r10k to build out their module list though https://github.com/openstack/puppet-openstack-integration/blob/master/install_modules.sh#L31
21:14 v1k0d3n he pointed me to a couple of github projects which were meant to vagrant up a puppet workflow with working r10k hooks to automatically create environments. but each one we found was pretty broken. ah, github...love or hate.
21:15 v1k0d3n good find there...that's pretty cool
21:15 v1k0d3n so these are the mods you wanted me to use...the openstack modules, correct?
21:15 v1k0d3n not forge etc.
21:15 Hunner Those methods appear to be called from a modules spec/spec_helper_acceptance.rb files prior to running any manifests
21:16 Hunner forge.puppetlabs.com/openstack are the released versions of github.com/openstack/puppet-*
21:16 Hunner So you can point r10k at github, the forge, or probably even gerrit. Ppatches should always be submitted to gerrit, and github is available just for conveniece
21:31 sergmelikyan joined #puppet-openstack
22:10 sergmelikyan joined #puppet-openstack
22:24 clayton r10k + gerrit works fine, that's how we do all our deploys
22:24 mesamoo joined #puppet-openstack
22:35 gildub joined #puppet-openstack
22:42 openstackgerrit Gilles Dubreuil proposed openstack/puppet-keystone: Public endpoint without API version  https://review.openstack.org/212523
22:48 bklei joined #puppet-openstack
22:49 sergmelikyan joined #puppet-openstack
23:03 xarses joined #puppet-openstack
23:19 xavpaice joined #puppet-openstack
23:20 xavpaice left #puppet-openstack
23:31 chem joined #puppet-openstack
23:38 sergmelikyan joined #puppet-openstack
23:57 xingchao joined #puppet-openstack
23:57 aimon joined #puppet-openstack

| Channels | #puppet-openstack index | Today | | Search | Google Search | Plain-Text | summary