Perl 6 - the future is here, just unevenly distributed

IRC log for #puppet-openstack, 2015-09-23

| Channels | #puppet-openstack index | Today | | Search | Google Search | Plain-Text | summary

All times shown according to UTC.

Time Nick Message
00:05 jerrygb_ joined #puppet-openstack
00:13 tiswanso joined #puppet-openstack
00:40 markvoelker joined #puppet-openstack
00:55 tiswanso joined #puppet-openstack
00:57 tiswanso_ joined #puppet-openstack
01:15 ducttape_ joined #puppet-openstack
01:16 v1k0d3n joined #puppet-openstack
01:19 v1k0d3n joined #puppet-openstack
01:21 v1k0d3n joined #puppet-openstack
01:35 jfluhmann joined #puppet-openstack
01:45 jerrygb joined #puppet-openstack
01:45 jerrygb joined #puppet-openstack
01:47 ilbot3 joined #puppet-openstack
01:47 Topic for #puppet-openstack is now Puppet OpenStack modules - https://wiki.openstack.org/wiki/Puppet
01:59 michchap_ joined #puppet-openstack
02:17 ducttape_ joined #puppet-openstack
02:30 EmilienM _ody: lol
02:35 obbs joined #puppet-openstack
02:38 ferest joined #puppet-openstack
02:42 michchap joined #puppet-openstack
02:47 michchap joined #puppet-openstack
02:48 higgins joined #puppet-openstack
03:05 morazi joined #puppet-openstack
03:06 gildub joined #puppet-openstack
03:07 ducttape_ joined #puppet-openstack
03:09 michchap joined #puppet-openstack
03:13 gildub michchap, hi, in the long sequel of domains fixes, could you please review this one? https://review.openstack.org/218044
03:13 gildub michchap, it's all green because it only add methods to be used in coming reviews
03:14 gildub michchap, well I leave it with you to judge :)
03:16 markvoelker joined #puppet-openstack
03:18 zhangjn_ joined #puppet-openstack
03:33 michchap joined #puppet-openstack
03:42 v1k0d3n joined #puppet-openstack
03:51 v1k0d3n joined #puppet-openstack
03:55 v1k0d3n joined #puppet-openstack
03:57 v1k0d3n joined #puppet-openstack
04:25 zhangjn joined #puppet-openstack
04:28 zhangjn_ joined #puppet-openstack
04:33 zhangjn joined #puppet-openstack
04:39 zhangjn_ joined #puppet-openstack
04:40 michchap_ joined #puppet-openstack
04:43 zhangjn joined #puppet-openstack
04:58 openstackgerrit Gilles Dubreuil proposed openstack/puppet-keystone: Adds domain checking for Keystone V3 support  https://review.openstack.org/218044
04:58 openstackgerrit Gilles Dubreuil proposed openstack/puppet-keystone: Replace indirection calls  https://review.openstack.org/226624
04:59 zhangjn joined #puppet-openstack
05:05 sanjayu joined #puppet-openstack
05:08 ducttape_ joined #puppet-openstack
05:13 sergmelikyan joined #puppet-openstack
05:48 leanderthal joined #puppet-openstack
05:58 chandankumar joined #puppet-openstack
06:08 jerrygb joined #puppet-openstack
06:10 ducttape_ joined #puppet-openstack
06:46 sanjayu joined #puppet-openstack
06:50 sergmelikyan joined #puppet-openstack
06:51 serg_melikyan joined #puppet-openstack
06:53 chandankumar joined #puppet-openstack
06:55 smakar_ joined #puppet-openstack
06:57 guessi joined #puppet-openstack
07:02 openstackgerrit Gilles Dubreuil proposed openstack/puppet-keystone: Adds domain checking for Keystone V3 support.  https://review.openstack.org/218044
07:03 dgurtner joined #puppet-openstack
07:03 dgurtner joined #puppet-openstack
07:05 guessi joined #puppet-openstack
07:10 ducttape_ joined #puppet-openstack
07:14 dgurtner joined #puppet-openstack
07:26 openstackgerrit Gilles Dubreuil proposed openstack/puppet-keystone: Replace indirection calls  https://review.openstack.org/226624
07:26 openstackgerrit Gilles Dubreuil proposed openstack/puppet-keystone: Replace indirection calls  https://review.openstack.org/226624
07:27 gildub chem, hi
07:34 jpena joined #puppet-openstack
07:35 openstackgerrit Gilles Dubreuil proposed openstack/puppet-keystone: Replace indirection calls  https://review.openstack.org/226624
07:36 openstackgerrit Gilles Dubreuil proposed openstack/puppet-keystone: Replace indirection calls  https://review.openstack.org/226624
08:13 derekh joined #puppet-openstack
08:15 markvoelker joined #puppet-openstack
08:26 rochaporto joined #puppet-openstack
08:27 karume joined #puppet-openstack
08:50 jpena would anyone be able to review https://review.openstack.org/211549 ? It's been stuck for a week now with no new reviews, and it just needs another +2 to be merged. Thanks ;)
08:56 openstackgerrit Merged openstack/puppet-murano: Initial module implementation  https://review.openstack.org/211043
09:01 gfidente joined #puppet-openstack
09:01 gfidente joined #puppet-openstack
09:08 jerrygb joined #puppet-openstack
09:12 ducttape_ joined #puppet-openstack
09:25 sergmelikyan joined #puppet-openstack
09:52 paramite joined #puppet-openstack
10:17 markvoelker joined #puppet-openstack
10:19 degorenko joined #puppet-openstack
10:28 beddari joined #puppet-openstack
11:08 karume joined #puppet-openstack
11:13 ducttape_ joined #puppet-openstack
11:17 markvoelker joined #puppet-openstack
11:27 openstackgerrit Alexey Deryugin proposed openstack/puppet-murano: Implementaion of api and engine classes  https://review.openstack.org/216682
11:34 openstackgerrit Alexey Deryugin proposed openstack/puppet-murano: MySQL and PostreSQL class implementation  https://review.openstack.org/218221
11:35 jerrygb joined #puppet-openstack
11:40 aderyugin Hi, folks! Review https://review.openstack.org/#/c/216682 please
11:45 michchap joined #puppet-openstack
11:48 jerrygb joined #puppet-openstack
11:52 openstackgerrit Sergey Kolekonov proposed openstack/puppet-neutron: Add support for prevent_arp_spoofing option  https://review.openstack.org/225131
11:55 morazi joined #puppet-openstack
11:55 dprince joined #puppet-openstack
12:02 sergmelikyan joined #puppet-openstack
12:04 zhangjn joined #puppet-openstack
12:04 richm joined #puppet-openstack
12:14 EmilienM good morning
12:15 ducttape_ joined #puppet-openstack
12:15 karume joined #puppet-openstack
12:20 openstackgerrit Emilien Macchi proposed openstack/puppet-ceilometer: compute agent: do not try to configure nova.conf  https://review.openstack.org/226512
12:20 markvoelker joined #puppet-openstack
12:25 openstackgerrit Merged openstack/puppet-openstack-integration: scenario001: set API workers number to 4  https://review.openstack.org/225261
12:46 iurygregory good morning
12:51 ducttape_ joined #puppet-openstack
13:01 EmilienM someone already deployed puppet-swift in one single puppet run?
13:01 v1k0d3n joined #puppet-openstack
13:01 EmilienM dprince: fyi https://review.openstack.org/226512
13:02 dprince EmilienM: thanks
13:04 dprince EmilienM: is the idempotency issue new. If I recall it used to work just fine...
13:05 EmilienM dprince: I guess it's happenning since the params are in puppet noa
13:05 EmilienM puppet-nova*
13:05 EmilienM puppet-nova by default make sure it's absent
13:05 EmilienM and ceilometer set them
13:05 EmilienM and by the way, ceilometer team told me the params were wrong in puppet-ceilo
13:05 dprince EmilienM: oh, can you point me to the puppet-nova changset?
13:05 dprince EmilienM: sure, always changing...
13:06 EmilienM dprince: https://review.openstack.org/#/c/226490 what you need to run ceilometer + nova
13:06 EmilienM dprince: puppet-nova: 3ca8d4d8c8d9f182c0e5fbf8c428c3891f60c9e9
13:06 EmilienM I tink
13:14 openstackgerrit Emilien Macchi proposed openstack/puppet-openstack-integration: scenario001: enable telemetry service  https://review.openstack.org/226490
13:18 tiswanso joined #puppet-openstack
13:28 pradk joined #puppet-openstack
13:29 openstackgerrit Denis Egorenko proposed openstack/puppet-nova: Remove dead nova providers  https://review.openstack.org/226782
13:30 degorenko hello folks! I'm working on rewriting nova providers with new auth based on Openstack client and i found that we have very, very, very old providers which are dead
13:30 degorenko EmilienM, spredzy sbadia https://review.openstack.org/#/c/226782/ take a look please
13:33 iurygregory hey degorenko, can you take a look at my comment in https://review.openstack.org/#/c/216682/22/manifests/engine.pp ?
13:34 degorenko iurygregory, hey o/ i saw already :) i think, Alexey forgot answer in prev patch set
13:34 degorenko iurygregory, yep, take a look now :)
13:34 iurygregory sure =)
13:45 openstackgerrit Alexey Deryugin proposed openstack/puppet-murano: Implementaion of api and engine classes  https://review.openstack.org/216682
13:47 iurygregory Alex, i think you should replace  Implementaion to  Implementation
13:56 dfisher joined #puppet-openstack
13:57 degorenko aderyugin, ^
14:02 v1k0d3n joined #puppet-openstack
14:02 openstackgerrit Emilien Macchi proposed openstack/puppet-openstack-integration: install_modules: allow to customize PUPPETFILE_DIR  https://review.openstack.org/226803
14:05 ducttape_ joined #puppet-openstack
14:07 jerrygb joined #puppet-openstack
14:08 openstackgerrit Emilien Macchi proposed openstack/puppet-openstack-integration: install_modules: allow to customize PUPPETFILE_DIR  https://review.openstack.org/226803
14:13 richm vsaienko: ping
14:16 bklei joined #puppet-openstack
14:18 chandankumar joined #puppet-openstack
14:26 khushbu_ joined #puppet-openstack
14:33 sergmelikyan joined #puppet-openstack
14:36 delattec joined #puppet-openstack
14:37 openstackgerrit Merged openstack/puppet-openstack-integration: scenario001: add volume service  https://review.openstack.org/223800
14:38 openstackgerrit Emilien Macchi proposed openstack/puppet-nova: Try to use zuul-cloner to prepare fixtures  https://review.openstack.org/226830
14:40 khushbu_ joined #puppet-openstack
14:40 openstackgerrit Emilien Macchi proposed openstack/puppet-openstacklib: DO NOT MERGE - zuul test  https://review.openstack.org/226833
14:41 openstackgerrit Emilien Macchi proposed openstack/puppet-nova: Try to use zuul-cloner to prepare fixtures  https://review.openstack.org/226830
14:42 EmilienM mwhahaha: fyi ^
14:48 delattec joined #puppet-openstack
14:49 aarefiev joined #puppet-openstack
14:50 ducttape_ joined #puppet-openstack
14:51 openstackgerrit Emilien Macchi proposed openstack/puppet-nova: Try to use zuul-cloner to prepare fixtures  https://review.openstack.org/226830
14:52 bklei joined #puppet-openstack
14:54 mdorman joined #puppet-openstack
15:00 mwhahaha cool
15:01 openstackgerrit Emilien Macchi proposed openstack/puppet-openstack-integration: install_modules: allow to customize PUPPETFILE_DIR  https://review.openstack.org/226803
15:02 openstackgerrit Emilien Macchi proposed openstack/puppet-nova: Try to use zuul-cloner to prepare fixtures  https://review.openstack.org/226830
15:10 fedexo joined #puppet-openstack
15:14 v1k0d3n joined #puppet-openstack
15:26 jfluhmann joined #puppet-openstack
15:26 openstackgerrit Emilien Macchi proposed openstack/puppet-nova: Try to use zuul-cloner to prepare fixtures  https://review.openstack.org/226830
15:43 gchamoul joined #puppet-openstack
15:46 khushbu joined #puppet-openstack
15:53 gchamoul joined #puppet-openstack
15:54 openstackgerrit Denis Egorenko proposed openstack/puppet-nova: Use OpenstackClient for nova auth  https://review.openstack.org/226862
15:59 openstackgerrit Emilien Macchi proposed openstack/puppet-ceilometer: compute agent: do not try to configure nova.conf  https://review.openstack.org/226512
16:04 dprince joined #puppet-openstack
16:08 openstackgerrit Emilien Macchi proposed openstack/puppet-nova: Implement WSGI support for Nova API  https://review.openstack.org/213315
16:09 bklei joined #puppet-openstack
16:10 smakar_ joined #puppet-openstack
16:10 khushbu_ joined #puppet-openstack
16:10 openstackgerrit Emilien Macchi proposed openstack/puppet-openstack-integration: scenario001: enable telemetry service  https://review.openstack.org/226490
16:16 openstackgerrit Merged openstack/puppet-openstack-integration: Handle the case when SELinux is disabled.  https://review.openstack.org/225151
16:17 EmilienM crinkle: you might want to see https://review.openstack.org/#/c/226830/ before it lands
16:23 openstackgerrit Merged openstack/puppet-nova: volume: allow to change catalog_info  https://review.openstack.org/225980
16:36 ducttape_ joined #puppet-openstack
16:41 openstackgerrit Alexander Tivelkov proposed openstack/puppet-murano: MySQL and PostreSQL class implementation  https://review.openstack.org/218221
16:43 EmilienM sbadia: it seems failing
16:43 EmilienM http://logs.openstack.org/30/226830/5/check/gate-puppet-nova-puppet-unit-3.3-dsvm-centos7/1ac89f4/console.html
16:43 EmilienM for rabbitmq
16:43 EmilienM I wonder if it's not the rabbitmq module version
16:44 EmilienM our test pinned origin/2.x
16:44 EmilienM and beaker 5.2.3
16:44 EmilienM I guess our tests are broken for 5.x
16:47 delattec joined #puppet-openstack
16:49 EmilienM mhh, Unable to determine lsbdistid
17:07 alokj_ joined #puppet-openstack
17:08 openstackgerrit Emilien Macchi proposed openstack/puppet-nova: Try to use zuul-cloner to prepare fixtures  https://review.openstack.org/226830
17:09 EmilienM sbadia: https://review.openstack.org/#/c/226882/
17:12 openstackgerrit Emilien Macchi proposed openstack/puppet-openstack-integration: DNM - CI test  https://review.openstack.org/226884
17:19 openstackgerrit Ramkumar Gowrishankar proposed openstack/puppet-neutron: Support for Nuage Neutron plugin and Nuage VRS in puppet-neutron  https://review.openstack.org/214798
17:23 ducttape_ joined #puppet-openstack
17:48 leanderthal joined #puppet-openstack
17:54 EmilienM dprince: have you seen that before http://logs.openstack.org/30/226830/5/check/gate-puppet-nova-puppet-unit-4.0-dsvm-centos7/cc1856b/console.html#_2015-09-23_16_38_09_624 ?
17:55 EmilienM dprince: I would love if you could do a release of your module asap - it will block puppet-nova after https://review.openstack.org/226830
17:56 EmilienM https://github.com/dprince/puppet-qpid/commit/16694772fe81088b23d0bb18c31efe35fe68d0ca
17:56 dprince EmilienM: I've not seen it
17:56 dprince EmilienM: you want a release to puppet forge?
17:56 smakar_ joined #puppet-openstack
17:57 EmilienM dprince: I need a 1.0.3
17:57 EmilienM from the last commit in master
17:57 dprince EmilienM: okay, will do
17:57 EmilienM dprince: awesome :)
17:57 dprince EmilienM: not many people using qpid anymore I'm afraid
17:57 dprince EmilienM: still some though...
17:58 EmilienM dprince: well, I don't use it, it's just our CI using it, for unit testing
18:10 xarses joined #puppet-openstack
18:14 zhangjn joined #puppet-openstack
18:20 EmilienM chem: just saw your review
18:20 openstackgerrit Athlan-Guyot sofer proposed openstack/puppet-keystone: Add semantic title for keystone_tenant.  https://review.openstack.org/226919
18:20 EmilienM so the goal is to not use fixtures.yaml at all
18:21 EmilienM so our unit testing & functional testing use a single Puppetfile which is centralized & gated
18:21 EmilienM because currently, .fixtures files are not consistent 1/ across modules 2/ with functional testing
18:24 delattec joined #puppet-openstack
18:24 EmilienM chem: commenting in gerrit
18:25 khushbu_ joined #puppet-openstack
18:25 openstackgerrit Jay_Clark proposed openstack/puppet-zaqar: continuing work on the initial pass of the zaqar module.  https://review.openstack.org/226921
18:26 ducttape_ joined #puppet-openstack
18:30 openstackgerrit Emilien Macchi proposed openstack/puppet-openstack-integration: Puppetfile: bump qpid to 1.0.3  https://review.openstack.org/226927
18:34 openstackgerrit David Gurtner proposed stackforge/puppet-ceph: Switch to new release key  https://review.openstack.org/226932
18:35 openstackgerrit Emilien Macchi proposed openstack/puppet-nova: Try to use zuul-cloner to prepare fixtures  https://review.openstack.org/226830
18:43 dprince EmilienM: https://forge.puppetlabs.com/dprince/qpid
18:43 dprince EmilienM: 1.0.3 published
18:45 EmilienM dprince: you rocks
18:45 bkero dprince: oh hey, I just wrote tests against that
18:45 bkero I guess I'll have to go see if I need to rewrite them :)
18:46 dprince bkero: should be fairly stable I think
18:46 dprince bkero: not too many changes between the releases
18:46 bkero Yeah. Super simple.
18:47 bkero dprince: https://pastebin.mozilla.org/8847269
18:48 dprince bkero: cool
18:48 bkero dprince: feel like taking tests upstream? :)
18:49 dprince bkero: sure, submit a PR
18:49 bkero ok
18:56 ducttape_ joined #puppet-openstack
18:57 _ducttape_ joined #puppet-openstack
19:03 delattec joined #puppet-openstack
19:03 openstackgerrit Emilien Macchi proposed openstack/puppet-openstack-integration: Puppetfile: bump apt from 1.8.x to 2.1x  https://review.openstack.org/226945
19:03 openstackgerrit Emilien Macchi proposed openstack/puppet-nova: Try to use zuul-cloner to prepare fixtures  https://review.openstack.org/226830
19:13 khushbu_ joined #puppet-openstack
19:17 openstackgerrit Emilien Macchi proposed openstack/puppet-nova: Try to use zuul-cloner to prepare fixtures  https://review.openstack.org/226830
19:24 EmilienM mwhahaha: not sure you saw crinkle's comment on https://review.openstack.org/219883
19:24 mwhahaha yea it's on my list of stuff to do
19:25 delattec joined #puppet-openstack
19:26 mwhahaha i think you also mentioned to talk to dfisher about it as well
19:32 mwhahaha note sent to the ML
19:33 openstackgerrit Merged openstack/puppet-cinder: DB purge cron job  https://review.openstack.org/226277
19:36 dfisher me?  swift security?
19:36 dfisher wat
19:36 derekh joined #puppet-openstack
19:36 dfisher oh, lookie there.  it does sort of link to that.
19:37 openstackgerrit Emilien Macchi proposed openstack/puppet-nova: Try to use zuul-cloner to prepare fixtures  https://review.openstack.org/226830
19:44 openstackgerrit Merged openstack/puppet-nova: Allow to change archive destination  https://review.openstack.org/226272
19:44 openstackgerrit Emilien Macchi proposed openstack/puppet-nova: Try to use zuul-cloner to prepare fixtures  https://review.openstack.org/226830
19:45 openstackgerrit Merged openstack/puppet-keystone: Allow to change archive destination  https://review.openstack.org/226271
19:49 openstackgerrit Merged openstack/puppet-keystone: Allow customization of db sync command line  https://review.openstack.org/199714
19:58 delattec joined #puppet-openstack
20:03 openstackgerrit Emilien Macchi proposed openstack/puppet-nova: Try to use zuul-cloner to prepare fixtures  https://review.openstack.org/226830
20:13 angdraug joined #puppet-openstack
20:13 openstackgerrit Emilien Macchi proposed openstack/puppet-nova: Try to use zuul-cloner to prepare fixtures  https://review.openstack.org/226830
20:16 ducttape_ joined #puppet-openstack
20:26 delattec joined #puppet-openstack
20:26 openstackgerrit Emilien Macchi proposed openstack/puppet-nova: Try to use zuul-cloner to prepare fixtures  https://review.openstack.org/226830
20:37 EmilienM crinkle: can you +A https://review.openstack.org/#/c/226803/ and +2 https://review.openstack.org/#/c/226927/ - it will help me to debug the nova bug locally - thanks
20:44 crinkle it looks like https://review.openstack.org/#/c/225151 broke centos integration tests?
20:44 ducttape_ joined #puppet-openstack
20:45 crinkle 226803 was working, then rebased on top of 226927 and broke
20:45 EmilienM crinkle: I don't think so
20:46 EmilienM it's packaging I think
20:46 EmilienM crinkle: I don't see how || true can break it, since we're setting selinux in permissive
20:46 EmilienM we just wanted avoid failure in case people run the script on some system that do not have selinux
20:46 crinkle it's a change affecting only centos that broke only centos, seems like a pretty big coincidence
20:48 EmilienM crinkle: I can try a revert, I'm pretty sure the job will fail also
20:49 EmilienM crinkle: rdo team is having issues to spawn vm with latest packages
20:49 crinkle EmilienM: okay i won't worry about it
20:49 EmilienM crinkle: let's discuss about my proposal
20:49 EmilienM it seems you don't like it and it worries me
20:50 EmilienM because it's bringing consistency with functional testing and how we test modules
20:50 openstackgerrit Merged openstack/puppet-openstack-integration: install_modules: allow to customize PUPPETFILE_DIR  https://review.openstack.org/226803
20:50 EmilienM fixtures.yaml is really painful
20:50 EmilienM not consistent across our modules
20:50 EmilienM and it's dupplicating what we test in integration & beaker
20:51 crinkle EmilienM: so cloning every module in the puppetfile takes a really really long time, which worried me in the functional testing but seemed like the best solution that was in line with infra's plan
20:51 crinkle if a developer has to wait for 10 minutes for modules to clone when trying to run unit tests locally that is really painful
20:51 EmilienM ok, let's compare both
20:51 EmilienM let me 2 min
20:52 crinkle the .fixtures.yml way is consistent with how everyone else is doing unit testing
20:52 crinkle we're striving to be more like the rest of the puppet community
20:53 crinkle but this change takes us in a very different direction
20:53 EmilienM the yes, the cloning now takes 50 seconds instead of 7 seconds
20:53 EmilienM but at least we are testing the same version of the modules everywhere
20:54 EmilienM and we allow our CI to use zuul-cloner
20:54 EmilienM crinkle: if you prefer, I can keep fixtures.yaml in place and move the conditionnal to run only install_modules.sh in our CI
20:55 EmilienM ie: run our custom spec_prep only in our CI
20:55 EmilienM it will take 40 seconds more than regular way, but allow to use Depends-On which is a feature our community is asking
20:57 crinkle I guess 50 seconds isn't that bad...
20:58 EmilienM crinkle: yes, time here is not the right argument. Keeping consistent with Puppet Community is a good one. If you think it's important to keep fixtures, we can move the conditionnal
21:00 clayton can you clone with r10k?  something we do is build a cache of modules we clone in our CI tests and then run r10k after extracting the cache
21:00 EmilienM crinkle: I think we should allow our developpers to test the same thing as our CI
21:00 clayton r10k is really fast in the "almost nothing changed" case
21:00 EmilienM crinkle: because if I put the conditionnal, you'll use fixtures but your patch will maybe fail in our CI
21:01 EmilienM and the dev would ask "why does it fail in upstream CI and not on my laptop"
21:01 crinkle EmilienM: yeah, I think I'm coming around
21:01 crinkle EmilienM: better to be consistent
21:01 crinkle clayton: EmilienM's change does use r10k, though it doesn't set up a cache
21:01 EmilienM so the current patch does it
21:02 EmilienM it's not passing our CI and this is good, it's what I wanted to track
21:02 clayton we have a jenkins job that builds a tar.gz that contains all the modules checked out plus the r10k cache, so we just wget that and pipe it to tar xf - before running r10k
21:02 clayton r10k will ensure that everything ends up the way it should
21:02 EmilienM my patch is demonstrating our unit testing CI is not consistent with our functional testing CI
21:19 cdelatte joined #puppet-openstack
21:26 openstackgerrit Emilien Macchi proposed openstack/puppet-nova: rabbitmq: drop do not manage rabbitmq service anymore  https://review.openstack.org/227007
21:27 openstackgerrit Emilien Macchi proposed openstack/puppet-nova: Try to use zuul-cloner to prepare fixtures  https://review.openstack.org/226830
21:27 EmilienM trying to get rid of this
21:28 EmilienM crinkle: it reminds me we would need asap a canary job for integration with puppet-keystone for example
21:29 EmilienM because there is still a risk to break our modules
21:29 EmilienM I guess the risk is acceptable today but we might need to think about this job asap
21:39 openstackgerrit Emilien Macchi proposed openstack/puppet-nova: rabbitmq: do not manage rabbitmq service anymore  https://review.openstack.org/227007
21:40 openstackgerrit Emilien Macchi proposed openstack/puppet-nova: Try to use zuul-cloner to prepare fixtures  https://review.openstack.org/226830
21:40 EmilienM ok it works now
21:40 EmilienM crinkle: the apt/rabbitmq issue is "fixed" > we used a too old version of rabbitmq module
21:40 EmilienM it seems it pass now (on my laptop), will see CI
21:50 mjb joined #puppet-openstack
22:01 holser joined #puppet-openstack
22:01 xarses_ joined #puppet-openstack
22:03 nihilifer1 joined #puppet-openstack
22:07 openstackgerrit Emilien Macchi proposed openstack/puppet-nova: Try to use zuul-cloner to prepare fixtures  https://review.openstack.org/226830
22:07 ianw joined #puppet-openstack
22:10 v1k0d3n joined #puppet-openstack
22:17 openstackgerrit joined #puppet-openstack
22:58 gildub joined #puppet-openstack
22:58 gildub richm, hi
23:08 sanjayu joined #puppet-openstack
23:24 zhangjn joined #puppet-openstack
23:30 gildub richm, hi - As I commented in https://review.openstack.org/226624, there are two things:
23:31 gildub richm, 1. The domain check reviews' purpose is to add deprecation warning when not using ::domain (depending on default domain ...)
23:33 gildub richm, it does't intend to normalize the different ways of using domain names. Which basically are ::domain (composite title, whether implementing self.title_patterns or not) or using a domain property(parameter).
23:34 gildub richm, per the mailing list discussion, it seems clear that a provider can implement either or both
23:35 gildub richm, if we push for 226624, that means we're forcing the way, across the entire keystone module for ::domain to be used
23:37 openstackgerrit Merged openstack/puppet-neutron: Add support for prevent_arp_spoofing option  https://review.openstack.org/225131
23:37 richm gildub: in the current code, you can specify keystone_tenant {'project': ...} and keystone_user_role { 'someuser@project': ...}
23:37 richm gildub: I should say keystone_tenant {'project': domain => 'somedomain'}
23:38 richm gildub: and keystone_user_role { 'someuser@project': ...}
23:38 richm and the keystone_user_role code will know that 'project' is 'project' in the domain 'somedomain'
23:38 gildub richm, true but keystone_user needed tenant_domain
23:39 gildub richm, so besides that latter one, there is no need for the domain check patches to be applied before the indirection fix, that's my point
23:39 richm gildub: ok
23:39 richm gildub: but
23:40 richm gildub: fetch_user and fetch_project still won't work
23:40 gildub richm, it does
23:40 richm gildub: not with every case supported by the current code
23:40 richm gildub: see the above example
23:40 richm gildub: in this case, it will look for 'project' in the default domain and will fail
23:41 richm because it doesn't implement all of the logic in keystone_user.self.instances and keystone_tenant.self.instances
23:41 richm which is required in order to replace the indirection lookup
23:41 gildub richm, the fetch_project uses the domain value whether that comes from ::domain or domain=
23:41 richm gildub: but in this case that I described above, there is no '::domain' or domain= value
23:42 richm gildub: and this case is supported by the current code
23:42 gildub richm, then the indirection patch to add what's missing not the default domain check
23:42 richm right
23:42 openstackgerrit Merged openstack/puppet-nova: Remove dead nova providers  https://review.openstack.org/226782
23:42 richm or
23:43 richm patch puppet-keystone to get rid of my overly complex code in favor of a simple 'name' means 'name::Default'
23:43 richm then base the code that replaces indirection on top of that code
23:43 gildub richm, yes
23:44 richm which makes fetch_user and fetch_project work
23:44 gildub richm, I know the complexity is the result of a noble cause of having a de-facto domain besides the default one, but that turned against us
23:45 gildub richm, ok so can we do that? Shall it be a different patch and the indirection on top?
23:46 richm gildub: re: https://review.openstack.org/#/c/226624
23:46 richm gildub: This code does get rid of the complex lookup
23:46 richm gildub: https://review.openstack.org/#/c/226624/5/lib/puppet/provider/keystone_user/openstack.rb
23:47 openstackgerrit Merged openstack/puppet-ironic: Add support for identity_uri.  https://review.openstack.org/223128
23:47 richm gildub: sorry, wrong link https://review.openstack.org/#/c/218059/45/lib/puppet/provider/keystone_user/openstack.rb
23:47 richm re: https://review.openstack.org/#/c/218059
23:48 richm gildub: you changed self.instances to just say 'name' in default domain is just 'name', and 'name
23:48 richm 'name' not in default domain is 'name::domainname'
23:49 richm gildub: which is why I suggested rebasing https://review.openstack.org/#/c/226624 on top of https://review.openstack.org/#/c/218059
23:49 richm is this not so?
23:49 richm Am I misunderstanding the intention of this code?
23:50 gildub richm, yes and no, we just have to remove the warning/deprecation part then
23:50 gildub richm, yes for the clean up part, no for the deprecation warnings, because if we do the latter then we'll force the use of ::domain where we want to offer the flexibility of both, isn't?
23:51 gildub richm, ok then, I'll do a clean up patch only the indirection to go on top?
23:54 gildub richm, are we good?
23:59 gildub richm, reading back, you're not misunderstanding the code, it's the intend of those reviews :)
23:59 zhangjn joined #puppet-openstack

| Channels | #puppet-openstack index | Today | | Search | Google Search | Plain-Text | summary