Perl 6 - the future is here, just unevenly distributed

IRC log for #puppet-openstack, 2016-01-14

| Channels | #puppet-openstack index | Today | | Search | Google Search | Plain-Text | summary

All times shown according to UTC.

Time Nick Message
00:03 zhangjn joined #puppet-openstack
00:04 openstackgerrit Keith Schincke proposed openstack/puppet-ceph: Add support for civetweb support  https://review.openstack.org/254548
00:06 openstackgerrit yuan.lu proposed openstack/puppet-neutron: Update new default value from documents  https://review.openstack.org/267240
00:10 openstackgerrit yuan.lu proposed openstack/puppet-glance: Delete deprecated options in Liberty  https://review.openstack.org/267221
00:36 baker joined #puppet-openstack
00:37 baker joined #puppet-openstack
00:57 zhangjn joined #puppet-openstack
01:00 openstackgerrit Marcus Furlong proposed openstack/puppet-keystone: Specify user and project domains for admin role  https://review.openstack.org/267252
01:05 zhangjn_ joined #puppet-openstack
01:08 zhangjn joined #puppet-openstack
01:20 zhangjn joined #puppet-openstack
01:23 zhangjn joined #puppet-openstack
01:29 jasondotstar joined #puppet-openstack
01:35 zhangjn joined #puppet-openstack
01:37 openstackgerrit Xingchao Yu proposed openstack/puppet-glance: Add memcached_servers parameter  https://review.openstack.org/266248
01:48 rahulait joined #puppet-openstack
02:16 zhangjn joined #puppet-openstack
02:25 baker joined #puppet-openstack
02:26 zhangjn joined #puppet-openstack
02:32 xarses joined #puppet-openstack
02:34 openstackgerrit yuan.lu proposed openstack/puppet-neutron: Update new default value from documents  https://review.openstack.org/267240
02:37 ducttape_ joined #puppet-openstack
02:46 baker joined #puppet-openstack
02:46 zhangjn joined #puppet-openstack
02:46 ducttape_ joined #puppet-openstack
02:48 ilbot3 joined #puppet-openstack
02:48 Topic for #puppet-openstack is now Puppet OpenStack modules - https://wiki.openstack.org/wiki/Puppet
02:51 crinkle_ joined #puppet-openstack
02:52 openstackgerrit yuan.lu proposed openstack/puppet-glance: Delete deprecated options in Liberty  https://review.openstack.org/267221
02:52 jgrassler joined #puppet-openstack
02:53 cfloare joined #puppet-openstack
02:53 aarefiev joined #puppet-openstack
03:03 zhangjn joined #puppet-openstack
03:13 baker joined #puppet-openstack
03:16 baker_ joined #puppet-openstack
03:17 zhangjn joined #puppet-openstack
03:26 xarses joined #puppet-openstack
03:43 baker joined #puppet-openstack
03:43 jfluhmann joined #puppet-openstack
03:47 openstackgerrit Xingchao Yu proposed openstack/puppet-designate: Remove pick for managing package name.  https://review.openstack.org/267058
04:03 EmilienM mwhahaha: I would like to put our common bits in https://github.com/openstack/puppe​t-openstack_spec_helper/tree/maste​r/lib/puppet-openstack_spec_helper
04:03 EmilienM and require the bits in our modules
04:03 EmilienM it will drop lot of dupplicated code again
04:09 ducttape_ joined #puppet-openstack
04:18 mwhahaha Sure makes sense
04:20 EmilienM mwhahaha: ok I'll work on it
04:33 baker joined #puppet-openstack
05:22 zhangjn joined #puppet-openstack
05:28 zhangjn joined #puppet-openstack
05:35 openstackgerrit Xingchao Yu proposed openstack/puppet-designate: Add designate::mdns class  https://review.openstack.org/214976
05:41 zhangjn joined #puppet-openstack
05:43 openstackgerrit yuan.lu proposed openstack/puppet-glance: Delete deprecated options in Liberty  https://review.openstack.org/267221
05:50 zhangjn joined #puppet-openstack
05:53 openstackgerrit Merged openstack/puppet-nova: Change SSL options to [ssl] section.  https://review.openstack.org/266454
05:54 jaosorior joined #puppet-openstack
05:59 openstackgerrit Merged openstack/puppet-nova: Fix bug for deprecated vnc options.  https://review.openstack.org/266443
05:59 zhangjn joined #puppet-openstack
06:06 jfluhmann joined #puppet-openstack
06:08 narasimhasv joined #puppet-openstack
06:12 zhangjn joined #puppet-openstack
06:15 brad[] joined #puppet-openstack
06:16 zhangjn joined #puppet-openstack
06:19 zhangjn joined #puppet-openstack
06:25 zhangjn joined #puppet-openstack
06:43 jaosorior joined #puppet-openstack
06:46 jaosorior joined #puppet-openstack
06:46 mfisch _degorenko|afk: ping me when you get in, Im up for maintenance until 2 my time
07:15 jtomasek joined #puppet-openstack
07:24 openstackgerrit yuan.lu proposed openstack/puppet-neutron: Update new default value from documents  https://review.openstack.org/267240
07:32 paramite joined #puppet-openstack
07:44 jpena joined #puppet-openstack
07:52 openstackgerrit Oleksiy Molchanov proposed openstack/puppet-ceph: Add possibility to use mod_proxy for radosgw  https://review.openstack.org/266027
08:11 gfidente joined #puppet-openstack
08:24 jaosorior joined #puppet-openstack
08:24 mfisch _degorenko|afk: didnt make it until 2, anyway you can take over that review if you have time, I wont have time to retest the code this week
08:28 zhangjn joined #puppet-openstack
08:32 karimb joined #puppet-openstack
08:34 openstackgerrit Xingchao Yu proposed openstack/puppet-keystone: (WIP) Update keystone::resource::authtoken  https://review.openstack.org/266723
08:42 dgurtner joined #puppet-openstack
08:43 markvoelker joined #puppet-openstack
08:56 karimb joined #puppet-openstack
08:57 derekh joined #puppet-openstack
09:02 openstackgerrit Juan Antonio Osorio Robles proposed openstack/puppet-tripleo: Enable X-Forwarded-Proto header for keystone admin endpoint  https://review.openstack.org/267417
09:03 jistr joined #puppet-openstack
09:09 openstackgerrit narasimha18sv proposed openstack/puppet-neutron: Removed duplicate keystone configurations in neutron api-paste.ini Closes-Bug: #1513532  https://review.openstack.org/267420
09:09 openstack bug 1513532 in puppet-neutron "puppet-neutron duplicates auth information in neutron.conf and api-paste.ini" [Undecided,New] https://launchpad.net/bugs/1513532 - Assigned to narasimha18sv (narasimha18sv)
09:11 narasimhasv joined #puppet-openstack
09:13 zhangjn joined #puppet-openstack
09:21 rochaporto joined #puppet-openstack
09:23 openstackgerrit Martin Mágr proposed openstack/puppet-neutron: LBaaSv2 support  https://review.openstack.org/234728
09:44 markvoelker joined #puppet-openstack
10:07 degorenko mfisch, ping :)
10:08 openstackgerrit yuan.lu proposed openstack/puppet-neutron: Update new default value from documents  https://review.openstack.org/267240
10:09 IvanBerezovskiy joined #puppet-openstack
10:24 samuelBartel joined #puppet-openstack
10:46 openstackgerrit Mykyta Karpin proposed openstack/puppet-heat: Switch Heat to $::os_service_default - part 2  https://review.openstack.org/249711
11:07 openstackgerrit Jaume Devesa proposed openstack/puppet-tripleo: Remove all 'validate_array' statements  https://review.openstack.org/267474
11:32 zhangjn joined #puppet-openstack
11:38 ericksonsantos joined #puppet-openstack
11:45 markvoelker joined #puppet-openstack
11:53 dgurtner joined #puppet-openstack
12:07 omartsyniuk_ joined #puppet-openstack
12:08 openstackgerrit Alexey Deryugin proposed openstack/puppet-murano: Add acceptance tests for client and application provider  https://review.openstack.org/246480
12:33 EmilienM good morning
12:36 iurygregory morning =)
12:45 markvoelker joined #puppet-openstack
12:48 degorenko morning ;)
12:59 openstackgerrit Clayton O'Neill proposed openstack/puppet-nova: Add ensure_package for nova libvirt package  https://review.openstack.org/267533
13:17 dprince joined #puppet-openstack
13:18 ducttape_ joined #puppet-openstack
13:25 markvoelker joined #puppet-openstack
13:36 baker joined #puppet-openstack
13:37 ferest joined #puppet-openstack
13:39 trown degorenko, EmilienM, would you mind looking at https://review.openstack.org/267081 RDO liberty is broken by this
13:40 EmilienM trown: +2
13:40 trown thanks EmilienM
13:42 richm joined #puppet-openstack
13:43 degorenko trown, +A
13:44 trown woot
13:44 trown thanks degorenko
13:44 openstackgerrit Merged openstack/puppet-aodh: Use openstack spec helper for spec defaults  https://review.openstack.org/267224
13:46 EmilienM trown: let us know if anything else we can help
13:47 morazi joined #puppet-openstack
13:55 EmilienM degorenko: hey so the idea would be to first put some bits in https://github.com/openstack/puppe​t-openstack_spec_helper/tree/maste​r/lib/puppet-openstack_spec_helper
13:55 EmilienM and then require them in our modules
13:56 degorenko i saw, yeah
13:57 EmilienM degorenko: so here the plan if you like :
13:57 EmilienM 1/ we patch https://github.com/openstack/puppe​t-openstack_spec_helper/tree/maste​r/lib/puppet-openstack_spec_helper first
13:57 EmilienM 2/ we add the gem & requires in one module and see how it works
13:57 EmilienM 3/ we patch all modules (or either amending mwhahaha's patches)
13:58 degorenko understood
13:58 degorenko so, we can move some part of Rakefile here and use it as function with passing project name
13:58 degorenko for example
13:59 degorenko same thing for spec_helper_acceptance.rb
13:59 degorenko EmilienM, ^ thoughts?
14:00 EmilienM Rakefile is definitly going to change yeah
14:00 EmilienM and refactored
14:00 EmilienM degorenko: yes same thing
14:01 degorenko :)
14:01 degorenko nice, we have one vision of problem :D
14:02 openstackgerrit Merged openstack/puppet-neutron: Default qos_notification_drivers to upstream  https://review.openstack.org/267081
14:05 EmilienM yeah
14:05 EmilienM it's all about refacto in this cycle ;)
14:05 EmilienM less code, more modules :-P
14:07 EmilienM so I think we can start by spec/spec_helper_acceptance.rb - spec/spec_helper.rb and Rakefile
14:07 EmilienM degorenko: ^
14:07 EmilienM that's already a good start
14:08 degorenko agree :)
14:09 degorenko i think we can start it since next week. I haven't quite enough time on this week, also need to be update rspec patches
14:10 EmilienM degorenko: I think all mwhahaha changes can be abandonned because we won't copy this code everywhere
14:10 EmilienM for the ones that are already merged, no worries, we'll just patch modules with the new way
14:10 EmilienM do that work for you?
14:12 degorenko EmilienM, i don't think that we can abandon patches. We can update them with new way like your patch for aodh. But we also should add a new gem, shouldn't we?
14:13 EmilienM degorenko: works for me !
14:13 EmilienM degorenko: yes in Gemfile
14:13 EmilienM look my patch on puppet-aodh
14:13 EmilienM that you merged
14:13 degorenko it's already merged ;)
14:13 degorenko yeah
14:13 degorenko remove spec/defaults and add gem from puppet-spec-helper repo
14:14 degorenko btw, do we need remove gem for puppet-rspec-tests?
14:14 degorenko https://review.openstack.org/#/c/267224/1/Gemfile
14:14 degorenko line 6
14:14 EmilienM I think we still need it
14:14 degorenko that was added in alex patch
14:14 degorenko ok, just clarify this moment
14:14 EmilienM if you drop it, you'll have ruby error I'm pretty sure
14:15 degorenko ok, ok :)
14:15 degorenko so
14:15 degorenko for example
14:15 degorenko we have https://review.openstack.org/#/c/264566/
14:15 degorenko we will remove spec/defaults, add new gem in gemfile and also fix spec_helper for including
14:15 degorenko and that's all update
14:15 EmilienM yes
14:15 degorenko right?
14:15 degorenko good :)
14:15 EmilienM degorenko: but now I'm also adding more bits in https://github.com/openstack/puppe​t-openstack_spec_helper/tree/maste​r/lib/puppet-openstack_spec_helper
14:16 degorenko yeah
14:16 degorenko i know
14:16 EmilienM but that's not a big deal if we add it later in our modules
14:16 degorenko i think it is different bunch of patches
14:16 EmilienM it can be, yea
14:16 ducttape_ joined #puppet-openstack
14:16 degorenko we can do it one patch for all these files - but it is definitely another patch
14:16 degorenko because right now - we are talking about only os_service_default
14:17 degorenko and another one - just kind of refactoring
14:17 EmilienM degorenko: ok
14:17 degorenko nice :)
14:18 rahulait joined #puppet-openstack
14:18 openstackgerrit Emilien Macchi proposed openstack/puppet-openstack_spec_helper: Import spec_helper_acceptance.rb  https://review.openstack.org/267594
14:18 EmilienM degorenko: like this ^
14:18 * degorenko looking
14:19 degorenko oh, nice
14:19 degorenko we parsing project name from metadata.json
14:19 degorenko that's pretty much looks good to me
14:20 EmilienM yeah
14:20 EmilienM degorenko: same for rakefile iirc
14:20 degorenko yeah
14:20 degorenko you can add it in one patch i think
14:20 EmilienM yeah?
14:20 EmilienM ok
14:20 degorenko yeah
14:20 degorenko why not?
14:21 degorenko i just said that shouldn't be mixed with os_service_default
14:21 EmilienM no ok good for me
14:23 EmilienM let's start with rakefile & spec_helper_acceptance.rb
14:23 EmilienM that's good enough
14:23 degorenko yeah
14:23 openstackgerrit Emilien Macchi proposed openstack/puppet-openstack_spec_helper: Import common bits from modules  https://review.openstack.org/267594
14:24 degorenko paramite, hey, as i remember, you want switch our providers from ini_file to our own openstacklib openstackconfig, can you please take a look on few patches?
14:24 degorenko from this bug: https://launchpad.net/bugs/1483371
14:24 openstack Launchpad bug 1483371 in puppet-sahara "Add type/provider for paste configs" [Medium,In progress] - Assigned to Denis Egorenko (degorenko)
14:26 openstackgerrit Emilien Macchi proposed openstack/puppet-openstack_spec_helper: Import common bits from modules  https://review.openstack.org/267594
14:26 degorenko EmilienM, we also should to update module-sync repo as well :)
14:26 paramite degorenko, /me checking
14:26 EmilienM degorenko, crinkle: when it happens you have some time, please review https://review.openstack.org/#/c/267594/
14:26 EmilienM degorenko: yeah, next step, when we know it works :-)
14:28 degorenko i guess you can use any module, like aodh or whatever, remove files from project and add gem deps :)
14:28 EmilienM degorenko: to test? we can't actually test this change now, because Gems are not installed with zuul-cloner
14:29 paramite degorenko, actually I don't want to switch our providers from ini_file to openstacklib, just the ones that need to support multiple value. Those providers gonna use ini_file again, once the code currently sitting ino openstacklib will be moved to ini_file.
14:30 degorenko erm, i meant, that we can install with gem puppet-openstack_spec_helper like it done for os_service_default for aodh, than add some require for file - and run function
14:30 degorenko EmilienM, ^
14:31 paramite this was discussed on ml .., let me find the thread
14:31 degorenko so, we can wrap up our current files in some function and call it
14:31 degorenko paramite, oh, ok :)
14:31 EmilienM degorenko: that's the idea for rakefile & acceptance
14:32 EmilienM I would like to wait for crinkle online before continuing this work, she has great experience in that
14:33 degorenko sure, no problem :)
14:33 EmilienM ok aodh seems fixed in ubuntu https://bugs.launchpad.net/cloud​-archive/+bug/1533014/comments/8
14:33 openstack Launchpad bug 1533014 in Ubuntu Cloud Archive "aodh can't be installed" [High,Fix committed]
14:34 degorenko nice
14:34 openstackgerrit Emilien Macchi proposed openstack/puppet-openstack-integration: scenario001: enable Aodh on ubuntu platform  https://review.openstack.org/265061
14:35 openstackgerrit Emilien Macchi proposed openstack/puppet-openstack-integration: Test Mitaka on UCA & RDO  https://review.openstack.org/255635
14:36 paramite degorenko, http://lists.openstack.org/pipermail/o​penstack-dev/2015-December/081836.html
14:36 paramite degorenko, and regarding the bug ... how is this connected with the openstackconfig provider?
14:37 openstackgerrit Emilien Macchi proposed openstack/puppet-openstack-integration: Bump repos.pp to Mitaka on UCA & RDO  https://review.openstack.org/255635
14:37 degorenko paramite, i misunderstand probably :) and for your question: because i'm using now ini_file :)
14:38 paramite degorenko, :) ok
14:38 degorenko paramite, sorry for disturbing :)
14:38 paramite degorenko, np
14:40 dfisher joined #puppet-openstack
14:41 jistr joined #puppet-openstack
14:43 jaosorior joined #puppet-openstack
14:45 jaosorior joined #puppet-openstack
14:45 rochaporto joined #puppet-openstack
14:57 EmilienM richm, chem: just some highlight on https://review.openstack.org/#/c/267252/
14:58 chem EmilienM: ack
15:07 xarses joined #puppet-openstack
15:11 xingchao joined #puppet-openstack
15:17 dprince joined #puppet-openstack
15:18 xingchao_ joined #puppet-openstack
15:18 baker joined #puppet-openstack
15:26 magicboiz joined #puppet-openstack
15:30 angdraug joined #puppet-openstack
15:36 xingchao joined #puppet-openstack
15:42 mdorman joined #puppet-openstack
15:44 xarses joined #puppet-openstack
15:46 openstackgerrit Denis Egorenko proposed openstack/puppet-zaqar: Add rspec-puppet-facts to the spec_helper  https://review.openstack.org/264566
15:52 ducttape_ joined #puppet-openstack
15:52 openstackgerrit Denis Egorenko proposed openstack/puppet-heat: Add rspec-puppet-facts to the spec_helper  https://review.openstack.org/264545
15:54 openstackgerrit Denis Egorenko proposed openstack/puppet-keystone: Add rspec-puppet-facts to the spec_helper  https://review.openstack.org/264548
15:55 EmilienM degorenko: before pushing all patches
15:55 EmilienM degorenko: let's wait crinkle to review one of them and make sure we're on the right direction
15:55 degorenko it is same way as for aodh, but ok, let's wait crinkle
15:58 yottatsa joined #puppet-openstack
16:12 jfluhmann joined #puppet-openstack
16:17 jpena|mtg joined #puppet-openstack
16:29 ducttape_ joined #puppet-openstack
16:30 degorenko mfisch, are you around? :)
16:30 degorenko clayton, may be you?
16:32 francois joined #puppet-openstack
16:46 dprince joined #puppet-openstack
16:49 openstackgerrit Richard Megginson proposed openstack/puppet-keystone: Testing some keystone types alone fails  https://review.openstack.org/267699
16:51 dprince joined #puppet-openstack
16:53 degorenko crinkle, are you here? :)
16:54 crinkle degorenko: hi
16:54 crinkle how can i help
16:54 degorenko hi o/
16:54 openstackgerrit Xingchao Yu proposed openstack/puppet-keystone: (WIP) Update keystone::resource::authtoken  https://review.openstack.org/266723
16:55 EmilienM crinkle: can you review https://review.openstack.org/267594 please ?
16:55 degorenko btw, i'm also think about wrap up to function here: https://review.openstack.org/#/c/267594/
16:55 EmilienM and then, https://review.openstack.org/264566 for example
16:55 degorenko EmilienM, she already +2 :)
16:55 EmilienM oh I'm late..
16:55 degorenko crinkle, it's about os_service_default btw
16:56 degorenko we trying to use this: https://review.openstack.org/267185
16:58 degorenko EmilienM, looks like she is ok :)
16:59 degorenko then i'm going to update another patches
16:59 EmilienM degorenko: cool
17:00 EmilienM degorenko: I'll let you do all patches for this thing and I'll follow up later by the patches for rakefile and acceptance ok?
17:00 degorenko sure :)
17:00 degorenko EmilienM, did you saw crinkle comment here: https://review.openstack.org/267594 ? May be we can use function right now?
17:02 openstackgerrit Merged openstack/puppet-murano: Make Horizon DB sync optional  https://review.openstack.org/262011
17:03 EmilienM degorenko: I saw it, I agree
17:03 degorenko :)
17:04 EmilienM degorenko: I'm updating
17:04 degorenko ok
17:05 EmilienM degorenko: what do you think? in fact it's also good to let it as it is now
17:05 EmilienM I don't see why we need a function now, maybe I missed something
17:06 openstackgerrit Denis Egorenko proposed openstack/puppet-swift: Add rspec-puppet-facts to the spec_helper  https://review.openstack.org/264559
17:06 EmilienM degorenko: we will iterate later I think, let's try this way first
17:06 degorenko EmilienM, well, ok. I'm good with current solution.
17:07 EmilienM degorenko: I'll let you approve
17:07 degorenko EmilienM, done
17:07 openstackgerrit Merged openstack/puppet-openstack_spec_helper: Import common bits from modules  https://review.openstack.org/267594
17:07 EmilienM cool, I'll work on it after lunch /me afk
17:07 degorenko have a nice lunch :)
17:09 openstackgerrit Denis Egorenko proposed openstack/puppet-openstacklib: Add rspec-puppet-facts to the spec_helper  https://review.openstack.org/264555
17:12 openstackgerrit Denis Egorenko proposed openstack/puppet-tempest: Add rspec-puppet-facts to the spec_helper  https://review.openstack.org/264560
17:14 ntpttr joined #puppet-openstack
17:15 openstackgerrit Denis Egorenko proposed openstack/puppet-trove: Add rspec-puppet-facts to the spec_helper  https://review.openstack.org/264562
17:18 openstackgerrit Denis Egorenko proposed openstack/puppet-sahara: Add rspec-puppet-facts to the spec_helper  https://review.openstack.org/264558
17:19 jpena joined #puppet-openstack
17:20 samuelBartel joined #puppet-openstack
17:21 mfisch degorenko: here now
17:21 mfisch I slept super late
17:21 degorenko mfisch, no problem
17:21 mfisch EmilienM: do you know Julien Danjou's IRC nick?
17:21 openstackgerrit Denis Egorenko proposed openstack/puppet-neutron: Add rspec-puppet-facts to the spec_helper  https://review.openstack.org/264553
17:21 degorenko mfisch, so, do you want discuss something?
17:22 EmilienM mfisch: jd___
17:23 mfisch EmilienM: Thx
17:23 mfisch degorenko: nah, I did a +1 on your patch
17:23 degorenko yeah, i saw
17:23 mfisch and abandoned mine for the time being and you can pick it up
17:23 degorenko why you abandoned your patch?
17:24 degorenko i'm good with, but small refactoring ;)
17:24 degorenko i can update it
17:24 degorenko btw, did you prepared tests?
17:24 mfisch no thats one of the reasons I abandoned, I figured one of us could come back after the refactor
17:25 mfisch I've been doing lots of maintenance work this week so I was low on time
17:25 degorenko hm, i see
17:25 mfisch anyway I can come back to it next week if yours lands by then
17:25 degorenko ok :)
17:26 mfisch I should not reply to reviews when Im tired because I get cranky too
17:26 degorenko if i will have time, i will update your change
17:26 degorenko may be on weekend
17:26 mfisch the fetch_domain test can be removed
17:26 mfisch althought we can probably write 2 new tests
17:26 degorenko yeah
17:26 mfisch I didnt look at it very long
17:27 degorenko i will look
17:28 openstackgerrit Denis Egorenko proposed openstack/puppet-ironic: Add rspec-puppet-facts to the spec_helper  https://review.openstack.org/264547
17:32 openstackgerrit Denis Egorenko proposed openstack/puppet-ceilometer: Add rspec-puppet-facts to the spec_helper  https://review.openstack.org/264540
17:32 xingchao joined #puppet-openstack
17:40 openstackgerrit Denis Egorenko proposed openstack/puppet-modulesync-configs: Add rspec-puppet-facts to the spec_helper  https://review.openstack.org/264830
17:47 openstackgerrit Denis Egorenko proposed openstack/puppet-gnocchi: Add rspec-puppet-facts to the spec_helper  https://review.openstack.org/264544
17:50 openstackgerrit Denis Egorenko proposed openstack/puppet-vswitch: Add rspec-puppet-facts to the spec_helper  https://review.openstack.org/264565
17:55 openstackgerrit Denis Egorenko proposed openstack/puppet-horizon: Add rspec-puppet-facts to the spec_helper  https://review.openstack.org/264546
17:59 openstackgerrit Ryan Bak proposed openstack/puppet-monasca: Add support for symlinked agent virtualenv  https://review.openstack.org/265357
17:59 openstackgerrit Denis Egorenko proposed openstack/puppet-barbican: Use openstack spec helper for spec defaults  https://review.openstack.org/267741
18:01 openstackgerrit Denis Egorenko proposed openstack/puppet-nova: Use openstack spec helper for spec defaults  https://review.openstack.org/267745
18:04 openstackgerrit Denis Egorenko proposed openstack/puppet-glance: Use openstack spec helper for spec defaults  https://review.openstack.org/267750
18:06 openstackgerrit Denis Egorenko proposed openstack/puppet-openstack_extras: Use openstack spec helper for spec defaults  https://review.openstack.org/267752
18:08 openstackgerrit Denis Egorenko proposed openstack/puppet-cinder: Use openstack spec helper for spec defaults  https://review.openstack.org/267753
18:10 openstackgerrit Denis Egorenko proposed openstack/puppet-murano: Use openstack spec helper for spec defaults  https://review.openstack.org/267755
18:10 ccie6747 joined #puppet-openstack
18:11 openstackgerrit Denis Egorenko proposed openstack/puppet-rally: Use openstack spec helper for spec defaults  https://review.openstack.org/267756
18:13 openstackgerrit Denis Egorenko proposed openstack/puppet-tripleo: Update to pull in rspec-puppet-facts  https://review.openstack.org/264561
18:15 openstackgerrit Denis Egorenko proposed openstack/puppet-manila: Add rspec-puppet-facts to the spec_helper  https://review.openstack.org/264550
18:17 openstackgerrit Denis Egorenko proposed openstack/puppet-vitrage: Add rspec-puppet-facts to the spec_helper  https://review.openstack.org/264564
18:19 openstackgerrit Denis Egorenko proposed openstack/puppet-mistral: Add rspec-puppet-facts to the spec_helper  https://review.openstack.org/264551
18:21 openstackgerrit Denis Egorenko proposed openstack/puppet-designate: Add rspec-puppet-facts to the spec_helper  https://review.openstack.org/264542
18:21 EmilienM degorenko: ok, I'm about to start to patch puppet-sahara on top of your patch https://review.openstack.org/264566
18:21 degorenko EmilienM, which patch?
18:22 ntpttr joined #puppet-openstack
18:22 EmilienM degorenko: to replace rakefile & spec acceptance by the gem
18:22 degorenko ah
18:22 degorenko :)
18:23 openstackgerrit Denis Egorenko proposed openstack/puppet-magnum: Add rspec-puppet-facts to the spec_helper  https://review.openstack.org/264549
18:24 degorenko EmilienM, i'm done with updating: https://review.openstack.org/#/q/branch:ma​ster+topic:rspec-puppet-facts+status:open
18:24 EmilienM degorenko: I'll wait for CI run, and review it
18:25 degorenko sure
18:29 rahulait joined #puppet-openstack
18:30 openstackgerrit Emilien Macchi proposed openstack/puppet-sahara: Use puppet-openstack_spec_helper for Rakefile & spec_helper_acceptance  https://review.openstack.org/267763
18:30 EmilienM degorenko: ^  lset's see
18:33 xingchao joined #puppet-openstack
18:34 openstackgerrit Ade Lee proposed openstack/puppet-barbican: Add simple keystone acceptance test  https://review.openstack.org/263461
18:53 degorenko EmilienM, can you +A this one: https://review.openstack.org/266817
18:54 degorenko i'm off for today :) good night :)
18:54 ntpttr joined #puppet-openstack
18:55 EmilienM _degorenko|afk: thanks for your work! good night man
19:02 openstackgerrit Merged openstack/puppet-openstack-integration: Remove unneeded var aodh_enabled from aodh manifest  https://review.openstack.org/266817
19:04 openstackgerrit Emilien Macchi proposed openstack/puppet-openstack-integration: scenario001: enable Aodh on ubuntu platform  https://review.openstack.org/265061
19:05 openstackgerrit Emilien Macchi proposed openstack/puppet-openstack-integration: Bump repos.pp to Mitaka on UCA & RDO  https://review.openstack.org/255635
19:05 openstackgerrit Emilien Macchi proposed openstack/puppet-openstack-integration: Bump repos.pp to Mitaka on UCA & RDO  https://review.openstack.org/255635
19:05 mfisch EmilienM: is there a reason we dont have collectors for all _config options in the modules?
19:05 mfisch to enforce ordering on the service
19:05 EmilienM mfisch: can you be a bit more specific?
19:06 EmilienM like an example
19:06 mfisch yeah 1 sec
19:07 openstackgerrit Emilien Macchi proposed openstack/puppet-openstack-integration: Bump repos.pp to Mitaka on UCA & RDO  https://review.openstack.org/255635
19:07 openstackgerrit Emilien Macchi proposed openstack/puppet-openstack-integration: Bump repos.pp to Mitaka on UCA & RDO  https://review.openstack.org/255635
19:08 mfisch EmilienM: something like Nova_config<||> ~> Service['nova']
19:09 mfisch oh wait I see it now in nova
19:10 mfisch it was moved to a deps class
19:12 clayton the modules I've done hooks support for handle all config directives equally.
19:17 ntpttr left #puppet-openstack
19:19 aimon joined #puppet-openstack
19:19 mfisch clayton: cinder also has them, curious how I ended up with signing directories, maybe the package starts the service before the config is dropped
19:20 clayton that'd make sense, the ubuntu package are stupid that way
19:20 mfisch I wont worry about 3 folders
19:20 aimon_ joined #puppet-openstack
19:25 dhollinger joined #puppet-openstack
19:45 dhollinger joined #puppet-openstack
19:52 openstackgerrit Ryan Bak proposed openstack/puppet-monasca: Add support for symlinked agent virtualenv  https://review.openstack.org/265357
19:53 openstackgerrit Merged openstack/puppet-aodh: Update tests to leverage rspec-puppet-facts  https://review.openstack.org/266142
19:55 openstackgerrit Merged openstack/puppet-glance: Add memcached_servers parameter  https://review.openstack.org/266248
20:00 openstackgerrit Merged openstack/puppet-heat: Add rspec-puppet-facts to the spec_helper  https://review.openstack.org/264545
20:00 xarses joined #puppet-openstack
20:07 karimb joined #puppet-openstack
20:09 openstackgerrit Merged openstack/puppet-zaqar: Add rspec-puppet-facts to the spec_helper  https://review.openstack.org/264566
20:10 openstackgerrit Merged openstack/puppet-openstacklib: openstackconfig idempotency fix  https://review.openstack.org/265238
20:12 openstackgerrit Merged openstack/puppet-neutron: Add related parameters to ovs section  https://review.openstack.org/263528
20:17 openstackgerrit Merged openstack/puppet-nova: Add ensure_package for nova libvirt package  https://review.openstack.org/267533
20:18 openstackgerrit Merged openstack/puppet-openstacklib: Add rspec-puppet-facts to the spec_helper  https://review.openstack.org/264555
20:22 openstackgerrit Merged openstack/puppet-keystone: Add rspec-puppet-facts to the spec_helper  https://review.openstack.org/264548
20:26 openstackgerrit Merged openstack/puppet-keystone: Refactor of domain_name_from_id  https://review.openstack.org/267032
20:36 xingchao joined #puppet-openstack
20:40 radez joined #puppet-openstack
20:43 mwoodson joined #puppet-openstack
20:47 openstackgerrit Merged openstack/puppet-ironic: Add rspec-puppet-facts to the spec_helper  https://review.openstack.org/264547
20:49 morazi joined #puppet-openstack
20:49 zeus joined #puppet-openstack
20:51 openstackgerrit Merged openstack/puppet-barbican: Use openstack spec helper for spec defaults  https://review.openstack.org/267741
20:52 openstackgerrit Ryan Bak proposed openstack/puppet-monasca: Add support for symlinked agent virtualenv  https://review.openstack.org/265357
20:59 mfisch is anyone using an array of allowed_hosts in openstacklib?
20:59 mfisch mdorman maybe?
20:59 mfisch its not handling the array properly
20:59 mfisch Error: Failed to apply catalog: Parameter name failed on Mysql_user[keystone@["localhost", "10.10.32.24", "10.10.32.25"]]: Invalid database user keystone@["localhost", "10.10.32.24", "10.10.32.25"] at /etc/puppet/environments/production/modules/ope​nstacklib/manifests/db/mysql/host_access.pp:31
21:02 gfidente|afk joined #puppet-openstack
21:03 mfisch mgagne: you here?
21:04 mgagne yes
21:04 mfisch mgagne: you added code to openstacklib to allow allowed_hosts as an array, are you using that feature?
21:04 mfisch actually sorry you just redid the logic a bit
21:04 mgagne mfisch link?
21:05 mgagne mfisch yea to avoid a couple of tmp variables I think
21:05 mfisch yeah
21:05 mfisch when I try it as an array its doing a mysql_user { user@ARRAY rather than splitting it out it seems
21:06 mgagne original code was from Xingchao and optimized it IIRC
21:06 mgagne mfisch hmmm let me see if I can see what values I'm using
21:06 mdorman we don’t manage mysql with puppet, so i can’t speak to this.
21:06 mfisch yeah just let me know if you have an array mgagne
21:07 mgagne mfisch aren't there unit tests?
21:08 mgagne mfisch not an array :D
21:08 mfisch yep
21:08 mfisch see the same
21:09 mfisch once I figure this out I will fix that too
21:09 mfisch not only that the acceptance test uses the same default value as $host
21:10 mgagne mfisch could it be the result of nested array?
21:10 mfisch that would explain the behavior
21:10 mfisch Im passing in an array from hiera
21:11 mfisch the docs for cinder etc dont say what type it wants
21:11 mfisch but I think it gets passed through as an array
21:11 mgagne can you add a notify or something for real_allowed_hosts ?
21:11 mfisch hah I just did that
21:11 mfisch had to comment out eveyrthing else
21:11 mfisch let me see what I get
21:12 mfisch any2array should not mess with an array
21:12 mgagne yea
21:12 mfisch concat should also do the right thing
21:13 mfisch this is a new box so it will take some time to get my notify code out
21:13 mgagne but logic changed since split
21:13 mfisch split?
21:13 mgagne hmm
21:13 mgagne to openstacklib
21:13 mgagne hold on
21:13 mgagne I should read more
21:13 mfisch I didnt mean to rope you in I can keep digging if you are busy
21:14 mfisch does rake spec run acceptance tests?
21:14 mfisch if so they pass with an array
21:14 crinkle no, only unit tests
21:14 mgagne I'm not the one to ask :P
21:14 mfisch I never knew that
21:14 mfisch crinkle: how do I run acceptance?
21:14 crinkle mfisch: bundle exec rspec spec/acceptance
21:15 crinkle possibley rake acceptance works too
21:15 mfisch I bet they fail with an array, any takers?
21:15 mfisch ah I need all my vagrant stuff setup
21:15 crinkle yeah :/
21:16 mfisch will let zuul run it for me
21:16 crinkle if you have a libvirt and an image handy i use https://github.com/nibalizer/beaker-libvirt for running tests, works better than vagrant/virtualbox
21:18 openstackgerrit Matt Fischer proposed openstack/puppet-openstacklib: dont merge test for array in allowed-hosts  https://review.openstack.org/267818
21:18 mfisch crinkle: thanks
21:20 openstackgerrit Ryan Bak proposed openstack/puppet-monasca: Add support for symlinked agent virtualenv  https://review.openstack.org/265357
21:29 openstackgerrit Gael Chamoulaud proposed openstack/puppet-heat: Revise keystone/trusts config to avoid deprecated options  https://review.openstack.org/265865
21:30 zeus joined #puppet-openstack
21:37 xingchao joined #puppet-openstack
22:10 openstackgerrit Ryan Bak proposed openstack/puppet-monasca: Add support for symlinked agent virtualenv  https://review.openstack.org/265357
22:13 cwolferh joined #puppet-openstack
22:18 EmilienM mitaka is passing everywhere now: https://review.openstack.org/#/c/255635/
22:18 EmilienM only blocker is https://review.openstack.org/#q,I3a2e677c2bd349322cfb08d5dc73c1ced38c3f60,n,z now
22:23 karimb joined #puppet-openstack
22:29 EmilienM _ody: do you have an idea why beaker fails on this one ? https://review.openstack.org/#/c/267763/ we're trying to use the new gem
22:32 zeus joined #puppet-openstack
22:36 _ody I'll take a look...
22:36 EmilienM thanks!
22:37 EmilienM I'm out, I'll catch-up tomorrow
22:46 gildub joined #puppet-openstack
22:51 openstackgerrit Karim Boumedhel proposed openstack/puppet-designate: Set correct options path for bind9 agent Closes-Bug: #1534309  https://review.openstack.org/267856
22:51 openstack bug 1534309 in puppet-designate "wrong option file for redhat based systems and bind9 Edit" [Undecided,New] https://launchpad.net/bugs/1534309 - Assigned to Karim Boumedhel (karmab)
22:58 mdorman joined #puppet-openstack
23:04 mfisch mgagne: it is indeed a nested array
23:04 mgagne mfisch could it be a change in stdlib?
23:04 openstackgerrit Karim Boumedhel proposed openstack/puppet-designate: Set correct options path for bind9 agent Closes-Bug: #1534309t review -v  https://review.openstack.org/267856
23:04 openstack bug 1534309 in puppet-designate "wrong option file for redhat based systems and bind9 Edit" [Undecided,In progress] https://launchpad.net/bugs/1534309 - Assigned to Karim Boumedhel (karmab)
23:04 mfisch mgagne: I dont think so because I setup that same logic with foo and bar and it worked
23:05 mfisch weird
23:05 mfisch allowed_hosts is ok
23:07 mfisch allowed-hosts-list: powerdns [["%", "10.10.16.24", "10.10.16.25"], 127.0.0.1]
23:07 mfisch mgagne: its stdlib
23:07 mfisch maybe with future parser?
23:07 mgagne haven't tried future parser yet
23:09 nibalizer mfisch: if you use beaker libvirt let ne know
23:10 mfisch mgagne: https://gist.github.com/matthe​wfischer/f602ab901786417cbb8c
23:10 mfisch that shows it clearly
23:10 nibalizer i keeep meaning to polish it but ETIME
23:10 mfisch nibalizer: no I havent used it
23:11 mgagne mfisch can't we use the flatten() hammer to flatten that thing?
23:11 mfisch mgagne: sure but why is it happening?
23:11 mgagne mfisch I have no idea :D
23:11 mfisch yeah me either
23:12 mfisch oh I know why I bet
23:12 mfisch maybe its that $host is in p[
23:12 mfisch []
23:12 mgagne mfisch just suggesting to use a hammer to push back that unexpected mole into its hole
23:12 mfisch this will not repro: https://gist.github.com/matthe​wfischer/0b26700baf57d4df190d
23:12 mfisch mgagne: I will use that if nothing else
23:14 mgagne mfisch could any2array now create an array even if input is an array? or concat creating an array with inputs instead of merging them in one array?
23:15 mfisch that repro case I posted should have failed then
23:15 mfisch non-repro case as it is
23:15 mfisch more prints!
23:15 mgagne yea
23:16 mgagne so many nested functions we don't know which one is causing problem
23:16 mfisch splitting it out now
23:16 xarses joined #puppet-openstack
23:16 mgagne I don't have much tools to run test code now ^^'
23:17 mgagne wasn't it failing before or did you just try to use an array today?
23:17 mfisch the latter
23:17 mgagne right
23:17 mfisch I found a test too that uses an array
23:18 mfisch found it
23:18 mfisch its any2array
23:18 mgagne mfisch haven't changed in many years: https://github.com/puppetlabs/puppetlabs-stdlib/bl​ob/master/lib/puppet/parser/functions/any2array.rb
23:19 mgagne so it looks like it always behave like that
23:19 mgagne if there is more than 1 argument, array of arguments is returned
23:19 mfisch Arrays are left untouched.
23:19 mfisch from the docs
23:20 mgagne right so I don't know how it ever worked :-/
23:21 mfisch the most logic explaination is that I'm passing in a nested array
23:21 mfisch but thats not what my notify shows
23:22 openstackgerrit Karim Boumedhel proposed openstack/puppet-designate: Use actual service names for RH osfamily Closes-Bug: #1523781  https://review.openstack.org/267859
23:22 openstack bug 1523781 in puppet-designate "params class uses incorrect service names for RedHat osfamily" [Undecided,In progress] https://launchpad.net/bugs/1523781 - Assigned to Karim Boumedhel (karmab)
23:22 mfisch Notice: mfisch allowed-hosts: powerdns ["%", "10.10.16.24", "10.10.16.25"]
23:27 mdorman is there some verbose or debug flag i can use when running ‘bundle exec rake spec’ to run tests?  i’ve got one that’s failing and i can’t figure it out
23:28 mgagne already redirecting logs to console?
23:29 mgagne Puppet::Util::Log.level = :warning
23:29 mgagne Puppet::Util::Log.newdestination(:console)
23:29 mdorman unsure, heh.  here’s what i get:  https://gist.github.com/mist​erdorm/115327bf3bd67ddf2d9a
23:30 mgagne maybe you could put info or debug level instead and brace yourself
23:30 mdorman k
23:32 mgagne but then, I'm not sure what you are trying to debug, shouldn't the expected value be updated since it's cells?
23:33 mdorman yeah on that one i was testing a theory.  here’s the actual error i’m getting:  https://gist.github.com/mist​erdorm/212c984d933e4bb52746
23:33 mdorman it’s due to this line, where i have a regex:   https://gist.github.com/misterdorm/c77e​e64c9435e232053c#file-gistfile1-txt-L5
23:34 mdorman if i take that out and replace it with a simple == comparison, the test runs ok (still fails b/c of cells, but at least it runs.)
23:34 mdorman wonder if there’s something else i need to do to load the Regexp module for the test?   i donno.  ruby is kind of a mystery to me, and rspec even more :)
23:35 mdorman so trial-and-erroring here
23:36 mgagne =( been a long time since I wrote rspec tests =(
23:36 mdorman :)  thanks for looking in any case
23:37 mgagne I'm trying to update qemu :-/
23:37 mgagne had to ask #qemu on oftc because no one on nova replied =)
23:39 xingchao joined #puppet-openstack
23:42 mdorman fun times
23:43 ducttape_ joined #puppet-openstack
23:46 rahulait joined #puppet-openstack

| Channels | #puppet-openstack index | Today | | Search | Google Search | Plain-Text | summary