Perl 6 - the future is here, just unevenly distributed

IRC log for #puppet-openstack, 2016-01-15

| Channels | #puppet-openstack index | Today | | Search | Google Search | Plain-Text | summary

All times shown according to UTC.

Time Nick Message
00:04 zhangjn joined #puppet-openstack
00:04 zhangjn joined #puppet-openstack
00:09 openstackgerrit Mike Dorman proposed openstack/puppet-nova: Nova cells support for nova_aggregate provider  https://review.openstack.org/267866
00:17 zhangjn joined #puppet-openstack
00:17 xarses joined #puppet-openstack
00:17 petems joined #puppet-openstack
00:18 petems nibalizer: I’m here now :P
00:21 nibalizer petems: welcome
00:21 petems RE: the infra-as-code-but-for-Openstack-puppet-resources thing, I remember someone talking about making a Fog type and provider
00:22 petems then using it to implement openstack as a provider
00:22 petems bingo, easy servers
00:22 petems I dunno what became of that though...
00:40 xingchao joined #puppet-openstack
00:45 ccie6747 joined #puppet-openstack
00:53 zhangjn joined #puppet-openstack
01:02 zhangjn joined #puppet-openstack
01:30 ferest joined #puppet-openstack
01:36 zhangjn joined #puppet-openstack
01:38 xarses joined #puppet-openstack
01:41 xingchao joined #puppet-openstack
01:46 zhangjn joined #puppet-openstack
01:53 zhangjn joined #puppet-openstack
02:01 openstackgerrit Liao Penghui proposed openstack/puppet-ceilometer: Move workers options into specific sections.  https://review.openstack.org/266523
02:06 cwolferh joined #puppet-openstack
02:08 zhangjn joined #puppet-openstack
02:30 woon joined #puppet-openstack
02:34 xingchao joined #puppet-openstack
02:38 jfluhmann joined #puppet-openstack
02:47 ilbot3 joined #puppet-openstack
02:47 Topic for #puppet-openstack is now Puppet OpenStack modules - https://wiki.openstack.org/wiki/Puppet
02:53 xarses_ joined #puppet-openstack
02:56 andreww joined #puppet-openstack
03:15 openstackgerrit Xingchao Yu proposed openstack/puppet-keystone: Update keystone::resource::authtoken  https://review.openstack.org/266723
03:26 ferest joined #puppet-openstack
03:43 baker joined #puppet-openstack
03:57 ferest joined #puppet-openstack
04:17 zhangjn joined #puppet-openstack
04:35 zhangjn joined #puppet-openstack
04:51 ferest joined #puppet-openstack
05:19 jaosorior joined #puppet-openstack
05:35 zhangjn joined #puppet-openstack
05:37 zhangjn joined #puppet-openstack
05:38 openstackgerrit Marcus Furlong proposed openstack/puppet-neutron: update README to reflect new puppet-nova parameter  https://review.openstack.org/267943
05:39 zhangjn_ joined #puppet-openstack
05:41 zhangjn_ joined #puppet-openstack
05:43 openstackgerrit Juan Antonio Osorio Robles proposed openstack/puppet-tripleo: Enable X-Forwarded-Proto header for cinder  https://review.openstack.org/267945
05:43 openstackgerrit Juan Antonio Osorio Robles proposed openstack/puppet-tripleo: Enable X-Forwarded-Proto header for keystone admin endpoint  https://review.openstack.org/267946
05:43 zhangjn joined #puppet-openstack
05:47 zhangjn joined #puppet-openstack
05:51 ferest joined #puppet-openstack
06:44 ferest joined #puppet-openstack
06:45 xingchao joined #puppet-openstack
06:46 jaosorior joined #puppet-openstack
07:11 jaosorior joined #puppet-openstack
07:31 jtomasek joined #puppet-openstack
07:56 magicboiz joined #puppet-openstack
08:13 spredzy- joined #puppet-openstack
08:15 magicboiz joined #puppet-openstack
08:19 gfidente joined #puppet-openstack
08:19 gfidente joined #puppet-openstack
08:20 dgurtner joined #puppet-openstack
08:20 dgurtner joined #puppet-openstack
08:21 samuelBartel joined #puppet-openstack
08:26 ferest joined #puppet-openstack
08:29 dgurtner joined #puppet-openstack
08:29 dgurtner joined #puppet-openstack
08:34 jfluhmann joined #puppet-openstack
08:53 openstackgerrit Xingchao Yu proposed openstack/puppet-keystone: Refactor keystone::resource::authtoken  https://review.openstack.org/266723
09:04 zhangjn joined #puppet-openstack
09:27 jistr joined #puppet-openstack
09:36 gildub joined #puppet-openstack
09:44 openstackgerrit Xingchao Yu proposed openstack/puppet-nova: Change section name for memcached_servers param  https://review.openstack.org/266136
09:48 derekh joined #puppet-openstack
09:55 xingchao_ joined #puppet-openstack
09:56 paramite joined #puppet-openstack
10:01 xingchao joined #puppet-openstack
10:11 karimb joined #puppet-openstack
10:14 paramite joined #puppet-openstack
10:27 yolanda joined #puppet-openstack
10:28 yolanda hi, i'm trying to use puppet modules, and i have a problem in getting a self signed cert to work, can i get help?
10:28 yolanda i'm getting an openstack ssl error, complaining about the self signed cert
10:38 degorenko yolanda, hi, which module?
10:38 yolanda hi degorenko, i'm having problems with keystone
10:39 yolanda i'm using keystone::apache to setup the certs, and a ssl validation shows is ok, although self signed
10:39 yolanda when trying to setup the service i get
10:39 yolanda Error: Could not prefetch keystone_service provider 'openstack': Execution of '/usr/bin/openstack service list --quiet --format csv --long' returned 1: ERROR: openstack SSL exception connecting to https://controller00.hpuseast.ic​.openstack.org:35357/v3/services
10:41 degorenko yolanda, did you specified all ssl config path in puppet?
10:41 degorenko https://github.com/openstack/puppet-keystone/b​lob/master/manifests/wsgi/apache.pp#L142-L148
10:41 yolanda degorenko, yes. And i verified config in apache, and the paths are pointing to the right files
10:41 yolanda admin shows something like
10:41 yolanda
10:41 yolanda SSLEngine on
10:41 yolanda SSLCertificateFile "/etc/ssl/certs/controller00.hpuse​ast.ic.openstack.org-keystone.pem"
10:41 yolanda SSLCertificateKeyFile "/etc/ssl/private/controller00.hpus​east.ic.openstack.org-keystone.pem"
10:41 yolanda SSLCertificateChainFile "/etc/ssl/certs/controller00.hp​useast.ic.openstack.org-ca.pem"
10:42 yolanda SSLCACertificatePath "/etc/ssl/certs"
10:42 yolanda cert verification is fine as well
10:42 yolanda openssl verify -purpose sslserver -CAfile /etc/ssl/certs/controller00.hp​useast.ic.openstack.org-ca.pem /etc/ssl/certs/controller00.hpuse​ast.ic.openstack.org-keystone.pem
10:42 yolanda /etc/ssl/certs/controller00.hpusea​st.ic.openstack.org-keystone.pem: OK
10:43 degorenko and keystone is also has proper configuration?
10:44 yolanda degorenko, i just set enable_ssl => true, and service_name => httpd on keystone
10:45 yolanda degorenko, http://paste.openstack.org/show/483988/
10:48 degorenko yolanda, what's about these https://github.com/openstack/puppet-keysto​ne/blob/master/manifests/init.pp#L555-L558 and https://github.com/openstack/puppet-keysto​ne/blob/master/manifests/init.pp#L531-L536 parameters? Do you have proper keystone config ssl section?
10:48 degorenko yolanda, https://github.com/openstack/puppet-keysto​ne/blob/master/manifests/init.pp#L720-L728
10:48 openstackgerrit Merged openstack/puppet-ceilometer: Move workers options into specific sections.  https://review.openstack.org/266523
10:48 jgrassler joined #puppet-openstack
10:48 degorenko does this section contain your ssl certs?
10:48 yolanda degorenko, i thought this wasn't used, because we use apache to manage the ssl config
10:49 yolanda i can try to setup them
10:53 yolanda degorenko, same error
10:54 degorenko did you restarted apache/keystone?
10:54 yolanda yes
10:54 degorenko hm
10:55 jpena joined #puppet-openstack
10:56 degorenko yolanda, i will try to test in my env
10:56 yolanda thanks
10:58 degorenko mgagne, ping
11:07 chem xenolog-: he, do you have 2 min to discuss https://review.openstack.org/#/c/262809/
11:07 chem xenolog-: The Neutron parses the wrong json revert to shell/csv. business
11:08 yolanda derogenko, i made it work by tweaking puppet-openstacklib button, adding a --insecure flag. But this cannot be populated in parameters?
11:08 yolanda openstacklib module, i mean
11:21 openstackgerrit Merged openstack/puppet-neutron: LBaaSv2 support  https://review.openstack.org/234728
11:34 openstackgerrit Merged openstack/puppet-keystone: Testing some keystone types alone fails  https://review.openstack.org/267699
11:40 degorenko yolanda, no :)
11:40 degorenko my env is not ready yet, some another stuff
11:41 degorenko i will ping you back, when i test it
11:41 yolanda thanks derorenko
11:41 yolanda degorenko
11:41 degorenko yolanda, use tab :)
11:41 yolanda yep :)
12:11 dprince joined #puppet-openstack
12:13 openstackgerrit Merged openstack/puppet-horizon: Add List/None type value in the local_settings.  https://review.openstack.org/266814
12:35 cdelatte joined #puppet-openstack
12:46 EmilienM good morning
12:48 karimb joined #puppet-openstack
12:51 openstackgerrit joined #puppet-openstack
12:57 openstackgerrit Alexey Deryugin proposed openstack/puppet-openstack-integration: [WIP] scenario002: enable application catalog service  https://review.openstack.org/250436
12:58 skolekonov joined #puppet-openstack
13:04 degorenko morning :)
13:06 ducttape_ joined #puppet-openstack
13:11 EmilienM degorenko: my patch to refactor does not work for beaker jobs
13:11 degorenko EmilienM, i saw
13:12 degorenko looks like sahara repo wasn't clonned
13:12 EmilienM yeah!
13:12 EmilienM I'll investigate a bit more
13:18 paramite joined #puppet-openstack
13:26 ducttape_ joined #puppet-openstack
13:34 cdelatte joined #puppet-openstack
13:41 trown joined #puppet-openstack
13:41 openstackgerrit Liao Penghui proposed openstack/puppet-nova: Fix inconsistent type/provider for paste configs.  https://review.openstack.org/266692
13:44 morazi joined #puppet-openstack
13:54 baker joined #puppet-openstack
13:59 richm joined #puppet-openstack
14:00 ccie6747 joined #puppet-openstack
14:19 xingchao joined #puppet-openstack
14:22 openstackgerrit Liao Penghui proposed openstack/puppet-trove: Disable exists_notification_transformer for all OS  https://review.openstack.org/268157
14:24 openstackgerrit Liao Penghui proposed openstack/puppet-trove: Disable exists_notification_transformer for all OS  https://review.openstack.org/268157
14:29 openstackgerrit Liao Penghui proposed openstack/puppet-trove: Disable exists_notification_transformer for all OS  https://review.openstack.org/268157
14:35 openstackgerrit Xingchao Yu proposed openstack/puppet-keystone: Refactor keystone::resource::authtoken  https://review.openstack.org/266723
14:36 EmilienM degorenko: http://logs.openstack.org/63/267763/1/check/gat​e-puppet-sahara-puppet-beaker-rspec-dsvm-trusty​/cb9948b/console.html#_2016-01-14_23_02_52_096
14:36 EmilienM the module is installed :/
14:38 degorenko why then it was not found?
14:38 degorenko :(
14:46 jaosorior joined #puppet-openstack
14:54 ducttape_ joined #puppet-openstack
15:12 jaosorior joined #puppet-openstack
15:23 mfisch mgagne: clayton had a good idea last night he said that he thought my array had been stringified somewhere along the path
15:23 mfisch mgagne: I will try to confirm that today
15:31 rahulait joined #puppet-openstack
15:31 mfisch mgagne: thats it
15:33 derekh joined #puppet-openstack
15:35 baker joined #puppet-openstack
15:38 mfisch mgagne: found it
15:44 andreww joined #puppet-openstack
15:44 mfisch mgagne: let me know when you get in, you'll like it
15:51 clayton where was the stringify?
15:53 mfisch hiera()
15:54 mfisch " The result of the lookup must be a string;"
15:54 mfisch it has to be that
15:54 mfisch docs claim also " any other result will cause an error."
15:54 mfisch except it doesn't error, it just makes it a string for you
15:55 openstackgerrit Xingchao Yu proposed openstack/puppet-keystone: Refactor keystone::resource::authtoken  https://review.openstack.org/266723
15:57 dfisher joined #puppet-openstack
15:58 clayton were you doing an explicit lookup?
15:58 clayton I've not seen that happen for automatic lookup
15:58 mfisch there's 2 layers
15:58 mfisch its like this
15:58 mfisch allowed_hosts:
15:58 mfisch - a
15:58 mfisch - b
15:58 mfisch then cinder::foo::db::blah: hiera('allowed_hosts')
15:59 mfisch designate:: keystone::: etc etc
15:59 mfisch I have a fix
16:19 mdorman joined #puppet-openstack
16:22 xingchao_ joined #puppet-openstack
16:28 xingchao joined #puppet-openstack
16:29 angdraug joined #puppet-openstack
16:31 xingcha__ joined #puppet-openstack
16:31 ericksonsantos joined #puppet-openstack
16:38 zhangjn joined #puppet-openstack
16:51 openstackgerrit Juan Antonio Osorio Robles proposed openstack/puppet-tripleo: Add resources to set ssl middleware for Nova  https://review.openstack.org/268230
17:00 openstackgerrit Xingchao Yu proposed openstack/puppet-nova: Change section name for memcached_servers param  https://review.openstack.org/266136
17:01 openstackgerrit Xingchao Yu proposed openstack/puppet-glance: Introduce keystone::resource::authtoken  https://review.openstack.org/268233
17:04 xingchao joined #puppet-openstack
17:06 openstackgerrit Merged openstack/puppet-monasca: Add support for symlinked agent virtualenv  https://review.openstack.org/265357
17:07 dhollinger joined #puppet-openstack
17:09 openstackgerrit Juan Antonio Osorio Robles proposed openstack/puppet-tripleo: Add resources to set ssl middleware for Nova  https://review.openstack.org/268230
17:13 chem xenolog-: he, are you around ?
17:16 jpena joined #puppet-openstack
17:21 xingchao_ joined #puppet-openstack
17:25 openstackgerrit Juan Antonio Osorio Robles proposed openstack/puppet-tripleo: Add resources to set ssl middleware for Nova  https://review.openstack.org/268230
17:39 IvanBerezovskiy left #puppet-openstack
17:43 openstackgerrit Emilien Macchi proposed openstack/puppet-heat: Implement crontab to purge deleted data  https://review.openstack.org/268249
17:49 openstackgerrit Xingchao Yu proposed openstack/puppet-glance: Unify configuration of [keystone_authtoken] parameters  https://review.openstack.org/268233
17:57 ntpttr joined #puppet-openstack
17:58 openstackgerrit James Slagle proposed openstack/puppet-tripleo: Upgrade all packages after puppet managed ones  https://review.openstack.org/268257
18:05 ericksonsantos joined #puppet-openstack
18:11 dgurtner joined #puppet-openstack
18:11 dgurtner joined #puppet-openstack
18:12 openstackgerrit Xingchao Yu proposed openstack/puppet-keystone: Refactor keystone::resource::authtoken  https://review.openstack.org/266723
18:13 xingchao joined #puppet-openstack
18:21 EmilienM _ody: hey, about https://review.openstack.org/#/c/267763/ - yeah it seems sahara is not installed properly. Though if you look at my patch, I'm just using the gem now, and we did not change anything in there
18:22 EmilienM _ody: see https://github.com/openstack/puppet-openst​ack_spec_helper/blob/master/lib/puppet-ope​nstack_spec_helper/beaker_spec_helper.rb
18:38 _ody EmilienM: This line is confusing me too, http://logs.openstack.org/63/267763/1/check/gat​e-puppet-sahara-puppet-beaker-rspec-dsvm-centos​7/d244b06/console.html#_2016-01-14_22_27_53_259.
18:38 _ody I can't seem to find where or why sahara would be cloned to "lib" then needing to be moved.
18:39 EmilienM _ody: oh nice catch
18:39 _ody I assume it is https://github.com/openstack/puppet-opensta​ck_spec_helper/blob/master/lib/puppet-opens​tack_spec_helper/beaker_spec_helper.rb#L49
18:40 EmilienM yes
18:40 _ody That means the "proj_root" variable is for some reason parsing bad.
18:40 ericksonsantos joined #puppet-openstack
18:40 _ody ...or I guess a new beaker bug, maybe?
18:41 _ody puppet_module_install is a beaker helper as I reccall
18:42 skippy left #puppet-openstack
18:49 openstackgerrit Juan Antonio Osorio Robles proposed openstack/puppet-tripleo: Add resources to set ssl middleware for Nova  https://review.openstack.org/268230
18:54 openstackgerrit Ben Nemec proposed openstack/puppet-tripleo: Handle redirects for Horizon  https://review.openstack.org/268288
19:11 ducttape_ joined #puppet-openstack
19:13 ntpttr left #puppet-openstack
19:14 openstackgerrit Merged openstack/puppet-modulesync-configs: Add rspec-puppet-facts to the spec_helper  https://review.openstack.org/264830
19:15 xingchao joined #puppet-openstack
19:18 openstackgerrit Juan Antonio Osorio Robles proposed openstack/puppet-tripleo: Add resources to set ssl middleware for Nova  https://review.openstack.org/268230
19:26 EmilienM _ody: back from lunch, looking now
19:27 imcsk8 joined #puppet-openstack
19:27 EmilienM _ody: I think I got it
19:28 EmilienM _ody: proj_root is not the path we want
19:28 EmilienM it takes the new path in lib/
19:32 ericksonsantos joined #puppet-openstack
19:35 EmilienM _ody: I'm looking for another variable that would give the path of the module
19:36 EmilienM we're using File.expand_path(File.join(File.dirname(__FILE__), '..'))
19:41 EmilienM I'm preparing a pathc
19:42 rahulait joined #puppet-openstack
19:42 _ody EmilienM: I was comparing vs other modules and it looked like we had been using that variable for a while.
19:42 EmilienM _ody: we need to change https://github.com/openstack/puppet-opensta​ck_spec_helper/blob/master/lib/puppet-opens​tack_spec_helper/beaker_spec_helper.rb#L9
19:43 EmilienM _ody: because it's taking the path of the gem
19:43 EmilienM and we want to the module path
19:43 _ody Ah!
19:43 EmilienM _ody: it's funny because the metadata of the module can be found
19:43 _ody Because it is a gem now and not in the module.
19:43 EmilienM _ody: yeah
19:43 _ody Make sense now.
19:43 EmilienM _ody: but I don't want to hardcode the module path
19:44 EmilienM _ody: otherwise it will break people who do not run the same paths as our CI does
19:44 EmilienM _ody: can't we get the path from where we run the require?
19:44 * EmilienM is reading http://ruby-doc.org/core-2.1.1/​File.html#method-c-expand_path
19:45 _ody You can always brag CWD.
19:45 EmilienM _ody: the CWD seems like the in lib dir, in the gem, no?
19:46 _ody CWD should come from the runtime environment
19:46 _ody So which directory you are in when you run ruby
19:47 EmilienM _ody: should I use http://ruby-doc.org/core-2​.3.0/Dir.html#method-c-pwd ?
19:49 EmilienM _ody: like proj_root = File.expand_path(File.join(Dir.getwd , '..'))
19:50 EmilienM I tested it, it works
19:53 openstackgerrit Emilien Macchi proposed openstack/puppet-openstack_spec_helper: beaker_spec_helper: build proj_root from cwd  https://review.openstack.org/268312
19:53 EmilienM crinkle, _ody: maybe you can review when you have some time, thanks ^
19:53 openstackgerrit Emilien Macchi proposed openstack/puppet-openstack_spec_helper: beaker_spec_helper: build proj_root from cwd  https://review.openstack.org/268312
20:00 openstackgerrit Ethan Gafford proposed openstack/puppet-trove: Use identity_uri and auth_uri in api module  https://review.openstack.org/233229
20:05 aimon joined #puppet-openstack
20:06 aimon_ joined #puppet-openstack
20:17 openstackgerrit Ben Nemec proposed openstack/puppet-tripleo: Handle redirects for Horizon  https://review.openstack.org/268288
20:17 xingchao joined #puppet-openstack
20:17 nibalizer t
20:20 jfluhmann joined #puppet-openstack
20:36 ericksonsantos joined #puppet-openstack
20:46 _ody EmilienM: done.  That is what I had in mind.
20:46 EmilienM cool
20:47 * _ody is fighting issues with horizon under uwsgi and nginx
20:47 EmilienM nginx?
20:47 EmilienM never tried
20:47 _ody Yeah.  That is what we use here.
20:47 EmilienM it's good!
20:47 _ody It isn't working out so far but it is the last piece of our openstack deployment that is without puppet
20:48 _ody We have really old apache module we can't easily get rid of so using puppetlabs-apache is also difficult.
20:48 EmilienM _ody: feel fee to submit a patch in puppet-horizon, we already support apache ;-)
20:48 _ody When I figure it out...requires a uwsgi module I quickly threw together.
20:49 _ody I'll have to clean it up up publish it when it works
20:53 openstackgerrit Ade Lee proposed openstack/puppet-barbican: Add simple keystone acceptance test  https://review.openstack.org/263461
21:01 angdraug joined #puppet-openstack
21:14 _matthias_ joined #puppet-openstack
21:17 openstackgerrit Merged openstack/puppet-openstack_spec_helper: beaker_spec_helper: build proj_root from cwd  https://review.openstack.org/268312
21:18 xingchao joined #puppet-openstack
21:20 EmilienM let's recheck https://review.openstack.org/#/c/267763/ now
21:21 ccie6747 joined #puppet-openstack
21:57 openstackgerrit Mike Dorman proposed openstack/puppet-nova: Nova cells support for nova_aggregate provider  https://review.openstack.org/267866
21:59 cdelatte joined #puppet-openstack
22:00 cdelatte joined #puppet-openstack
22:01 openstackgerrit Emilien Macchi proposed openstack/puppet-heat: Implement crontab to purge deleted data  https://review.openstack.org/268249
22:18 xingchao joined #puppet-openstack
22:31 openstackgerrit Ade Lee proposed openstack/puppet-barbican: Add simple keystone acceptance test  https://review.openstack.org/263461
22:43 EmilienM I think I broke CI
22:43 EmilienM http://logs.openstack.org/49/268249/2/check/ga​te-puppet-heat-puppet-beaker-rspec-dsvm-trusty​/c1c7734/console.html#_2016-01-15_22_10_06_017
22:43 EmilienM on a Friday, nice
22:45 chem well you'll have all the week-end to fix, np :)
22:45 dmsimard EmilienM: ah so there's indeed a heat problem then ?
22:45 EmilienM dmsimard: no it's something else
22:45 EmilienM it's beaker jobs
22:45 EmilienM not integration
22:45 dmsimard oh, okay.
22:45 dmsimard I'll keep looking :p
22:45 EmilienM and beaker jobs are voting !
22:46 chem that's a strange module name gate-puppet-heat-puppet-beaker-rspec-dsvm-trusty
22:46 EmilienM yes...
22:46 chem an job env var put in the wrong place
22:46 EmilienM chem: https://github.com/openstack/puppet​-openstack_spec_helper/commit/8a5c3​e36de3b33f54811e88903527b311ccc04aa
22:46 EmilienM that's my fault
22:47 EmilienM we might want to drop the '..'
22:47 chem EmilienM: sorry, I don't know where to look ... ah oki
22:47 chem EmilienM: Ah !!! you did it again :)
22:49 chem EmilienM: just revert it.  You cannot know where the getwd (process directory) will be.
22:49 EmilienM in fact yes
22:49 chem EmilienM: you can ?
22:49 EmilienM when you run rspec, you're supposed to be in the root dir no?
22:49 EmilienM I mean, in theory...
22:50 chem not necessarily you can be further  down the hierarchy
22:50 EmilienM I know
22:50 EmilienM but I don't know how to deal with that in another way then
22:51 EmilienM actually, we could try to find the metadata.json
22:51 EmilienM and get the path from there
22:51 chem EmilienM: that's what we already doing no ?
22:51 EmilienM no
22:51 EmilienM modname = JSON.parse(open('metadata.json​').read)['name'].split('-')[1]
22:51 chem module_name = JSON.parse(File.read(File.join(module_root, 'metadata.json')))['name']
22:51 chem .sub(/^(?:[^-]+-)(.*)/, '\1')
22:51 chem
22:52 chem that's one of mine :)
22:52 EmilienM chem: where do you see the sub?
22:52 chem EmilienM: ?
22:52 EmilienM chem: where do you see this code?
22:53 chem EmilienM: sorry, it's local it seems ...
22:53 chem but your split is better ...
22:53 chem for module_root I use module_root = File.expand_path(File.join(File.dirname(__FILE__), '..'))
22:53 EmilienM chem: what do you suggest for proj_root ?
22:53 chem so that won't help
22:54 chem oki, let me think about the context ... you're a lib not in the module path anymore
22:54 chem ...
22:54 EmilienM proj_root = File.expand_path(File.join(Dir.getwd)) <--- that would work but not if you run beaker in spec dir for example
22:54 EmilienM chem: right
22:54 * chem thinking
22:54 baker joined #puppet-openstack
22:55 EmilienM oh dear I broke all CI
22:55 chem oki, yes just remove the '..' you'll be fine 99 of the time
22:55 EmilienM yeah
22:56 EmilienM add maybe a comment for doc
22:57 chem You can add a check for an existing Rakefile or metadata.json in the directory and exit with a nice error message if it's missing
22:57 chem but not all project have a metadata.json or a Rakefile ... (puppet-pacemaker someone ?)
22:57 EmilienM chem: puppet-pacemaker does not belong to us
22:57 chem in the checked project in openstack I think they all have them
22:57 EmilienM they do have
22:58 chem EmilienM: I know :)
22:58 chem so you add the check and the nice error message
22:58 chem so you can add the check and the nice error message
22:58 EmilienM ok
22:58 chem so know you cover 100% of the case \o/
22:59 openstackgerrit Mike Dorman proposed openstack/puppet-nova: Sort host_aggregate hosts list for comparison  https://review.openstack.org/268364
23:01 mdorman joined #puppet-openstack
23:04 EmilienM chem: patch coming
23:05 chem ack
23:06 openstackgerrit Emilien Macchi proposed openstack/puppet-openstack_spec_helper: beaker_spec_helper: fix module root path  https://review.openstack.org/268365
23:06 EmilienM chem: ^
23:07 EmilienM crinkle, _ody: this is outstanding, please look
23:15 openstackgerrit Emilien Macchi proposed openstack/puppet-openstack_spec_helper: beaker_spec_helper: fix module root path  https://review.openstack.org/268365
23:19 xingchao joined #puppet-openstack
23:32 EmilienM any core around, please review https://review.openstack.org/#/c/268365/ <-- this is outstanding
23:35 ducttape_ joined #puppet-openstack
23:49 openstackgerrit Merged openstack/puppet-openstack_spec_helper: beaker_spec_helper: fix module root path  https://review.openstack.org/268365
23:53 openstackgerrit Mike Dorman proposed openstack/puppet-nova: Allow metadata hash for nova_aggregate resources  https://review.openstack.org/268376
23:57 EmilienM it does not work
23:57 EmilienM mv /etc/puppet/modules/gate-puppet-saha​ra-puppet-beaker-rspec-dsvm-centos7 /etc/puppet/modules/sahara
23:58 EmilienM not sure that's what we want
23:58 EmilienM https://jenkins01.openstack.org/job/gate-puppet-s​ahara-puppet-beaker-rspec-dsvm-centos7/46/console
23:58 EmilienM oh it works actually
23:58 EmilienM chem: ^
23:59 chem EmilienM: great :)
23:59 EmilienM chem: thanks for your help and also to reviewers

| Channels | #puppet-openstack index | Today | | Search | Google Search | Plain-Text | summary