Perl 6 - the future is here, just unevenly distributed

IRC log for #puppet-openstack, 2016-04-06

| Channels | #puppet-openstack index | Today | | Search | Google Search | Plain-Text | summary

All times shown according to UTC.

Time Nick Message
00:10 _ody w00t!!!
00:10 _ody puppet4 is passing.
00:15 xarses joined #puppet-openstack
00:15 openstackgerrit Cody Herriges proposed openstack/puppet-keystone: Make the SSL apache module happens at correct time  https://review.openstack.org/301924
00:45 xarses joined #puppet-openstack
00:47 xarses joined #puppet-openstack
01:05 rmallah joined #puppet-openstack
01:38 ducttape_ joined #puppet-openstack
01:48 ilbot3 joined #puppet-openstack
01:48 Topic for #puppet-openstack is now CI status: GREEN - Puppet OpenStack modules - https://wiki.openstack.org/wiki/Puppet
01:56 _ducttape_ joined #puppet-openstack
01:57 johnmilton joined #puppet-openstack
02:12 xarses joined #puppet-openstack
02:26 baker joined #puppet-openstack
02:29 xingchao joined #puppet-openstack
02:39 baker joined #puppet-openstack
03:17 fedexo joined #puppet-openstack
03:28 baker joined #puppet-openstack
03:32 baker_ joined #puppet-openstack
04:05 chandankumar joined #puppet-openstack
04:26 markvoelker joined #puppet-openstack
04:55 jaosorior joined #puppet-openstack
05:27 xingchao joined #puppet-openstack
05:39 xarses joined #puppet-openstack
05:44 xarses_ joined #puppet-openstack
05:56 openstackgerrit Babu Shanmugam proposed openstack/puppet-neutron: Add support for OVN plugin  https://review.openstack.org/301613
05:59 rcernin joined #puppet-openstack
06:02 fawadkhaliq joined #puppet-openstack
06:06 openstackgerrit Babu Shanmugam proposed openstack/puppet-neutron: Add support for OVN plugin  https://review.openstack.org/301613
06:16 xingchao joined #puppet-openstack
06:23 openstackgerrit Babu Shanmugam proposed openstack/puppet-ovn: Added .gitreview for the puppet-ovn project  https://review.openstack.org/302044
06:24 openstackgerrit Babu Shanmugam proposed openstack/puppet-ovn: Revise OVN package names  https://review.openstack.org/301442
06:28 jmikolajczak joined #puppet-openstack
06:29 markvoelker joined #puppet-openstack
06:30 dgurtner joined #puppet-openstack
06:45 xingchao_ joined #puppet-openstack
07:03 openstackgerrit joined #puppet-openstack
07:07 jaosorior joined #puppet-openstack
07:09 rcernin joined #puppet-openstack
07:22 jaosorior joined #puppet-openstack
07:23 gfidente joined #puppet-openstack
07:33 karimb joined #puppet-openstack
07:42 amoralej joined #puppet-openstack
07:47 jaosorior joined #puppet-openstack
07:53 magicboiz joined #puppet-openstack
07:54 magicboiz left #puppet-openstack
08:02 openstackgerrit Babu Shanmugam proposed openstack/puppet-ovn: Added .gitreview for the puppet-ovn project  https://review.openstack.org/302044
08:04 openstackgerrit Babu Shanmugam proposed openstack/puppet-ovn: Revise OVN package names  https://review.openstack.org/301442
08:13 paramite joined #puppet-openstack
08:22 jistr joined #puppet-openstack
08:27 brad[] joined #puppet-openstack
08:30 markvoelker joined #puppet-openstack
08:35 openstackgerrit Aleksandr Didenko proposed openstack/puppet-cinder: Fix deprecation warnings about notification_driver  https://review.openstack.org/302094
08:38 hjensas joined #puppet-openstack
08:46 derekh joined #puppet-openstack
08:59 karimb joined #puppet-openstack
09:17 amoralej joined #puppet-openstack
09:21 chandankumar joined #puppet-openstack
09:23 chandankumar joined #puppet-openstack
09:27 chem joined #puppet-openstack
10:03 xingchao joined #puppet-openstack
10:19 chandankumar joined #puppet-openstack
10:20 openstackstatus NOTICE: npm lint jobs are failing due to a problem with npm registry. The problem is under investigation, and we will update once the issue is solved.
10:20 Topic for #puppet-openstack is now npm lint jobs are failing due to a problem with npm registry. The problem is under investigation, and we will update once the issue is solved.
10:31 amoralej joined #puppet-openstack
10:31 markvoelker joined #puppet-openstack
10:52 openstackgerrit Merged openstack/puppet-neutron: Use global_physnet_mtu to fix MTU settings in Mitaka  https://review.openstack.org/301531
11:07 karimb joined #puppet-openstack
11:12 xingchao joined #puppet-openstack
11:18 michchap joined #puppet-openstack
11:57 openstackgerrit Denis Egorenko proposed openstack/puppet-tempest: Update unit tests for tempest setter  https://review.openstack.org/302197
11:59 johnmilton joined #puppet-openstack
12:02 openstackgerrit Denis Egorenko proposed openstack/puppet-tempest: TEST DNM  https://review.openstack.org/302200
12:12 morazi joined #puppet-openstack
12:15 markvoelker joined #puppet-openstack
12:44 dprince joined #puppet-openstack
12:49 karimb joined #puppet-openstack
13:07 openstackgerrit Denis Egorenko proposed openstack/puppet-tempest: Update spec tests for Tempest  https://review.openstack.org/302197
13:13 degorenko we have broken unit tests for puppet-tempest
13:13 degorenko crinkle, mfisch hey guys, can you take a look on https://review.openstack.org/#/c/302197/
13:15 kgalanov joined #puppet-openstack
13:15 holser_ joined #puppet-openstack
13:22 pabelanger joined #puppet-openstack
13:23 pabelanger morning! We're migrating puppet jobs from devstack-centos7 to centos-7 this morning. So, expect to see some NOT_REGISTERED jobs in zuul until the migrate is complete.  I'll post again when rechecks can happen
13:24 pabelanger EmilienM: mwhahaha: ^
13:24 darkxploit joined #puppet-openstack
13:26 mwhahaha K thanks
13:28 baker joined #puppet-openstack
13:29 dprince joined #puppet-openstack
13:33 baker joined #puppet-openstack
13:40 vinsh joined #puppet-openstack
13:41 baker joined #puppet-openstack
13:55 openstackgerrit Dmitry Burmistrov proposed openstack/puppet-oslo: Update oslo::policy define  https://review.openstack.org/301079
13:55 openstackgerrit Dmitry Burmistrov proposed openstack/puppet-oslo: Process list values inside oslo module  https://review.openstack.org/302271
14:04 karimb joined #puppet-openstack
14:12 jaosorior joined #puppet-openstack
14:13 openstackgerrit Paul Belanger proposed openstack/puppet-cinder: Fix typo in README  https://review.openstack.org/302277
14:21 xarses_ joined #puppet-openstack
14:25 dhollinger joined #puppet-openstack
14:32 dgurtner joined #puppet-openstack
14:39 richm joined #puppet-openstack
14:48 chandankumar joined #puppet-openstack
14:50 mdorman joined #puppet-openstack
14:50 ducttape_ joined #puppet-openstack
14:52 iurygregory joined #puppet-openstack
15:20 baker joined #puppet-openstack
15:31 mjblack degorenko: so with regards to lbaas in puppet-neutron, I think lbaas has to change into a plugin model so its kind of like ml2.
15:32 dgurtner joined #puppet-openstack
15:32 dgurtner joined #puppet-openstack
15:34 haplo37 joined #puppet-openstack
15:34 degorenko mjblack, i'm not against moving to plugin, i need just properly to do it :)
15:34 degorenko s/i/you
15:35 mjblack oh I know but I'm looking at the documentation and its digging through it to see what the devs intended
15:35 mjblack the doc on the documentation site is wrong
15:35 mjblack ls
15:35 mjblack oops
15:36 degorenko may be have very old documentation
15:36 degorenko arh, we have
15:36 openstackgerrit Ade Lee proposed openstack/puppet-barbican: Added keystone config to barbican api manifest  https://review.openstack.org/263461
15:36 openstackgerrit Ade Lee proposed openstack/puppet-barbican: Added apache component Add test and mods for deployment as an apache module  https://review.openstack.org/263462
15:37 mjblack I dont know but the doc talks about using octavia and to set it up is not a simple add one line like it suggests
15:38 degorenko mjblack, can you give me a link, where you are looking for this?
15:38 mjblack http://docs.openstack.org/admin-gu​ide/networking_config-agents.html
15:39 degorenko oh, i thought that puppet wiki docs are outdated :D
15:39 mjblack https://github.com/openstack/neutron-lbaas/​blob/stable/liberty/etc/neutron_lbaas.conf
15:39 mjblack https://github.com/openstack/neutron-lbaas/​blob/stable/liberty/etc/services_lbaas.conf
15:39 dtantsur EmilienM, hi! sorry for missing the patch https://github.com/openstack/puppet-ironic/co​mmit/527917904019cea89d2568f14299714a7d0fec98, but is it something people can actually ship?
15:39 degorenko dtantsur, he is on PTO today :)
15:40 dtantsur degorenko, ok, may I ask you the same question when you're free? :)
15:40 degorenko dtantsur, wait please one-two minutes, i'm looking on mjblack links :D
15:41 mjblack degorenko: in short, my current patch is woefully inadequate for supporting lbaas v2
15:41 dtantsur no problem, just ping me please
15:42 degorenko mjblack, you're about these lines yes? http://docs.openstack.org/admin-gu​ide/networking_config-agents.html
15:42 degorenko oops
15:43 degorenko missed anchor
15:43 degorenko hm, that's not added to url, ok, section: Configure Load-Balancer-as-a-Service (LBaaS v2)
15:43 mjblack yeah
15:43 degorenko mjblack, ^ ?
15:43 degorenko oh, i see
15:43 mjblack configuring octavia isnt just popping in one line
15:43 degorenko agree
15:44 mjblack and going to a plugin model to support other lb types might be a better long term goal
15:44 degorenko mjblack, btw, why here is only lbaas v2? where is docs for lbaas v1?
15:44 mjblack lol good question
15:45 mjblack considering that horizon doesnt even support v2 yet
15:45 degorenko exactly lol
15:45 mjblack even the dashboard for it that you have to add in manually doesnt quite work yet
15:47 degorenko mjblack, take a look on this https://access.redhat.com/documentation/en-US/​Red_Hat_Enterprise_Linux_OpenStack_Platform/4/​html/Installation_and_Configuration_Guide/Conf​iguring_Load_Balancing_as_a_Service_LBaas.html
15:47 mjblack the thing that gets me is that the  lbaas drops a services_lbaas.conf that neither neutron-server or lbaasv2 agent read from
15:49 mjblack degorenko: the only problem with that doc is that I'm not sure what /usr/share/neutron/neutron-dist.conf is
15:49 mjblack that doesnt exist on ubuntu packaging
15:49 degorenko mjblack, that's just place for config file for rpms
15:50 mjblack ah ok
15:50 degorenko usually then all files will be moved to /etc/<project>
15:50 mjblack so I can just pop that into neutron.conf then
15:51 degorenko mjblack, now rpms also have all configs in same with ubuntu path
15:51 degorenko may be with some exceptions
15:51 degorenko dtantsur, hey, what's question do you have?
15:52 dtantsur degorenko,  https://github.com/openstack/puppet-ironic/co​mmit/527917904019cea89d2568f14299714a7d0fec98 concerns me. it brings binaries in the source tree, which is something all packagers will be angry about
15:52 dtantsur so it was done by our (RH) request, but I'm afraid we won't be able to ship it
15:52 dalees joined #puppet-openstack
15:52 dtantsur (and sorry for not tracking this patch before it merged)
15:52 mwhahaha pabelanger, looks like our syntax jobs are failing because of liberasecode-devel
15:53 openstackgerrit Mykyta Karpin proposed openstack/puppet-glance: Switch glance to os_service_default facts  https://review.openstack.org/299822
15:53 degorenko dtantsur, binaries are ipxe.efi and undionly.kpxe?
15:53 dtantsur yep
15:53 mjblack degorenko: yeah so what I'm going to do is go update my patch with a huge difference :D
15:53 pabelanger mwhahaha: yes, have a patch up to fix it.  It is because rdo-release is getting removed my JJB template
15:54 pabelanger mwhahaha: so, the fix is to call bindep first, then remove rdo-release
15:54 mwhahaha k
15:54 pabelanger also a python-requests issue that we are fixing too
15:54 pabelanger it is just about to merge and I'll rerun JJB
15:54 pabelanger https://review.openstack.org/#/c/302305/
15:54 degorenko dtantsur, so, and what's problem for packagers? they have same files in packages?
15:55 pabelanger https://review.openstack.org/#/c/302298/
15:55 pabelanger are 2 patches
15:55 mwhahaha thanks
15:55 mwhahaha degorenko: yea people get angry with binary stuff, go ask zigo :D
15:55 dtantsur degorenko, all packaging policy afaik bans having binaries in sources. everything should be built
15:55 degorenko yeah, looks like you're right :D
15:56 mwhahaha so we should probably revert that change then
15:56 degorenko or update
15:56 openstackgerrit Mykyta Karpin proposed openstack/puppet-glance: Switch glance to os_service_default facts  https://review.openstack.org/299822
15:56 degorenko with require
15:56 mgould joined #puppet-openstack
15:56 dtantsur the author is with us now ^^^
15:57 mwhahaha it'll need to get reworked completely so might as well back it out
15:57 mwhahaha i'm surpised zigo didn't notice it
15:57 degorenko mwhahaha, i guess he just started his work
15:58 degorenko for stable/mitaka
15:58 dtantsur it's not on mitaka
15:58 dtantsur iiuc
15:58 mwhahaha but i thought he packages the b1 version
15:58 degorenko oh, yeah
15:58 mwhahaha which would have had it
15:58 mwhahaha oh well
15:58 degorenko b1 don't have it
15:58 mwhahaha it didn't?
15:59 dtantsur so we're talking about newton, right?
15:59 mwhahaha oh yea it got merged on march 1
15:59 degorenko it was merged 8 days ago
15:59 mwhahaha it's in 8.0.0 tho
15:59 fedexo joined #puppet-openstack
16:00 degorenko mwhahaha, it is not
16:00 dtantsur I don't see it in mitaka: https://github.com/openstack/pup​pet-ironic/commits/stable/mitaka
16:00 mwhahaha stupid github interface
16:00 degorenko it's only in master
16:00 degorenko :D
16:00 mwhahaha well then back it out :D
16:01 degorenko dtantsur, you can revert it and update in proper way :)
16:01 dtantsur mgould, feel like doing it ^^^ or should I?
16:02 mgould I can do it
16:02 ducttape_ joined #puppet-openstack
16:02 dtantsur thanks a lot
16:02 degorenko mjblack, may be will be useful for you: https://wiki.openstack.org/wiki/​Neutron/LBaaS/DeployWithDevstack
16:03 dtantsur mgould, we probably should assume a user have the firmware somewhere. if they don't - fail gracefully. packagers will slowly catch up :)
16:05 mgould dtantsur, I just ran "yum install ipxe-bootimgs" on my CentOS box and there's no ipxe.efi in there
16:05 * dtantsur checks
16:06 dtantsur mgould, what's the usual location?
16:06 mgould dtantsur, /usr/share/ipxe
16:06 dtantsur mgould, for RHEL it's there. maybe CentOS will need some time to catch up
16:07 mgould dtantsur, OK, thanks
16:07 dtantsur anyway, as soon as people figure out they need it, they'll make their packagers package it :D
16:07 degorenko dtantsur, mgould you could ask in rdo channel then for missed files
16:08 dtantsur degorenko, it's part of the base system. so it should propagate to CentOS from RHEL eventually, if I understand the process right
16:08 * mgould does not understand the process
16:08 dtantsur it just appeared in RHEL (actually I might be talking about non-official package right now :D
16:09 degorenko dtantsur, well, i'm not sure too :)
16:10 dtantsur anyway, I hope RHEL and CentOS catch up during the newton time frame
16:10 mgould yep
16:10 degorenko dtantsur, ask RDO guys :D
16:11 degorenko they can answer you quickly
16:11 degorenko are you on rdo channel?
16:11 mgould dtantsur, could you mark the packaging bug as verified?
16:11 dtantsur degorenko, definitely. actually, I can be treated as one of "RDO guys", but I still don't get the process well
16:11 dtantsur will do, anyway! thanks folks
16:12 mjblack degorenko: oh yeah and you also have this too... http://docs.openstack.org/liberty/config-ref​erence/content/networking-plugin-lbaas.html
16:12 mjblack neutron-lbaas project config reference has one line example for octavia where as the liberty reference has a ton more
16:13 degorenko dtantsur, i also thought, that packages comes from RHEL to CentOS with some restrictions :D
16:13 degorenko mjblack, it's still for liberty :( for mitaka it is probably outdated
16:14 dtantsur degorenko, dunno about restrictions, I assume everything goes there. but I'm not the best source of information on this topic
16:14 degorenko then, looking for fix for puppet-ironic :)
16:15 karimb joined #puppet-openstack
16:16 mjblack degorenko: true but it just highlights that the current documentation isnt great :D
16:16 mgould mwhahaha, degorenko so my existing UEFI patch is going to be reverted?
16:17 degorenko mjblack, well, they missed lbaas v1, so, only this makes me mistrustful
16:17 degorenko :D
16:17 degorenko mgould, well, yes :)
16:18 mgould as opposed to rebased away, I mean
16:19 dtantsur mgould, just realized, that we didn't carry undionly.kpxe before, even though we did rely on it.. should we just assume users have ipxe.efi in /tftpboot and continue from that point?
16:20 dtantsur than leave getting the file up to the higher-level tool (tripleo, fuel, ...)
16:20 dtantsur some users might be fine with downloading it from internet, some might get it packaged
16:20 mgould dtantsur, undionly.kpxe is contained in OS packages that we install
16:20 dtantsur directly in /tftpboot?
16:20 dtantsur I thought it's shipped in /usr/share/something
16:21 mgould IIRC there's code to copy it from wherever the OS packages put it into tftpboot
16:21 dtantsur where is this code?
16:21 mgould not sure, looking now...
16:21 openstackgerrit Matthew J Black proposed openstack/puppet-neutron: Moved lbaasv2 from service to agent.  https://review.openstack.org/301797
16:21 dtantsur mgould, and here's the answer: https://github.com/openstack/instac​k-undercloud/blob/master/elements/i​pxe/post-install.d/88-setup-ipxe#L9
16:22 dtantsur so yes, it was up to tripleo to do that, I don't see why it should be any different for the UEFI file
16:22 dtantsur so my suggestion: revert this patch, apply patch that assumes the file is in place
16:22 dtantsur degorenko, mgould, wdyt ^^^?
16:23 dtantsur on the other hand, I'm not sure why this code is not in puppet...
16:23 dtantsur maybe because it assumes a specific packaging layout
16:24 mgould weird, I'm sure there was code somewhere to do that
16:24 mgould maybe I'm thinking of Bifrost?
16:25 openstackgerrit Matthew J Black proposed openstack/puppet-neutron: WIP lbaas v2 service plugin support.  https://review.openstack.org/301797
16:25 dtantsur mgould, see the link above
16:25 mjblack degorenko: ^^ can you take a quick look, thats the path I'm on for the change to lbaas
16:26 mgould yep: https://github.com/openstack/bifrost/b​lob/master/playbooks/roles/bifrost-iro​nic-install/tasks/create_tftpboot.yml
16:26 mgould OK, so: revert my patch, create a new one assuming the files are already in /tftpboot, add a copy command to instack-undercloud
16:27 degorenko dtantsur, well, we can check that files are present yes
16:27 openstackgerrit Miles Gould proposed openstack/puppet-ironic: Revert "Allow chainloading of Inspector ramdisk over UEFI"  https://review.openstack.org/302348
16:27 degorenko mjblack, ack, will look
16:27 dtantsur mgould, sounds good to me
16:28 zigo degorenko: mwhahaha: What package includes binaries?
16:28 dtantsur mgould, sorry for missing all this stuff on review :( I feel bad by dragging you into redoing your stuff
16:28 degorenko dtantsur, mgould we can use simply exec with bash command test
16:28 mwhahaha zigo: nothing yet, we were talking about puppet-ironic
16:28 dtantsur zigo, ALL OF THEM OH NOES... kidding, we nearly got it in puppet-ironic
16:28 degorenko zigo, we are going to fix that
16:28 mgould degorenko, sorry, I don't follow
16:28 zigo :)
16:28 jistr joined #puppet-openstack
16:29 zigo mwhahaha: dtantsur: degorenko: Do you guys know lintian? It's the package linter. It run on each package build, before I upload.
16:29 zigo It would complain about such blob, so I would see it...
16:29 dtantsur zigo, it's debian-only, right?
16:29 zigo Yup.
16:29 degorenko mgould, exec resource with command 'test -f <path to file>'
16:30 alee mwhahaha, how does one unset a value in the config file?  soemthing like barbican_api_paste_ini { 'foo': ensure => 'absent' } } ?
16:30 mwhahaha alee: yea
16:30 zigo BTW, I uploaded all of puppet-openstack tagged 8.0.0 to Debian unstable this morning (FYI).
16:30 mgould degorenko, ah, I see
16:30 alee mwhahaha, cool - modifying now ..
16:30 zigo Well, not all, but what we use in Fuel.
16:30 zigo (which is maybe most of it?)
16:30 degorenko mgould, something like that, may be you have some another ideas :)
16:31 dtantsur can't we check file existence from ruby(ish?) without using shell?
16:31 mgould I'd be astonished if there isn't a native way of checking file existence from Puppet
16:31 mgould but OTOH, Puppet keeps astonishing me
16:32 mwhahaha well puppet can use bash stuff
16:32 dtantsur http://serverfault.com/questions/25​8677/puppet-testing-if-a-file-exist ?
16:32 mwhahaha the onlyif takes shell command basically
16:32 mgould D:
16:32 mwhahaha so yea "test -f /something"
16:33 degorenko ^ ugly - but 100% works :D
16:33 dtantsur I'm referring to the first example in http://serverfault.com/a/258860
16:33 mwhahaha you have to remember that normally the catalog is compiled on a different server from the target
16:33 mwhahaha so doing it in ruby only works if you create a custom fact or something
16:33 mwhahaha which could expose if the files exist prior to running puppet
16:34 * dtantsur stopped understanding what's going on, so he relies on mwhahaha's advice
16:34 dprince joined #puppet-openstack
16:34 mwhahaha yea it gets complicated :D
16:35 degorenko and btw i don't see such attributes now in file resource https://docs.puppetlabs.com/puppe​t/latest/reference/type.html#file
16:35 degorenko i'm about noop and audit
16:35 degorenko also ensure => present will create file, if it not exists https://docs.puppetlabs.com/puppe​t/latest/reference/type.html#file
16:35 dtantsur okie-okie :)
16:35 degorenko ;D
16:36 mwhahaha yea the onlyif is usually part of exec but there are a few others that can do it
16:36 * mgould takes a step back
16:37 mgould so puppet-ironic should only be run *after* some other provisioning step?
16:37 mwhahaha like what?
16:37 mgould like whatever is expected to put ipxe.efi in /tftpboot
16:37 mwhahaha I guess the better question is what exactly are we trying to solve
16:38 mwhahaha so the question would be what provides these files
16:38 mwhahaha then we can figure out how to get them into /tftpboot via pupet
16:38 dtantsur mgould, that's what happens in tripleo. the "ipxe" element runs before the "puppet-stack-config" one. so files are there when we run puppet
16:38 degorenko dtantsur, mgould mwhahaha here is example for this: http://paste.openstack.org/show/493198/
16:38 degorenko it will fail if file is not exist
16:39 dtantsur thanks!
16:39 mgould yeah, I guess that's the best we can do
16:39 degorenko and there is no any magic words :)
16:39 openstackgerrit Miles Gould proposed openstack/puppet-ironic: Revert "Allow chainloading of Inspector ramdisk over UEFI"  https://review.openstack.org/302348
16:40 openstackgerrit Miles Gould proposed openstack/puppet-ironic: Revert "Allow chainloading of Inspector ramdisk over UEFI"  https://review.openstack.org/302348
16:41 * mgould notes that there was a whole discussion in his original commit message about including binaries :-)
16:43 openstackgerrit Denis Egorenko proposed openstack/puppet-tempest: Update spec tests for Tempest  https://review.openstack.org/302197
16:43 openstackgerrit Alex Schultz proposed openstack/puppet-gnocchi: Switch gnocchi to rspec-puppet-facts  https://review.openstack.org/298528
16:47 mgould degorenko, dtantsur if I put in a test for the existence of /tftpboot/ipxe.efi then it's going to fail CI, at least on CentOS
16:47 mgould wdyt?
16:47 ntaylor1781 joined #puppet-openstack
16:47 dtantsur mgould, maybe we need a flag to enable UEFI?
16:48 degorenko mgould, well, yes :D
16:48 degorenko +1
16:48 degorenko at least why centos doesn't have these files
16:48 degorenko s/why/until
16:48 * mgould nods
16:51 mgould OK, so my options are
16:51 mgould 1) don't test for their existence, get through CI, break in live when someone tries to deploy on CentOS
16:52 mgould 2) test for their existence, fail CI because the CI harness doesn't have a pre-install step that puts them in the right place
16:52 mgould 3) ???
16:53 degorenko 3) add a new flag for checking them :D
16:53 degorenko like: enable_uefi_checks
16:53 degorenko if yes - execute execs
16:53 degorenko if no - do nothing
16:53 mgould which is true by default, and false in CI?
16:53 mgould OK, that makes sense
16:53 degorenko yeah
16:54 dtantsur degorenko, mgould, I'd go as far as "enable_uefi" at all, if it's possible
16:54 degorenko mgould, probably you also need to patch this one
16:54 degorenko https://github.com/openstack/puppet-openstack​-integration/blob/master/manifests/ironic.pp
16:54 dtantsur I'm not sure what side effects we can get if we just enable it unconditionally
16:54 degorenko dtantsur, that's fine
16:54 degorenko mwhahaha, your thoughts? :) ^^^
16:55 mwhahaha yea we should add a flag
16:56 mwhahaha but to be honest this shows an issue with the installability of ironic
16:56 degorenko and it should be fixed on package side, yeah
16:56 mwhahaha relying on some magical step for this seems bad
16:57 degorenko we can do nothing at all
16:57 degorenko for puppet-ironic
16:57 degorenko and have some additional check on orchestration layer
16:58 * mgould thinks it would be better to specify all the dependencies in one place, rather than spreading them over multiple steps
16:59 degorenko i'm just sharing all my ideas
16:59 mwhahaha well i would think there should be some package for these files and then it's easily accomplished in puppet
16:59 mwhahaha it seems the sticking point is how do we get these files on the node to use
16:59 mgould yep
16:59 mwhahaha which is not a puppet problem :D
17:00 mgould well, it's a problem that can be solved with puppet, but not in a way that's acceptable :-)
17:00 * mwhahaha points at the packagers
17:00 mwhahaha egg, meet chicken!
17:01 degorenko mwhahaha, dtantsur said that for RHEL packages everything is ok
17:01 degorenko so, problem is only on CentOS side
17:01 mwhahaha how is it ok for rhel and not centos
17:01 mwhahaha :disapproval:
17:01 * degorenko doesn't know
17:02 mwhahaha well if we have a RHEL package we can throw it into params and just key off of it
17:02 mwhahaha and throw a warning or some shit
17:02 dfisher joined #puppet-openstack
17:02 degorenko :D
17:02 degorenko one more dirty way
17:02 dfisher _ody: ping
17:04 dfisher _ody: are there plans to get the 8.0.0 tarballs published on the forge?
17:05 * mgould looks up ERB syntax
17:06 mwhahaha pabelanger: how long does it take for the jjb updates to hit? since the gates are currently blocked :(
17:08 angdraug joined #puppet-openstack
17:09 dprince joined #puppet-openstack
17:12 degorenko mjblack, commented on your change
17:13 twm2016 joined #puppet-openstack
17:13 jtomasek joined #puppet-openstack
17:15 openstackgerrit Miles Gould proposed openstack/puppet-ironic: Allow chainloading of Inspector ramdisk over UEFI  https://review.openstack.org/302376
17:15 mgould ^^^ degorenko dtantsur mwhahaha
17:16 mwhahaha so is there a package that provides those files for RHEL?
17:16 mwhahaha if so we should probably get that added in
17:16 degorenko i guess it's already added
17:17 mgould mwhahaha, apparently
17:17 mwhahaha well i would argue it wasn't added if we were delivering the files via puppet :D
17:17 mgould or rather, when dtantsur runs `yum install ipxe-bootimgs` in RHEL (7.2?), he gets the file
17:18 mgould when I run that in CentOS 7.2, I don't
17:18 * dtantsur was out of internet, so he lost the context
17:18 mgould dtantsur, http://paste.openstack.org/show/493208/
17:18 mwhahaha dtantsur: was wondering what package delivers those files and if we should include that as soemthing that gets included by ironic
17:19 mwhahaha or should the ironic packages depend on it
17:19 mgould IIRC the corresponding Debian package installs them somewhere else
17:19 mwhahaha yea that's kinda what i keep asking about it because this seems like it should get added to something and then we'll need the file locations based on OS
17:20 dtantsur mwhahaha, I think it goes beyond what puppet should bother with
17:20 mwhahaha we do that all the time
17:20 mwhahaha we do it for the wsgi files
17:20 dtantsur also it's not any different with undionly.kpxe, which we assumed as granted for some time already
17:20 mwhahaha https://github.com/openstack/puppet-keys​tone/blob/master/manifests/params.pp#L13 and https://github.com/openstack/puppet-keys​tone/blob/master/manifests/params.pp#L34
17:21 * mgould thinks we shouldn't be taking the existence of files for granted
17:21 mwhahaha i'm just asking how we can make sure this is somewhat distro agnostic or at least implemented in a way that can be extended when other distros catch u
17:21 dtantsur we have to. we're not the packagers, we're configuration
17:21 mwhahaha catch up
17:22 dtantsur how do we *already* do it?
17:22 mgould or at least, we should make sure such assumptions are documented
17:22 dtantsur reminder: this problem did not change with the UEFI work
17:22 mgould dtantsur, true
17:23 mgould but "this works because some other piece of code in a different repo happened to have been called first" is fragile
17:24 ntaylor1781 So I am looking to contribute (never done it before). I have been looking over the documentation, but there is something I am still fuzy on. I want to add a purge config option to the various modules that don't already have it. I'm not sure if this will require a blueprint. I was hoping for advice.
17:24 mwhahaha ntaylor1781: we already have a mechanism for it, do you have an example of what you want to purge?
17:25 ntaylor1781 The glance module added it in liberty, in both the api and registry.pp's. Basically use the inifile's purge_config option to only include changes passed to the configs.
17:25 ntaylor1781 I didn't see it on the master branch in neutron at least.
17:26 mwhahaha let me see
17:27 basilAB joined #puppet-openstack
17:27 mwhahaha ntaylor1781: you  mean this, https://github.com/openstack/puppet-glance/co​mmit/c629376782efbc55bcf882543fa5801ddf5f1cfb
17:27 mgould instack-undercloud change to install the EFI bootloader: https://review.openstack.org/#/c/302379/
17:27 ntaylor1781 Yea that is what I was looking at.
17:28 mwhahaha ntaylor1781: you can just propose it to the modules
17:28 basilAB joined #puppet-openstack
17:28 mgould should I make that a dependency of #302376 ?
17:28 mwhahaha ntaylor1781: we aren't super strict about the blueprint stuff, if you'd like to do it then feel free
17:28 mwhahaha mgould: we can still copy the files
17:28 ntaylor1781 Ok sorry for my ignorance, how would I do that exactly? Would I create a branch, work on it, add my commits? Or is there a more proper way of doing this?
17:28 ntaylor1781 Also thanks for your input mwhahaha
17:29 degorenko ntaylor1781, we are using gerrit for this
17:29 ntaylor1781 Yea I have gerrit setup. Played in the sandbox, just still really new to this.
17:29 mgould mwhahaha, I'm totally in favour of doing "install rpm/deb; copy file into the right place" in puppet-ironic
17:30 degorenko you clone repo, do your changes, then git add <your files>, git commit -a, git review
17:30 degorenko ntaylor1781, ^
17:30 ntaylor1781 Ok perfect, thanks. I will get started then.
17:30 mwhahaha mgould: yea we can still do that
17:31 degorenko ntaylor1781, also you need to update tests under specs/classes directory for your file, for example for init.pp it will be spec/class/module_init_spec.rb
17:31 mwhahaha which is what i was refering to about adding the package/locations in
17:31 mwhahaha you can still use the file with a source
17:31 mwhahaha but you have to know where the source file is and you'd need to be able to ensure the package was installed
17:31 ntaylor1781 Thanks degorenko. I had started looking at the specs to get a feel for that.
17:31 mwhahaha since it's probably not an ironic package thats where it gets weird because we try and keep the extra deps down to a minimum
17:32 mgould mwhahaha, want me to add that to my patch?
17:32 mwhahaha yea
17:32 mgould OK
17:32 mgould with the understanding that it won't work on CentOS :-)
17:32 mwhahaha the better way is to update params with the like ipxe install locations for each distro, and if it's unavailable then skip the file copy and throw a warning or something
17:33 mwhahaha yea which is why i said leverage params where we can do the centos/RHEL check
17:33 mwhahaha so for RHEL it's /usr/share/ipxe or whatever and undef for centos
17:33 ayoung joined #puppet-openstack
17:34 mwhahaha then in the code if $ipxe_location == undef { warning('OMGWTFBBQ ixpe makes me sad') }
17:34 mwhahaha or $::ironic::params::ipxe_location or something
17:34 mwhahaha but you get the point
17:34 mgould and /usr/lib/ipxe for Debian, apparently
17:35 mgould I feel this should be a separate commit
17:35 mwhahaha separate from what?
17:36 mgould from the "add support for UEFI" commit
17:36 mgould because it's also changing the assumptions we're making about undionly.kpxe
17:37 mwhahaha well we're talking about the thing that is replacing the thing we're reverting
17:37 openstackgerrit Matthew J Black proposed openstack/puppet-neutron: WIP lbaas v2 service plugin support.  https://review.openstack.org/301797
17:37 mgould actually, wait
17:37 mwhahaha because we need to copy ipxe.efi and undionly.kpxe
17:38 mgould my existing replacement patch already has code to check for undionly.kpxe
17:38 mgould ...but it assumes it's already there
17:38 mjblack degorenko: the package was removed as it should go under the agent
17:38 mjblack its really there only for haproxy lbaas v2
17:39 degorenko mjblack, ok, got it
17:39 ayoung joined #puppet-openstack
17:39 mjblack degorenko: the question is though, is that format for the lbaas service plugin layout good?
17:39 mwhahaha mgould: so we're reverting https://review.openstack.org/#/c/302348/ and then in https://review.openstack.org/#/c/302376/ we should have this location stuff added in to copy the files and throw warnings
17:39 mgould OK, fine
17:39 mwhahaha and do the checks
17:40 mwhahaha if you do the checks we'll know if packagers screw up in an more easily consumable way
17:40 degorenko mjblack, well, probably we should move it under plugins
17:40 mgould yeah, fair enough
17:40 degorenko let's wait for more feedbacks
17:41 mgould though this does mean the patch won't pass CI until the CentOS package is updated
17:41 mjblack degorenko: I can move it, I didnt want to since the plugins seemed to be more network driver plugins than service plugins
17:42 degorenko mjblack, let's wait for ci and for feedbacks :)
17:42 mwhahaha mgould: not necessarily, if you wrap the file copy in a check for the location == undef it'll pass won't it?
17:42 mwhahaha we can just move this conversation to the review when you get it updated :)
17:42 mgould ah, good point
17:43 mjblack degorenko: lol ci is most certainly going to fail, not done with it
17:43 degorenko mjblack, because of some updates on infra side
17:43 * mgould generally finds that CI will fail with P=1 no matter what he does :-(
17:43 mjblack nah, the change is far from complete
17:44 mjblack I just wanted to get some feedback about the layout of the service plugins
17:49 mgould mwhahaha, puppet-n00b question: are the statements in a class definition executed in order?
17:49 mwhahaha maybe
17:49 mwhahaha :D
17:49 mgould ie, can I set a variable in one line and then use it in the next
17:49 mgould ?
17:49 mwhahaha that yea
17:49 mgould ffffffffuuuuuuuu
17:49 mgould OK
17:49 mwhahaha variable stuff is in order
17:49 mwhahaha resources might be executed in a different order
17:50 mwhahaha which is why i said maybe
17:51 dtantsur mgould, if implement copying files in puppet, we need to support also user-supplied ones
17:51 dtantsur I'd say these are 2 separate patches, yes
17:52 dtantsur 1. implement UEFI in the same way as BIOS is implemented (assuming files are there)
17:52 openstackgerrit Ade Lee proposed openstack/puppet-barbican: Added keystone config to barbican api manifest  https://review.openstack.org/263461
17:52 openstackgerrit Ade Lee proposed openstack/puppet-barbican: Added apache component Add test and mods for deployment as an apache module  https://review.openstack.org/263462
17:52 dtantsur 2. support copying both files from packages
17:52 dtantsur mgould, mwhahaha ^^^
17:52 mgould ^^^ what dtantsur said
17:52 alee mwhahaha, _degorenko|afk ^^ should address your comments
17:52 mwhahaha busy day today
17:53 mwhahaha so i didn't say anything abotu user supplied ones
17:53 mwhahaha for me your 1 and 2 are 1
17:53 mwhahaha and custom files would eb a 2
17:53 dfisher1 joined #puppet-openstack
17:53 mwhahaha we already have an established pattern for such things as i pointed to the wsgi.py stuff
17:53 mwhahaha where based on the distro we will copy them to the correct location
17:54 mgould on the grounds that (1) it's late here, (2) I'm tired and fed up, (3) it's much easier to merge patches than split them, I'll do it as multiple patches and we can argue about it in the comments
17:55 mwhahaha sure
17:55 mgould cool
17:55 mwhahaha i just see multiple patching being more trouble than it's worth here but maybe it's just me
17:56 mwhahaha so propose and we shall review :)
17:56 mgould cool, will do
17:56 mwhahaha lunch time
17:56 * mwhahaha wanders off
18:05 shaikapsar joined #puppet-openstack
18:12 openstackgerrit Miles Gould proposed openstack/puppet-ironic: Copy iPXE ROMs into /tftpboot  https://review.openstack.org/302390
18:12 mgould ^^^ mwhahaha _degorenko|afk dtantsur|afk
18:13 openstackgerrit Alex Schultz proposed openstack/puppet-glance: Release notes for glance_image updates  https://review.openstack.org/302391
18:13 mgould doesn't support user-supplied ROMs in some other directory, doesn't install the necessary packages
18:13 mwhahaha sure i'll comment
18:14 mgould thanks!
18:14 mgould but right now I'm going home, because it's dinnertime
18:14 mgould good night!
18:16 ducttape_ joined #puppet-openstack
18:17 mwhahaha yup later
18:19 mgould ffs, my revert patch failed CI
18:19 mgould question: which of the following is true?
18:19 mgould 1) our CI is incredibly flaky
18:19 mgould 2) I am incredibly unlucky
18:19 mgould 3) I am doing something very wrong
18:20 mgould the error here is that liberasurecode-devel failed to install, FWIW
18:23 * mwhahaha blames pabelanger
18:23 mwhahaha it's not you
18:23 mwhahaha 4) openstack-infra switch out the centos7 image and broke it all
18:24 mgould aha
18:24 mgould trouble is, there *always* seems to be something like that happening :-(
18:24 mwhahaha yes
18:25 mwhahaha people like to change stuff for some silly reason
18:25 mwhahaha bugs, features, sun flares
18:26 openstackgerrit Ethan Gafford proposed openstack/puppet-trove: Adding trove db sync  https://review.openstack.org/278105
18:27 mgould mwhahaha, craziness
18:28 mwhahaha pretty much
18:28 openstackgerrit Miles Gould proposed openstack/puppet-ironic: Copy iPXE ROMs into /tftpboot  https://review.openstack.org/302390
18:29 ayoung joined #puppet-openstack
18:31 mgould and now I really am going home
18:31 mgould good night!
18:41 openstackgerrit Cody Herriges proposed openstack/puppet-swift: Keystone endpoints should go before the service  https://review.openstack.org/301971
18:44 alee mwhahaha, _degorenko|afk - so I'm guessing ci is broken today?
18:45 mwhahaha yea
18:45 alee sigh ..
18:53 angdraug joined #puppet-openstack
19:09 openstackgerrit Nathan Taylor proposed openstack/puppet-neutron: Set the ini/openstackconfig libs to pass file_path properly.  https://review.openstack.org/302408
19:11 ntaylor1781 If anyone would like to review that I would appreciate it. That is backend work that is needed for a purge_config option to work. I figured I would do a second review for the frontend changes that add the purge_config option.
19:16 ayoung joined #puppet-openstack
19:32 ducttape_ joined #puppet-openstack
19:35 bookwar alee, mwhahaha: should work already, just delayed with a queue to process
19:35 mwhahaha bookwar: no we're talking about upstream tests
19:35 mwhahaha they are broken
19:35 mwhahaha they switched the centos7 image and it's unhappy so the syntax jobs are currently failing
19:35 bookwar mwhahaha: sorry, reacted on trigger :)
19:35 mwhahaha for once, not you ;)
19:36 pabelanger fix is pending, once puppet starts running again on jenkins
19:55 openstackgerrit Dan Prince proposed openstack/puppet-tripleo: Add Glance profiles  https://review.openstack.org/296076
20:09 rcernin joined #puppet-openstack
20:46 amoralej joined #puppet-openstack
20:47 dgurtner joined #puppet-openstack
20:50 openstackgerrit Nathan Taylor proposed openstack/puppet-neutron: Set the ini/openstackconfig libs to pass file_path properly  https://review.openstack.org/302408
20:55 openstackgerrit Nathan Taylor proposed openstack/puppet-neutron: Set ini/openstack libs to pass file_path properly  https://review.openstack.org/302408
20:59 ntaylor1781 Sorry for the spam, fixing commit message and title.
21:08 pabelanger mwhahaha: EmilienM: puppet-jobs happy again: https://review.openstack.org/#/c/302277/
21:08 pabelanger give it another few minutes before you start rechecking
21:09 pabelanger because jenkins02 and jenkin04 are still running JJB
21:09 mwhahaha k
21:12 pabelanger okay, jenkins02 done
21:13 pabelanger if you see any failures on jenkins04, you might need to recheck
21:13 pabelanger I'd put in into shutdown mode, but were working on fixing a nodepool issue
21:14 openstackgerrit Athlan-Guyot sofer proposed openstack/puppet-openstacklib: Add the possibility to execute without retry.  https://review.openstack.org/302442
21:15 openstackgerrit Nathan Taylor proposed openstack/puppet-neutron: Set ini/openstack libs to pass file_path properly  https://review.openstack.org/302408
21:30 openstackgerrit Athlan-Guyot sofer proposed openstack/puppet-keystone: WIP: Remove user/role prefetch to support multi-domain.  https://review.openstack.org/299301
21:33 twm2016 joined #puppet-openstack
21:37 amoralej joined #puppet-openstack
21:54 openstackgerrit Athlan-Guyot sofer proposed openstack/puppet-keystone: WIP: multi-domain testing with ldap backend.  https://review.openstack.org/296370
21:55 openstackgerrit Athlan-Guyot sofer proposed openstack/puppet-keystone: WIP: multi-domain testing with ldap backend.  https://review.openstack.org/296370
21:56 openstackgerrit Nathan Taylor proposed openstack/puppet-neutron: Set ini/openstack libs to pass file_path properly  https://review.openstack.org/302408
22:12 ntaylor1781 joined #puppet-openstack
22:18 social joined #puppet-openstack
22:33 exedore6 joined #puppet-openstack
22:36 dgurtner joined #puppet-openstack
22:54 openstackgerrit Alex Schultz proposed openstack/puppet-glance: Implement ability to pass CA bundle certificate for vCenter server  https://review.openstack.org/302461
22:55 exedore6 joined #puppet-openstack
23:01 beddari joined #puppet-openstack
23:09 ayoung joined #puppet-openstack
23:09 openstackgerrit Merged openstack/puppet-neutron: Add ml2 package requirement to neutron::plugins::ml2::mech_driver  https://review.openstack.org/301142
23:36 Matum joined #puppet-openstack
23:44 baker joined #puppet-openstack

| Channels | #puppet-openstack index | Today | | Search | Google Search | Plain-Text | summary