Perl 6 - the future is here, just unevenly distributed

IRC log for #puppet-openstack, 2016-10-20

| Channels | #puppet-openstack index | Today | | Search | Google Search | Plain-Text | summary

All times shown according to UTC.

Time Nick Message
00:16 ducttape_ joined #puppet-openstack
00:31 agrebennikov_ joined #puppet-openstack
00:33 dmsimard mwhahaha: I THINK THIS IS DEPRECATED http://logs.openstack.org/89/388589/1/g​ate/gate-puppet-openstack-integration-4​-scenario001-tempest-centos-7/fc2567b/c​onsole.html#_2016-10-19_22_24_58_032854
00:39 mwhahaha dmsimard: OK? :D it's not related to this failure but yea we need to fix that
00:44 ducttape_ joined #puppet-openstack
00:47 xarses joined #puppet-openstack
02:06 michapma_alt joined #puppet-openstack
02:11 openstackgerrit Steve Baker proposed openstack/puppet-tripleo: Use HAProxy for docker-registry endpoint  https://review.openstack.org/388963
02:33 cgfbee joined #puppet-openstack
02:54 ducttape_ joined #puppet-openstack
02:54 openstackgerrit Xingchao Yu proposed openstack/puppet-cloudkitty: This is the initial commit for puppet-cloudkitty.  https://review.openstack.org/387149
03:21 rpittau joined #puppet-openstack
04:04 richm1 joined #puppet-openstack
04:15 ducttape_ joined #puppet-openstack
05:09 jaosorior joined #puppet-openstack
05:15 ducttape_ joined #puppet-openstack
05:15 openstackgerrit Juan Antonio Osorio Robles proposed openstack/puppet-openstacklib: Add tls options to mysql user creation  https://review.openstack.org/387880
05:18 skramaja joined #puppet-openstack
05:30 markvoelker_ joined #puppet-openstack
05:33 rpittau joined #puppet-openstack
07:02 imcsk8_PTO joined #puppet-openstack
07:05 dgurtner joined #puppet-openstack
07:05 dgurtner joined #puppet-openstack
07:10 fxpester joined #puppet-openstack
07:11 tesseract joined #puppet-openstack
07:17 ducttape_ joined #puppet-openstack
07:42 danpawlik joined #puppet-openstack
07:48 exed_ joined #puppet-openstack
07:48 rmart04 joined #puppet-openstack
07:49 openstackgerrit Alfredo Moralejo proposed openstack/puppet-neutron: Fix domain_id in server manifest  https://review.openstack.org/389047
07:50 exed_ left #puppet-openstack
08:04 jpich joined #puppet-openstack
08:08 paramite joined #puppet-openstack
08:16 hjensas joined #puppet-openstack
08:16 hjensas joined #puppet-openstack
08:18 ducttape_ joined #puppet-openstack
08:19 markvoelker joined #puppet-openstack
08:32 rpittau joined #puppet-openstack
08:40 hjensas joined #puppet-openstack
08:40 hjensas joined #puppet-openstack
08:46 derekh joined #puppet-openstack
09:19 ducttape_ joined #puppet-openstack
09:20 social joined #puppet-openstack
09:21 jtomasek_ joined #puppet-openstack
09:32 hjensas joined #puppet-openstack
09:32 hjensas joined #puppet-openstack
09:41 exed_ joined #puppet-openstack
09:44 colonwq joined #puppet-openstack
09:44 jaosorior joined #puppet-openstack
09:47 derekh joined #puppet-openstack
09:57 ddmitriev joined #puppet-openstack
10:16 b00tcat joined #puppet-openstack
10:17 b00tcat hi, quick question: what's the format of this parameter in puppet-tripleo? https://github.com/openstack/puppet-tripl​eo/blob/master/manifests/haproxy.pp#L427
10:17 b00tcat it says "Filename of an HAProxy-compatible certificate and key file", does this mean the file contains the two things?
10:20 ducttape_ joined #puppet-openstack
10:24 jaosorior b00tcat: yep
10:25 jaosorior b00tcat: that's the way haproxy reads it :/
10:25 jaosorior pretty weird, but it's the way it is
10:26 Kvisle first proposal-question; my proposal now has 5 points on code, 1 point on verified, but it needs workflow ... is there anything I need to do, or will it eventually be merged at this point? https://review.openstack.org/#/c/387263/
10:27 b00tcat thanks jaosorior
10:34 derekh joined #puppet-openstack
10:37 markvoelker joined #puppet-openstack
10:58 dprince joined #puppet-openstack
11:07 markvoelker_ joined #puppet-openstack
11:18 EmilienM I'm failing to see where scenarios are failing
11:18 EmilienM well, it sounds like they are passing now
11:19 EmilienM degorenko: I saw your recheck :)
11:20 degorenko EmilienM, so, if i see failed jobs - i can recheck right?
11:20 ducttape_ joined #puppet-openstack
11:21 EmilienM degorenko: I don't know, I just read backlog and saw conversation between dmsimard and mwhahaha
11:21 degorenko yeah, i see
11:21 degorenko hm
11:22 EmilienM well, I saw some jobs running now, so let's see :)
11:25 gfidente joined #puppet-openstack
11:25 degorenko yeah
11:36 davideagle_ joined #puppet-openstack
11:51 openstackgerrit Merged openstack/puppet-gnocchi: Release 9.4.1 (newton)  https://review.openstack.org/388520
11:56 bogdando joined #puppet-openstack
12:06 johnmilton joined #puppet-openstack
12:07 iurygregory good morning
12:10 ducttape_ joined #puppet-openstack
12:11 iurygregory EmilienM, did you recived the mascot logo?
12:12 markvoelker joined #puppet-openstack
12:27 fultonj joined #puppet-openstack
12:37 openstackgerrit Merged openstack/puppet-ironic: Release 9.4.1 (newton)  https://review.openstack.org/388522
12:41 richm joined #puppet-openstack
12:44 ducttape_ joined #puppet-openstack
12:46 openstackgerrit Emilien Macchi proposed openstack/puppet-ironic: Release 9.4.1 (newton)  https://review.openstack.org/389168
12:46 EmilienM backport ^
12:46 iurygregory +2
12:47 openstackgerrit Dmitry Tantsur proposed openstack/puppet-ironic: [WIP] Remove "dhcp" command from the iPXE script  https://review.openstack.org/389169
12:53 rcernin joined #puppet-openstack
13:00 openstackgerrit Dan Prince proposed openstack/puppet-tripleo: Set memcached_servers for nova API  https://review.openstack.org/389176
13:05 morazi joined #puppet-openstack
13:08 mkoderer joined #puppet-openstack
13:09 derekh joined #puppet-openstack
13:09 davideagle_ joined #puppet-openstack
13:10 richm1 joined #puppet-openstack
13:25 morazi joined #puppet-openstack
13:26 ducttape_ joined #puppet-openstack
13:27 jtriley joined #puppet-openstack
13:38 dgurtner joined #puppet-openstack
13:38 dgurtner joined #puppet-openstack
14:06 ducttape_ joined #puppet-openstack
14:16 mwhahaha hey it looks like infra fixed the test problems, yay
14:17 agrebennikov_ joined #puppet-openstack
14:17 dmsimard mwhahaha: so it was not our fault ?
14:17 iurygregory \o/
14:17 dmsimard mwhahaha: also re last night: I know the deprecations are not related to the issue
14:17 dmsimard mwhahaha: they just started happening recently so I thought I'd highlight them :p
14:17 mwhahaha yea it wasn't our fault, ansible was erroring
14:18 iurygregory ansible...
14:18 iurygregory =P
14:18 mwhahaha dmsimard: yea i saw those yesterday, i'll take a look today if i get time
14:20 openstackgerrit Merged openstack/puppet-ironic: Release 9.4.1 (newton)  https://review.openstack.org/389168
14:30 xarses joined #puppet-openstack
14:30 cgfbee joined #puppet-openstack
14:36 bogdando joined #puppet-openstack
14:38 ducttape_ joined #puppet-openstack
14:54 davideagle joined #puppet-openstack
15:19 social joined #puppet-openstack
15:21 ducttape_ joined #puppet-openstack
15:28 _ducttape_ joined #puppet-openstack
15:34 openstackgerrit Merged openstack/puppet-tripleo: Fixes missing ODL ML2 Authentication info  https://review.openstack.org/386820
15:35 sbadia joined #puppet-openstack
15:39 priteau joined #puppet-openstack
15:40 dgurtner joined #puppet-openstack
15:43 ducttape_ joined #puppet-openstack
15:43 mwhahaha Hunner: just thought i'd comment that the stdlib deprecation function spits totally unreadable stack traces, http://logs.openstack.org/89/388589/1/g​ate/gate-puppet-openstack-integration-4​-scenario001-tempest-centos-7/fc2567b/c​onsole.html#_2016-10-19_22_24_59_667975
15:43 mwhahaha Hunner: so i have absolutely no idea what is deprecated
15:48 dmsimard Hunner: this man speaks the truth ^
15:48 mwhahaha i think the is_array function is deprecated
15:48 mwhahaha which is lunacy
15:48 mwhahaha just make it puppet4 compatible so we don't have to see all these notices
15:51 fultonj do any more cores want to review https://review.openstack.org/#/c/387540/ ?
15:51 fultonj thanks mwhahaha for looking at that
15:52 iurygregory fultonj, looking now
15:52 fultonj iurygregory: thanks
15:55 mwhahaha https://tickets.puppetlabs.com/browse/MODULES-3961 ಠ_ಠ
15:56 mwhahaha looks like all the validate_* calls are deprecated
15:56 iurygregory and what we should use?
15:56 iurygregory '-'
15:59 dgurtner joined #puppet-openstack
16:00 mwhahaha i have no idea
16:00 mwhahaha it claims validate_legacy with some sort of type
16:01 iurygregory ody, do you have any idea ^
16:01 iurygregory ?
16:01 mwhahaha https://github.com/puppetlabs/pu​ppetlabs-stdlib#validate_legacy
16:01 mwhahaha ody: Hunner -^ who thought this was a good idea
16:06 openstackgerrit Dmitry Tantsur proposed openstack/puppet-ironic: Remove "dhcp" command from the iPXE script  https://review.openstack.org/389169
16:07 dfisher joined #puppet-openstack
16:08 mwhahaha guess it's time to tack on yet another annoying mass update to address this
16:09 iurygregory yeah lets add
16:09 iurygregory now we should follow: validate_legacy("Optional[String]", "validate_re", "Value to be validated", ["."]) ? O.o omg
16:11 mwhahaha i guess, trying to figure out that out now
16:11 mwhahaha like i said, who thought that was a good idea
16:11 ducttape_ joined #puppet-openstack
16:14 mwhahaha i guess it's validate_legacy(<puppet4 type>, "validate_<old function type>", $var)
16:14 mwhahaha https://dzone.com/articles/nt​p-a-puppet-4-language-update
16:15 mwhahaha not sure what Optional[string] is i guess that's a puppet4 language thing
16:16 iurygregory a better example in the readme would be good
16:16 mwhahaha pretty much
16:18 mwhahaha https://docs.puppet.com/puppet/lat​est/reference/lang_data_type.html
16:19 mwhahaha my god that's overly complicated
16:19 openstackgerrit joined #puppet-openstack
16:19 iurygregory maybe we should ask in #puppet ?
16:19 mwhahaha eh we're just hitting the puppet3 eol, puppet4 push
16:20 mwhahaha just annoying
16:21 mwhahaha looks like the heredoc syntax has also chaged, https://docs.puppet.com/puppet/latest/r​eference/lang_data_string.html#heredocs
16:22 mwhahaha fortunately i don't think we use that anywhere
16:27 hjensas joined #puppet-openstack
16:27 hjensas joined #puppet-openstack
16:27 mwhahaha gah all the is_* functions are also deprecated, you're supposed to use if $var =~ Stdlib::Compat::<type> instead
16:28 mwhahaha i wonder if that works in puppet3
16:30 openstackgerrit Alex Schultz proposed openstack/puppet-aodh: Switch to stdlib validate_legacy  https://review.openstack.org/389271
16:30 * mwhahaha cries
16:30 mwhahaha guess i figured out what i'm going to do today
16:30 Hunner mwhahaha: :(
16:30 Hunner mwhahaha: I'll pass it on (dev_el_ops is the one behind it)
16:31 mwhahaha Hunner: this is a nightmare, jfyi
16:32 Hunner mwhahaha: oh, the p4 typing?
16:32 mwhahaha no having to switch all these functions
16:32 mwhahaha typing is annoying
16:32 mwhahaha but this, this is crap
16:32 Hunner mwhahaha: Or you could use the real types instead of the Stdlib::Compat::* types
16:33 Hunner mwhahaha: are you at pconf? dev_el_ops is there and probably happy to chat about it
16:33 mwhahaha no
16:34 mwhahaha Hunner: what's the p4 friendly way to validate_re
16:34 mwhahaha the example in stdlib doesn't really make sense
16:36 dgurtner joined #puppet-openstack
16:38 Hunner mwhahaha: If you want p4 way and not just validate_legacy way, Variant[Boolean, Enum['true', 'false', 'running', 'stopped']]
16:38 openstackgerrit Alex Schultz proposed openstack/puppet-barbican: Switch to stdlib validate_legacy  https://review.openstack.org/389273
16:38 Hunner for example is a way that people often do validation
16:38 Hunner mwhahaha: as well as https://docs.puppet.com/puppet/4.7/ref​erence/lang_data_abstract.html#pattern
16:38 Hunner the abstract data types specifically have a lot of flexibility
16:39 iurygregory i'll miss validate_* functions =(
16:39 mwhahaha Hunner: they might, but we don't need any of that heh
16:39 dmsimard iurygregory: welcome to the future
16:39 iurygregory dmsimard, not very welcome right? haha XD
16:40 mwhahaha the validate_* functions where always a basic check and we weren't relying on the annoying special cases so for us just making them continue to function would have been better than having to switch all of them
16:40 mwhahaha i'm glad we've really not been to strict about these checks or this could have been worse
16:40 iurygregory yep
16:43 Hunner mwhahaha: want to start a puppet-dev@ mail? David is UK tz usually and at pconf doing a talk today
16:43 Hunner getting user feedback is ++
16:43 mwhahaha i probably need to signup for that :D
16:43 mwhahaha where is that
16:43 Hunner puppet-dev@groups.google.com
16:44 Hunner If you don't want to sign up, CC yourself and mention that you're not subscribed to the list. Replies should CC you as swell
16:45 mwhahaha i'll just subscribe
16:47 amoralej may i get your reviews on https://review.openstack.org/#/c/389047/ ?
16:47 amoralej easy one, but is blocking promotion of mitaka in rdo-ci
16:48 mwhahaha amoralej: commented
16:49 dmsimard amoralej: https://review.openstack.org/#/c/389047/ straight to mitaka ?
16:49 amoralej lemme explain it in the change...
16:50 iurygregory also there is a OOO failure =(
16:50 dmsimard amoralej: oh, mwhahaha beat me to it
16:57 openstackgerrit Alex Schultz proposed openstack/puppet-openstack-integration: Move rbd_default_features to ensure_resources  https://review.openstack.org/387540
17:01 _ducttape_ joined #puppet-openstack
17:04 mwhahaha ugh validate_legacy isn't added until 4.13 meaning that becomes the minium version of stdlib we need
17:04 mwhahaha eff all this
17:05 mwhahaha oh and it doesn't work in puppet3
17:12 mwhahaha so i guess we need to figure out an EOL of puppet3 for us as well
17:13 iurygregory yeah
17:13 iurygregory mwhahaha, you will participate in puppet sessions via hangouts or something? maybe is a topic we should discuss
17:15 mwhahaha i could try
17:16 mwhahaha the first session is at 4 am my time
17:16 iurygregory urgh
17:16 iurygregory omg
17:16 iurygregory very hard for you =(
17:16 mwhahaha the second is 10:30
17:16 mwhahaha which is more reasonable :D
17:16 iurygregory oh yes XD
17:20 mwhahaha i added it to the etherpad, i figure we might want to mention in O but actually do it in P
17:21 iurygregory nice :D
17:22 mjblack mwhahaha: have a link to the etherpad?
17:22 amoralej mwhahaha, i think cherry-picking https://review.openstack.org/#/c/336958/ is the right way
17:23 dmsimard mwhahaha: oh, not going to BCN ?
17:23 mwhahaha mjblack: https://etherpad.openstack.org/p/ocata-puppet
17:23 mwhahaha dmsimard: nope
17:23 dmsimard :(
17:23 mwhahaha amoralej: yea
17:24 mjblack mwhahaha: so one suggestion for octa release
17:24 mjblack are we open to using hiera data binding?
17:24 vinsh joined #puppet-openstack
17:25 dmsimard mjblack: where ?
17:25 mwhahaha mjblack: tripleo uses it extensively, but what do you have in mind?
17:25 mwhahaha switching just the tests or something?
17:25 mjblack mwhahaha: like a community supported hiera that people can use to do least amount of composition to make workable
17:25 mjblack CI could benefit from it too
17:25 dmsimard mjblack: we chose not to use it in puppet-openstack-integration and acceptance tests because it adds another layer of complexity
17:26 mjblack it does
17:26 mjblack but it also makes it much more flexible
17:26 dmsimard like, when troubleshooting things.. okay, where's the issue, is it in packaging, is it in the project, is it in the gate vm, is it an external puppet module, is it in hiera, etc. etc.
17:26 mjblack or maybe its in the fixtures
17:26 dmsimard right
17:27 mjblack or the p-o-i manifests
17:27 mjblack the argument doesnt negate that it is already complex
17:27 openstackgerrit Jiri Stransky proposed openstack/puppet-tripleo: WIP Glance NFS  https://review.openstack.org/389284
17:27 mwhahaha i would assume that doing hiera for p-o-i  would actually simplify it
17:27 mwhahaha but maybe i'm wrong
17:27 mjblack wont know till we take a look at it
17:28 dmsimard mwhahaha: simplify what for who
17:28 mjblack dmsimard: well for starters, you could put in the hiera.yaml a distro and distro-release to add flexiblity, like for example...turning something on for xenial that was off for trusty
17:28 dmsimard mwhahaha: if it's because there's too many parameters, we can just create a params class
17:28 ducttape_ joined #puppet-openstack
17:29 mjblack its more than just parameters
17:29 dmsimard mjblack: I know what hiera is and what it provides, but CI is already hard enough to troubleshoot
17:30 dmsimard that's my opinion, anyway
17:30 mwhahaha i guess the question is what exactly to move to hiera and what not to
17:30 mwhahaha for me  the hardcoded crud like https://github.com/openstack/puppet-openstack-int​egration/blob/master/manifests/mistral.pp#L29-L41
17:30 mwhahaha would make sense in hiera
17:30 mjblack well, we're not talking about just the CI though in my opinion
17:30 mwhahaha all those passwords and usernames
17:30 dmsimard it'd make things cleaner, simpler /for [me, you, select individuals]/ but increases the required ramp up for people to help
17:32 dmsimard mjblack: I'm not against the idea but I need to be convinced :)
17:32 mwhahaha dmsimard: we already had to do it for apache btw
17:33 mwhahaha https://github.com/openstack/puppet-openstac​k-integration/blob/master/hiera/common.yaml
17:33 dmsimard mwhahaha: yup, and I even hook into that to extend p-o-i
17:34 dmsimard I believe there was a debate around hiera a while back.. I'm trying to find where it is
17:34 dmsimard probably find arguments for and against there
17:34 dmsimard all I remember is that Colleen shared my opinion :(
17:36 mwhahaha i think things have changed a bit since it was last discussed :D
17:36 dmsimard was it that long ago ?
17:37 mjblack it was probably before puppet 4
17:38 openstackgerrit Alfredo Moralejo proposed openstack/puppet-neutron: Add user_domain_name and project_domain_name  https://review.openstack.org/389290
17:44 ducttape_ joined #puppet-openstack
17:49 exed_ joined #puppet-openstack
17:54 amoralej mwhahaha thanks for your help!
18:02 ducttape_ joined #puppet-openstack
18:04 openstackgerrit craig delatte proposed openstack/puppet-manila: WIP - Manila hooks support  https://review.openstack.org/389302
18:09 openstackstatus NOTICE: The Gerrit service on review.openstack.org is being restarted now in an attempt to resolve some mismatched merge states on a few changes, but should return momentarily.
18:46 openstackgerrit Alex Schultz proposed openstack/puppet-ceph: Make pid_max settable on OSD nodes.  https://review.openstack.org/375798
18:46 markvoelker joined #puppet-openstack
18:47 mwhahaha guess we had a bunch of stuff stuck
18:47 markvoelker joined #puppet-openstack
18:48 openstackgerrit Merged openstack/puppet-ceph: Ensure wget is installed for RGW Keystone integration  https://review.openstack.org/326732
18:48 openstackgerrit Merged openstack/puppet-ceph: Change conf from create to ensure  https://review.openstack.org/387686
18:48 openstackgerrit Merged openstack/puppet-ceph: Notify radosgw service on configuration change  https://review.openstack.org/388080
18:48 mwhahaha lol wat
18:49 _ducttape_ joined #puppet-openstack
18:51 xarses sticky stuck
18:53 openstackgerrit Merged openstack/puppet-cloudkitty: This is the initial commit for puppet-cloudkitty.  https://review.openstack.org/387149
18:57 openstackgerrit Alex Schultz proposed openstack/puppet-openstack-integration: Fix package version on Fedora  https://review.openstack.org/288619
18:59 openstackgerrit OpenStack Proposal Bot proposed openstack/puppet-openstack-integration: Updated from Puppet OpenStack modules constraints  https://review.openstack.org/388589
18:59 ducttape_ joined #puppet-openstack
18:59 mwhahaha chem: you going to continue with this or should it just be aboandoned? https://review.openstack.org/#/c/296370
19:02 chem mwhahaha: hum .... good question.  give me till end of next week to see if I can finish this up.  Thanks for poping this up.
19:02 mwhahaha sure
19:10 openstackgerrit Alex Schultz proposed openstack/puppet-keystone: Make fernet the default token provider  https://review.openstack.org/389322
19:26 openstackgerrit Tim Rozet proposed openstack/puppet-tripleo: Fixes missing ODL ML2 Authentication info  https://review.openstack.org/389328
19:32 openstackgerrit Alex Schultz proposed openstack/puppet-swift: Allow a replication network to be specified  https://review.openstack.org/302483
19:38 paramite joined #puppet-openstack
19:39 johnmilton joined #puppet-openstack
19:40 openstackgerrit Alex Schultz proposed openstack/puppet-murano: Add acceptance tests for client and application provider  https://review.openstack.org/246480
19:48 openstackgerrit Alex Schultz proposed openstack/puppet-openstack-integration: Fix package version on Fedora  https://review.openstack.org/288619
20:02 openstackgerrit Alex Schultz proposed openstack/puppet-vswitch: rework service and fix service for debian jessie  https://review.openstack.org/322495
20:03 mwhahaha vinsh: you still working on https://review.openstack.org/#/c/264966/ or should it be abandoned?
20:04 vinsh I am working on it.  I will land the storage policy change in the next week, then this one follows.
20:05 vinsh It's a priority for me
20:07 vinsh I have a massive update to the storage policy change to push up still
20:07 vinsh am bringing up some new swift clusters today though, so gotta get that done.
20:09 mwhahaha k
20:10 vinsh and then comes ini provider/remove templates for all the object/account/container classes
20:10 vinsh THEN the change for dedicated replication networks can be re done
20:10 vinsh That ring one that you updated today is good/cool
20:17 dmsimard EmilienM, mwhahaha, iurygregory: fyi I just fixed an issue that prevent puppet repository promotion in RDO for the past ~2 days, promotion just occured after passing all three scenarios
20:17 iurygregory dmsimard, thank you man :D
20:17 dmsimard iurygregory: well take that for what it is, I'm the one who also introduced the issue
20:17 dmsimard so yeah :p
20:18 iurygregory dmsimard, you don't need to tell me that part =P hahaha
20:18 EmilienM dmsimard: you rocks
20:18 dmsimard hey gotta take credit
20:18 dmsimard I break things and I fix things
20:18 dmsimard I don't discriminate against who broke things
20:18 iurygregory yeah that's true
20:18 dmsimard even if that's myself
20:20 openstackgerrit Alex Schultz proposed openstack/puppet-gnocchi: Change worker defaults to ::os_workers  https://review.openstack.org/383948
20:23 openstackgerrit Alex Schultz proposed openstack/puppet-cinder: Update NetApp configuration parameters  https://review.openstack.org/341777
20:26 openstackgerrit Alex Schultz proposed openstack/puppet-openstack-integration: Re-enable Mistral testing  https://review.openstack.org/339813
20:27 EmilienM mwhahaha: they were flappy last time I tried ^
20:27 mwhahaha yea i know just rebasing so we can keep testing
20:27 mwhahaha good ol' merge conflicts
20:29 openstackgerrit Alex Schultz proposed openstack/puppet-openstack-integration: Re-enable SSL testing on Ubuntu  https://review.openstack.org/379463
20:31 openstackgerrit Alex Schultz proposed openstack/puppet-openstack-integration: Re-enable linuxbridge testing on Ubuntu  https://review.openstack.org/379472
20:41 openstackgerrit Alex Schultz proposed openstack/puppet-openstack-cookiecutter: Added ensure parameter to pass to service identity  https://review.openstack.org/342768
20:49 Kvisle do I understand it correct that "Needs Review" mean I need a second core dev to ack on my proposal? I'm a bit confused, because there's a green checkmark on the Code Review-column in gerrit
20:49 Kvisle (first proposal)
20:51 iurygregory Kvisle, another core need to +A your change =)
20:52 Kvisle ok! is this a part of the process I should actively engage in, or is it something that will happen eventually when someone gets to it?
20:53 iurygregory well when you have change that need review you can ask here for reviews and when we have time we will give feedback =)
20:53 xarses Kvisle: we do two +2 code review +1 verified, and +1 (A) workflow to get merged
20:53 iurygregory can you put the link for review?
20:53 Kvisle https://review.openstack.org/#/c/387263/
20:54 Kvisle I don't think I understand what the difference between code review and workflow
20:54 Kvisle ... is
20:55 xarses code review is people reviewing, cores can +/-2, others can +/-1
20:55 xarses workflow is telling gerrit to start the gate validation for merging
20:57 xarses for most projects, workflow involves rebasing the current CR onto master and re-running the same check CI and requiring that it all pass before it can be merged
20:58 Kvisle I see.
20:58 xarses it's an additional step that helps ensure that we don't land a patch because master changed in a conflicting way from when verification CI ran maybe some days ago.
21:10 ilbot3 joined #puppet-openstack
21:10 Topic for #puppet-openstack is now CI status: green - Puppet OpenStack modules http://docs.openstack.org/deve​loper/puppet-openstack-guide/
21:10 dmsimard it's not like we're doing that or anything
21:10 * dmsimard still very unhappy with the outcome of that issue
21:12 Kvisle iurygregory: the "cinder.volume.drivers.emc.​emc_cli_fc.EMCCLIFCDriver" does not require it at least --- the documentation does not say that it is required for ISCSI, and I don't have the hardware to test behaviour without it -- so I don't want to make it completely optional
21:12 Kvisle (maybe I should?)
21:13 iurygregory Kvisle, maybe ask cinder devs about it?
21:13 iurygregory if the other drive does not require the parameter the change is fine =) can you confirm and put in the review?
21:16 openstackgerrit Giulio Fidente proposed openstack/puppet-ceph: Always allow setting keystone token/user/pass/project/domain  https://review.openstack.org/389355
21:17 Kvisle iurygregory: put in the review?
21:17 openstackgerrit Merged openstack/puppet-keystone: set 0600 permissions on fernet keys & folder  https://review.openstack.org/382136
21:17 openstackgerrit Merged openstack/puppet-ceph: Make pid_max settable on OSD nodes.  https://review.openstack.org/375798
21:18 openstackgerrit Merged openstack/puppet-openstack-integration: Updated from Puppet OpenStack modules constraints  https://review.openstack.org/388589
21:18 iurygregory Kvisle, ask someone in cinder if the parameter is optional for the other driver, when you get the answer you can reply the review with this information or just ping me here in the channel
21:20 Kvisle in that case, I could create another change making iscsi_ip_address completely optional?
21:20 iurygregory When you acess https://review.openstack.org/#/c/387263/ you can just click in Reply.. and add a message with the answer you got from cinder and just click Post =D
21:20 Kvisle ah, ok!
21:20 iurygregory if is optional for both you need just to update your patch :D
21:26 Kvisle unless it has been introduced as a required parameter, it's optional ... in mitaka it's a valid parameter, but a noop
21:26 davideagle joined #puppet-openstack
21:26 Kvisle seems like the backend has been completely reworked since then though
21:30 Kvisle iurygregory: looks like I'll rework the patch and make it completely optional -- the parameter does nothing in mitaka, and in master it isn't even there
21:31 Kvisle throw warning that it has been removed, and will be removed on next release perhaps
21:31 * Kvisle leaves with these thoughts in mind
21:32 openstackgerrit Merged openstack/puppet-ironic: Remove "dhcp" command from the iPXE script  https://review.openstack.org/389169
21:32 openstackgerrit Merged openstack/puppet-neutron: Add user_domain_name and project_domain_name  https://review.openstack.org/389290
21:45 openstackgerrit Merged openstack/puppet-swift: Release 9.4.3 (newton)  https://review.openstack.org/388879
21:51 openstackgerrit Merged openstack/puppet-tripleo: pacemaker/mysql: wait step 2 to remove default accounts  https://review.openstack.org/386042
21:53 davideagle joined #puppet-openstack
22:06 openstackgerrit Giulio Fidente proposed openstack/puppet-tripleo: Uses keystone user/pass/project instead of token for RadosGW  https://review.openstack.org/389372
22:11 openstackgerrit Merged openstack/puppet-swift: Change worker defaults to ::os_workers  https://review.openstack.org/382829
22:20 openstackgerrit Alex Schultz proposed openstack/puppet-cinder: Update NetApp configuration parameters  https://review.openstack.org/341777
22:23 ayoung joined #puppet-openstack
22:59 openstackgerrit Giulio Fidente proposed openstack/puppet-tripleo: Uses keystone user/pass/project instead of token for RadosGW  https://review.openstack.org/389372
23:11 davideagle_ joined #puppet-openstack
23:23 davideagle_ joined #puppet-openstack
23:59 ayoung joined #puppet-openstack

| Channels | #puppet-openstack index | Today | | Search | Google Search | Plain-Text | summary